Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[mrbaggins]

   (*)fixed world gen crash caused when a prisoner escapes from a site at the same time the last person to arrive at the site commits murder

Why the hell should that crash DF?

Probably "last person to arrive at the site commits murder" targets prisoner, but "prisoner escapes from a site at the same time" so it targets invalid person, so it targets invalid index, so it reads invalid area of memory, so it crashes.

Or because two seperate processes (murder and escape) access the same property of the site (population number).

AFAIK DF is not multithreaded.

Correct, and you beat me to posting it.

[Jeoshua]

Well while DF may not be multithreaded, it does appear to be object oriented.  Therefore, the idea that what the two, non-related objects want to do is counter to each other and makes the game crash isn't out of the question.  It's merely that it happens in serial fashion, rather than simultaneously.

I have to say tho, I'm really glad that the majority of these fixes have been in the RAWs.  Makes it easier to upgrade than if the API had been changed.

[Buttery_Mess]

What does today code in anyway?

[Aequor]

Mr. Toady, you do spoil us so.

[SirAaronIII]

Thanks for another great update, Toady! And another, and another, and another...
Seriously though, you should take a break. All these rapid-fire updates have got to be bad for you in the long run.

[monk12]

What does today code in anyway?

C++, I believe

[Toady One]

   (*)fixed world gen crash caused when a prisoner escapes from a site at the same time the last person to arrive at the site commits murder

Why the hell should that crash DF?

It decides what to do with a site's population in one loop, and the general workers are the ones that kill each other.  It does the escape attempts in there, but the attempted reindex wasn't correct, so the last arrival ended up being assigned to work twice if somebody escaped.  That part of the bug is normally virtually invisible, since you'd just get a little extra work done on the site every escape year, and even the regular murder routine was set up to handle that worker being eliminated (it wouldn't have tried to kill the worker twice because of an extra check).  However, when the last doubled-up worker was chosen as the murderer, then in the process of choosing potential victims, it wasn't prepared to skip two entries in the target list (to prevent self-murder), and it crashed.  Now the original bug is fixed, and if that double-up situation arises in some other way it'll drop an error in the log instead of crashing.

[greycat]

What does today code in anyway?

C++, I believe

The Linux version is linked against libstdc++, so at least some part of it is written in C++.

[isitanos]

I had loads of fun yesterday night trying out the new stuff (grazing animals, pottery, ...)
Marksmen actually train (sometimes) and use metal bolts against baddies, having a somewhat working military is great. They turned a goblin snatcher into a pincushion. They do display "Soldier - cannot follow order" 90% of the time though, which is rather confusing. Any chance of telling us what they need to get to work instead of that cryptic error message?


A hilarious moment was when a water buffalo and a horse got into a fight: the horse first kicked the hell out of the buffalo, and then bit and latched on to its back and wouldn't let go. Trying to imagine the scene had me laugh out loud.
Overall animals being a big unruly is fun. I put two war dogs and a giant scorpion (all non-grazers) in a small pasture in front of my entrance to guard it, and they also got into a fight (the dog actually wounded the scorpion and was unhardmed  ).
The scorpion didn't use its sting and only grabbed the dog with its rear legs, as if it really didn't want to harm it. This made me think that it would be fun if animals (and dwarves, why not) did have a set of attacks (some of them toned down as when training) that they use in friendly brawls. Puppies would have those kind of brawls all the time.


Also very funny is "Urist bashes Asob in the head with its iron battleaxe, lightly tapping the target".


One last thing: do you guys manage to visually distinguish grass from muddy floor, pebbles, and various other kinds of soil? Around my fortress, it seems that the only way to see if grass is growing somewhere is to use 'k' and check tiles one at a time, not very good if you want to quickly assess how much food is left for your grazers, or if a place is good for a pasture. Some different tiles for grass and bare soil would help I think.

[steppenfox]

Whoa.  Thanks for the updates!

Would installing the latest newbie pack + updating the executable and raws work?  Or... does dwarf therapist get messed up every time there is an update?

[Aklyon]

You'll need to check the therapist thread for an updated memory layout.

[abadidea]

   (*)fixed world gen crash caused when a prisoner escapes from a site at the same time the last person to arrive at the site commits murder

Why the hell should that crash DF?

Probably "last person to arrive at the site commits murder" targets prisoner, but "prisoner escapes from a site at the same time" so it targets invalid person, so it targets invalid index, so it reads invalid area of memory, so it crashes.

Or because two seperate processes (murder and escape) access the same property of the site (population number).

AFAIK DF is not multithreaded.

It doesn't necessarily have to be multithreaded to produce spectacular inconsistency.

For example: Prisoner leaves, population decrements to zero. Murderer murders nobody and population decrements to negative one. Code a few lines down that assumes it can't go negative crashes. (Just speculation but you see what I mean.)

[HammerDave]

Wow, that's a lot of bugfixes.  I'm merrily playing along in .21, biding my time while Therapist, dfhack, and Mayday are available on the latest version.  'cept the latest version doesn't last long enough for the others to get updated!   

I am wondering how Toady finds enough time in the day to release so frequently.  Perhaps compiling while he sleeps?   

On the "it's not multi-threaded" comments -- Toady already posted a pretty open description, but in general for event loops like this one there are always exposures to iteration N adversely affecting other things in the same iteration, or in the next one.

Prisoners escaping must be an adventure mode thing, right?

And "release 1" had me worried the plan was to not release anything until 1.0.0.  I hope it means the next 0.nn number?

[Footkerchief]

Or because two seperate processes (murder and escape) access the same property of the site (population number).

AFAIK DF is not multithreaded.

It doesn't necessarily have to be multithreaded to produce spectacular inconsistency.

For example: Prisoner leaves, population decrements to zero. Murderer murders nobody and population decrements to negative one. Code a few lines down that assumes it can't go negative crashes. (Just speculation but you see what I mean.)

I'm sure Kogut knows that -- what s/he was getting at with the response to Areyar's comment was that multiple processes weren't at work here, i.e. this wasn't a race condition / critical section type thing.

Also, for completeness, DF does have multithreaded rendering code, just not the rest of the game.

Prisoners escaping must be an adventure mode thing, right?

World gen thing, hence world gen crash.

And "release 1" had me worried the plan was to not release anything until 1.0.0.  I hope it means the next 0.nn number?

Yes, it's 0.32.  Release 1 and subsequent releases are described here.  Toady discussed the timeframe recently:

I'm not sure how long Release 1 will take, but after Release 1, I'm going to do another cycle like this.  Hopefully it'll be lighter on the new bug fixes, since that took a lot of time this time around by itself, but another 2 week or 20 day period or whatever of old bug fixes will come up then.  If I end up starting Release 1 next, then ultra-tentatively-and-without-any-serious, let's say that takes up April.  Then the better part of May will be debugging, and so on.

[Iggbyoo]

Man, he is going so fast that he can't stop now! He'll get coding whiplash!  Poor guy.