Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Stworca]

I do, yes.

[Jonathan S. Fox]

Given the nature of the error, it's almost certainly specific to an item, or even a specific group of two items.

[Virroken]

The inventory bug comes from CCS safehouse raids. Some of the loot you pick up is marked with [2]. These items will cause crashes unless sold.

[Hyo]

I have had [2] items before, mainly from my tailoring, so I think something more specific is needed.

I must admit, I sold all my [2] items and the crash disappeared, so it might be still true somehow though.

[Innominate]

Invalid operator< means that a function which sorts imitating operator< has detected a break in total ordering (that is, there are some three or more elements that cannot be put in a consistent order). Are you using the latest version? There was a fix for an extremely similar bug in a previous version - the bug was caused by having multiple non-stacking but identical items, pretty much only secrets you can publish in the Liberal Guardian.

If this is from the latest version, then I think I know what the bug is; in Armor's sort_compare_special, the check is made (correctly) for quality; if 'this' is better quality than 'other', put 'this' before 'other'. However, a key error occurs afterwards: the quality comparison is discarded. This causes the error because:
If 'this' is higher (i.e. worse) quality than 'other' then we swap the order. But if we evaluate them in the opposite order then we might end up swapping them again if the original 'other' is damaged and the original 'this' isn't (or any of the remainder of the existing code's swap cases).

Existing code:

Spoiler (click to show/hide)

Code: [Select]

reorder = (this->quality_ > a->quality_)
                   || (this->damaged_ && !a->damaged_)
                   || ((this->bloody_ || this->damaged_) && !a->bloody_ && !a->damaged_)
                   || (this->bloody_ && this->damaged_ && !a->bloody_ && a->damaged_);

New code (fixed bug, touched up a few other things):

Spoiler (click to show/hide)

Code: [Select]

if(this->quality_ < a->quality_) return false;
else if(this->quality_ > a->quality_) return true;
else if(this->damaged_ != a->damaged_) return this->damaged_; //i.e. if damaged is different
else if(this->bloody_ != a->bloody_ ) return this->bloody_ ; //i.e. if bloody is different
return false;

[pollo2019]

First of all Hello to Everyone,

i want to mentioned that i really like the game and a big thank you for working on improving it all the time

I have found a bug on my game like one that was mentioned before.

the error message :
http://i734.photobucket.com/albums/ww344/pollo2019/LCS-Error.jpg

that happens whenever any squad character is putting on/off any clothing

to bypass i just click the Ignore button and the game will not crash, any other button will crash the game...

if you need more information to investigate on this you can always message me

happened the first time when i striped my character wile entering the Garment Maker. Since then any clothing will cause that box to pop up.

i will backup my game so if you need the game data for some reason it will also be available to send to you.

Sorry about the trouble and once again thank you for improving that great game

[Jonathan S. Fox]

Sounds like exactly the issue Innominate was addressing above. As a workaround, try selling off your second rate clothing and/or cleaning and repairing all of your clothing.

[a1s]

I have a bug to report:
After having a hostage die on me, I discovered that the character was accused of kidnapping, so I sent him to the police station to clear his name. Imagine my surprise, when at the trial he was accused of 3 kidnappings, while I only did one, ever, in that game.

[GodlikeSoldier]

Since Jonathan is doing a different project who is going to be taking care of the game crashing bugs i mean i don't mind if the games not updated balance wise or anything. These game crashing bugs though i would like fixed since losing days of work is very discouraging . I think i got hit by that clothes bug, but unlike the other guy ignoring does not work probably cause i'm on windows 7 and i don't think they are.

[ryan5050]

omfg NOOOOSE  why did you change the sieges 

[Jonathan S. Fox]

omfg NOOOOSE  why did you change the sieges 

1. Fortify for a siege.
2. Buy food.
3. Wait a few days for them to force a fight before selecting escape/engage.

Following this strategy will get you the same outcome as before; fighting in the safehouse against several squads of attackers.

[ryan5050]

omfg NOOOOSE  why did you change the sieges 

1. Fortify for a siege.
2. Buy food.
3. Wait a few days for them to force a fight before selecting escape/engage.

Following this strategy will get you the same outcome as before; fighting in the safehouse against several squads of attackers.

lol sorry john just a random RAGE moment

[Jonathan S. Fox]

I need to change the sally forth option so you don't get first striked by a bazillion SWAT members. Should also change the escape/engage text on the main screen so that it's clear that the two situations are different... or even remove the option of trying to fight your way out early? Not sure if that's better than leaving it in and making it extremely deadly.

[RedWarrior0]

It should be extremely deadly, but also rewarding. For example, if you could somehow implement sniping for Liberals (use a sniper rifle somehow, then select an enemy you have LoS on and everyone wielding sniper rifles shoots at the enemy?), then you could make the enemy snipers killable, and this would be the only way other than the army base and occasionally the HQ to get sniper rifles. Of course, it would probably be a pain in the rear end to code, but it would be awesome.

Hm... more consolidated idea: in the safehouse fortification menu, you could choose to (I)nstall Defensive Weaponry or something such as that. It then has a sub-menu with four to six positions, which are placed from left to right, and you can place a sniper rifle, machine gun, or salvaged tank weapon on the position in the sub-menu. Then, if you add the front wall of the safehouse and a clear line all the way along it with the weapon positions that you can (U)se to attack non-adjacent foes.

Hopefully you get what I'm trying to say here.

[Carlos Gustavos]

I've committed a fix for the armor sorting as noted by Innominate.

If you have an unplayable save file because of this bug, you can try to open the save in an editor. Search for <quality> tags and replace any 2, 3 or 4 with 1.