So I've managed to shake off that lack of time and energy a lil bit to do some work in BN:
1.
For starters, fixing a fuckup I made back when I tweaked the code for how woodcutting tires you out (
which was here). I still need to continue this and apply similar rebalances to other exhausting long actions but weh.
2.
Fixed mount gunmods like sight mount, stock mount, etc being basically always impossible to install regardless of skill level. The math behind it is very janky and basically you NEED to define skill requirements or else you'll need superhuman stats to go from 0% odds to LITERALLY 17% tops. Looks like someone at some point also already noticed this problem in DDA at some point but hadn't thought to look for a DDA PR to port over when I ran afoul of this.
3.
Tweaking how guns use the stock slot vs. stock mount. In a nutshell, some vanilla rifles with wooden stocks use the stock slot but others use only stock mount. This basically just stamps down on this inconsistency and rigs it so that if the gun has a stock, it has a stock slot. If the gun doesn't have a stock, either it has a stock mount slot, or it's a pistol that's big and/or tacticool enough to warrant being able to use a pistol stock gunmod right off the bat. Stock mount is now basically only used for guns that neither have an existing stock nor would logically be able to have one slapped onto it out of the box.
4.
Tweaks to make much more use, and much more consistent use, of the barrel length property. Basically, more guns that have some amount of barrel you could afford to cut off IRL have a barrel length definition, and for all but the smallest affected guns you can take a minimum of 250 mL off them. Often more, for the sake of making the difference matter more. Key thing to keep in mind here is that item volume in BN represents bulk/clunkiness just as much as it does actual liquid displacement volume, because we don't have a max length system that's basically only really used to make it so you can't have an item half-stuck into the opening of your backpack (which is a fine example of a realistic feature intrinsically making things unrealistic in a situation where adhering to real-life logic more closely would benefit the player, can you guess why "realism isn't real unless it hurts the player" is a meme?).
5.
Porting over a PR that allows you to saw off stocks from guns. A few notable differences between the source PR and my port of it: the big one is that it looks for the stock slot, not the stock mount slot, explicitly because as mentioned which guns get the stock slot is pretty inconsistent in DDA (and in BN at present until PR 3 is merged). To avoid sawing a stock that will likely not actually exist, the code is additionally set to exclude pistols so that only items likely to actually have a fixed factory stock can be shaved down. Third, it requires the item to have wood as a material subtype. This is a much cleaner way to distinguish for old-school wood-furniture guns vs modern tacticooll plastic or all-metal guns, compared to JUST checking for stock vs stock mount. You would expect a gun with a wooden stock to have wood in its material list, after all! Finally, I implemented all of the actual gameplay effects of having a shortened stock in the JSON entry for the gunmod applied by the wood saw, unlike the old shortened barrel where the volume reduction is located in each individual gun that can be affected by it and the weight reduction is buried in hardcode. In addition, I removed the old janky way that volume bonuses were applied to guns with folding/sawed stocks so that instead of several tiers of reduction based off item volume (item volume MINUS barrel length if any, only), it's a simplified removal of one-third of the item's baseline volume.
6.
And lastly, a minor tweak to make it possible to take signal flares apart for resources. You can craft your own signal flares despite them being almost useless, and you can take HAND flares apart for resources, so why you were never able to take apart signal flares to get infinitely-more-useful shotshells and shotgun primers is beyond me.
PRs 3, 4, and 5 are all intended to combine to achieve one particular goal: make it so you can take the bog-standard double-barreled shotgun, cut both the stock and the barrel short, and have its resulting volume reduced to JUST enough to fit in an XL holster. As mentioned in alternatives section for two of those PRs, one alternative I could do if pestered to but haven't tried yet would be just buffing the maximum capacity of the XL holster from 1.25 liters to 1.5 liters, because that's a MUCH more forgiving volume target to hit.
Author
Topic: The Cataclysm games thread. (Read 114090 times)