Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[PatrikLundell]

The other good reason I can think of is testing. If the script author isn't interested in adventure mode there is very little incentive to test the script in it (or to deal with complaints about it not working in adventure mode).

[MC]

Sounds reasonable. Just wanted to make sure there wasn't some arcane reasoning I was missing. Thanks!

[Evans]

We've only included timestream.lua since 0.47.04-r3, which is currently the latest version. It is a heavily modified version of a script originally by IndigoFenix, though - were you using that? I didn't think it worked in 0.47.04 as-is. If not, where did you get timestream.lua from previously?

We could try adding that feature, but since I'm not aware of it being intentionally removed, I'm not really sure where to look. Are you asking for something like "-rate 0.25" to work? From looking through the code briefly, I think that should work as-is (at least, I don't see anything actively preventing it from working).

-rate 0.25 resets to default fps instead, making game to run at 1x speed.

Code: [Select]

        if rate ~= 1 then
            last_frame = df.global.world.frame_counter
            --if rate > 0 then            -- Won't behave well with unit simulation
            if rate > 1 and not simulating_desired_fps then
                print('timestream: Time running at x'..rate..".")
            else
                print('timestream: Time running dynamically to simulate '..desired_fps..' FPS.')
                if rate ~= 0 then
                    print('timestream: Rate setting ignored.')
                end
I'm using some older version, but it works very well - at least at slowing calendar, I'm sure other things may be affected in funny way.


Anyway, I'm having crashes in DF by totally different reasons now:
Class not in symbols.xml: 'viewscreen_unitlaborsst': vtable = 0x7fedc200ff0

This happens when I try to manage labour and enable herbalist job for my dwarves.
File search points to \Dwarf Fortress\hack\plugins\manipulator.plug.dll

I have dfhack-0.47.04-r3-Windows-64bit now.

[lethosor]

-rate 0.25 resets to default fps instead, making game to run at 1x speed.

Okay, I see the relevant code now, although it's right after the snippet you posted - if you comment out the "rate = 1" line (add "--" to the beginning of it), does that do what you want?

I'm using some older version, but it works very well

If my suggestion doesn't work, it would be very helpful to know where you got this older version from (or to have a copy of it).

Anyway, I'm having crashes in DF by totally different reasons now:
Class not in symbols.xml: 'viewscreen_unitlaborsst': vtable = 0x7fedc200ff0

The message you pasted is a harmless diagnostic message that is not related to the crash. It's in stderr.log because it's occasionally useful for development. Is there any way we could make it clearer that it is not an error? Would having something like "INFO:" prepended make it clearer?

This happens when I try to manage labour and enable herbalist job for my dwarves.

I'm having trouble reproducing this. I was able to enable herbalism on around 100 dwarves across two forts with no crash.
Does it happen exactly when you press "Enter" with herbalism selected for a dwarf, or at some later time? Are you able to reproduce it consistently? Does it only occur for specific dwarves? Are you using any mods?

[Evans]

-rate 0.25 resets to default fps instead, making game to run at 1x speed.

Okay, I see the relevant code now, although it's right after the snippet you posted - if you comment out the "rate = 1" line (add "--" to the beginning of it), does that do what you want?

I'll give it a go.

I'm using some older version, but it works very well

If my suggestion doesn't work, it would be very helpful to know where you got this older version from (or to have a copy of it).

Mkay. I'm sure I got it from *somewhere* near the original author. If the above does not work, I'll post my ancient script here.

I'm having trouble reproducing this. I was able to enable herbalism on around 100 dwarves across two forts with no crash.
Does it happen exactly when you press "Enter" with herbalism selected for a dwarf, or at some later time? Are you able to reproduce it consistently? Does it only occur for specific dwarves? Are you using any mods?

Mods were most likely conflict source. I've refreshed DFhack from the latest release and now all the problems are gone.
For the moment anyway.

Thank you for your answers. I'll take a look at timestream.

[Evans]

commenting that line out does not seem to be doing anything.

I don't think it will help you much, but here is what is inside my ancient timestream.lua:

Spoiler (click to show/hide)

-- Multiplies the speed of calendar time by the specified value.  The parameter can be any positive number, though going over 10 is likely to cause bugs.  1 is normal speed.
 
args={...}
local rate=tonumber(args[1])
local prev_tick = 0
if rate == nil then
   rate = 1
elseif rate < 0 then
   rate = 0
end
 
eventNow = false
seasonNow = false
timestream = 0
counter = 0
if df.global.cur_season_tick < 3360 then
   month = 1
elseif df.global.cur_season_tick < 6720 then
   month = 2
else
   month = 3
end
 
dfhack.onStateChange.loadTimestream = function(code)
   if code==SC_MAP_LOADED then
      if rate ~= 1 then
         print('Time running at x'..rate)
         
         eventNow = false
         seasonNow = false
         timestream = 0
         if df.global.cur_season_tick < 3360 then
            month = 1
         elseif df.global.cur_season_tick < 6720 then
            month = 2
         else
            month = 3
         end
         if loaded ~= true then
            dfhack.timeout(1,"ticks",function() update() end)
            loaded = true
         end
      else
         print('Time set to normal speed.')
         loaded = false
      end
   elseif code==SC_MAP_UNLOADED then
   end
end
 
function update()
   prev_tick = df.global.cur_year_tick
   if rate ~= 1 then
      timestream = 0
      
      if rate < 1 then
         if df.global.cur_year_tick - math.floor(df.global.cur_year_tick/10)*10 == 5 then
            if counter > 1 then
               counter = counter - 1
               timestream = -1
            else
               counter = counter + 1/rate
            end
         end
      else
         counter = counter + rate-1
         while counter >= 10 do
            counter = counter - 10
            timestream = timestream + 1
         end
      end
      
      eventFound = false
      for i=0,#df.global.timed_events-1,1 do
         event=df.global.timed_events
         if event.season == df.global.cur_season and event.season_ticks <= df.global.cur_season_tick then
            if eventNow == false then
               --df.global.cur_season_tick=event.season_ticks
               event.season_ticks = df.global.cur_season_tick
               eventNow = true
            end
            eventFound = true
         end
      end
      if eventFound == false then eventNow = false end
      
      if df.global.cur_season_tick >= 3359 and df.global.cur_season_tick < 6719 and month == 1 then
         seasonNow = true
         month = 2
         if df.global.cur_season_tick > 3359 then
            df.global.cur_season_tick = 3360
         end
      elseif df.global.cur_season_tick >= 6719 and df.global.cur_season_tick < 10079 and month == 2 then
         seasonNow = true
         month = 3
         if df.global.cur_season_tick > 6719 then
            df.global.cur_season_tick = 6720
         end
      elseif df.global.cur_season_tick >= 10079 then
         seasonNow = true
         month = 1
         if df.global.cur_season_tick > 10080 then
            df.global.cur_season_tick = 10079
         end
      else
         seasonNow = false
      end
      
      if df.global.cur_year > 0 then
         if timestream ~= 0 then
            if df.global.cur_season_tick < 0 then
               df.global.cur_season_tick = df.global.cur_season_tick + 10080
               df.global.cur_season = df.global.cur_season-1
               eventNow = true
            end
            if df.global.cur_season < 0 then
               df.global.cur_season = df.global.cur_season + 4
               df.global.cur_year_tick = df.global.cur_year_tick + 403200
               df.global.cur_year = df.global.cur_year - 1
               eventNow = true
            end
            if (eventNow == false and seasonNow == false) or timestream < 0 then
               if timestream > 0 then
                  df.global.cur_season_tick=df.global.cur_season_tick + timestream
                  remainder = df.global.cur_year_tick - math.floor(df.global.cur_year_tick/10)*10
                  df.global.cur_year_tick=(df.global.cur_season_tick*10)+((df.global.cur_season)*100800) + remainder
               elseif timestream < 0 then
                  df.global.cur_season_tick=df.global.cur_season_tick
                  df.global.cur_year_tick=(df.global.cur_season_tick*10)+((df.global.cur_season)*100800)
               end
            end
         end
      end
      dfhack.timeout(1,"ticks",function() update() end)
   end
end
 
--Initial call
 
if dfhack.isMapLoaded() then
   dfhack.onStateChange.loadTimestream(SC_MAP_LOADED)
end

[Ramiel.]

Hey, just wanted to throw out real quick that I just got dfhack-run.exe reported as a trojan like several others recently.  I see it's happened to multiple users now, such as here and here.  Using dfhack 0.47.04-r2, downloaded and installed directly from github on 8/30, run several times since then with no issues but only today it registered as a Trojan. I didn't even run Dwarf Fortress, just opened the folder containing it. Microsoft Security Essentials (on Win7) detected it as "MSIL/Stealer.RS!MTB". Microsoft's page on the file was made/updated on Sept 23.
I'm sure it's just a false positive, and I'll just be adding it as an exception in my system, but I thought I'd give my experience as an extra data point, give what info I have in case developers want to look into why this is happening/how to stop it.  Either way keep up the fantastic work you guys do, it's so very appreciated.

[lethosor]

There isn't much we can do about that, unfortunately. dfhack-run itself hasn't changed very much in recent years, so this is almost certainly an issue with antivirus definitions.

I would be curious to know if 0.47.04-r3 also triggers the same detection, though. If it does, and 0.47.03-beta1 does not, then it could be related to the color change from March. Otherwise, my reasoning above would still apply.

[Evans]

Scripting question.

I'm trying to restore ancient cage-thrower script into working order.
I'm java guys myself, and LUA was always incredibly weird for me, but after scouring through dozen lua files and some mods, I have finally managed to (almost) restore this script.

Here is how it looks like now (I might refactor it later):

Spoiler (click to show/hide)

local eventful = require 'plugins.eventful'
local utils = require 'utils'

local function posIsEqual(pos1,pos2)
   if pos1.x ~= pos2.x or pos1.y ~= pos2.y or pos1.z ~= pos2.z then return false end
   return true
end

function createItem(mat_type,mat_index,itemType,quality,pos)
   pname = itemType[1]
    local item=df['item_'..pname..'st']:new() --incredible
    item.id=df.global.item_next_id
    df.global.world.items.all:insert('#',item)
    df.global.item_next_id=df.global.item_next_id+1
    if itemType[2]~=-1 then
        item:setSubtype(itemType[2])
    end
    item:setMaterial(mat_type)
    item:setMaterialIndex(mat_index)
    item:categorize(true)
    item.flags.removed=true
    item:setSharpness(1,0)
    item:setQuality(quality)
    dfhack.items.moveToGround(item,{x=pos.x,y=pos.y,z=pos.z})
   return item
end

eventful.onProjItemCheckImpact.capture = function(projectile)
  if dfhack.items.getSubtypeDef(projectile.item:getType(),projectile.item:getSubtype()) ~= nil then
    local ammoType = projectile.item.subtype.id
   -- print ("ammo type " .. tostring(ammoType))
   -- print ("mat type " .. tostring(projectile.item.mat_type))
   -- print ("mat index " .. tostring(projectile.item.mat_index))
   -- print ("mat? " .. tostring(dfhack.matinfo.decode(projectile.item)))
   -- print ("quality? " .. tostring(projectile.item.quality))
    if string.find(ammoType, "_PROJCAGE", 9) then
      local material = dfhack.matinfo.decode(projectile.item)
      if not material then return nil
      end
      
      local unit = nil
      for uid,u in ipairs(df.global.world.units.active) do
         if posIsEqual(u.pos,projectile.cur_pos) then unit = u end
      end

      local cage = createItem(projectile.item.mat_type,projectile.item.mat_index,{'cage',-1},projectile.item.quality,projectile.cur_pos)
      if unit ~= nil then
         local damagefactor = 1
         if unit.counters.winded > 0 then damagefactor = damagefactor/1.5 end
         if unit.counters.stunned > 0 then damagefactor = damagefactor/1.5 end
         if unit.counters.unconscious > 0 then damagefactor = damagefactor/2 end
         if unit.counters.webbed > 0 then damagefactor = damagefactor/1.5 end
         if unit.counters.nausea > 0 then damagefactor = damagefactor/1.5 end
         local bloodfrac = 1
         blood_max = unit.body.blood_max
         if blood_max == 0 then bloodfrac = 1
         else bloodfrac = unit.body.blood_count/unit.body.blood_max
         end
         local prob = 100 - ((unit.body.size_info.size_cur*10 ^ 1/3)*bloodfrac*damagefactor)
         print ("prob " .. tostring(prob))

         if math.random(100) > prob then
            cage_ref = df.general_ref_contained_in_itemst:new()
            cage_ref.item_id = cage.id
            unit.general_refs:insert('#',cage_ref)
            unit.flags1.caged = true

            local allUnits = nil
            allUnits = df.global.world.units.all
            --make other units stop following it
            for i=#allUnits-1,0,-1 do   -- search list in reverse
               newu = allUnits
               if newu.relations.following == unit then
                  newu.relations.following = nil
               end
            end
                  
            unit_ref = df.general_ref_contains_unitst:new()
            unit_ref.unit_id = unit.id
            cage.general_refs:insert('#',unit_ref)
         end
      deleteProjectile(projectile)
     end
    end
  end
end

Now the gun shots nets, they hit the target and put it in the cages just fine.

But I'm getting this error here:

hack/scripts/cageammo.lua:74: Cannot read field unit.relations: not found.

Say waaat?

How do I access relations now? How do I change 'following' flag?

And finally - is there a list of these fields for different objects somewhere?

[PatrikLundell]

All the fields known by the DFHack community are documented as XML files, and yes, I think the relations thing has changed over the years.

In addition to using the XML files, you can also use gui/gm-editor to look at structures (which is often easier). For the unit structure, select any unit in a fortress (probably works in adventure mode as well) and invoke gui/gm-editor from the DFHack terminal. This allows you to browse the structure, and thus see what the current one looks like.

[Evans]

All the fields known by the DFHack community are documented as XML files, and yes, I think the relations thing has changed over the years.

Where would these xml files? I can only see symbols and some files in stonesense folder.

In addition to using the XML files, you can also use gui/gm-editor to look at structures (which is often easier). For the unit structure, select any unit in a fortress (probably works in adventure mode as well) and invoke gui/gm-editor from the DFHack terminal. This allows you to browse the structure, and thus see what the current one looks like.

Thanks. I have ocd when it comes to dealing with problems in the code. To the point, where I can sit for two days straight doing nothing else. But I'm learning to deal with it by asking other people. Kind of works

Anyway.
The field following is there, but its nil and does not seem to be do anything.
After fixing the code, it seems like it is doing nothing now, but LUA keeps executing and now this:

Code: [Select]

unit_ref = df.general_ref_contains_unitst:new()
unit_ref.unit_id = unit.id
cage.general_refs:insert('#',unit_ref)...causes everybody interested to follow the caged creature.

I'll comment it out and see if it works (previously as execution broke earlier, this block wasn't executing and at least my hunter ignored caged animal).

If I get this all working I'll upload whole this as a standalone package for anyone interested.



Edit:
...and they no longer follow the cage with an animal, but now game does not know how to get to this animal either.
Any quick way to clear their interest?

[PatrikLundell]

The XML files are on github, in one of the DFHack projects you'd download if you wanted to develop code.

[mross]

what does the second column in the auto cut gems menu represent? documentation doesn't say anything about it

[lethosor]

what does the second column in the auto cut gems menu represent? documentation doesn't say anything about it

Could you clarify which screen you're talking about or provide a screenshot?

[mross]

what does the second column in the auto cut gems menu represent? documentation doesn't say anything about it

Could you clarify which screen you're talking about or provide a screenshot?