Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Roses]

Couple item syndrome questions:

1. So with itemsyndrome, is it possible to give an item that gives a syndrome that gives an interaction to a dwarf? For example, if I give a dwarf a shield can I give that shield a syndrome that allows the dwarf to do the 'shield bash' interaction?

2. If this is possible, can a single item confer multiple interactions?

3. Can itemsyndrome also work on materials the item is made from? For instance, normal boots do nothing, but boots made of levisium make the user faster?

4. If both are possible, can a single item confer a syndrome from the item type and material type?

[Nahere]

Couple item syndrome questions:

1. So with itemsyndrome, is it possible to give an item that gives a syndrome that gives an interaction to a dwarf? For example, if I give a dwarf a shield can I give that shield a syndrome that allows the dwarf to do the 'shield bash' interaction?

2. If this is possible, can a single item confer multiple interactions?

3. Can itemsyndrome also work on materials the item is made from? For instance, normal boots do nothing, but boots made of levisium make the user faster?

4. If both are possible, can a single item confer a syndrome from the item type and material type?

Yes to all four, as far as I'm aware.

[Putnam]

To the first two: anything you can do with normal syndromes can be done with itemsyndrome.

To 3: actually, that was how it originally worked. I added item-based syndromes later.

4. Yeah. I didn't exactly try to make that happen, but it does happen, which is a welcome coincidence.

[Meph]

But can you make levisium boots that make you faster, but a levisium armor that does not make you faster? a way to give a syndrome only if material and item fit together.

[Putnam]

Why? I can't really think of why you'd want that. I mean, you could always have items only able to be made of the one material.

Code: [Select]

local function applySyndromesBasedOnItems(_uid,unit)
    if itemsyndromedebug then print("Checking unit #" .. _uid+1) end
    local transformation = false
    for itemid,item_inv in ipairs(unit.inventory) do
        local item = item_inv.item
        if itemsyndromedebug then print("checking item #" .. itemid+1 .." on unit #" .. _uid+1) end
        if getSyndrome(getMaterial(item)) then
            if itemsyndromedebug then print("item has a syndrome, checking if item is valid for application...") end
            local syndrome = getSyndrome(getMaterial(item))
            local syndromeApplied
            if syndromeIsTransformation(syndrome) then
                unitInventory = rememberInventory(unit)
                transformation = true
            end
            if syndromeIsDfHackSyndrome(syndrome) and creatureIsAffected(unit,syndrome) and itemIsInValidPosition(item_inv, syndrome) then
                assignSyndrome(unit,syndrome.id)
                syndromeApplied = true
            end
        end
        if itemHasSyndrome(item) then
            if itemsyndromedebug then print("Item itself has a syndrome, checking if item is in correct position and creature is affected") end
            local syndrome = itemHasSyndrome(item)
            if syndromeIsTransformation(syndrome) then
                unitInventory = rememberInventory(unit)
                transformation = true
            end
            if item_inv.mode~=0 and item_inv.mode~=7 and creatureIsAffected(unit,syndrome) then assignSyndrome(unit,syndrome.id) end --the mode thing is to avoid stuckins from doing
        end
        if itemsyndromecontaminants and item.contaminants then
            if itemsyndromedebug then print("Item has contaminants. Checking for syndromes...") end
            for _,contaminant in ipairs(item.contaminants) do
                if itemsyndromedebug then print("Checking contaminant #" .. _ .. " on item #" .. itemid .. " on unit #" .. _uid ..".") end
                if getSyndrome(getMaterial(contaminant)) then
                    local syndrome = getSyndrome(getMaterial(contaminant))
                    if syndromeIsTransformation(syndrome) then
                        unitInventory = rememberInventory(unit)
                        transformation =true
                    end
                    if syndromeIsDfHackSyndrome(syndrome) and creatureIsAffected(unit,syndrome) and itemIsInValidPosition(item_inv, syndrome) then assignSyndrome(unit,syndrome.id) end
                end
            end
        end
    end
    if transformation then dfhack.timeout(2,"ticks",function() moveAllToInventory(unit,unitInventory) end) end
end
I don't wanna make this function any bigger, dang it!

[Meph]

It wasnt a request, it was a question. Because I think that is what the poster above me meant. No worries, I know how to do it with interactions and your current script, I was just wondering about it.

Possible use is some sort of wonder material that gives different effects to different items, but even then you can just use identical inorganics with same name, different ID and different effects.

[Roses]

To the first two: anything you can do with normal syndromes can be done with itemsyndrome.

To 3: actually, that was how it originally worked. I added item-based syndromes later.

4. Yeah. I didn't exactly try to make that happen, but it does happen, which is a welcome coincidence.

That is perfect, thanks!

[Putnam]

I'm going to be modifying itemsyndrome like crazy so here's a snapshot of it

[Roses]

I'm going to be modifying itemsyndrome like crazy so here's a snapshot of it

My knowledge of Dwarf Hack is very limited. What are you going to be modifying?

[Putnam]

Minor performance and sense improvements. The current version there, for example, has a slight (untested) difference in how it determines when a unit will get their items checked relative to other units (I.E only units that have inventories will be checked and they will be checked sequentially, tick by tick).

The version I posted up there is always to be considered experimental, note, unless I say it's tested working.

[narhiril]

Hey,

Running into an issue that I was hoping you might be able to help with.  If a unit picks up an item without an assigned material, the plugin crashes.

stderr:

Code: [Select]

...sktop\LFR DFHack Test Copy\hack\scripts/itemsyndrome.lua:54: attempt to index local 'material' (a nil value)
stack traceback:
...sktop\LFR DFHack Test Copy\hack\scripts/itemsyndrome.lua:54: in function 'getMaterial'
...sktop\LFR DFHack Test Copy\hack\scripts/itemsyndrome.lua:280: in function 'findItems'
...sktop\LFR DFHack Test Copy\hack\scripts/itemsyndrome.lua:335: in function <...sktop\LFR DFHack Test Copy\hack\scripts/itemsyndrome.lua:333>


Is there a way to add a safeguard against this situation (maybe another if statement)?  If I were more familiar with lua, I'd do it myself, but I'm not sure exactly which command in the if statement on line 54 is causing the issue.

[Putnam]

The script doesn't crash, just throw an error. Of course, that's still damn annoying, so I'll fix it.

EDIT: Fixed in the snapshot version, which is stable, btw.

[narhiril]

The script doesn't crash, just throw an error. Of course, that's still damn annoying, so I'll fix it.

...Except it stops performing checks after throwing that error.  Not sure why - maybe that's a DFHack thing?

Anyway, I think this will work.

Code: [Select]

local function getMaterial(item)
    local material = dfhack.matinfo.decode(item)
    if itemsyndromedebug then
print(material)
end
    if material ~= nil then
    if material.mode ~= "inorganic" then
return nil
else
return material.material --the "material" thing up there contains a bit more info which is all pretty important, like the creature that the material comes from
end
end
end


[Putnam]

Then it's a good thing I fixed it, eh?

(though it would have been better had I not been all naive about my return codes--reminder to self: never have a function return nil if the function is supposed to return a value!)

[Meph]

the the currently included version in your download on DFFD includes a fix for this`?