These are my soldiers. I tend to screen migrants to be added to existing units or start new ones over time. Skill with a melee weapon and a historical career as a hunter/wanderer/scout (that is potentially large kill lists from worldgen,) automatically gets them earmarked for the military no matter what.
Personality: Bravery (or only a slight lack thereof,) Sense of Duty, Likes to Pick Fights, Adventurous
Physical: Willpower, Endurance, Agility, with Strength as a secondary since it doesn't matter as much for edged weapons.
Personal beliefs/Dreams: Exercising power over others, Values chaos/war over Peace, Dreams of mastering a skill <- These last two are preferred attributes, as they tend to be religious in thier pursuit of mastery of arms and easily fulfill thier dream of skill mastery.
Skilled workers tend to be based heavily on what skills they already posses and what needs doing, along with thier work ethic and preferences (someone with high endurance, a love of silver, gold, copper, or bronze, and a sense of duty is preferred to be making my crafts or swords than that jackass who likes sparrow bone and tapir leather and has a lazy streak.) For example, someone who likes shields will end up a carpenter, as I tend to always make my shields out of wood to save on metal and weight, and I prize skilled leatherworkers because as of late I've been eschewing heavy armor.
Creativity/Intellectualism and valuing art and its creation are bonuses but not strictly needed, due to the higher quality of goods such dorfs produce, while those who don't give a damn about art are going to end up farmhands, haulers, construction workers, or soldiers in all likelihood, unless they arrive with exceptional skill in a crafts field.