Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[i2amroy]

I'm saying get two variables, hours and minutes, and store/check them separately.  So, if I understand you correctly, yes.

But why would you make two IF's? If one of the ifs for error are triggered then why check the rest?

Doing If (Hours <24) and if (minutes <.59) would make two seprate checks and that could continue the program despite its answer being flawed.

Code it as:

Code: [Select]

if (hours > 24 || minutes >59) {
throw error
}

do other stuff

[3man75]

I'm saying get two variables, hours and minutes, and store/check them separately.  So, if I understand you correctly, yes.

But why would you make two IF's? If one of the ifs for error are triggered then why check the rest?

Doing If (Hours <24) and if (minutes <.59) would make two seprate checks and that could continue the program despite its answer being flawed.

Code it as:

Code: [Select]

if (hours > 24 || minutes >59) {
throw error
}

do other stuff

Spoiler: Code (click to show/hide)

    if (startTime > 23.59 || startTime < 0){

      cout << "Error. Hours and minutes cannot be negative or above 24 hours." << endl;




   if (startTime <= timeMorning || startTime >= timeMorningBegins){
      // In here is my code for the morning rate.
      cout << "Because you talked for: " << minutes << " minutes. It will cost you: "
         << minutes*morningRate << "." << endl;
      cout << "MORNING!";
   }

Like so? Doesn't seem to compile for me..

[RulerOfNothing]

Again, typing 19.-33 won't trigger the first error because 19.-33 is not an actual number. When you store input as a number the variable can only take values that are actual numbers and so minuteRemainder will never be less than 0. Also because of how cin works when you type 19.-33 it treats it as "19." and "-33" because it stops when it encounters the minus sign when it is taking the first number.

[TheBiggerFish]

I'm saying get two variables, hours and minutes, and store/check them separately.  So, if I understand you correctly, yes.

But why would you make two IF's? If one of the ifs for error are triggered then why check the rest?

Doing If (Hours <24) and if (minutes <.59) would make two seprate checks and that could continue the program despite its answer being flawed.

Code it as:

Code: [Select]

if (hours > 24 || minutes >59) {
throw error
}

do other stuff

Thanks.

I misrepresented my suggestion.  You shouldn't change the singular if statement which you have checking the validity.
But you should definitely take minutes and hours in as separate variables, because as others have said, the .-33 is not reaching your code properly.
It should stop messing up.

[Bauglir]

Also, that code won't compile because you forgot a curly brace after the error check. || means "or", in case that wasn't mentioned.

[3man75]

Also, that code won't compile because you forgot a curly brace after the error check. || means "or", in case that wasn't mentioned.

Found that after I posted 

Again, typing 19.-33 won't trigger the first error because 19.-33 is not an actual number. When you store input as a number the variable can only take values that are actual numbers and so minuteRemainder will never be less than 0. Also because of how cin works when you type 19.-33 it treats it as "19." and "-33" because it stops when it encounters the minus sign when it is taking the first number.

I'm saying get two variables, hours and minutes, and store/check them separately.  So, if I understand you correctly, yes.

But why would you make two IF's? If one of the ifs for error are triggered then why check the rest?

Doing If (Hours <24) and if (minutes <.59) would make two seprate checks and that could continue the program despite its answer being flawed.

Code it as:

Code: [Select]

if (hours > 24 || minutes >59) {
throw error
}

do other stuff

Thanks.

I misrepresented my suggestion.  You shouldn't change the singular if statement which you have checking the validity.
But you should definitely take minutes and hours in as separate variables, because as others have said, the .-33 is not reaching your code properly.
It should stop messing up.

I don't think I understand. Can you re-word this a bit?

What I think i'm getting is that I should: Keep my startime check and after that bit of code ask for minutes. Once I get minutes I should check it to make sure its fine?

I use minute *Garbled mind blown*

Okay. I'm doing this now.

else if (minuiteRemainder < 0.00 || minutes < 0){

How would that stop me from inputing 19.333 as a time?

[TheBiggerFish]

You need to get two things from the user (number of hours and also number of minutes), instead of one compound thing (number of hours with number of minutes stuck on the end).
Other than that, you should be good, as long as you fix the actual variables and the numbers.

[Bauglir]

What sorts of user input are you dealing with, here? Because if you really want to idiot-proof this, you'll probably want to do something like storing the input as a string, then attempting to parse every format you can imagine down to a correct sequence of numbers, and generate an error message for the ones you don't predict or which are too ambiguous. That's probably more than you really want.

Realistically, you should probably be getting two separate inputs for each of minutes and hours, because despite time being measured numerically most common representations aren't numbers as far as the computer is concerned. For example, ':' isn't a valid character in a numeral, and the time 6.30 is very much not the same as the decimal number 6.30. So you should expect that user input won't be in the form of a number.

EDIT: So the user would see something like "Please enter the hour" followed by "Please enter the minute" after they entered the hour.

[TheBiggerFish]

What sorts of user input are you dealing with, here? Because if you really want to idiot-proof this, you'll probably want to do something like storing the input as a string, then attempting to parse every format you can imagine down to a correct sequence of numbers, and generate an error message for the ones you don't predict or which are too ambiguous. That's probably more than you really want.

Realistically, you should probably be getting two separate inputs for each of minutes and hours, because despite time being measured numerically most common representations aren't numbers as far as the computer is concerned. For example, ':' isn't a valid character in a numeral, and the time 6.30 is very much not the same as the decimal number 6.30. So you should expect that user input won't be in the form of a number.

EDIT: So the user would see something like "Please enter the hour" followed by "Please enter the minute" after they entered the hour.

Yeah.

[EnigmaticHat]

Arch Linux

This sounds fake.

Like someone was making a computer wizard joke.

[Avis-Mergulus]

Arch Linux

This sounds fake.

Like someone was making a computer wizard joke.

Little did EnigmaticHat know... It was not a computer wizard joke, but instead a horrifying computer wizard reality.

[EnigmaticHat]

Sorry.

[Gatleos]

I seem to have tangled myself up in a hell of inheritance and static data classes.

Say I have a class called Animal, which defines things like a position for the animal. Then I have a class called StaticAnimal, which defines data that is common to all animals of a specific species. It doesn't make sense to copy this data every time I make an animal of that type, so every Animal of a specific type just contains a const pointer to a single instance of StaticAnimal.

But then I add in some child classes for Animal, like Dog. It contains some dynamic dog-specific information and overridden functions, but now I need some static data. Out comes StaticDog, which inherits from StaticAnimal. It sounds pretty logical, but then I start seeing flaws. Every object of a type that derives from Animal has a pointer to both its own static type and a StaticAnimal object, which isn't so much a problem as it is inelegant. I realize later that I need to change the static data pointed to by an Animal-derived object sometimes, which means every child class needs its own individual setStaticData function. Problems just seem to keep piling up.


Anybody here have a policy they usually use for storing separate static data like this? My method here was essentially developed in a vacuum, I've never seen other people's methods before.

[EnigmaticHat]

Can the data for each species be expressed as an array?  If the answer is yes, use a dictionary of string keys and array values.  Make it part of a class that has functions that take a key and retrieve a given value from the array.

Alternately, make a separate dictionary for each property, and give them all the same keys for each species.  So something like numberOfLegsDict, numberOfEyesDict, each of which accepts the values of "dog" and "spider".

[Gatleos]

Can the data for each species be expressed as an array?  If the answer is yes, use a dictionary of string keys and array values.  Make it part of a class that has functions that take a key and retrieve a given value from the array.

Alternately, make a separate dictionary for each property, and give them all the same keys for each species.  So something like numberOfLegsDict, numberOfEyesDict, each of which accepts the values of "dog" and "spider".

Hmm, I didn't think of organizing data in groups of the same trait. That could work.

Also I guess the static data thing I was referring to is called the Flyweight Pattern.