Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[cerapa]

Why would you want to split it into two loops though?

It's multithreaded. It was quite consistently crashing before I pulled the drawing of a surface and creation of a texture out of the secondary thread and into the main one. Seems quite a bit more stable right now. Most likely the conversion to texture was crashing it*, but the drawing of the surface is so lightweight that you really only notice it when the created thing is fuckhuge, so it's not really worth it to juggle things around more.

*putpixel() doesn't affect the inner workings of SDL at all actually, but whatever

[Virex]

You might want to check the documentation for whatever you're using to draw stuff. Graphics libraries generally don't like it when you're sending requests from multiple threads.

[MrWillsauce]

Is the problem here that tokens is never reset in the loop, so that tokens[3] means the same thing no matter how many times the loop is run? If so, how do I reset the value of a vector? Should I be using some other aggregate data type besides a vector for this?

[MagmaMcFry]

Code: [Select]

                vector<string> tokens;
                for(int iii = 0; iii < (sizeof tokens); ++iii)
                {
                        string strCommand;
                        getline(inf, strCommand);
                        if (strCommand == strEndRead) break;
                        istringstream iss(strCommand);
                        copy(istream_iterator<string>(iss), istream_iterator<string>(), back_inserter<vector<string> >(tokens));
                        if (nTemporaryPopulation < 1) break;
                        int y = strToInt(tokens[1]);
                        nTemporaryPopulation = nTemporaryPopulation - y;
                        CommandController::runCommand(tokens, data, y, strStartRead);
                }
                inf.close();
                return 0;
Okay, this is an absolute mess. First off, what the hell is the for loop for? Next, "sizeof tokens" doesn't even remotely mean what you think it means, you should never ever use it unless you're writing advanced memory optimization code.
Lemme just clean this up for you:

Code: [Select]

vector<string> tokens;
string strCommand;
getline(inf, strCommand);
if (strCommand == strEndRead) break;
istringstream iss(strCommand);
copy(istream_iterator<string>(iss), istream_iterator<string>(), back_inserter<vector<string> >(tokens));
nTemporaryPopulation -= y;
if (nTemporaryPopulation < 0) break;
if (tokens.size() < 2) break;
int y = strToInt(tokens[1]);
CommandController::runCommand(tokens, data, y, strStartRead);
inf.close();
return 0;


[MrWillsauce]

Right. I think I originally made the for loop conditions while not entirely coherent after I tried to make the condition tokens.size and that didn't work (or something). I don't really have an excuse for that manifestation of my idiocy, but I do know what the sizeof operator does. I actually changed it to a while(inf) loop since my last paste, but I figured it wouldn't have worked either way.

Code: [Select]

while(inf)
{
string strCommand;
getline(inf, strCommand);
if (strCommand == strEndRead) break;
istringstream iss(strCommand);
copy(istream_iterator<string>(iss), istream_iterator<string>(), back_inserter<vector<string> >(tokens));
if (tokens.size() < 2) break;
int y = strToInt(tokens[1]);
nTemporaryPopulation -= y;
if (nTemporaryPopulation < 0)
{break;
cout << "error";}
CommandController::runCommand(tokens, data, y, strStartRead);
}
Seems to work perfectly, I just need to tidy up the function that prints everything.

[Mephisto]

Code: [Select]

{break;
cout << "error";}


Unreachable code?

Also, those curly braces.

[Siquo]

Code: [Select]

{break;
cout << "error";}


Unreachable code?

Also, those curly braces.

It's a totally new style.

I dig it.

I'm going to spend the afternoon re-styling all my code like that.

[Skyrunner]

I just realized that Visual Studio 2010 doesn't support the for (x : y) syntax, which is why it instead has for each (x in y)....

[MrWillsauce]

My program suddenly stopped working, seemingly without cause.

1>------ Build started: Project: MrWillsauce2.0, Configuration: Debug Win32 ------
1>LINK : fatal error LNK1168: cannot open C:\Microsoft Visual Studio 10.0\Projects\MrWillsauce2.0\Debug\MrWillsauce2.0.exe for writing
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Any idea why this file would disappear or how I can fix this or what?

[MagmaMcFry]

If there is such a file, you need to delete it. If it is currently used by another process, your program is probably still running and you need to quit it.

[olemars]

Googling for help abot a stack overflow problem has becoming a lot harder in recent years.

[Skyrunner]

Googling for help abot a stack overflow problem has becoming a lot harder in recent years.

What changed?

[Draxis]

Now all you will find is the site Stack Overflow.

[MrWillsauce]

I'm having difficulties with my program.

When the EmpireHoldings.dat file has these contents

Spoiler (click to show/hide)

*Human Empire:
Coal: 0
Dwarves: 0
Elves: 0
Farms: 0
Fisheries: 0
Food: 0
Forges: 0
Fortresses: 0
Graveyards: 0
Hobbits: 0
Horses: 0
IronArmor: 0
IronBars: 0
IronOre: 0
IronWeapons: 0
Kobolds: 0
Mines: 0
MithrilArmor: 0
MithrilBars: 0
MithrilWeapons: 0
NaturePreserves: 0
Population: 2
RawMithril: 0
Stables: 0
SteelArmor: 0
SteelBars: 0
SteelWeapons: 0
SubterraneanFarms: 0
Sulfur: 0
Towers: 0
Towns: 0
UnicornPens: 0
Unicorns: 0
Wood: 0
endHuman

and HFC Input.dat has these

Spoiler (click to show/hide)

*Human Empire:

build 2 towns

endHuman

the holdings of the empire aren't changed at all. Also, in the loop that reads the inputs, trying to stream the strings being read from the input file into the console doesn't work.

Code: [Select]

while(inf)
{
string strCommand;
getline(inf, strCommand);
cout << strCommand; //does not show up on console
if (strCommand == strEndRead) break;
istringstream iss(strCommand);
copy(istream_iterator<string>(iss), istream_iterator<string>(), back_inserter<vector<string> >(tokens));
if (tokens.size() < 2) break;
int y = strToInt(tokens[1]);
nTemporaryPopulation -= y;
if (nTemporaryPopulation < 0)
{cout << "error";
break;}
CommandController::runCommand(tokens, data, y, strStartRead);
}

[MagmaMcFry]

There's a problem with this line:

Code: [Select]

if (tokens.size() < 2) break;

This will abort the entire input reading process if any line has less than 2 tokens.
Try this instead:

Code: [Select]

while(inf) {
string strCommand;
getline(inf, strCommand);
cout << "Parsing command: " << strCommand << endl;
if (strCommand == strEndRead) break;
istringstream iss(strCommand);
copy(istream_iterator<string>(iss), istream_iterator<string>(), back_inserter<vector<string> >(tokens));
if (tokens.size() >= 2) {
int y = strToInt(tokens[1]);
nTemporaryPopulation -= y;
if (nTemporaryPopulation < 0) {
cout << "error";
break;
}
CommandController::runCommand(tokens, data, y, strStartRead);
}
}