Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[MagmaMcFry]

Huh, I'm pretty sure I actually used something from that header. I guess it's gone now.

[MrWillsauce]

Is there a way for me to write a loop that prints all of the values from the getHoldings function?

[cerapa]

Is there a way for me to write a loop that prints all of the values from the getHoldings function?

Code: [Select]

for (auto holding: data) {
cout << holding.first << " " << holding.second << endl;
}Should work.

[MagmaMcFry]

Is there a way for me to write a loop that prints all of the values from the getHoldings function?

Code: [Select]

for (auto holding: data) {
cout << holding.first << " " << holding.second << endl;
}Should work.

That prints out all the holdings, but it doesn't look very good. To make it look good, you could make a static map<string, string> langMap of translations, mapping "sRawMithril" to "Raw Mithil" and similar, then use langMap[holding.first] instead of holding.first. If you read that translation from an external text file, you could even have multiple language files in different languages to choose from.

[MrWillsauce]

Code: [Select]

        int getHoldings(string strEndRead)
        {
ifstream fin("EmpireHoldings.dat");
                istringstream is();
                while (true) {
                        string key;
                        int value;
                        is.str(fin.getline());
                        is >> key;
                        if (key == strEndRead) break;
                        is >> value;
                        data[key] = value;
                }
        }
My compiler tells me "left of '.str' must have class/struct/union." I did #include <sstream> in case that might have been the cause.

E: I think it's because the declaration of is has parentheses. I got a different error when I removed them though.

"'std::basic_istream<_Elem,_Traits>::getline' : no overloaded function takes 0 arguments"

[MagmaMcFry]

Okay, so getline works differently than I thought:

Code: [Select]

        int getHoldings(string strEndRead)
        {
ifstream fin("EmpireHoldings.dat");
                istringstream is;
                while (true) {
                        string key;
                        int value;
                        string line;
                        getline(fin, line);
                        is.str(line);
                        is >> key;
                        if (key == strEndRead) break;
                        is >> value;
                        data[key] = value;
                }
        }


[MrWillsauce]

Are you sure 'is' should be used to assign a value to 'value'? I don't think we can give value a string.

[Lightningfalcon]

I finally finished code for a problem I was given in my AP CompSci class just now.  The purpose is to "Write a function that takes and integer argument.  Return true if the number is divisible by all of its digits (if a digit is 0 return false) else retuen false" Can you guys tell me how badly I messed this up-

Spoiler (click to show/hide)

public static boolean divstuff(int num)
    {
       int newnum=num; //sets initial value because otherwise I get errors
       int length = String.valueOf(num).length(); //Gets length of num
       boolean tf=false; //use this for determining if class returns true/false because otherwise errors      
       for(int count=0; count<=length; count++)
       {
          if (count==length) //if count is equivelent to the length of the number then everything is divisible
          {
             tf=true;
             break;
          }
          else  //still numbers that need to be divided
          {
             
             int temp=newnum%10;  //get's last number
             if (temp==0)  //Because I don't want divided by zero
             break; //A number can't be divided by it's factors if it has zero
             else
             if ((num%temp)!=0) //Divides num by one of it's numbers, and checks if modulo is zero
             break;
             else
             newnum=newnum/10; //get's new last number
          }
       }
       if (tf==true)
       return true;
       else return false;
   }

Also are there are any ways to improve the efficiency of this?  And are there any ways to input a number to break this?

[MagmaMcFry]

Are you sure 'is' should be used to assign a value to 'value'? I don't think we can give value a string.

Since 'value' is of type int, the >> operator extracts an integer definition from the stringstream and stores that in 'value'.

Edit for Lightningfalcon:

Code: [Select]

public static boolean divstuff (int basenum) {
int num = basenum;
while (num > 0) {
int digit = num % 10;
if (digit == 0 || basenum % digit != 0) return false;
num /= 10;
}
return true;
}

[MrWillsauce]

Well when I try to compile the program, I get the error "binary '[' : no global operator found which takes type 'std::string' (or there is no acceptable conversion)," referring to data[key] = value;

[MagmaMcFry]

I guess that means that data has no operator[](string). Weird. Can you post your entire code, just to be sure?

[MrWillsauce]

Code: [Select]

#include "stdafx.h"
#include <iostream>
#include <fstream>
#include <sstream>
#include <string>
#include <map>
using namespace std;



struct Structures
{
int farms;
int subterraneanFarms;
int mines;
int forges;
int naturePreserves;
int stables;
int unicornPens;
int fisheries;
int fortresses;
int towns;
int graveyards;
int towers;
};
struct Stocks
{
int food;
int wood;
int horses;
int coal;
int sulfur;
int ironOre;
int ironBars;
int ironWeapons;
int ironArmor;
int steelBars;
int steelWeapons;
int SteelArmor;
int rawMithril;
int mithrilBars;
int mithrilWeapons;
int mithrilArmor;
int unicorns;
int humanPopulation;
int elfPopulation;
int dwarfPopulation;
int koboldPopulation;
int hobbitPopulation;
};
struct Technologies
{
bool mining;
bool mithrilMining;
bool blastingCharges;
bool fieldAgriculture;
bool subterraneanFarming;
bool horseDomestication;
bool unicornDomestication;
bool preservation;
bool fishDomestication;
bool woodcutting;
bool smelting;
bool steelsmelting;
bool armoring;
bool weaponSmithing;
bool mithrilSmelting;
bool mithrilSmithing;
bool charcoalBurning;
bool theft;
bool masterTheft;
bool stealthManeuvering;
bool fortress;
bool wallConstruction;
bool sailing;
int researchPoints;
};
struct Population
{
int population;
};
class Holdings
{
public:
map <string, int> data();

//takes data from EmpireHoldings.dat and assigns it to variables
int getHoldings(string strEndRead)
{
ifstream fin("EmpireHoldings.dat");
                istringstream is;
                while (true) {
                        string key;
                        int value;
                        string line;
                        getline(fin, line);
                        is.str(line);
                        is >> key;
                        if (key == strEndRead) break;
                        is >> value;
                        data[key] = value;
                }
}

//changes variables based on HFC Input.dat
int getInputs()
{
return 0;
}
//prints up-to-date data to EmpireHoldings.dat
int printHoldings()
{
return 0;
}

};
int main()
{
Holdings HumanHoldings;
HumanHoldings.getHoldings("endHuman");
return 0;
}

[MagmaMcFry]

Oh, whoops.

Code: (Quick fix) [Select]

map <string, int> data;


[MrWillsauce]

That's what I get for just copying things >.< thanks.

[MrWillsauce]

How would I return all of the values that I fed to the map at the end of the function? Just 'return data'?