Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Mego]

DIBS

Let's start off with dealing with errors first, and then we'll talk about improving the code.

Compiling with gcc 4.7.2:

Code: [Select]

main.cpp: In function ‘std::unordered_map<std::basic_string<char>, MarkovNode> MarkovBuilder(std::queue<std::basic_string<char> >)’:
main.cpp:39:41: error: ‘class std::map<std::basic_string<char>, unsigned int>’ has no member named ‘emplace’
main.cpp:48:48: error: ‘class std::map<std::basic_string<char>, unsigned int>’ has no member named ‘emplace’
main.cpp: In function ‘std::unordered_map<std::basic_string<char>, MarkovNode> MarkovBuilder(std::queue<std::basic_string<char> >, std::unordered_map<std::basic_string<char>, MarkovNode>)’:
main.cpp:67:38: error: ‘class std::map<std::basic_string<char>, unsigned int>’ has no member named ‘emplace’
main.cpp:77:45: error: ‘class std::map<std::basic_string<char>, unsigned int>’ has no member named ‘emplace’
main.cpp: In function ‘std::queue<std::basic_string<char> > Tokeniser(std::string)’:
main.cpp:96:38: error: ‘strtok’ was not declared in this scope

All but the last error comes from the fact that you're trying to call map::emplace, which doesn't exist. Change those to unordered_map, or (what I believe is your intention) use map::operator[]. Also, iterators act like pointers, so you'll need to dereference them to access the value.

The last error comes from the fact that you're trying to call the strtok function without including <cstring>. Include it, and use std::strtok.

Some warnings also popped up about not returning anything from non-void functions. FindLikeliest and MarkovBuilder will have issues if tokens is empty, because then they will reach the end of the function without a return statement. I added some throws in there to circumvent that. It'll help your testing.

Fixed code:

Code: [Select]

#include <map>
#include <unordered_map>
#include <queue>
#include <string>
#include <fstream>
#include <iostream>
#include <cstring>

struct MarkovNode {
   MarkovNode();
   std::string FindLikeliest();
   unsigned int totalLinksCount;
   std::map <std::string, unsigned int> linksForward;
};

MarkovNode::MarkovNode() {
   totalLinksCount = 0;
}
std::map <std::string, unsigned int> linksForward;

std::string MarkovNode::FindLikeliest() {
   std::pair <std::string, unsigned int> likeliest;
   if (linksForward.empty() != true) {
      likeliest = *linksForward.begin();
      for ( std::map <std::string, unsigned int>::iterator it = linksForward.begin(); it != linksForward.end(); ++it ) {
         if(it->second > likeliest.second); likeliest = *it;
      }
      return likeliest.first;
   } else throw std::exception();
}

std::unordered_map <std::string, MarkovNode> MarkovBuilder (std::queue <std::string> tokens) {
   if (tokens.empty() != true) {
      std::string lastWord;
      std::unordered_map <std::string, MarkovNode> markovChain; // New graph

      markovChain.emplace ("START", MarkovNode()); // Start node for empty text

      markovChain.emplace (tokens.front(), MarkovNode()); // Node for first
      markovChain["START"].linksForward[tokens.front()] = 1; // Link to start node

      lastWord = tokens.front();
      while (tokens.empty() == false) {
         tokens.pop(); // Removes first word
         markovChain.emplace (tokens.front(), MarkovNode()); // Node for second
         if ( markovChain[lastWord].linksForward.count(tokens.front()) == 1 ) { // Increments count for link to second word if one exists
            markovChain[lastWord].linksForward[tokens.front()]++;
         } else {
            markovChain[lastWord].linksForward[tokens.front()] = 1; // Creates a new link.
         }
         lastWord = tokens.front(); // Moves on to third.
      }

      return markovChain;
   } else throw std::exception();
}
   // Chain always starts with a START node.

std::unordered_map <std::string, MarkovNode> MarkovBuilder
      ( std::queue <std::string> tokens, std::unordered_map <std::string, MarkovNode> markovChain) {

   std::string lastWord;

   markovChain.emplace (tokens.front(), MarkovNode()); // Node for first
   if (markovChain["START"].linksForward.count(tokens.front()) == 1 ) {
      markovChain["START"].linksForward[tokens.front()]++;
   } else {
   markovChain["START"].linksForward[tokens.front()] = 1; // Link to start node
   }

   lastWord = tokens.front();
   while (tokens.empty() == false) {
      tokens.pop(); // Removes first word
      markovChain.emplace (tokens.front(), MarkovNode()); // Node for second; if existing, this will simply let it refer to the earlier occurrence.
      if ( markovChain[lastWord].linksForward.count(tokens.front()) == 1 ) { // Increments count for link to second word if one exists
         markovChain[lastWord].linksForward[tokens.front()]++;
      } else {
         markovChain[lastWord].linksForward[tokens.front()] = 1; // Creates a new link.
      }
      lastWord = tokens.front(); // Moves on to third.
   }

   return markovChain;
}

std::queue <std::string> Tokeniser (std::string filename) {
   std::queue <std::string> token;
   std::ifstream file (filename, std::ios::in|std::ios::binary|std::ios::ate);
   if (file.is_open())
   {
      file.seekg(0, std::ios::end);
      unsigned long size = file.tellg();
      char *contents = new char [size];
      file.seekg (0, std::ios::beg);
      file.read (contents, size);
      file.close();
      char* tok = std::strtok(contents," ");
      while (tok != NULL) {
         token.push(tok);
         tok = strtok(NULL," ");
      }
      delete [] contents;
   }
   return token;
}

int main ()
{
   std::queue <std::string> tokens = Tokeniser ("sample.txt");
   std::unordered_map <std::string, MarkovNode> markovChain = MarkovBuilder(tokens);

   unsigned int outputLengthTokens = 5;

   std::string nextToken;
   std::string temp;

   std::string typicalPhrase;
   nextToken = markovChain["START"].FindLikeliest();
   temp = nextToken;
   typicalPhrase = nextToken;

   for(unsigned short i = 1; i < outputLengthTokens; ++i) {
      nextToken = markovChain[temp].FindLikeliest();
      temp = nextToken;
      typicalPhrase.append(" ");
      typicalPhrase.append(nextToken);
   }

   std::cout << typicalPhrase;

   return 0;
}

There are more issues, but I trust that you will be able to figure them out on your own.

[ECrownofFire]

But map::emplace does exist, it's just that GCC 4.7 doesn't implement it.

4.8.1 has it, though. Stop using outdated compilers

[lordnincompoop]

Yeah, I get none of those errors, Mego. std::map has an emplace member as specified in the standard. There are lots of things about c++11 that gcc 4.7 doesn't implement.

Thanks about the throws, but leaving the most critical error (the iteration runtime error) as "something to figure out on my own" when I've already spent too many hours pulling my hair at this before coming here is counter-productive.

Use the debugger and find out where it crashed. MSVC has a fairly good one. It sounds like you might be dereferencing an "end" iterator or an iterator inside an empty container.

Alright, I'll try that later today.

On other notes, that code hurts my eyes

You should really be using range-for loops.
MarkovNode constructor is unnecessary and inefficient, you should just use default initialization (totalLinksCount = 0;).
This is incredibly overcomplicated. Just have each node store its own string and a std::list of its children.

Hey, I never said I was good at this stuff.

I needed a counter for each child because that's the only way of keeping track of what is the most commonly used word after that one. I also wanted to implement a probabilistic method later down the road to create paragraphs that the user would conceivably write (in the program's mind). I realise the findLikeliest function and all that is inefficient, but I'm not familiar enough with STL to know a better alternative than std::map that allows for such convenient coupling b/w the word and its commonality.

'sides, this is a kinda hacky proof-of-concept for a mathematics essay. It doesn't need to be fully compatible with the Programming Best Practices.

[Mego]

But map::emplace does exist, it's just that GCC 4.7 doesn't implement it.

4.8.1 has it, though. Stop using outdated compilers

And apparently outdated reference materials - the site I was using for reference didn't have it listed, even though it had unordered::map documented. My bad.

lordnincompoop - I would help you, but I have no idea what kind of data you're giving to the program. If you uploaded sample.txt, I'd be able to help you better.

[lordnincompoop]

Fair enough.

sample.txt is just a bunch of lorem ipsum, but any prose text would do. For example:

Spoiler (click to show/hide)

In the late summer of that year we lived in a house in a village that looked across the river and the plain to the mountains. In the bed of the river there were pebbles and boulders, dry and white in the sun, and the water was clear and swiftly moving and blue in the channels. Troops went by the house and down the road and the dust they raised powdered the leaves of the trees. The trunks of the trees too were dusty and the leaves fell early that year and we saw the troops marching along the road and the dust rising and leaves, stirred by the breeze, falling and the soldiers marching and afterward the road bare and white except for the leaves. The plain was rich with crops; there were many orchards of fruit trees and beyond the plain the mountains were brown and bare. There was fighting in the mountains and at night we could see the flashes from the artillery. In the dark it was like summer lightning, but the nights were cool and there was not the feeling of a storm coming. Sometimes in the dark we heard the troops marching under the window and guns going past pulled by motor-tractors. There was much traffic at night and many mules on the roads with boxes of ammunition on each side of their pack-saddles and gray motor trucks that carried men, and other trucks with loads covered with canvas that moved slower in the traffic. There were big guns too that passed in the day drawn by tractors, the long barrels of the guns covered with green branches and green leafy branches and vines laid over the tractors. To the north we could look across a valley and see a forest of chestnut trees and behind it another mountain on this side of the river. There was fighting for that mountain too, but it was not successful, and in the fall when the rains came the leaves all fell from the chestnut trees and the branches were bare and the trunks black with rain. The vineyards were thin and bare-branched too and all the country wet and brown and dead with the autumn. There were mists over the river and clouds on the mountain and the trucks splashed mud on the road and the troops were muddy and wet in their capes; their rifles were wet and under their capes the two leather cartridge-boxes on the front of the belts, gray leather boxes heavy with the packs of clips of thin, long 6.5 mm. cartridges, bulged forward under the capes so that the men, passing on the road, marched as though they were six months gone with child. There were small gray motor cars that passed going very fast; usually there was an officer on the seat with the driver and more officers in the back seat. They splashed more mud than the camions even and if one of the officers in the back was very small and sitting between two generals, he himself so small that you could not see his face but only the top of his cap and his narrow back, and if the car went especially fast it was probably the King. He lived in Udine and came out in this way nearly every day to see how things were going, and things went very badly. At the start of the winter came the permanent rain and with the rain came the cholera. But it was checked and in the end only seven thousand died of it in the army.

[MorleyDev]

Technically the GCC C++ compiler is fully C++11 compliant now.

Unfortunately the standard library, libstdc++, is lagging behind significantly. Which is annoying me because I really want built-in support for regular expressions...

[Mego]

While looking through your code in search of the segfault, I noticed how you're handling reading in from the file. Why are you reading in binary format? Much simpler and easier to debug:

Code: [Select]

std::ifstream file(filename);
    if(file.is_open()) {
        while(file.good()) {
            std::string word;
            file >> word;
            token.push(word);
        }
    }


[lordnincompoop]

While looking through your code in search of the segfault, I noticed how you're handling reading in from the file. Why are you reading in binary format? Much simpler and easier to debug:

Code: [Select]

std::ifstream file(filename);
    if(file.is_open()) {
        while(file.good()) {
            std::string word;
            file >> word;
            token.push(word);
        }
    }


That was just something I overlooked. Sorry.

[lordnincompoop]

An update: I still don't know what caused it, but I rewrote the tokeniser to output an std::vector instead of a queue. That seems to have fixed it.

[MorleyDev]

Argh, trying to get clang building my unit testing library on a Raspberry Pi is a headache. Build clang, got it so clang builds a simple runnable hello world program fine. So almost got it working, but now it's just giving undefined references to __atomic_add_4 at the linker stage.

And now, having given up on clang and Linux for the time being, I'm trying to get it building in Visual Studio 2013 (The introduction of variadic templates was a requirement for this being even possible). Turns out that Visual Studio's macro support really sucks because as soon as you start to do complex stuff involving variadic macros and nesting macros inside each other nothing works.



EDIT: Oh it gets even better. It crashes the compiler. My code. Crashes. The visual studio 2013 compiler. That makes me feel oddly proud. I mean, I've heard of a brain drain problem at Microsoft but it's starting to just look embarrassing for them.

EDIT2: Yay, got it compiling and running fine. All tests pass in GCC still, but two fail in Visual Studio 2013. Turns out there's a bug associated with initializer lists. On the bright side, the library is still usable. On the downside, this means that functionality doesn't work. Fortunately it's easy to not use.

[Putnam]

Code: [Select]

-- Assigns claspects based on personality, attributes etc.

claspects = {
aspects={
"breath", --1
"light",
"time",
"space",
"life",
"hope",
"void",
"heart",
"blood",
"doom",
"mind",
"rage"},
classes={
"heir", --1
"seer",
"knight",
"witch",
"maid",
"page",
"rogue",
"prince",
"sylph",
"mage",
"thief",
"bard"}
}

personality_weights = {
{ --aspects
{ --breath
ANXIETY                 = -3,
ANGER                   =  0,
DEPRESSION              = -2,
SELF_CONSCIOUSNESS      = -5,
IMMODERATION            =  2,
VULNERABILITY           =  0,
FRIENDLINESS            =  2,
GREGARIOUSNESS          =  3,
ASSERTIVENESS           =  3,
ACTIVITY_LEVEL          =  2,
EXCITEMENT_SEEKING      =  6,
CHEERFULNESS            =  4,
IMAGINATION             =  1,
ARTISTIC_INTEREST       =  1,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  6,
INTELLECTUAL_CURIOSITY =  1,
LIBERALISM              =  0,
TRUST                   =  1,
STRAIGHTFORWARDNESS     =  2,
ALTRUISM                =  1,
COOPERATION             =  2,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  5,
ORDERLINESS             = -2,
DUTIFULNESS             = -3,
ACHIEVEMENT_STRIVING    =  1,
SELF_DISCIPLINE         = -1,
CAUTIOUSNESS            =  1},

{ --light
ANXIETY                 = -1,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  1,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  1,
INTELLECTUAL_CURIOSITY = 10,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             =  1,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  1,
SELF_DISCIPLINE         =  1,
CAUTIOUSNESS            =  1},

{ --time
ANXIETY                 =  1,
ANGER                   =  0,
DEPRESSION              =  1,
SELF_CONSCIOUSNESS      = -1,
IMMODERATION            =  0,
VULNERABILITY           = -1,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  1,
EXCITEMENT_SEEKING      =  1,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  1,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  1,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  2,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  5,
ORDERLINESS             = 10,
DUTIFULNESS             =  1,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  5,
CAUTIOUSNESS            =  2},

{ --space
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              = -1,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            =  2,
GREGARIOUSNESS          =  2,
ASSERTIVENESS           =  2,
ACTIVITY_LEVEL          =  2,
EXCITEMENT_SEEKING      =  1,
CHEERFULNESS            =  1,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  1,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --life
ANXIETY                 = -1,
ANGER                   = -2,
DEPRESSION              = -2,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            = -1,
VULNERABILITY           = -2,
FRIENDLINESS            =  5,
GREGARIOUSNESS          =  3,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  5,
IMAGINATION             =  2,
ARTISTIC_INTEREST       =  1,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  1,
ALTRUISM                = 10,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  1,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --hope
ANXIETY                 =  1,
ANGER                   =  1,
DEPRESSION              =  1,
SELF_CONSCIOUSNESS      =  5,
IMMODERATION            =  2,
VULNERABILITY           =  5,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  2,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  3,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  5,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 = -1,
SYMPATHY                = -4, --douchebags
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            = -2},

{ --void
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ACTIVITY_LEVEL          =  0,
ASSERTIVENESS           =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  1,
ARTISTIC_INTEREST       =  2,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         = -2,
CAUTIOUSNESS            =  0},

{ --heart
ANXIETY                 =  1,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  2,
IMMODERATION            =  0,
VULNERABILITY           =  1,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ACTIVITY_LEVEL          =  0,
ASSERTIVENESS           =  1,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  2,
ARTISTIC_INTEREST       =  2,
EMOTIONALITY            = 20,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 = -1,
SYMPATHY                =  3,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            = -1},

{ --blood
ANXIETY                 =  2,
ANGER                   =  2,
DEPRESSION              =  1,
SELF_CONSCIOUSNESS      =  2,
IMMODERATION            =  1,
VULNERABILITY           =  1,
FRIENDLINESS            = -1,
GREGARIOUSNESS          = 20,
ASSERTIVENESS           = -2,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            = -1,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  1,
LIBERALISM              = 30,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  1,
COOPERATION             =  5,
MODESTY                 = -3,
SYMPATHY                =  1,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --doom
ANXIETY                 =  5,
ANGER                   =  5,
DEPRESSION              =  5,
SELF_CONSCIOUSNESS      = -1,
IMMODERATION            =  1,
VULNERABILITY           = -1,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          = -1,
ASSERTIVENESS           =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  1,
ARTISTIC_INTEREST       =  3,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  8,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     = -2,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  2,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  4,
ACHIEVEMENT_STRIVING    =  1,
SELF_DISCIPLINE         =  1,
CAUTIOUSNESS            = -1},

{ --mind
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            =  5,
GREGARIOUSNESS          =  3,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
ASSERTIVENESS           =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  5,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY = 15,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     = 10,
ALTRUISM                =  0,
COOPERATION             = 15,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --rage
ANXIETY                 = 30,
ANGER                   = 50,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           = 20,
FRIENDLINESS            = -1,
GREGARIOUSNESS          = -1,
ASSERTIVENESS           =  8,
ACTIVITY_LEVEL          =  0,
ASSERTIVENESS           =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            = -1,
IMAGINATION             =  1,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              = 80,
TRUST                   = -5,
STRAIGHTFORWARDNESS     = -1,
ALTRUISM                = -2,
COOPERATION             = -1,
MODESTY                 = -1,
SYMPATHY                = -1,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  5}
},
     { --classes
{ --heir
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  1,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           = -5,
ACTIVITY_LEVEL          =  0,
ASSERTIVENESS           =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  5,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             = 10,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --seer
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              =  2,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  1,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
ASSERTIVENESS           =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         = -1,
INTELLECTUAL_CURIOSITY = 10,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     = -2,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             =  1,
DUTIFULNESS             =  1,
ACHIEVEMENT_STRIVING    = -1,
SELF_DISCIPLINE         =  1,
CAUTIOUSNESS            =  1},

{ --knight
ANXIETY                 =  1,
ANGER                   =  1,
DEPRESSION              =  1,
SELF_CONSCIOUSNESS      = 10,
IMMODERATION            = -1,
VULNERABILITY           =  2,
FRIENDLINESS            =  3,
GREGARIOUSNESS          =  4,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
ASSERTIVENESS           =  0,
EXCITEMENT_SEEKING      =  2,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  4,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 = -4,
SYMPATHY                =  0,
SELF_EFFICACY           = -1,
ORDERLINESS             =  1,
DUTIFULNESS             = 15,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         = -1,
CAUTIOUSNESS            =  0},

{ --witch
ANXIETY                 =  1,
ANGER                   =  1,
DEPRESSION              = -1,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            = 50,
IMAGINATION             = 10,
ARTISTIC_INTEREST       =  8,
EMOTIONALITY            =  3,
ADVENTUROUSNESS         =  5,
INTELLECTUAL_CURIOSITY =  2,
LIBERALISM              =  1,
TRUST                   =  1,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  2,
COOPERATION             =  1,
MODESTY                 = -1,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --maid
ANXIETY                 =  1,
ANGER                   =  5,
DEPRESSION              =  2,
SELF_CONSCIOUSNESS      =  1,
IMMODERATION            =  8,
VULNERABILITY           =  8,
FRIENDLINESS            =  5,
GREGARIOUSNESS          =  5,
ASSERTIVENESS           =  6,
ACTIVITY_LEVEL          =  4,
EXCITEMENT_SEEKING      =  3,
CHEERFULNESS            =  2,
IMAGINATION             =  2,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  7,
INTELLECTUAL_CURIOSITY =  2,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           = -1,
ORDERLINESS             =  0,
DUTIFULNESS             = -1,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         = -5,
CAUTIOUSNESS            =  0},

{ --page
ANXIETY                 =  5,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  5,
IMMODERATION            =  3,
VULNERABILITY           =  1,
FRIENDLINESS            =  5,
GREGARIOUSNESS          = 10,
ASSERTIVENESS           =  1,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  1,
CHEERFULNESS            =  2,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           = -1,
ORDERLINESS             = -1,
DUTIFULNESS             = -1,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --rogue
ANXIETY                 =  1,
ANGER                   =  0,
DEPRESSION              =  1,
SELF_CONSCIOUSNESS      =  1,
IMMODERATION            =  0,
VULNERABILITY           =  1,
FRIENDLINESS            =  1,
GREGARIOUSNESS          =  1,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          = -1,
EXCITEMENT_SEEKING      = -1,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     = -1,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             = -1,
DUTIFULNESS             = -1,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --prince
ANXIETY                 =  1,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  1,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  2,
ACTIVITY_LEVEL          =  2,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  1,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY = -1,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                = -2,
SELF_EFFICACY           = -1,
ORDERLINESS             = -1,
DUTIFULNESS             = -1,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         = -1,
CAUTIOUSNESS            = -2},

{ --sylph
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           = -1,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  1,
LIBERALISM              =  0,
TRUST                   =  1,
STRAIGHTFORWARDNESS     =  5,
ALTRUISM                =  5,
COOPERATION             =  5,
MODESTY                 =  5,
SYMPATHY                =  5,
SELF_EFFICACY           =  5,
ORDERLINESS             =  5,
DUTIFULNESS             =  5,
ACHIEVEMENT_STRIVING    =  5,
SELF_DISCIPLINE         =  5,
CAUTIOUSNESS            =  5},

{ --mage
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              =  1,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            =  0,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          = -1,
EXCITEMENT_SEEKING      =  1,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  1,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     = -1,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           = -1,
ORDERLINESS             =  0,
DUTIFULNESS             =  1,
ACHIEVEMENT_STRIVING    =  0,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0,},

{ --thief
ANXIETY                 =  0,
ANGER                   =  2,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  1,
IMMODERATION            =  0,
VULNERABILITY           =  1,
FRIENDLINESS            = -1,
GREGARIOUSNESS          = -1,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  5,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  2,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   = -1,
STRAIGHTFORWARDNESS     =  1,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                =  0,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  0,
ACHIEVEMENT_STRIVING    =  5,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0},

{ --bard
ANXIETY                 =  0,
ANGER                   =  0,
DEPRESSION              =  0,
SELF_CONSCIOUSNESS      =  0,
IMMODERATION            =  0,
VULNERABILITY           =  0,
FRIENDLINESS            = -1,
GREGARIOUSNESS          =  0,
ASSERTIVENESS           =  0,
ACTIVITY_LEVEL          =  0,
EXCITEMENT_SEEKING      =  0,
CHEERFULNESS            =  0,
IMAGINATION             =  0,
ARTISTIC_INTEREST       =  0,
EMOTIONALITY            =  0,
ADVENTUROUSNESS         =  0,
INTELLECTUAL_CURIOSITY =  0,
LIBERALISM              =  0,
TRUST                   =  0,
STRAIGHTFORWARDNESS     =  0,
ALTRUISM                =  0,
COOPERATION             =  0,
MODESTY                 =  0,
SYMPATHY                = -5,
SELF_EFFICACY           =  0,
ORDERLINESS             =  0,
DUTIFULNESS             =  1,
ACHIEVEMENT_STRIVING    =  1,
SELF_DISCIPLINE         =  0,
CAUTIOUSNESS            =  0
}
    }
}

local function getTotal(tbl)
local total = {0,0}
for k,v in pairs(tbl) do
if v>0
then
total[1]=v+total[1]
else
total[2]=v+total[2]
end
end
return total
end

function getSignlessTotal(tbl)
local total=0
for k,v in pairs(tbl) do
total=v+total
end
return total
end

local function getWeightAverages()
local weightAverages={{0,0},{0,0}}
for i=1,2 do
for k,claspect in ipairs(personality_weights[i]) do
local total = getTotal(claspect)
for ii=1,2 do
weightAverages[i][ii]=weightAverages[i][ii]+total[ii]
end
end
for ii=1,2 do
weightAverages[i][ii]=weightAverages[i][ii]/12
end
end
return weightAverages
end

function fixWeights() --this is here so I don't have to think about my weights meaning anything :D What's important is that they stay similar relative to one another, which this preserves.
local weightAverages=getWeightAverages()
for i=1,2 do
for k,claspect in ipairs(personality_weights[i]) do
local total=getTotal(claspect)
for kk,trait in pairs(claspect) do
if trait>0
then
trait=(weightAverages[i][1]/total[1])*trait
elseif trait<0 then
trait=(weightAverages[i][2]/total[2])*trait
else
trait=0 --:V
end
end
end
end
print("claspect assignment enabled.")
end

local function alreadyHasSyndrome(unit,syn_id)
    for _,syndrome in ipairs(unit.syndromes.active) do
        if syndrome.type == syn_id then return true end
    end
    return false
end

local function assignSyndrome(target,syn_id) --taken straight from here, but edited so I can understand it better: https://gist.github.com/warmist/4061959/. Also implemented expwnent's changes for compatibility with syndromeTrigger. I have used this so much ;_;
    if df.isnull(target) then
        return nil
    end
    if alreadyHasSyndrome(target,syn_id) then
        return true --I can omit the reset because they aren't going to ever lose their claspect
    end
    local newSyndrome=df.unit_syndrome:new()
    local target_syndrome=df.syndrome.find(syn_id)
    newSyndrome.type=target_syndrome.id
    newSyndrome.year=df.global.cur_year
    newSyndrome.year_time=df.global.cur_year_tick
    newSyndrome.ticks=1
    newSyndrome.unk1=1
    for k,v in ipairs(target_syndrome.ce) do
        local sympt=df.unit_syndrome.T_symptoms:new()
        sympt.ticks=1
        sympt.flags=2
        newSyndrome.symptoms:insert("#",sympt)
    end
    target.syndromes.active:insert("#",newSyndrome)
    return true
end

function assignClaspect(unit,creatureClass,creatureAspect) --Putting all of the claspect combos into a single table would be... problematic.
for k,v in ipairs(df.global.world.raws.syndromes.all) do
if string.find(string.lower(v.syn_name),string.lower(creatureClass)) and string.find(string.lower(v.syn_name),string.lower(creatureAspect)) then
assignSyndrome(unit,k)
end
end
end

function unitAlreadyHasClaspect(unit)
    for k,c_syn in ipairs(unit.syndromes.active) do
for _,ce in ipairs(df.global.world.raws.syndromes.all[c_syn.type].ce) do
if string.find(tostring(ce),"display_namest") and string.find(ce.name,"hero") then return true end
end
end
    return false
end

local function getHighestClaspects(claspects)
local highest={}
for i=1,2 do --1 is aspect, 2 is class
local topValue=-1000000000 --meaning top value after weight calculations; "highest" refers to the highest claspect, which can be referred to by the table at the top
for claspect=1,12 do
if getSignlessTotal(claspects[i][claspect])>topValue then
topValue=getSignlessTotal(claspects[i][claspect])
highest[i]=claspect
end
end
end
return highest
end

function makeClaspect(unit)
if unitAlreadyHasClaspect(unit) then return nil end
local personality    =  unit.status.current_soul.traits
local creatureWeights=  {{},{}}
for i=1,2 do
for k,claspect in ipairs(personality_weights[i]) do
for trait_name,trait in pairs(claspect) do
creatureWeights[i][k]={}
creatureWeights[i][k][trait_name]=(personality[trait_name]-50)*trait
end
end
end
local highestClaspect = getHighestClaspects(creatureWeights)
local creatureAspect  = claspects.aspects[highestClaspect[1]]
local creatureClass   = claspects.classes[highestClaspect[2]]
assignClaspect(unit,creatureClass,creatureAspect)
end

dfhack.onStateChange.claspect = function(code)
if code==SC_WORLD_LOADED then
dfhack.timeout(1,'ticks',monthlyClaspectAssign)
end
end

function monthlyClaspectAssign()
for _,unit in ipairs(df.global.world.units.active) do
makeClaspect(unit)
end
dfhack.timeout(200,'ticks',monthlyClaspectAssign) --okay so not monthly but still
end

dfhack.onStateChange.claspect()

fixWeights()
Why is? Two pairs, every time, class and aspect are independent, but my results, I have over 300 creatures, I run the script, only two pairs of class and aspect, different every time, heir of breath, knight of hope? This time same, both of them, no heart in sight, what changed? Why 1+1 and 3+6? Did I do something stupid with the weights? Looks like I did, and my laziness is my downfall, O, the folly of Putnam! God dang I'm dramatic today.

[Putnam]

Sorry for double post. I rewrote much of it, still getting the problem. However, I think I may have the culprit.

Code: [Select]

for trait_name,trait in pairs(claspect) doThe pairs(table) function is an undefined-behavior motherfucker, as the order of the items in the table being iterated order is not defined. However, that's not the problem. The problem is that I can't figure out the goddamn problem.
Okay, this function:

Code: [Select]

local function getHighestClaspects(claspects)
local highest={}
for i=1,2 do --1 is aspect, 2 is class
local topValue=-1000000000 --meaning top value after weight calculations; "highest" refers to the highest claspect, which can be referred to by the table at the top
for claspect=1,12 do
if getSignlessTotal(claspects[i][claspect])>topValue then
topValue=getSignlessTotal(claspects[i][claspect])
highest[i]=claspect
end
end
print(highest)
end
return highest
endIs currently returning only two tables:
{10,2}
and
{11,9}
Why only those two, I wonder?
Well, it probably has something to do with the getSignlessTotal(table) function:

Code: [Select]

function getSignlessTotal(tbl)
local total=0
for k,v in pairs(tbl) do
total=v+total
end
return total
endThere's that "pairs" function again. But why would that change it? Let's see the debug result for that, done by adding print(v) below total=v+total and print("DEMARCATE") above return total:

Code: [Select]

200
DEMARCATE
5
DEMARCATE
Shit. I've found my problem, and it is pairs. Let's change it to ipairs:

Code: [Select]

DEMARCATE
DEMARCATE
DEMARCATE
DEMARCATEWELP.
Check the size of the input table:

Code: [Select]

0
Oh.

Let's get out of the rabbit hole a bit.

#claspects[\i][claspect]

Code: [Select]

0Oh. Found it. Turns out, my original intuition was entirely correct. It's right here:

Code: [Select]

for trait_name,trait in pairs(claspect) do
creatureWeights[i][k]={}
creatureWeights[i][k][trait_name]=(personality[trait_name]-50)*trait
end
That third line is my exact issue. creatureWeights[\i][k][trait_name] remains perfectly nil and nothing told me that until I found it.

EDIT: So it's not pairs() fault, I just misunderstood the = operator or tables. Joy.

EDIT 2: There's a thunderstorm outside and it didn't come close to the sound of my palm slapping my face. table.insert().

EDIT 3: ALSO I MISUNDERSTOOD #

EDIT 4: table.insert() is still giving me only one value when there should be FUCKING 30

EDIT 5: Holy fuuuuuuuuck:

Code: [Select]

for trait_name,trait in pairs(claspect) do
creatureWeights[i][k]={} --DING DING LOOK HERE'S THE ISSUE YOU REDEFINED THE ENTIRE TABLE THAT CONTAINS THESE VALUES EVERY TIME YOU ADD ONE YOU STUPID ASS

[alexandertnt]

So, polygon clipping algorithms, specifically this one for Unity

Code: (C#) [Select]

                        // Select vertexes for triangle, as "triangle" is just a list of int indexes of the triangle
                        List<Vertex> outputs = new List<Vertex>(triangle.Select(x => vs[x]));
for(int i = 0; i < 4; i++){ // for each edge
List<Vertex> inputList = new List<Vertex>(outputs);
outputs = new List<Vertex>();
if (inputList.Any()){
Vertex S = inputList.Last();
foreach (Vertex E in inputList){
if (Inside(i, E.ProjectedPosition)){  // Inside is a simple switch for an integer.
if (!Inside(i, S.ProjectedPosition)){
Vector2 ls = Vector2.zero;
ls = LineIntersect(new Line(new Vector2(S.ProjectedPosition.x, S.ProjectedPosition.y), new Vector2(E.ProjectedPosition.x, E.ProjectedPosition.y)), Edges[i]);
outputs.Add(CalculateVertexFrom(S, E, ls));
}
outputs.Add(E);
} else if (Inside(i, S.ProjectedPosition)){
Vector2 ls = Vector2.zero;
ls = LineIntersect(new Line(new Vector2(S.ProjectedPosition.x, S.ProjectedPosition.y), new Vector2(E.ProjectedPosition.x, E.ProjectedPosition.y)), Edges[i]);
outputs.Add(CalculateVertexFrom(S, E, ls));
}
S = E;
}
}
}

This works, but apart from the fact it is messy (its all a WIP), is there anything that particularly stands out as being horribly slow? It takes about 500ms on a 30,000 tri skinned mesh (it is executed for each triangle), which is too slow. It is ran on a seperate thread, so it doesnt impact FPS, but still...

[MagmaMcFry]

Well, you are allocating 120000 new Lists every iteration, so there's that. Try using a Vertex[7] instead, because if you're only working with triangles and a rectangle, you'll never need more than 7 vertices per list anyway.

Edit: To clarify, you should allocate that Vertex[7] right at the start of the algorithm and reuse it for all 30k triangles.

[alexandertnt]

After proper time measurement, it (the original version) actually takes about 250ms to execute.

Are you referring to the "outputs" list? As far as I can tell, it is allocated 120000 for each total mesh clip (30,000 triangles * 4)
I replaced the outputs list with a 7 long array allocated outside the loop and an integer (to keep track of where to place the new Vertex in) and it slowed it down by 100ms (to about 350ms)...

Code: (C#) [Select]

Vertex[] Outputs = new Vertex[7];
int OutputAdd = 0;
foreach(IEnumerable<int> triangle in Triangles.Batch(3)){
List<Vertex> outputs = new List<Vertex>(triangle.Select(x => vs[x]));
for (int i = 0; i < outputs.Count; i++){
Outputs[i] = outputs[i];
}
OutputAdd = outputs.Count;
for(int i = 0; i < 4; i++){ // for each edge
List<Vertex> inputList = new List<Vertex>(Outputs.Take(OutputAdd));
OutputAdd = 0;
if (inputList.Any()){
Vertex S = inputList.Last();
foreach (Vertex E in inputList){
if (Inside(i, E.ProjectedPosition)){
if (!Inside(i, S.ProjectedPosition)){
Vector2 ls = Vector2.zero;
ls = LineIntersect(new Line(new Vector2(S.ProjectedPosition.x, S.ProjectedPosition.y), new Vector2(E.ProjectedPosition.x, E.ProjectedPosition.y)), Edges[i]);
//outputs.Add(CalculateVertexFrom(S, E, ls));
Outputs[OutputAdd] = CalculateVertexFrom(S, E, ls);
OutputAdd++;
}
//outputs.Add(E);
Outputs[OutputAdd] = E;
OutputAdd++;
} else if (Inside(i, S.ProjectedPosition)){
Vector2 ls = Vector2.zero;
ls = LineIntersect(new Line(new Vector2(S.ProjectedPosition.x, S.ProjectedPosition.y), new Vector2(E.ProjectedPosition.x, E.ProjectedPosition.y)), Edges[i]);
//outputs.Add(CalculateVertexFrom(S, E, ls));
Outputs[OutputAdd] = CalculateVertexFrom(S, E, ls);
OutputAdd++;
}
S = E;
}
}
}
}

I could try to replace inputList in a similar fashion perhaps, but I have a feeling the compiler is doing some black magic that may nullify any potential speed gain from doing this.
I am also working on threading the algorithm (work on batches of triangles in several seperate threads, rather than just running the whole thing in a single thread).