Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Wolfy]

I've done it off and on for years, I've never been able to "use" what I know, I dont see how to use each thing as a group to make what I want.

[GalenEvil]

In pseudocode (assuming string::find will return -1 if it doesn't find it):
*see note at bottom of post

do{
   int stringIndex = string::find(blahString);
   string::replace(stringChunk, stringIndex, wordLength, replaceString);
}while (stringIndex != -1;

Also going with the assumption that I didn't totally bork the pseudocode on that one hehe

*Note: I haven't used C++ in a while, mostly C# for me nowadays. Hopefully I didn't bork the code too much!

[MagmaMcFry]

Slightly optimized:

Code: (Pseudocode) [Select]

for each pattern, replacement {
  newString = "";
  stringIndex = find(string, pattern);
  while (stringIndex != string.length) {
    newStringIndex = find(string, pattern, stringIndex+pattern.length);
    if (newStringIndex == -1) {
      newStringIndex = string.length;
    }
    newString.append(replacement);
    newString.append(string.substr(stringIndex + pattern.length, newStringIndex);
    stringIndex = newStringIndex;
  }
  string = newString;
}


[Mego]

string::find returns string::npos if the substring is not found. The standard is string::npos == -1, but certain compilers (cough cough Microsoft) have been known not to follow standards.

[Skyrunner]

Entire errors & command line input

Compiling on Linux using g++ 4.6.3.

I believe the error can be traced back to

Code: (PODS.h) [Select]

class statpairs
{
public: int current;
                  int max;
                  const string nameof;
                  TCODColor color;
                  statpairs(string name, TCODColor statcolor);
  void updatestats(int stat, int maxstat) {current = stat; max = maxstat;}
  };

Code: (PODS.cpp) [Select]

HUDisplay::statpairs::statpairs(string name, TCODColor statcolor) : nameof(name), color (statcolor)  {}

Code: (PODS.cpp) [Select]

void sideDisplay::update(SoilMap &map, Cursor &cursor)
{
  tile *tilepointer = 0;
  plants *tempplant = 0;
  herb *tempherb = 0;
 
  if (cursor.visible == true)
    {
    tempherb = map.herb_at_pointer(cursor.getX(), cursor.getY());
    if (tempherb != 0) //if it exists
      {
      string plantname; plantname.assign(tempherb->plantname.c_str());
            //test code start
      plantname.append("(");
      plantname.append(to_string((long double)tempherb->strength));
      plantname.append(",");
      plantname.append(to_string((long double)tempherb->plant_durability));
      plantname.append(")");
           //end test code

      infovector.push_back(pair<string, pair<TCODColor, TCODColor> >(plantname, pair<TCODColor,TCODColor>(tempherb->background, tempherb->foreground)));
      }

    tempplant = map.grass_at_pointer(cursor.getX(), cursor.getY());
    if (tempplant != 0)
      {
       
      string plantname; plantname.assign(tempplant->plantname.c_str());
      //testcode start
      plantname.push_back(' ');
      plantname.append(to_string((long double)tempplant->plant_durability));
      //testcode ends

      infovector.push_back(pair<string, pair<TCODColor, TCODColor> >(plantname, pair<TCODColor, TCODColor>(TCODColor::lerp(tempplant->background, TCODColor::black,0.5f), tempplant->foreground)));
      }   
   
>>>>>>    tilepointer = &map.tile_at(cursor.getX(), cursor.getY());
    infovector.push_back(pair<string, pair<TCODColor, TCODColor> >(tilepointer->getTileName(), pair<TCODColor, TCODColor>(TCODColor::lerp(tilepointer->foreground, TCODColor::black,0.5f), tilepointer->background)));
   
    }


}
Relevant errors:
PODS.h:48:9: error: ‘HUDisplay::statpairs& HUDisplay::statpairs::operator=(const HUDisplay::statpairs&)’ is implicitly deleted because the default definition would be ill-formed:

In member function ‘void sideDisplay::update(SoilMap&, Cursor&)’:
PODS.cpp:65:60: error: taking address of temporary [-fpermissive]
(this error's line is marked as >>>>>>)

I'm pretty sure there's a lot more errors, but it's too much gibberish to understand.

This code compiles fine on MSVC / windows. @_@

[RulerOfNothing]

The problem would probably be in SoilMap::tile_at. Can you give us the code for that function?

[Mego]

I'm reading through the entire error output, and I'll make notes here as I see things.

Error with using TRUE - use true instead.

Taking address of temporary - g++ (and all standards-conforming compilers, for that matter) don't like when you take a reference to something that isn't an lvalue (a function call is an rvalue). So, store the result of the function call, and take reference of that.

Ill-formed default definition - your class doesn't have a default constructor (constructor with no arguments) that instantiates the const string nameof field. Your choices are to define the default constructor and initialize nameof, or to make nameof a static field.

Fixing these things should make the rest of the errors go away.

[Skyrunner]

I already caught the first error xD
Taking address of temporary : I don't quite understand what that means, probably because I can't understand "lvalue" and "rvalue" @_@ I think I can fix it by changing tile_at to tile_at_pointer, though, which is the second function I made to return an address. I made the tile_at function incorrectly, but there was some usages that relied on it being copied instead of an address.

Edit: now only if I could get Linux and Virtual Box to cooperate with each other.

[Mego]

An lvalue is something that can have a value assigned to it. An rvalue is something that cannot have a value assigned to it. For example, variables are lvalues, while function calls are rvalues.

[MorleyDev]

An lvalue is something that can have a value assigned to it. An rvalue is something that cannot have a value assigned to it. For example, variables are lvalues, while function calls are rvalues.

Yeeeah, about that...

[Skyrunner]

You can see those concepts whistling over my head. I still can't understand it.

Also, while linking, I have errors of '-l[libraryname] not found' despite the files being along the path I added with -L/home/skyrunner/Desktop/ASCII\ sandbox/Resources/libtcod-1.5.1"... The files' names are 'libtcod.so' and 'libtcodgui.so' which are included by -llibtcod and -llibtcodgui. Am I doing wrong? The .so files aren't in the standard path, which might be a problem...?

By the way, is letting programs use shared objects in Linux hard? Do they just have to be where the executable is, or do they need an arcane method to add tem to the system's info? If they have to be magicked into the system, does -static while compiling let the sos be forcibly statically linked?

[Mego]

An lvalue is something that can have a value assigned to it. An rvalue is something that cannot have a value assigned to it. For example, variables are lvalues, while function calls are rvalues.

Yeeeah, about that...

Damnit. Every time I think I have C++ semantics figured out, something else pops up.

Skyrunner, basically, if you want to make a pointer to an object that is the result of a function call, store the return value somewhere first, and take the reference to that. If you have a const field in a class, either define a default constructor that initializes it, or make it static.

[MorleyDev]

Damnit. Every time I think I have C++ semantics figured out, something else pops up.

They're introduced by C++11 and basically exist so you can explicitly break those rvalue rules and make it clear you're doing it. auto_ptr had to do some hideous tricks, which introduced some problems. unique_ptr can achieve the same goal without those hacks via the move semantics rvalue references introduced.

[darklord92]

I see to be having my own short comings as well learning nes/6502 asm 

I'm following pataters guide to it using nesasm3

(( http://www.patater.com/nes-asm-tutorials/day-9  and http://www.patater.com/nes-asm-tutorials/day-10  for refrence))

I seem to be unable to set the x and y of sprites as well as having more than one sprite when i do the steps in part 10 to load sprites into the DMA

code so far:

Spoiler (click to show/hide)

    ;;--- CODE START ---;;
    .inesprg 1
    .inesmap 0
    .inesmir 1
    .ineschr 1

    .bank 1
    .org $FFFA
    .dw 0 ; no VBlank
    .dw Start ; address to execute on reset
    .dw 0 ; no whatever


    .bank 0
    .org $0000
    .org $0300 ; OAM Copy location $0300
Sprite1_Y: .db 20 ; sprite #1's Y value
Sprite1_T: .db 0 ; sprite #1's Tile Number
Sprite1_S: .db 0 ; sprite #1's special byte
Sprite1_X: .db 20 ; sprite #1's X value
Sprite2_Y: .db 0 ; same thing, same order for sprite #2
Sprite2_T: .db 0 ; note that I numbered 1 2 ...
Sprite2_S: .db 0 ; some people may actually prefer starting
Sprite2_X: .db 0 ; the count at 0, but it doesn't really matter.
; this would just go on and on for however many sprites you have


    .org $8000 ; code starts at $8000 or $C000
Start:


    lda #%00001000 ;
    sta $2000 ;
    lda #%00011110 ; Our typical PPU Setup code.
    sta $2001 ;


    ldx #$00 ; clear X
    ;; start of palette loading code

    lda #$3F ; have $2006 tell
    sta $2006 ; $2007 to start
    lda #$00 ; at $3F00 (palette).
    sta $2006


loadpal:     ; this is a freaky loop
    lda tilepal, x ; that gives 32 numbers
    sta $2007 ; to $2007, ending when
    inx ; X is 32, meaning we
    cpx #32 ; are done.
    bne loadpal ; if X isn't =32, goto "loadpal:" line.
        ;; end of palette loading code
    lda #$20
    sta $2006 ; give $2006 both parts of address $2020.
    sta $2006

    ldx #$00
loadNames:
    lda ourMap, X ; load A with a byte from address (ourMap + X)
    inx
    sta $2007
    cpx #$FF ; map in previous section 64 bytes long
    bne loadNames ; if not all 64 done, loop and do some more

infinite: ; a label to start our infinite loop

    ;store the body vertically aligned below the head
    lda Sprite1_Y     ;load sprite1_Y into A
    sbc #8        ;subtract 8 from A
    sta Sprite2_Y    ;store A in sprite2_Y
    ;keep the body horizontally aligned
    lda Sprite1_X     ;load sprite1_Y into A
    sta Sprite2_X    ;store A in sprite2_Y

waitblank:
    lda $2002 ; these 3 lines wait for VBlank, this loop will actually miss VBlank
    bpl waitblank ; alot, in a later Day, I'll give a better way.

    lda #$3 ; could be #3, 3 is the same hex and decimal (obviously).
    sta $4014 ; when we write to it, the copy from $0300+ to actual OAM, is carried out.
    ; and yes, it MUST go in that order.

    lda #$01 ; these
    sta $4016 ; lines
    lda #$00 ; setup/strobe the
    sta $4016 ; keypad.
    lda $4016 ; load Abutton Status ; note that whatever we ain't interested
    lda $4016 ; load Bbutton Status ; in we just load so it'll go to the next one.
    lda $4016 ; load Select button status
    lda $4016 ; load Start button status

    lda $4016 ; load UP button status
    and #1 ; AND status with #1
    bne UPKEYdown ; for some reason (not gonna reveal yet), need to use NotEquals
    ;with ANDs. So it'll jump (branch) if key was down.

    lda $4016 ; load DOWN button status
    and #1 ; AND status with #1
    bne DOWNKEYdown

    lda $4016 ; load LEFT button status
    and #1 ; AND status with #1
    bne LEFTKEYdown

    lda $4016 ; load RIGHT button status
    and #1 ; AND status with #1
    bne RIGHTKEYdown
    jmp NOTHINGdown ; if nothing was down, we just jump (no check for conditions)
    ; down past the rest of everything.

UPKEYdown:
    lda Sprite1_Y ; load A with Y position
    sbc #2 ; subtract 1 from A. Only can do math on A register. SBC (Subtract with Borrow)
    sta Sprite1_Y ; store back to memory
    jmp NOTHINGdown ; jump over the rest of the handling code.

DOWNKEYdown:
    lda Sprite1_Y
    adc #1 ; add 1 to A. ADC (Add with Carry)((to A register))
    sta Sprite1_Y
    jmp NOTHINGdown ; jump over the rest of handling code.

LEFTKEYdown:
    lda Sprite1_X
    sbc #2
    sta Sprite1_X
    jmp NOTHINGdown ;the left and right handling code does the same as UP and Down except.. well.. with
    ; left and right.

RIGHTKEYdown:
    lda Sprite1_X
    adc #1
    sta Sprite1_X ; don't need to jump to NOTHINGdown, it's right below. Saved several bytes of
    ; PRG-Bank space!

NOTHINGdown:
    jmp infinite

tilepal:
    .incbin "basicgame.pal" ; a label for our palette data
    ourMap: .incbin "basicgame.map" ; assuming our.map is the binary map file.
    .bank 2
    .org $0000
    .incbin "basicgame.bkg"
    .incbin "basicgame.spr"
    ;;--- END OF CODE FILE ---;;

[Virex]

First of all, why are you going right/up twice as fast as left/down?


Other than that I can't find any obvious errors. Can you describe what's happening? Do you have a debugger to step through the code?