Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1] 2 3

Author Topic: Max Number of Reactions?  (Read 2480 times)

Mephansteras

  • Bay Watcher
  • Forger of Civilizations
    • View Profile
Max Number of Reactions?
« on: August 25, 2011, 07:19:06 pm »

I think I may have hit a maximum number of reactions that a civilization can have.

I tried to add in an additional set of reactions to make candles (both wax and tallow). They didn't show up in game.

After carefully checking the raws, and not finding any issues or errors, I decided to try something. I cut out the 5 reactions above them in the list and genned a new world. Lo and behold, I could now make wax and tallow candles.

There are 283 permitted reactions in my entity file that work. After that, they seem to just vanish.

Anyone else experience this limit?
Logged
Civilization Forge Mod v2.80: Adding in new races, equipment, animals, plants, metals, etc. Now with Alchemy and Libraries! Variety to spice up DF! (For DF 0.34.10)
Come play Mafia with us!
"Let us maintain our chill composure." - Toady One

UristMcHuman

  • Bay Watcher
    • View Profile
Re: Max Number of Reactions?
« Reply #1 on: August 25, 2011, 07:49:53 pm »

I think I may have hit a maximum number of reactions that a civilization can have.

I tried to add in an additional set of reactions to make candles (both wax and tallow). They didn't show up in game.

After carefully checking the raws, and not finding any issues or errors, I decided to try something. I cut out the 5 reactions above them in the list and genned a new world. Lo and behold, I could now make wax and tallow candles.

There are 283 permitted reactions in my entity file that work. After that, they seem to just vanish.

Anyone else experience this limit?
Is this for Civ Forge? And I don't usually poke around making new reactions, just fiddling around with current ones.
Logged

Silicoid

  • Bay Watcher
    • View Profile
Re: Max Number of Reactions?
« Reply #2 on: August 25, 2011, 07:56:52 pm »

I have not experienced it in my personal mod for gem making-reations of each gem+ SethCreid's gemshaping forge reactions and Forlorn Lands.... or maybe there is a limit on tags for each entity...  Only Toady One would know if there is a limit...
Logged

Fallen Flame

  • Bay Watcher
    • View Profile
Re: Max Number of Reactions?
« Reply #3 on: August 26, 2011, 01:51:28 am »

Could it possible be a max amount of reactions for a single workshop?
You could try adding them to a different workshop.
Logged

Mephansteras

  • Bay Watcher
  • Forger of Civilizations
    • View Profile
Re: Max Number of Reactions?
« Reply #4 on: August 26, 2011, 10:51:38 am »

Could it possible be a max amount of reactions for a single workshop?
You could try adding them to a different workshop.

Well, the Libraries have way more reactions than the crafts workshop and they work fine. Plus, when I removed some of the reactions in other workshops, the candle jobs showed up fine at the craftshop.

So I'm pretty sure it's a limit. Probably just hitting the end of whatever array or data structure Toady is stuffing them into.

I'll e-mail Toady, though. If nothing else he might want to know that it's easy* to hit that limit with modding.

*Well, if you're crazy like me.
Logged
Civilization Forge Mod v2.80: Adding in new races, equipment, animals, plants, metals, etc. Now with Alchemy and Libraries! Variety to spice up DF! (For DF 0.34.10)
Come play Mafia with us!
"Let us maintain our chill composure." - Toady One

narhiril

  • Bay Watcher
  • [DUTY_BOUND]
    • View Profile
Re: Max Number of Reactions?
« Reply #5 on: August 27, 2011, 02:40:10 am »

Could it possible be a max amount of reactions for a single workshop?
You could try adding them to a different workshop.

Well, the Libraries have way more reactions than the crafts workshop and they work fine. Plus, when I removed some of the reactions in other workshops, the candle jobs showed up fine at the craftshop.

So I'm pretty sure it's a limit. Probably just hitting the end of whatever array or data structure Toady is stuffing them into.

I'll e-mail Toady, though. If nothing else he might want to know that it's easy* to hit that limit with modding.

*Well, if you're crazy like me.

I'd like to know if/when you get an answer.

I'm finding it hard to believe though, since there are a few combination mods that throw civ forge in with other mods, and they wouldn't work with only 283 permitted reactions.  Of course, when you're mixing that many mods, the definition of "work" is subjective.

Rhenaya

  • Bay Watcher
  • Usstan tlun natha hargluk ssinssriggin ilythiiri!
    • View Profile
    • X-Fire Profile
Re: Max Number of Reactions?
« Reply #6 on: August 27, 2011, 02:44:01 am »

there is also an annoying limit for clothing/armor :(
Logged
User Profile: http://df.magmawiki.com/index.php/User:Rhenaya
Mods: http://dffd.wimbli.com/who.php?id=554

From "Angroshs Kinder" Das schwarze Auge Zwergenhandbuch - (Angrosh Children, the dark eye, german pen&paper, dwarven handbook):
"Elves!? Their men dont wear beards, and their women bathe nacked to lure you into the water and drown you. Thank Angrosh they are as ugly as the day and all big and skinny."

Deon

  • Bay Watcher
  • 💀 💀 💀 💀 💀
    • View Profile
Re: Max Number of Reactions?
« Reply #7 on: August 27, 2011, 04:11:36 am »

So is it 283 per entity? Because I think I had more totally, but I've never stuffed so  many in a single entity.
Logged
▬(ஜ۩۞۩ஜ)▬
✫ DF Wanderer ✫ - the adventure mode crafting and tweaks
✫ Cartographer's Lounge ✫ - a custom worldgen repository

Mephansteras

  • Bay Watcher
  • Forger of Civilizations
    • View Profile
Re: Max Number of Reactions?
« Reply #8 on: August 27, 2011, 10:29:24 am »

So is it 283 per entity? Because I think I had more totally, but I've never stuffed so  many in a single entity.

Per entity. And, actually, it's 281. I miscounted last time.

I have more reactions than that overall, but after 281 they stopped showing up in the dwarf civ.
Logged
Civilization Forge Mod v2.80: Adding in new races, equipment, animals, plants, metals, etc. Now with Alchemy and Libraries! Variety to spice up DF! (For DF 0.34.10)
Come play Mafia with us!
"Let us maintain our chill composure." - Toady One

Dienes

  • Bay Watcher
    • View Profile
Re: Max Number of Reactions?
« Reply #9 on: August 27, 2011, 12:25:03 pm »

281 is kind of a strange number from a programing perspective, I suspect something else might be interfering with it like a buffer running out of space while reading a file.

I assume that nothing shows up in your game log? Are the reactions all in one giant file or split over a few ones? Are your dwarves still in entity_default? Maybe try moving them into their own file. And does the removing non-reactions from the entity file like, like shoes or instruments, change anything?

As a last resort can you merge them in after world gen using dfworldtinker?
Logged

Halconnen

  • Bay Watcher
  • Danmaku Fortress
    • View Profile
    • Certaincake
Re: Max Number of Reactions?
« Reply #10 on: August 27, 2011, 06:22:33 pm »

Does anything happen to the reactions if you add/remove other tags from the entity? Just to rule out if it's a general tag limit of some sort or not.

281 is a pretty weird number.
Logged

Mephansteras

  • Bay Watcher
  • Forger of Civilizations
    • View Profile
Re: Max Number of Reactions?
« Reply #11 on: August 27, 2011, 09:39:07 pm »

I'll have to run some tests at some point. So far I just tested permitted reactions.
Logged
Civilization Forge Mod v2.80: Adding in new races, equipment, animals, plants, metals, etc. Now with Alchemy and Libraries! Variety to spice up DF! (For DF 0.34.10)
Come play Mafia with us!
"Let us maintain our chill composure." - Toady One

Fallen Flame

  • Bay Watcher
    • View Profile
Re: Max Number of Reactions?
« Reply #12 on: August 27, 2011, 09:51:36 pm »

Would the reactions that are added to the smelter and forge when a new metal is added count, against the limit for reactions? If so then for each type of metal added and weapon would use up quite a few reactions.
Logged

Mephansteras

  • Bay Watcher
  • Forger of Civilizations
    • View Profile
Re: Max Number of Reactions?
« Reply #13 on: August 27, 2011, 10:02:20 pm »

I imagine that the list of hard-coded reactions is being included. But it's hard to say for sure exactly what's going on in the code.
Logged
Civilization Forge Mod v2.80: Adding in new races, equipment, animals, plants, metals, etc. Now with Alchemy and Libraries! Variety to spice up DF! (For DF 0.34.10)
Come play Mafia with us!
"Let us maintain our chill composure." - Toady One

Rhenaya

  • Bay Watcher
  • Usstan tlun natha hargluk ssinssriggin ilythiiri!
    • View Profile
    • X-Fire Profile
Re: Max Number of Reactions?
« Reply #14 on: August 28, 2011, 11:05:40 am »

maybe the number os so weird because other hardcoded jobs like "store item in stockpile" or crafting armor, etc. is a reaction in ts own right, and custom reactions will just be lined up and culled one they reac the limit (512? 1024? whatever) :x
Logged
User Profile: http://df.magmawiki.com/index.php/User:Rhenaya
Mods: http://dffd.wimbli.com/who.php?id=554

From "Angroshs Kinder" Das schwarze Auge Zwergenhandbuch - (Angrosh Children, the dark eye, german pen&paper, dwarven handbook):
"Elves!? Their men dont wear beards, and their women bathe nacked to lure you into the water and drown you. Thank Angrosh they are as ugly as the day and all big and skinny."
Pages: [1] 2 3