Some info on the windows crash:
It is occurring in the void game::update_overmap_seen() function, immediately upon entering it. It never even gets to declare the first variables. The rest of the map seems to load fine, the data appears sound. Maybe this has to do with the new sight range, and there being undeclared or generated underground tiles? A return statement in one of the sight functions? I don't know, and I'm not up enough on c++ to figure it out, but maybe better people than me can start looking in this area.
Yeah, this one stumps me. Underground tiles are all declared (as is all data like this--undeclared data would cause big problems that would've been noticed long ago!), all the relevent functions return sane values.
The segfault I've seen crashes on a memory allocation function only used in MingW--though there may be others. Any backtraces would be appreciated (unless they go straight from calling game::update_overmap_seen() to alloca(); I already know that one!).
If your building it yourself make clean and make without using -j. I find I get way more crashes with parallel builds for some reason (something which I don't see how is possible, I blame the lack of initialisation )
Does whales really not initialize variables? That sounds kind of... distressing? I don't know how often that would actually cause a problem, but it's one of the first good programming practices anybody learns in a language like C++.
I do, of course. It's not a "good programming practice," it's a rule you follow if you don't want your program to spit out garbage or crash immediately. I don't init variables in a couple spots, but only where it clearly doesn't matter.
I'm not to keen on specifics, but what's the issue with porting it to windows? Isn't C++ a pretty platform independent language?
Is it some libraries that only work on linux?
Do you have to make special adjustments to build a windows version?
Windows uses pdcurses, not ncurses.
There's a new "port" of the code which unifies the Windows and Linux source into the same thing, just with an extra header file for Windows compilers. That should make everything much easier.