Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  
Pages: 1 ... 13 14 [15] 16

Author Topic: Bugs, UI issues and Minor Suggestions  (Read 27493 times)

Pesi

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #210 on: November 01, 2012, 02:50:45 am »

Discussion with KA101 gave me the idea that if a sleeper who can't spread liberalism is made to do that, they should stop on their own after one month.
Code: [Select]
      /* No influence at all block - for people were liberal anyway, or have no way of doing any good */
      case CREATURE_WORKER_FACTORY_CHILD:
      case CREATURE_GENETIC:
      case CREATURE_GUARDDOG:
      case CREATURE_BUM:
      case CREATURE_CRACKHEAD:
      case CREATURE_TANK:
      case CREATURE_HIPPIE: // too liberal to be a proper sleeper
      case CREATURE_WORKER_FACTORY_UNION: // same
      case CREATURE_JUDGE_LIBERAL: // more again
      case CREATURE_POLITICALACTIVIST: // ??!?!? impressive getting an LCS Member sleeper, but no effect
      case CREATURE_MUTANT:
         return;
I suggest adding the line
cr.activity.type=ACTIVITY_NONE;
just before the return;
Logged

Jonathan S. Fox

  • Bay Watcher
    • View Profile
    • http://www.jonathansfox.com/
Re: Bugs, UI issues and Minor Suggestions
« Reply #211 on: November 01, 2012, 05:15:27 pm »

Pesi, your bug reports, while appreciated, are like a Wikipedia editor suggesting fixes to spelling errors in the talk page instead of fixing them. You're spending way more effort telling other people how to fix the problem than it would take to just do it yourself. I've offered you SVN commit rights before, but you said no. Are you absolutely sure you don't want to save everyone the trouble, including yourself, and just make changes directly?

Don't get me wrong, I'd rather get detailed bug reports than not get bug reports at all. But given that you're already so deep in the code that you know the solution, I'd rather you just solve it! It's great that you're finding bugs, but it kills me that you're telling others how to fix them when you're already staring at the problem with the solution in hand.

Just send me your Sourceforge username (it's free if you don't have one) and I can get you hooked up. SVN commit is as easy as SVN update, and if they prompt you for a login, it's your Sourceforge username and password. You just make the change in the source file, do an SVN commit, then boom, you're done, bug fixed for everyone. You can leave a little commit in the commit log if you want to make sure you're being communicative. If you're worried about breaking something, changes can always be reverted; it's like Wikipedia, nothing is gone forever. You can even keep posting about bugs you find if you like, only now with the added bonus of having already fixed them.

There are no added responsibilities associated with this. You just get to commit changes and have your edits to the game become canon. That's it. And you can make feature changes and stuff too, if you have ideas for improving the game. Or you could just fix bugs. Or you could do nothing! There's really no drawback.
Logged

KA101

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #212 on: November 03, 2012, 08:05:19 am »

Quick note re Pesi's code-cite there: All of my games tend to have a Political Activist sleeper.  It's what happens when that Teenager sleeper* I always recruit grows up.  If my current game goes the distance I suspect the Child Worker active member I have will in time grow to a Teenager (he's 10 now) and eventually into a Political Activist.

*Who lives at the CEO House, and is thus highly useful for the map.
Logged

Jonathan S. Fox

  • Bay Watcher
    • View Profile
    • http://www.jonathansfox.com/
Re: Bugs, UI issues and Minor Suggestions
« Reply #213 on: November 03, 2012, 01:06:08 pm »

Quick note re Pesi's code-cite there: All of my games tend to have a Political Activist sleeper.  It's what happens when that Teenager sleeper* I always recruit grows up.  If my current game goes the distance I suspect the Child Worker active member I have will in time grow to a Teenager (he's 10 now) and eventually into a Political Activist.

*Who lives at the CEO House, and is thus highly useful for the map.

That would do it. When I wrote that comment, I was imagining that the way you'd get a Political Activist sleeper would be to have an active member Teenager grow into a Political Activist, then have that character flipped by a wisdom-based attack, then kidnap the newly flipped character and flip them back in interrogation. But your approach, of turning one of the CEO's teenagers into a sleeper, makes way more sense.

I'm still impressed.
Logged

Pesi

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #214 on: December 08, 2012, 04:48:02 pm »

I used to think that pleading guilty at trial always resulted in lenience, probably because of this part from Justice.cpp:
Code: [Select]
         // Check for lenience; sleeper judge will always be merciful
         if(defensepower/3>=jury/4 || sleeperjudge || defense==2)
...until suddenly it didn't happen, so I looked again.
It turns out that the above portion is inside this if-block:
Code: [Select]
   if(defense!=2)
   {
Actual lenience chance : 50%
My first throught : "Have I just been UNBELIEVABLY lucky so far?"
----
The " || defense==2"-part was a part of 4.03.0
I imagine it was to make guilty pleas always lenient, but the only thing it does is confuse code-readers.
This has been a  public service announcement.

@Reply #211:
It's not that I don't want to commit the changes, I'd love to be able to, I never said no; but several reasons conspire against me so that I just CAN'T.
Furthermore, I am of the school of thought that any change should be discussed at least a little bit before being made. The "anyone can edit" aspect is, I.M.O. the worst part of Wikipedia, not settling on things is how edit wars begin.
Logged

Elodie Hiras

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #215 on: December 18, 2012, 05:12:00 pm »

Hello!

I was thinking about one thing... How about having "joke" weapons?

I mean, someone insane Elite Liberal enough to throw a cream pie in the face of a Navy SEAL should affect public opinion... I want to be able to throw cream pies at conservatives to affect public opinion... I want to fire brightly colored water guns full of harmless glowing food colorant to make a statement about radioactive water... I want to be able to slap conservatives instead of beating them up... In fact, I want my Elite Liberal to be able to fight not to kill, but to disturb the peace... I mean, I am tired of avoiding conservatives when doing my pacifist runs...

Is there a way to code and balance this? Thank you in advance!
Logged

BoxOfAids

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #216 on: December 18, 2012, 11:29:51 pm »

Hello!

I was thinking about one thing... How about having "joke" weapons?

I mean, someone insane Elite Liberal enough to throw a cream pie in the face of a Navy SEAL should affect public opinion... I want to be able to throw cream pies at conservatives to affect public opinion... I want to fire brightly colored water guns full of harmless glowing food colorant to make a statement about radioactive water... I want to be able to slap conservatives instead of beating them up... In fact, I want my Elite Liberal to be able to fight not to kill, but to disturb the peace... I mean, I am tired of avoiding conservatives when doing my pacifist runs...

Is there a way to code and balance this? Thank you in advance!

Oh my god, this would be so funny. Someone please tell me this would be possible...
Logged

Elodie Hiras

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #217 on: December 26, 2012, 08:18:04 pm »

Bug report:

I downloaded the last LCS trunk version, compiled it, and yet I can't make profession armors (like army armor, police armor, SWAT armors, SEAL Suit and Heavy Body Armor) because they don't even show up on the list... The format for the armor file in the XML seems correct, my tailor has 10 skill, 14 Int, I know it's the latest since I have access to the bank, the perfectly legal AA Gun (nightmare mode)... I'm on Ubuntu if it helps...

Can someone help me please?

Edit: I've got it from the wiki because SVN doesn't gives the game to me, saying that LCS Game already is a work copy for another URL...

Edit 2: The bug isn't there when I use my Windows version with Wine...
« Last Edit: December 26, 2012, 08:31:21 pm by Elodie Hiras »
Logged

KA101

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #218 on: December 27, 2012, 05:41:33 pm »

UI improvement request: could we let players set the Founder's gender as Ambiguous during Founder-creation?

Thanks much.
Logged

Yannanth

  • Guest
.
« Reply #219 on: December 28, 2012, 10:57:08 am »

.
« Last Edit: November 21, 2016, 04:52:39 pm by Yannanth »
Logged

KA101

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #220 on: December 28, 2012, 07:40:37 pm »

UI improvement request: could we let players set the Founder's gender as Ambiguous during Founder-creation?

Thanks much.
That's not a UI improvement, that's a new feature. And honestly, what does a person of ambiguous gender look like? An angel, with no genitals? Silly proposition.
Hmm.  Only game-performance difference I'd noticed based on characters' gender label was the CEO's reaction to a failed pickup line; professions break down along gender lines the more C-slanted Women's Rights is, but that doesn't directly affect character performance.  (Stats from the profession do, and initial skillsets can help, see Locksmith.  But if you're looking for great stats, I'd recommend screening Mutants.)

So, I'm not sure why its being a new feature, rather than a timing change that I thought made the game more accessible to Ambiguous players*, is a strike against this idea.  Sure, someone wanting to have an Ambiguous Founder could fix the label as soon as they cleared character creation, but it's not quite the same as having been born with genitalia that in whatever way didn't easily classify as a slot or a tab.  (Plenty of photos on the Wiki page for "Intersex", if that's what you're asking after.)

*I'm sure no LCS player ever identifies even the tiniest bit with xyr Founder and wants to create a protagonist that resembles xem.  Nope, never happens, not at all, no way nohow.  Uh-uh.
Logged

Soadreqm

  • Bay Watcher
  • I'm okay with this. I'm okay with a lot of things.
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #221 on: December 30, 2012, 09:17:26 am »

Thing is, the thing you select at character creation is your biological sex, not the gender label. What the doctors said you were when you were born. And although the LCS does not care about the CONSERVATIVE SOCIETY'S ARBITRARY LIMITATIONS, the game secretly keeps track of both. It even matters in a couple places. When someone who was born female but has switched to male tries to get into the Gentlemen's Club, they have to pass an additional disguise check.

Unless you're saying that you should be able to select "ambiguous" as your biological sex. I guess that's plausible. Probably not all that hard to code,[citation needed] but you'd need to decide how the game reacts to you and write a bunch of flavor text. "The doctors said you were neither a boy nor a girl. Your parents were horrified."
Logged

KA101

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #222 on: December 30, 2012, 10:49:51 pm »

Thanks for the reminder--the only time I send anyone to the Club/Bar is when I'm looking to get a sleeper bouncer or find CCS members to loosen up.

Yep, that's what I'm looking for: selecting "Ambiguous" as one's "official" label.  Hadn't known how much attention the game paid to the creation choice v Fixable labels.  Thanks for the coding insight.

(Given that the parents divorce 10 years later, possibly one was horrified & demanded assignment-surgery whilst the other felt you ought to be allowed to develop and decide for yourself?)
Logged

Jonathan S. Fox

  • Bay Watcher
    • View Profile
    • http://www.jonathansfox.com/
Re: Bugs, UI issues and Minor Suggestions
« Reply #223 on: January 10, 2013, 05:24:05 am »

* UI consistency needs work - every screen should scroll and exit using the same keys

Did this for exiting, but need more information about scrolling. What are the inconsistencies?

* Elections/political situation should be visible during prison/hospital time. Perhaps the waiting screen should be substituted with a modified version of the disband screen?

Hospitalization shouldn't be suppressing politics. I don't intend to change this for prison; while it may be realistic that you would be able to track the political situation from prison, the sense of isolation from the world and emerging to find things radically changed is something that I want to preserve.

* Flag burning gives a criminal flag even when L, and past flag burning crimes won't be nullified until L+

This doesn't appear to be a problem in the latest code; it's probably already fixed.

* Z - key seems to stop scrolling at Robert E. Lee bunker (or any last safehouse on the list?)

Now fixed on SVN.

* Military sleepers stealing equipment causes vector subscript out of range during certain conditions (see Tylus' post below)

Can't find the reason for this in the code, and I'm a little too lazy to try to reproduce the bug directly tonight. Does anyone know if this has been fixed? Kinda wondering if Pesi found this one, he's caught a lot of little mistakes like this.

Edit:

Unless you're saying that you should be able to select "ambiguous" as your biological sex. I guess that's plausible. Probably not all that hard to code,[citation needed] but you'd need to decide how the game reacts to you and write a bunch of flavor text. "The doctors said you were neither a boy nor a girl. Your parents were horrified."

Citation: It would indeed be easy to code, and is already almost supported. "The doctors said you were an intersex baby" is actually in the game code, but it's a bug if you ever see it.
« Last Edit: January 10, 2013, 05:32:28 am by Jonathan S. Fox »
Logged

Pesi

  • Bay Watcher
    • View Profile
Re: Bugs, UI issues and Minor Suggestions
« Reply #224 on: January 10, 2013, 03:53:25 pm »

* Military sleepers stealing equipment causes vector subscript out of range during certain conditions (see Tylus' post below)

Can't find the reason for this in the code, and I'm a little too lazy to try to reproduce the bug directly tonight. Does anyone know if this has been fixed? Kinda wondering if Pesi found this one, he's caught a lot of little mistakes like this.
I seem to remember this one being because of a typo where the sleeper tried to take the nonexisting item SILVERWEAR, and that changing it to SILVERWARE fixed it.
Logged
Pages: 1 ... 13 14 [15] 16