Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1] 2

Author Topic: reaction not making any product  (Read 1317 times)

zozeer

  • Bay Watcher
    • View Profile
reaction not making any product
« on: March 20, 2011, 04:45:02 pm »

I have been working on this one for a while and I can't see whats wrong.

When testing in fortress mode after the time period that it takes to make the reagent is gone, the fuel too, but it is not making any of the products. 

Code: [Select]
[REACTION:FORGE_SUIT_OF_ARMOR]
    [NAME:Forge Suit of armor]
    [BUILDING:ARMOR_SMITH:CUSTOM_A]
    [REAGENT:A:6:BAR:NONE:NONE:NONE][IS_METAL]
    [PRODUCT:100:1:ITEM_ARMOR_BREASTPLATE:NONE:GET_MATERIAL_FROM_REAGENT]
    [PRODUCT:100:1:ITEM_GLOVES_GAUNTLETS:NONE:GET_MATERIAL_FROM_REAGENT]
    [PRODUCT:100:1:ITEM_HELM_HELM:NONE:GET_MATERIAL_FROM_REAGENT]
    [PRODUCT:100:1:ITEM_PANTS_GREAVES:NONE:GET_MATERIAL_FROM_REAGENT]
    [PRODUCT:100:1:ITEM_SHIELD_SHIELD:NONE:GET_MATERIAL_FROM_REAGENT]
    [PRODUCT:100:1:ITEM_SHOES_BOOTS:NONE:GET_MATERIAL_FROM_REAGENT]
    [FUEL]
    [SKILL:FORGE_ARMOR]
Logged

D_E

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #1 on: March 20, 2011, 04:55:04 pm »

Should be
[PRODUCT:100:1:ARMOR:ITEM_ARMOR_BREASTPLATE:GET_MATERIAL_FROM_REAGENT:A:NONE]
   
[PRODUCT:100:1:GLOVES:ITEM_GLOVES_GAUNTLETS:GET_MATERIAL_FROM_REAGENT:A:NONE]

Also, I think the gauntlets this reaction produces won't be wearable, because gauntlets have to be either left or right and reaction produced gauntlets are neither.  Perhaps someone else will confirm or deny that?
Logged
Mods I've done:
Zelda mod-mod, Beta in the Wild DF 47.04
Illithid Empire mod DF 31.25 (update canceled)
Spotter's Guide to Illithids (Genesis mod-mod) genesis 3.19a4 (update canceled)

Girlinhat

  • Bay Watcher
  • [PREFSTRING:large ears]
    • View Profile
Re: reaction not making any product
« Reply #2 on: March 20, 2011, 05:01:16 pm »

Also be aware that custom-reaction armor is of a fixed size that only humans can wear.  Weapons are different though, so you can make custom reaction weapons.

zozeer

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #3 on: March 20, 2011, 05:06:42 pm »

Thanks for the fast reply!

Is there a way to make dwarf sized armor via [PRODUCT_DIMENSION:] or something like that?
Logged

Langdon

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #4 on: March 20, 2011, 05:13:31 pm »

Also, I think the gauntlets this reaction produces won't be wearable, because gauntlets have to be either left or right and reaction produced gauntlets are neither.  Perhaps someone else will confirm or deny that?

I can confirm this at least with adventurer mods - the bone gauntlets and leather gloves I produce using Wanderer's Friend/Tanmod are not marked "left/right", and are unwearable.
Logged

D_E

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #5 on: March 20, 2011, 05:24:21 pm »

I've never tried PRODUCT_DIMENSION, but I don't think that will work.  PRODUCT_DIMENSION seems to default to 1, so if it was necessary, reaction-made armor should fit NOBODY by default.

Has anyone tried reaction-created gauntlets, in fort mode?  My guess is that they won't work there, either, but....
Logged
Mods I've done:
Zelda mod-mod, Beta in the Wild DF 47.04
Illithid Empire mod DF 31.25 (update canceled)
Spotter's Guide to Illithids (Genesis mod-mod) genesis 3.19a4 (update canceled)

Jay

  • Bay Watcher
  • ☼Not Dead Yet☼
    • View Profile
Re: reaction not making any product
« Reply #6 on: March 20, 2011, 05:31:22 pm »

In 31.21 (at least), I'm pretty sure that reaction-armor is sized according to the creator.
At least, my dwarf can wear the stuff I make out of leather.
« Last Edit: March 20, 2011, 05:40:30 pm by Jay »
Logged
Mishimanriz: Histories of Pegasi and Dictionaries

zozeer

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #7 on: March 20, 2011, 05:38:22 pm »

The first hurdle is what girlinhat brought up, if the armor is human sized it cannot be equipped in the first place, even if we can get left/right.

I guess the simple solution is to make the dwarf's human sized...

any thoughts on how to make SHAPED gloves for left and right in items_gloves.txt to give left/right?
also with that method we might be able to add LAYER_SIZE to custom armor items to make dwarf sized armor.

* zozeer runs off to mess with raws.
Logged

Jay

  • Bay Watcher
  • ☼Not Dead Yet☼
    • View Profile
Re: reaction not making any product
« Reply #8 on: March 20, 2011, 05:41:12 pm »

I guess the simple solution is to make the dwarf's human sized...
In 31.21 (at least), I'm pretty sure that reaction-armor is sized according to the creator.
Huh?
Logged
Mishimanriz: Histories of Pegasi and Dictionaries

Girlinhat

  • Bay Watcher
  • [PREFSTRING:large ears]
    • View Profile
Re: reaction not making any product
« Reply #9 on: March 20, 2011, 05:42:09 pm »

Layer size determines how armor stacks.  You can't stack a vest on top of a breastplate, but you can put a mail shirt on under a breastplate.

Langdon

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #10 on: March 20, 2011, 05:44:17 pm »

The first hurdle is what girlinhat brought up, if the armor is human sized it cannot be equipped in the first place, even if we can get left/right.

I guess the simple solution is to make the dwarf's human sized...

any thoughts on how to make SHAPED gloves for left and right in items_gloves.txt to give left/right?
also with that method we might be able to add LAYER_SIZE to custom armor items to make dwarf sized armor.

* zozeer runs off to mess with raws.

As Jay said, the armor size bug was fixed in .20. The armor is now the correct size for the creator (verified by playing with Wanderer's Friend mod in .21, where my dwarf adventurer could make armor for himself, but it didn't fit my human companions).

So your only bug left is the left/right gauntlet/glove bug.
Logged

Girlinhat

  • Bay Watcher
  • [PREFSTRING:large ears]
    • View Profile
Re: reaction not making any product
« Reply #11 on: March 20, 2011, 05:46:47 pm »

I don't suppose you've tried to use GAUNTLET_LEFT or LEFT_GAUNTLET as a token, have you?

zozeer

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #12 on: March 20, 2011, 05:56:22 pm »

I have not tried the gauntlet_left or left_gauntlet tokens yet.  and the dwarfs can wear the armor created. 

However, the reaction is creating 150 of each item it creates...

Code: [Select]
[REACTION:FORGE_SUIT_OF_ARMOR]
    [NAME:Forge Suit of armor]
    [BUILDING:ARMOR_SMITH:CUSTOM_A]
    [REAGENT:A:1:BAR:NONE:NONE:NONE][IS_METAL]
    [PRODUCT:100:1:ARMOR:ITEM_ARMOR_BREASTPLATE:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]
    [PRODUCT:100:1:GLOVES:ITEM_GLOVES_GAUNTLETS:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]
    [PRODUCT:100:1:HELM:ITEM_HELM_HELM:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]
    [PRODUCT:100:1:PANTS:ITEM_PANTS_GREAVES:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]
    [PRODUCT:100:1:SHIELD:ITEM_SHIELD_SHIELD:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]
    [PRODUCT:100:1:SHOES:ITEM_SHOES_BOOTS:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE]
    [FUEL]
    [SKILL:FORGE_ARMOR]

I'm not sure where the 150 is coming from.  Any thoughts?

I will try to add the gauntlet_left and left_gauntlet tokens.
Logged

Girlinhat

  • Bay Watcher
  • [PREFSTRING:large ears]
    • View Profile
Re: reaction not making any product
« Reply #13 on: March 20, 2011, 06:02:05 pm »

A bar is size 150.  Try [DOES_NOT_DETERMINE_PRODUCT_AMOUNT] right under the bar reagent.

zozeer

  • Bay Watcher
    • View Profile
Re: reaction not making any product
« Reply #14 on: March 20, 2011, 06:11:39 pm »

[DOES_NOT_DETERMINE_PRODUCT_AMOUNT] got rid of the 150 issue!

No dice on the GAUNTLET_LEFT / LEFT_GAUNTLET token.

On another side note the armor is not getting the material from the reagent, any thoughts?
Logged
Pages: [1] 2