This is excellent work. I've added it to my own mod, and have of course credited you.
Thank you.
Thanks. I do kind of want to check the colors again, including adding links to pictures, because some of the current DF colors are arguably inconsistent. Granted, you can't do much for things like opal, but it might be worth doing some experiments to see if making bloodstone red with a dark green background looks reasonable, because that's what the IRL gem looks like. But it's a little bit hard to make gems appear on demand, you know?
If experienced modders like you have advice on that front, I'd like to hear it. For now, I'm actually going through the DF wiki and trying to make sure we have images if any free images exist (for a lot of them, we seem to have images on the wiki, but not the article, and I'm not sure why).
There's also the fact that I'm reluctant to change some things. We've been used to, say, cobaltite being blue for so long that the fact that the real stone isn't like that (at least on any of the samples I could find online) might actually be an unwelcome change. I think gems are generally safer to change, though, because the average person probably has no idea what color anything other than, say, diamonds, emeralds and rubies are.
So I don't think I put anything too controversial in this mod in terms of color, but I'm certainly willing to listen to advice from anyone who has ideas on good ways to handle things. As for myself, I'm thinking that not making any major color changes is better, even if bismuth is mostly blue with purplish highlights in the light, not the purple color it's shown as in game, just because I want people to be able to have colorful fortresses if they want to (though I guess they'd have rose gold for that particular case).
Anyhow, the point is that feedback on my color choices would be appreciated.