Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Nkosi_SW]

thanks for the report, unfortunately i have a save with merchants, but they don't show up in DT, so i may still need you to upload that save if it's not too much trouble.

The caravan was halfway through arriving when I "Read Dwarves" in DT and it showed the extra 14 from the caravan.  However, a minute or two later after the whole caravan had arrived, DT stopped showing the caravan members.  My save is exactly when those extra 14 are showing, so hopefully it can help diagnose the problem.

Here is the save file.

I can't remember where the screen is centered, but F7 is the hotkey for the Traders Depot in the unlikely event you need to look at it in-game.

Good luck and thanks again!  Let me know what happens and if I can provide any other info.  I'm also running DFHack, but hopefully that hasn't made a difference - I don't use it for much.

[splinterz]

thanks for the report, unfortunately i have a save with merchants, but they don't show up in DT, so i may still need you to upload that save if it's not too much trouble.

The caravan was halfway through arriving when I "Read Dwarves" in DT and it showed the extra 14 from the caravan.  However, a minute or two later after the whole caravan had arrived, DT stopped showing the caravan members.  My save is exactly when those extra 14 are showing, so hopefully it can help diagnose the problem.

Here is the save file.

I can't remember where the screen is centered, but F7 is the hotkey for the Traders Depot in the unlikely event you need to look at it in-game.

Good luck and thanks again!  Let me know what happens and if I can provide any other info.  I'm also running DFHack, but hopefully that hasn't made a difference - I don't use it for much.

so it turns out that those merchants had the same flags as migrants, but no merchant flags while off the map. once they appeared on the map, they were then flagged as merchants and DT hid them correctly. i think i've found a solution and i'll put it in the next release. thanks for sending the save file and the detailed report, it's a huge help.

[Nkosi_SW]

thanks for sending the save file and the detailed report, it's a huge help.

No problem at all.  Thank YOU for the quick response and fix, and for making my DF experience far more enjoyable with your wonderful DT. 

[Nkosi_SW]

I have some suggestions that I thought I'd run past you splinterz and see what you thought.  Make of them what you will. 

The first suggestion is (hopefully) relatively minor.  The "Group By" drop down box can list 10 categories, which I think back in the day used to be all of them.  But there are now 16 categories, which necessitates much scrolling up and down over the course of a DF session.  Would it be possible to make the number of concurrently displayed categories (ie the size of the drop down box) equal to the total number of categories?

The second suggestion is a bit more beefy.  I put a fair bit of effort in to managing the highest moodable skills on all my dwarves to ensure I get the maximum number of artifact weapons and armour, and the minimum number of artifact toy forges.  With around 200 dwarves, it's a big job, but it's made a lot harder because I can't directly tell who has already had a mood from the main view.

For example, I have twelve dwarves in the "Metalworker" custom profession and I want to set three of them to do metalcrafting, but I don't want any of the three to be ones who haven't yet had a mood, because the experience gain in metalcrafting skill could overtake the current highest moodable skill (say weaponsmith or armoursmith) and result in an artifact goblet.  The only ways for me to tell who has already had a mood that I know about are to change Group By to Highest Moodable Skill, multi-select all the dwarves who have already had a mood, change back to group by Profession, and then enable the metalcrafting labour on the highlighted dwarves.  Seeing as the multi-highlighting is lost as soon as I click to enable a labour, I have to go through the whole process again and again if I forget which dwarves are highlighted or there are a lot of dwarves to set labours for.

The other way to tell is to right-click on each dwarf in the "Metalworker" custom profession sequentially and select Show Details, scroll down the Skill list until I find the one that's highlighted in blue, hover the cursor over it until the tooltip appears and tells me if they've already had a mood, and then close the Details box.  This gets pretty tedious pretty fast for lots of dwarves.

If I could tell who has had a mood from the main grid view that would save me so much time and fiddly effort.  It seems to me the best solution would be a new column, "Highest Moodable Skill".  It could re-use some of the icons from the "Current Job" column to indicate what is the current highest moodable skill, or the "No Job" icon to indicate there has already been a mood.  An added advantage of this method would be the you could sort on this column.

Another way I can think of to do it would be to put a coloured border around the labour cells for the highest moodable skill, in the same way as for "Pending Changes", but with different colours.  Say a blue border around the cell for the labour that is the current highest moodable skill, or a green border if they have already had a mood for that skill.  The red of a pending change would take precedence over either of these.  This method would not allow sorting.

A couple of minor ancillary suggestions are in the Details of a dwarf under Skills to change the highlight colour of the highest moodable skill if the have already had a mood (so you don't have to hover for the tooltip), and to add text to the header section of Details (around the Name and Age section) to say "Creator of <artifact name>" in the same way as the [v]iew - [g]eneral header section of DF (though this last suggestion might be a bit tricky I would guess and is not really important).

Anyway, just thought I'd make some suggestions that would make managing Highest Moodable Skills a whole lot easier.  Look forward to hearing your thoughts, and thanks in advance for considering them. 

[thistleknot]

I commend these detailed requests... but... they are a lot to code...  good job, I need to re-read in the morn... this is how I play df... resort, resort, resort, 1 requirement is met.

[splinterz]

I have some suggestions that I thought I'd run past you splinterz and see what you thought.  Make of them what you will. 

The first suggestion is (hopefully) relatively minor.  The "Group By" drop down box can list 10 categories, which I think back in the day used to be all of them.  But there are now 16 categories, which necessitates much scrolling up and down over the course of a DF session.  Would it be possible to make the number of concurrently displayed categories (ie the size of the drop down box) equal to the total number of categories?

The second suggestion is a bit more beefy.  I put a fair bit of effort in to managing the highest moodable skills on all my dwarves to ensure I get the maximum number of artifact weapons and armour, and the minimum number of artifact toy forges.  With around 200 dwarves, it's a big job, but it's made a lot harder because I can't directly tell who has already had a mood from the main view.

For example, I have twelve dwarves in the "Metalworker" custom profession and I want to set three of them to do metalcrafting, but I don't want any of the three to be ones who haven't yet had a mood, because the experience gain in metalcrafting skill could overtake the current highest moodable skill (say weaponsmith or armoursmith) and result in an artifact goblet.  The only ways for me to tell who has already had a mood that I know about are to change Group By to Highest Moodable Skill, multi-select all the dwarves who have already had a mood, change back to group by Profession, and then enable the metalcrafting labour on the highlighted dwarves.  Seeing as the multi-highlighting is lost as soon as I click to enable a labour, I have to go through the whole process again and again if I forget which dwarves are highlighted or there are a lot of dwarves to set labours for.

The other way to tell is to right-click on each dwarf in the "Metalworker" custom profession sequentially and select Show Details, scroll down the Skill list until I find the one that's highlighted in blue, hover the cursor over it until the tooltip appears and tells me if they've already had a mood, and then close the Details box.  This gets pretty tedious pretty fast for lots of dwarves.

If I could tell who has had a mood from the main grid view that would save me so much time and fiddly effort.  It seems to me the best solution would be a new column, "Highest Moodable Skill".  It could re-use some of the icons from the "Current Job" column to indicate what is the current highest moodable skill, or the "No Job" icon to indicate there has already been a mood.  An added advantage of this method would be the you could sort on this column.

Another way I can think of to do it would be to put a coloured border around the labour cells for the highest moodable skill, in the same way as for "Pending Changes", but with different colours.  Say a blue border around the cell for the labour that is the current highest moodable skill, or a green border if they have already had a mood for that skill.  The red of a pending change would take precedence over either of these.  This method would not allow sorting.

A couple of minor ancillary suggestions are in the Details of a dwarf under Skills to change the highlight colour of the highest moodable skill if the have already had a mood (so you don't have to hover for the tooltip), and to add text to the header section of Details (around the Name and Age section) to say "Creator of <artifact name>" in the same way as the [v]iew - [g]eneral header section of DF (though this last suggestion might be a bit tricky I would guess and is not really important).

Anyway, just thought I'd make some suggestions that would make managing Highest Moodable Skills a whole lot easier.  Look forward to hearing your thoughts, and thanks in advance for considering them.

i think these are some great ideas. first, for the dropdown, it's trivial to increase the amount of visible items, and i'll be sure to fix that in the next release. i like the idea of adding the highest moodable skill column, specifically because of the ability to sort. it's also easy to add additional column types so this is very feasible. i'll also try to change the color of the background for skills which have already had a mood in the details pane, that makes sense as well. i'll also see about adding some extra information about the highest moodable skill in some of the tooltips.

i can't comment on the artifact idea as i'd need to look into if it's possible, but it might be. i was hoping to get the next release out by now, but i noticed there's a nasty memory leak every time a read is performed that i'm trying to hunt down. hopefully i'll get it sorted soon before it drives me insane.

[Nkosi_SW]

I commend these detailed requests...

i think these are some great ideas.

Thanks for the positive feedback guys.   

first, for the dropdown, it's trivial to increase the amount of visible items, and i'll be sure to fix that in the next release. i like the idea of adding the highest moodable skill column, specifically because of the ability to sort. it's also easy to add additional column types so this is very feasible. i'll also try to change the color of the background for skills which have already had a mood in the details pane, that makes sense as well. i'll also see about adding some extra information about the highest moodable skill in some of the tooltips.

Great to hear that these ideas are not completely unfeasible!

i can't comment on the artifact idea as i'd need to look into if it's possible, but it might be.

Yeah, that one's not too important at all.  A nice touch, but probably not worth spending much time on.

i was hoping to get the next release out by now, but i noticed there's a nasty memory leak every time a read is performed that i'm trying to hunt down. hopefully i'll get it sorted soon before it drives me insane.

Ouch!  Mysterious memory leaks are an enourmous pain in the arse.  I haven't been tormented by one for a long time now, knock on wood.  Good luck tracking it down.

[arclance]

I just tired building the default branch from splintermind-attributes on Linux and it failed with this error.

Code: [Select]

src/laboroptimizer.cpp: In member function ‘void LaborOptimizer::optimize_labors(QList<Dwarf*>)’:
src/laboroptimizer.cpp:133:5: error: ‘sort’ is not a member of ‘std’
make: *** [bin/release/laboroptimizer.o] Error 1


[arclance]

I just tired building the default branch from splintermind-attributes on Linux and it failed with this error.

Code: [Select]

src/laboroptimizer.cpp: In member function ‘void LaborOptimizer::optimize_labors(QList<Dwarf*>)’:
src/laboroptimizer.cpp:133:5: error: ‘sort’ is not a member of ‘std’
make: *** [bin/release/laboroptimizer.o] Error 1


I was able to build it using a different distro.
It works there but not on my 64bit computer.

Code: [Select]

2012-Dec-23 22:11:21.252 INFO core Dwarf Therapist "0.6.12" starting normally. [src/dwarftherapist.cpp:103] (setup_logging)
2012-Dec-23 22:11:21.313 INFO core Loaded 8 views from disk [src/viewmanager.cpp:136] (reload_views)
2012-Dec-23 22:11:21.314 DEBUG core group_by now set to 0 [src/models/dwarfmodel.cpp:782] (set_group_by)
2012-Dec-23 22:11:21.317 DEBUG core group_by now set to 0 [src/models/dwarfmodel.cpp:782] (set_group_by)
2012-Dec-23 22:11:21.317 DEBUG core "redrew views in 4ms" [src/viewmanager.cpp:258] (draw_views)
2012-Dec-23 22:11:21.361 DEBUG core setting up connections for MainWindow [src/mainwindow.cpp:140] (MainWindow)
2012-Dec-23 22:11:21.362 DEBUG core group_by now set to 0 [src/models/dwarfmodel.cpp:782] (set_group_by)
2012-Dec-23 22:11:21.363 DEBUG core beginning to read settings [src/dwarftherapist.cpp:125] (read_settings)
2012-Dec-23 22:11:21.363 DEBUG core finished reading settings [src/dwarftherapist.cpp:173] (read_settings)
2012-Dec-23 22:11:21.387 DEBUG core attempting connection to running DF game [src/mainwindow.cpp:262] (connect_to_df)
2012-Dec-23 22:11:21.389 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.389 DEBUG core adding valid layout "v0.34.11" "0xe966ee88" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.389 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.389 DEBUG core adding valid layout "v0.34.10" "0x71406692" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.390 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.390 DEBUG core adding valid layout "v0.34.09" "0xde041bf6" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.390 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.390 DEBUG core adding valid layout "v0.34.08" "0xe4a4d9c6" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.391 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.391 DEBUG core adding valid layout "v0.34.07" "0x61b4fa72" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.391 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.391 DEBUG core adding valid layout "v0.31.25" "0xfc15065c" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.391 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.391 DEBUG core adding valid layout "v0.31.24" "0xa47468ce" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.392 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.392 DEBUG core adding valid layout "v0.31.22" "0xc8e82e6e" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.392 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.392 DEBUG core adding valid layout "v0.31.22" "0xc7319be1" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.392 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.392 DEBUG core adding valid layout "v0.31.21" "0xc3d2af10" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.392 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.392 DEBUG core adding valid layout "v0.31.20" "0x6d33ec73" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.393 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.393 DEBUG core adding valid layout "v0.31.19" "0x8fcb1f10" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.393 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.393 DEBUG core adding valid layout "v0.31.18" "0x884f794d" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.393 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.393 DEBUG core adding valid layout "v0.31.17" "0x03afc836" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.393 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.393 DEBUG core adding valid layout "v0.31.16" "0x9cca2fa5" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.394 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.394 DEBUG core adding valid layout "v0.31.15" "0x1cd8dc24" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.394 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.394 DEBUG core adding valid layout "v0.31.08" "0xe3775089" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.394 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.394 DEBUG core adding valid layout "v0.31.05" "0xfea3801a" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.394 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.394 DEBUG core adding valid layout "v0.31.04" "0x1d759a11" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.394 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:21.394 DEBUG core adding valid layout "v0.28.181.40d16" "0xdab3ce6b" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:21.400 ERROR core Unable to open "/proc/0/maps" [src/dfinstancelinux.cpp:381] (map_virtual_memory)
2012-Dec-23 22:11:21.400 ERROR core Could not attach to PID 0 [src/dfinstancelinux.cpp:192] (attach)
2012-Dec-23 22:11:21.400 ERROR core Unable to open "/proc/0/mem" [src/dfinstancelinux.cpp:225] (read_raw)
2012-Dec-23 22:11:21.400 DEBUG core base_addr: 0 HEX 0 [src/dfinstancelinux.cpp:351] (find_running_copy)
2012-Dec-23 22:11:21.402 DEBUG core DF's checksum is "0x00000000" [src/dfinstancelinux.cpp:355] (find_running_copy)
2012-Dec-23 22:11:21.402 INFO core Dwarf fortress path: "/media/Linux_Data/Dwarf_Fortress/Utilities/DwarfTherapist/0_Build/dwarftherapist_2012-12-23/bin/release" [src/dfinstancelinux.cpp:362] (find_running_copy)
2012-Dec-23 22:11:24.532 DEBUG core attempting connection to running DF game [src/mainwindow.cpp:262] (connect_to_df)
2012-Dec-23 22:11:24.532 DEBUG core already connected, disconnecting [src/mainwindow.cpp:264] (connect_to_df)
2012-Dec-23 22:11:24.532 DEBUG core DFInstance baseclass virtual dtor! [src/dfinstance.cpp:123] (~DFInstance)
2012-Dec-23 22:11:24.534 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.534 DEBUG core adding valid layout "v0.34.11" "0xe966ee88" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.534 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.534 DEBUG core adding valid layout "v0.34.10" "0x71406692" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.535 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.535 DEBUG core adding valid layout "v0.34.09" "0xde041bf6" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.535 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.535 DEBUG core adding valid layout "v0.34.08" "0xe4a4d9c6" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.535 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.535 DEBUG core adding valid layout "v0.34.07" "0x61b4fa72" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.536 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.536 DEBUG core adding valid layout "v0.31.25" "0xfc15065c" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.536 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.536 DEBUG core adding valid layout "v0.31.24" "0xa47468ce" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.536 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.536 DEBUG core adding valid layout "v0.31.22" "0xc8e82e6e" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.536 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.536 DEBUG core adding valid layout "v0.31.22" "0xc7319be1" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.536 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.536 DEBUG core adding valid layout "v0.31.21" "0xc3d2af10" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.536 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.536 DEBUG core adding valid layout "v0.31.20" "0x6d33ec73" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.536 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.536 DEBUG core adding valid layout "v0.31.19" "0x8fcb1f10" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.31.18" "0x884f794d" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  1 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.31.17" "0x03afc836" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.31.16" "0x9cca2fa5" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.31.15" "0x1cd8dc24" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.31.08" "0xe3775089" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.31.05" "0xfea3801a" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.31.04" "0x1d759a11" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.537 DEBUG core valid_flags_2 count:  0 [src/memorylayout.cpp:85] (load_data)
2012-Dec-23 22:11:24.537 DEBUG core adding valid layout "v0.28.181.40d16" "0xdab3ce6b" [src/dfinstance.cpp:108] (DFInstance)
2012-Dec-23 22:11:24.543 ERROR core Unable to open "/proc/0/maps" [src/dfinstancelinux.cpp:381] (map_virtual_memory)
2012-Dec-23 22:11:24.543 ERROR core Could not attach to PID 0 [src/dfinstancelinux.cpp:192] (attach)
2012-Dec-23 22:11:24.543 ERROR core Unable to open "/proc/0/mem" [src/dfinstancelinux.cpp:225] (read_raw)
2012-Dec-23 22:11:24.543 DEBUG core base_addr: 0 HEX 0 [src/dfinstancelinux.cpp:351] (find_running_copy)
2012-Dec-23 22:11:24.544 DEBUG core DF's checksum is "0x00000000" [src/dfinstancelinux.cpp:355] (find_running_copy)
2012-Dec-23 22:11:24.544 INFO core Dwarf fortress path: "/media/Linux_Data/Dwarf_Fortress/Utilities/DwarfTherapist/0_Build/dwarftherapist_2012-12-23/bin/release" [src/dfinstancelinux.cpp:362] (find_running_copy)
2012-Dec-23 22:11:24.547 DEBUG core Connection to unknown DF Version established. [src/mainwindow.cpp:292] (connect_to_df)
2012-Dec-23 22:11:29.270 WARNING core lost connection to DF [src/mainwindow.cpp:355] (lost_df_connection)
2012-Dec-23 22:11:29.279 DEBUG core group_by now set to 0 [src/models/dwarfmodel.cpp:782] (set_group_by)
2012-Dec-23 22:11:29.280 DEBUG core DFInstance baseclass virtual dtor! [src/dfinstance.cpp:123] (~DFInstance)
2012-Dec-23 22:11:32.677 INFO core Beginning shutdown [src/mainwindow.cpp:252] (closeEvent)
2012-Dec-23 22:11:32.677 DEBUG core beginning to write settings [src/mainwindow.cpp:228] (write_settings)
2012-Dec-23 22:11:32.677 DEBUG core finished writing settings [src/mainwindow.cpp:247] (write_settings)
2012-Dec-23 22:11:32.677 INFO core Closing Dwarf Therapist normally [src/mainwindow.cpp:258] (closeEvent)
That is the computer I need it to work on, any ideas on how to get it to work there?

[xiziz]

I just tired building the default branch from splintermind-attributes on Linux and it failed with this error.

I was able to build it using a different distro.
It works there but not on my 64bit computer.

That is the computer I need it to work on, any ideas on how to get it to work there?

Saw you were having trouble, I just managed to bypass the exact same thing a few weeks back. Found the solution here. Simple as adding a line to src/laboroptimizer.cpp with any text editor prior to running through the building process.

Good Luck!

[arclance]

I just tired building the default branch from splintermind-attributes on Linux and it failed with this error.

I was able to build it using a different distro.
It works there but not on my 64bit computer.

That is the computer I need it to work on, any ideas on how to get it to work there?

Saw you were having trouble, I just managed to bypass the exact same thing a few weeks back. Found the solution here. Simple as adding a line to src/laboroptimizer.cpp with any text editor prior to running through the building process.

Good Luck!

Okay I figured out the problem.
I was running some test builds of dfhack earlier and one of them had left a stuck process but no window when it died.
Killing that got it to work.

After looking at the code

Code: [Select]

    args << "Dwarf_Fortress"; // 0.31.05+
    proc->start("pidof", args);
    proc->waitForFinished(1000);
    if (proc->exitCode() == 0) { //found it
        QByteArray out = proc->readAllStandardOutput();
        QString str_pid(out);
        m_pid = str_pid.toInt();
I can see that there is no check for there being multiple processes with "Dwarf_Fortress" in the name there and it fails trying to read a non-existent process because of that.
If this was not C++ I would make a patch to fix that but I don't know how to do anything in that language.

Ideally a fix for this would either popup and say

Error: Multiple Running Dwarf Fortresses Detected
Please close all but one Dwarf Fortress process and try to connect again.

or

Error: Multiple Running Dwarf Fortresses Detected
Please select the correct process from this list.

[splinterz]

new version is ready for release testing! 

summary of main highlights (see link below for full patch notes)

• enhanced highest moodable skill feature to include cell highlighting, new column and tooltip information
• new options to set fonts for the application and tooltips
• preferences can be added to roles much like skills, attributes and traits. these can be specific preferences or general categories
• new profession icons have been added to tooltips, dwarf details pane, as well as a new column
• custom professions can now have customized icons and import/export everything correctly
• added 'creator of <artifact name>' in a few places
• many other tweaks and bug fixes

there will probably be some bugs with this version as quite a lot was updated and adjusted, especially for a few memory leaks. just let me know in as much detail as possible and i'll get things fixed up when i can.

happy new year's eve!

Download // Project Home // Full Patch Notes

[arclance]

there will probably be some bugs with this version as quite a lot was updated and adjusted, especially for a few memory leaks. just let me know in as much detail as possible and i'll get things fixed up when i can.

Any chance you could address the lack of a check for multiple detected processes in Linux I mentioned in my previous post?
pidof can give false positives so it is more serious than failing if you have two copies of Dwarf Fortress running at the same time.
All you need to do to check for multiple returns by "pidof" is to split the string it returns on the space " " character and check how many pieces you get from that split.
If you get more than one piece after that split "pidof" returned the PID of more than one process.

Right now "str_pid.toInt()" returns "0" when "pidof" returns multiple PIDs and fails trying to read "/proc/0/maps" since it does not exist (at least on my system).
The code does not stop when this fails so it goes on to try connection to a "0x00000000" process with ptrace.
Unless you read the log file this error looks like a ptrace control issue so it has the potential to be very frustrating unless you know to look for it.

You may also want mark the downloads on your release page as "Windows Only" in some way since the "v19.0 (DF 34.07 - DF 34.11 Windows SDL & Linux)" right above them is misleading about the contents of the file.

[splinterz]

yes i've read your post and i'm aware of the issue. ideally it may be better to remove the dependency on pidof in the first place since it's been pointed out that it's not available on all flavours of linux.

[thistleknot]

it would be nice to see the % in the role editor update as I change options.  basically to recalculate the role % for the selected dwarf based on the weights that are changed.