Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Tierre]

Great work:) I have a request: can noble positions be showed near you dwarfes, so that you won't conscript your manager in the squad by incident and them start trying to understand why are those job not assigned to workshps.

Thanks for your work.

[Rose]

Noble positions are stored very differently from job positions, and I'm not sure if therapist can support them yet.

DFhack does, though.

[Tierre]

Well it is only a humble request that's it:) But knowing that THIS one is your manager can make you reconsider making him a hunter:) Just a simple (not so simple to implement though) usability upgrade to DT. Also having some role evaluation to noble positions could be quite awesome too;)

[splinterz]

thanks for all the support!

@Tierre: i'd like to show the noble positions, but as Japa has pointed out, it may be tricky to find them. i'll have to dig through dfhack's offsets and see if i can figure out how/where they're using them

[ab9rf]

thanks for all the support!

@Tierre: i'd like to show the noble positions, but as Japa has pointed out, it may be tricky to find them. i'll have to dig through dfhack's offsets and see if i can figure out how/where they're using them

Autolabor applies an assignment penalty based on responsibilities, which are derived from nobles, and has special cases for the CMD and broker.  See https://github.com/peterix/dfhack/blob/master/plugins/autolabor.cpp, lines 779 to 807.

[Jon-Ace]

Another bug for you splinterz:

Started a new fort and upon going to squads, I see garbage left over from my last fort. Namely the squad names I used:




Upon unpausing after looking at this issue, two of my dwarfs randomly turned into recruits. I didn't even go into the military screen in DF yet!

[GoldenShadow]

Another feature request:
Can we have a list of happy and bad thoughts listed in a good and bad categories with a number that shows how strong of an effect that thought has? It could be hidden in a right click menu like you did with the squad assignments.

[Grax]

Upon unpausing after looking at this issue, two of my dwarfs randomly turned into recruits. I didn't even go into the military screen in DF yet!

In Soviet Russia you become a recruit upon your birth.

[ag]

• dwarfs can be assigned/removed from squads via right-click menu. you can assign/remove multiple dwarfs at once. this is done immediately and if grouping by squad the view will be refreshed automatically. only squads with positions available are shown. there may be some invalid squads, i haven't sorted out a way to filter them yet.
  

To find which squads actually belong to the current fortress, you need to use ui->main.fortress_entity->squads (contains ids). The same fortress_entity thing also contains noble positions and assignments, but they are more complicated to understand.

Also, you may want to disable changing the squad commander, because that entails appointment as the commander/captain, and DT can't do that, since it involves creating objects - although just simply opening the military screen in-game fixes any mismatch automatically.

[MaxxK]

I've tried to merge splintermind-attributes branch with mainstream to get OS X support and now I'm trying to find correct offsets for 0.34.10.

If anyone can correct me, it would be great:

Spoiler: addresses with help of mainstream 0.34.10.ini (click to show/hide)

[addresses]
translation_vector=0x01634a88
language_vector=0x01634a70
creature_vector=0x015f36ec
active_creature_vector=0x015f36f8
dwarf_race_index=0x015daf80
squad_vector=0x01631600
inactive_squad_vector=0x0163160c
current_year=0x015d8a40
cur_year_tick=0x015d8a48
dwarf_civ_index=0x015daf74
races_vector=0x0
reactions_vector=0x0
historical_figures=0x0
fake_identities=0x0

• Is it ok that cur_year_tick here is 8 bytes next to the current_year? There is another offset with cur_year_tick, but it's about few megabytes from main data area.
• Is there any markers to find last four offsets?
• How can inactive_squad_vector (and, if possible, all the others) be verified?

And is it normal that DT crashes and hangs DF when I'm trying to read dwarves? It looks like creature_vector and active_creature_vector have the same lengths in Windows and Mac versions for the same save. Log:

Spoiler (click to show/hide)

2012-May-31 10:16:14.773 DEBUG  core    loading creatures from  "0x015f36ec" "0x015f36ec" (UNCORRECTED) [/Volumes/Media/Sources/dwarftherapist-git/mydt/dwarftherapist/src/dfinstance.cpp:373] (load_dwarves)
2012-May-31 10:16:14.773 DEBUG  core    dwarf race index "0x015daf80" "0x015daf80" (UNCORRECTED) [/Volumes/Media/Sources/dwarftherapist-git/mydt/dwarftherapist/src/dfinstance.cpp:375] (load_dwarves)
2012-May-31 10:16:14.773 DEBUG  core    current year "0x015d8a40" "0x015d8a40" (UNCORRECTED) [/Volumes/Media/Sources/dwarftherapist-git/mydt/dwarftherapist/src/dfinstance.cpp:377] (load_dwarves)
2012-May-31 10:16:14.773 DEBUG  core    civilization id: "0x000008a6" [/Volumes/Media/Sources/dwarftherapist-git/mydt/dwarftherapist/src/dfinstance.cpp:383] (load_dwarves)
2012-May-31 10:16:14.773 DEBUG  core    dwarf race: "0x000001d1" [/Volumes/Media/Sources/dwarftherapist-git/mydt/dwarftherapist/src/dfinstance.cpp:387] (load_dwarves)
2012-May-31 10:16:14.774 DEBUG  core    current year: 12 [/Volumes/Media/Sources/dwarftherapist-git/mydt/dwarftherapist/src/dfinstance.cpp:390] (load_dwarves)
2012-May-31 10:16:14.774 DEBUG  core    no active units with our civ (reclaim), using full unit list [/Volumes/Media/Sources/dwarftherapist-git/mydt/dwarftherapist/src/dfinstance.cpp:611] (get_creatures)

[splinterz]

• dwarfs can be assigned/removed from squads via right-click menu. you can assign/remove multiple dwarfs at once. this is done immediately and if grouping by squad the view will be refreshed automatically. only squads with positions available are shown. there may be some invalid squads, i haven't sorted out a way to filter them yet.
  

To find which squads actually belong to the current fortress, you need to use ui->main.fortress_entity->squads (contains ids). The same fortress_entity thing also contains noble positions and assignments, but they are more complicated to understand.

Also, you may want to disable changing the squad commander, because that entails appointment as the commander/captain, and DT can't do that, since it involves creating objects - although just simply opening the military screen in-game fixes any mismatch automatically.

ah i see. at first i tried comparing them with the 'bad squads' vector but that wasn't working consistently. yeah i was actually surprised to see that changing the commander seemed to work. originally i intended not to assign them, but after trying it out i thought it might be alright. do you think it'll potentially cause problems?

i've taken a look at the autolabor script link posted before for the nobles, but i've been getting hung up on how to read the assignment_id for a histfig_entity_link_positionst.

anyway thanks for all the help.

[ag]

ah i see. at first i tried comparing them with the 'bad squads' vector but that wasn't working consistently. i didn't even try the ui vector as i saw the note about it only being valid when the ui was displayed. thanks for the help.

Don't ever look at those 'bad' vectors: they are 'bad' because they are serialization/deserialization temporaries and basically contain garbage once anything changes. Can even contain dangling pointers if/when some objects get deleted.

Re ui: that's a different vector altogether. I pointed you at the vector inside the fortress entity (object of the same general kind as civilization).

yeah i was actually surprised to see that changing the commander seemed to work. originally i intended not to assign them, but after trying it out i thought it might be alright. do you think it'll potentially cause problems?

It can be surprising. Maybe it should warn that you should open the military screen in-game and look at the squad to finalize changes if you change the commander.

i've taken a look at the autolabor script link posted before, but i've been getting hung up on how to read the assignment_id for a histfig_entity_link_positionst.

hm?

[splinterz]

ah i see. at first i tried comparing them with the 'bad squads' vector but that wasn't working consistently. i didn't even try the ui vector as i saw the note about it only being valid when the ui was displayed. thanks for the help.

Don't ever look at those 'bad' vectors: they are 'bad' because they are serialization/deserialization temporaries and basically contain garbage once anything changes. Can even contain dangling pointers if/when some objects get deleted.

Re ui: that's a different vector altogether. I pointed you at the vector inside the fortress entity (object of the same general kind as civilization).

yeah i was actually surprised to see that changing the commander seemed to work. originally i intended not to assign them, but after trying it out i thought it might be alright. do you think it'll potentially cause problems?

It can be surprising. Maybe it should warn that you should open the military screen in-game and look at the squad to finalize changes if you change the commander.

i've taken a look at the autolabor script link posted before, but i've been getting hung up on how to read the assignment_id for a histfig_entity_link_positionst.

hm?

haha i was just editing my post as i realized the mistake about the squad vector. for the nobles i was assuming i'd have to walk through similar to this

[ag]

for the nobles i was assuming i'd have to walk through similar to this

The game does it that way, yes; that's because it has to be able to deal with foreign nobles, e.g. diplomats and similar. If you are only interested in local ones, you can directly use fortress_entity->positions.own and fortress_entity->positions.assignments.

Edit: also, see here: https://github.com/peterix/dfhack/blob/master/library/modules/Units.cpp#L710. That autolabor code was copy&pasted from here.

[splinterz]

for the nobles i was assuming i'd have to walk through similar to this

The game does it that way, yes; that's because it has to be able to deal with foreign nobles, e.g. diplomats and similar. If you are only interested in local ones, you can directly use fortress_entity->positions.own and fortress_entity->positions.assignments.

Edit: also, see here: https://github.com/peterix/dfhack/blob/master/library/modules/Units.cpp#L710. That autolabor code was copy&pasted from here.

to indicate which dwarfs are nobles that should work perfectly! thanks again.