Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[devek]

Nice catch.

Will fix it in the next release.

Spoiler (click to show/hide)

Code: [Select]

diff --git a/main.cpp b/main.cpp
--- a/main.cpp
+++ b/main.cpp
@@ -78,16 +78,17 @@ public:
             inDFJobs = true;
             return true;
         }
 
         if ( name == "dfjob" )
         {
             job = new dfjob;
             job->enabled = false;
+            job->all = false;
             job->target = 0;
             job->count = 0;
             job->sourcecount = 0;
             job->pending = 0;
             job->stack = 1;
             for( int i=0; i<attrs.count(); i++ )
             {
                 if( attrs.localName( i ) == "name" )


[onart]

hello i am currently working on the xml and i have and question can i change the category of jobs without breaking the the thing ? because it is getting a bit messy in both the xml and the manager XD

[wedrifid]

hello i am currently working on the xml and i have and question can i change the category of jobs without breaking the the thing ? because it is getting a bit messy in both the xml and the manager XD

Hi Onart. The 'category' thing is pure eye candy. You can make the categories 'bikinis' and 'boobies' if you really want.

[onart]

haha thanks wil make it a bit less cluttery

[Quietust]

It's a shame you can't specify specific materials for stone/wood jobs (e.g. in order to do "Make nether-cap Barrel" or "Construct bauxite Floodgate") - I know that it's possible to hack active jobs like that (i.e. once they're in the workshop), but adding it that way to the job manager just makes the job take no materials and create no products. Certain odd combinations are possible, though - I added a job with type="129" and materialType="wood" and successfully created a wooden window.

Questions:
How exactly are the "item" and "source" tags (including the misspelled "soure" for clear glass portals) within <dfjob> used?
Is it possible to specify item subtypes by their ID rather than by their [NAME] (e.g. ITEM_TRAPCOMP_MENACINGSPIKE instead of "spike")?

Comments:
Items of type "tool" (85) also need subtypes.
The job list in readme.txt has a bunch of errors in it, since the list in DFHack's memory.xml is similarly incorrect - the list from Dwarf Therapist (located here) is much more correct.

[onart]

are you sure you can't specify material type ? i mean stone / wood is set on allow all on default but then again it get's treathen all the same and yes i've discovered that the list is incorrect and as far as i know all the combinations are possible although i haven't tried yet but thanks for the list will be working on the next part.

[devek]

It's a shame you can't specify specific materials for stone/wood jobs (e.g. in order to do "Make nether-cap Barrel" or "Construct bauxite Floodgate") - I know that it's possible to hack active jobs like that (i.e. once they're in the workshop)

Maybe someday in the future we can change it to add jobs to the workshop. It can be done, it is just a lot more complicated.

How exactly are the "item" and "source" tags (including the misspelled "soure" for clear glass portals) within <dfjob> used?

I'm not sure I understand the question. There is a map called itemMap, when I iterate through the items to populate it like so:

Spoiler (click to show/hide)

Code: [Select]

        itemCount[itemName][material] += quantity;
        itemCount[itemName][materialType] += quantity;
        itemCount[itemName]["all"] += quantity;

        if(!subtype.empty())
        {
            itemCount[subtype][material] += quantity;
            itemCount[subtype][materialType] += quantity;
            itemCount[subtype]["all"] += quantity;
        }

Once the items are counted, the jobs source and item count are calculated by going through each <item> and <source> tag and adding them to a total. FYI the creature type materials are broken, as they are for dfhack. I never bothered to fix them because so far there hasn't been a case where knowing the specific creature material type mattered (but it at least identifies the material as the right category.)

Is it possible to specify item subtypes by their ID rather than by their [NAME] (e.g. ITEM_TRAPCOMP_MENACINGSPIKE instead of "spike")?

It is, but why? Is there a conflict between subtypes and types? I can resolve it in a simpler manner if so.

Items of type "tool" (85) also need subtypes.

Thanks.

The job list in readme.txt has a bunch of errors in it, since the list in DFHack's memory.xml is similarly incorrect - the list from Dwarf Therapist (located here) is much more correct.

I don't even use dfhack's list lol. I have been basing my job types off the decompiled DF code, but I obviously can't release that with my program. I will put Therapist's list in the readme instead if it is more accurate.

Also, if you guys are adding jobs to your own.. mind sending me your google account names? You can modify the offical dfjobs.xml online at the project site without having to download or use any source revision software, it is really easy.

[profit]

I wonder how many decompile DF code and just dont mention it...

Because even I *might* have done it once or twice....

[wedrifid]

I will put Therapist's list in the readme instead if it is more accurate.

On a related note - if you have a dwarf doing the job you want to automate the hover text in therapist gives the code for you. Can save a little guessing.

[Halnoth]

I'd like a little help. My experiance with this stuff is limited. I tried to automate leather shoes, robes, hoods, and gloves but it crashed DF when I went to the manager screen. I don't think I am doing it right can anyone help me out?

This is what I have in the jobs list for foreman;

<dfjob name="leather hood" category="leatherworks" type="102" materialType="leather">
        <item type="hood" material="all" />
    </dfjob>
    <dfjob name="leather gloves" category="leatherworks" type="117" materialType="leather">
        <item type="glove" material="all" />
    </dfjob>
    <dfjob name="leather shoes" category="leatherworks" type="118" materialType="leather">
        <item type="shoe" material="all" />
    </dfjob>
    <dfjob name="leather robes" category="leatherworks" type="101" materialType="leather">
        <item type="robe" material="all" />
    </dfjob>

[devek]

all clothing has to have a subtype.

<dfjob name="leather hood" category="leatherworks" type="102" subtype="hood" materialType="leather">

[Halnoth]

Will you be so good as to tell me the other subtypes. While I awaited your response I tried that but I think I got the wrong subtypes. For instance I had helm instead of hood.

[devek]

Spoiler (click to show/hide)

Code: [Select]

armor -> 2
arrow -> 1
axe blade -> 0
ball -> 2
ballista arrow -> 0
battle axe -> 1
biscuits -> 0
blowdart -> 2
blowgun -> 9
bolt -> 0
boning knife -> 6
bow -> 8
bowl -> 2
braies -> 8
breastplate -> 0
buckler -> 1
cap -> 1
cape -> 8
carving fork -> 9
carving knife -> 5
cauldron -> 0
chausse -> 4
cloak -> 5
coat -> 3
corkscrew -> 1
crossbow -> 6
dagger -> 16
disc -> 3
dress -> 10
drum -> 3
face veil -> 6
flail -> 18
flute -> 0
gauntlet -> 0
glove -> 1
great axe -> 15
greaves -> 1
halberd -> 11
harp -> 2
head veil -> 5
headscarf -> 7
helm -> 0
high boot -> 1
hive -> 13
honeycomb -> 14
hood -> 2
jug -> 11
ladle -> 1
leggings -> 2
loincloth -> 3
long skirt -> 7
long sword -> 13
low boot -> 2
mace -> 5
mail shirt -> 1
mask -> 4
maul -> 14
meat cleaver -> 8
mini-forge -> 4
mitten -> 2
morningstar -> 19
mortar -> 3
nest box -> 10
pestle -> 4
piccolo -> 4
pick -> 7
pike -> 10
pot -> 12
puzzlebox -> 0
roast -> 2
robe -> 11
sandal -> 3
scimitar -> 20
scourge -> 17
shield -> 0
shirt -> 4
shoe -> 0
short skirt -> 6
short sword -> 3
skirt -> 5
slicing knife -> 7
sock -> 5
spear -> 4
spike -> 4
stew -> 1
thong -> 4
toga -> 7
toy axe -> 3
toy boat -> 1
toy hammer -> 2
training axe -> 21
training spear -> 23
training sword -> 22
trousers -> 0
trumpet -> 1
tunic -> 6
turban -> 3
two-handed sword -> 12
vest -> 9
war hammer -> 2
whip -> 0

[wedrifid]

Have a look at the other exe, the test one. You can look at the items that you have and figure out the part that refers to the item type.

[Quietust]

Will you be so good as to tell me the other subtypes. While I awaited your response I tried that but I think I got the wrong subtypes. For instance I had helm instead of hood.

This is one of the reasons why I was suggesting using item IDs rather than the singular form, considering the game's own raws use those IDs everywhere else. It would also make Foreman tool more compatible with mods that rename items without changing their IDs (e.g. translating them into another language).