Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Artanis00]

Look at this shit


That is the graph of code DF uses to figure out what an item is. That is more branches than all of dfhack put together, and it doesn't include the myriad of functions called from within that function..  it is just one function.

DF is chock full of this crap and I run into it wherever I go. I have no choice but to push ahead. Despite the fact this isn't my first rodeo, this is turning into the single most complicated piece of code I have untangled in my entire life.

Erm, wow. That looks like an amazingly complicated function... Two things, though: How did you generate that graph? What does a slightly less complicated function look like?

[devek]

IDA Pro, it will cost ya.

With a less complicated function, you should be able to make out some of the actual code and not just lots of lines

[Artanis00]

IDA Pro, it will cost ya.

With a less complicated function, you should be able to make out some of the actual code and not just lots of lines

I see. It's a feature of the disassembler. Don't do enough of that to warrant any outlay. Nifty graph, though if I guess if I ever need a tool to visualize my code paths plan A is "rewrite."

[devek]

Well if outlay is a problem you could check out clang. Clang is poised to replace all c/c++ compilers in the near feature and has static analysis built in.

X Code for the mac is the only IDE that supports it from within the IDE, but you can still do static analysis from the command line on other platforms.

[peterix]

So. I just looked at the Items module because I'm updating everything to use the new offset storage classes... and it really needs a rewrite. Consider the module's API deprecated.

[devek]

Well, I don't think anyone actually uses the API directly due to its memory leak.

1 question though.

Why doesn't it work on Linux?

Reading the code to get the get the type and material ids is correct and identical to how DF itself does it. The only other way to do it would be to find the exact offset of the id for each item class and switching for it. I'm assuming it has different code due to linux having a different c++ runtime, but I don't know due to the fact I have never reverse engineering any code on linux (never had a job where it came up).

EDIT: wow, I should have done this sooner. IDA's output on linux binaries is a lot more informative Switch statements are organized so much better... MSVC does some sneaky shit to optimize switches. I should have some code for you by next weekend you can build a proper item and material module with.

[Luewen82]

Been trying to use DF clear task on items that are accumulating all over the fortress and dwarfs wont claim,dump or retrieve items no matter what i do. Cleartask worked fine until recently that it has started to crash DF after 15 seconds of use. I wonder whats going on.

[Quietust]

Cleartask is only meant to be used immediately after reclaiming (i.e. before you unpause) - using it in an active fortress is asking for trouble, since it can easily disrupt all of your active tasks. I did some testing on a fortress with legitimately active tasks and it didn't seem to cause immediate problems (aside from some jobs cancelling due to "job item lost or destroyed"), though it's possible something else may be going on in your case. By any chance are you running the tool while your game is unpaused?

It's far more likely that the items your dwarves won't collect are owned by other dwarves who don't have bedrooms with sufficient storage space (either a cabinet or lots of floor space).

[Luewen82]

Cleartask is only meant to be used immediately after reclaiming (i.e. before you unpause) - using it in an active fortress is asking for trouble, since it can easily disrupt all of your active tasks. I did some testing on a fortress with legitimately active tasks and it didn't seem to cause immediate problems (aside from some jobs cancelling due to "job item lost or destroyed"), though it's possible something else may be going on in your case. By any chance are you running the tool while your game is unpaused?

It's far more likely that the items your dwarves won't collect are owned by other dwarves who don't have bedrooms with sufficient storage space (either a cabinet or lots of floor space).

Hmmm. the items loitering around are mostly from migrants that arrive and i change their jobs. And suddenly they drop half of their stuff and leave it there. Have to try assigning them room and see if that works.  But some times there seem to be whole set of wardrobe dropped from dwarf for no visible reason in middle of their running around.

[calrogman]

I'm just curious here, but could DFHack be used to modify the contents of the embark rectangle offsets (horribly worded, I know) and replicate the functionality of Nano Fortress?

[peterix]

I'm just curious here, but could DFHack be used to modify the contents of the embark rectangle offsets (horribly worded, I know) and replicate the functionality of Nano Fortress?

Interesting idea. I'll have to try that

[Truean]

Hi,

The link on your README page is broken, and I just thought that you should know.

Read the README

Takes me here:

http://github.com/peterix/dfhack/blob/master/README

Thanks again for making this.

[mLegion]

I'm just curious here, but could DFHack be used to modify the contents of the embark rectangle offsets (horribly worded, I know) and replicate the functionality of Nano Fortress?

Should include 'embark anywhere' functionality as well in that case.

EDIT: How difficult would it be to implement a hotkey/keypress hook so that we can make DFHack based utilities that run in the background and do something when a person presses a key in DF?

[lolghurt]

Is there some issue with spawning liquids above a certain level or is it impossible to place liquids above the max natural elevation to stop people binding obsidian to the top pf the sky?

[peterix]

Is there some issue with spawning liquids above a certain level or is it impossible to place liquids above the max natural elevation to stop people binding obsidian to the top pf the sky?

The map simply doesn't exist there to keep the memory use low. No simple way around that I'm afraid.