Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[rickvoid]

Let's compile a list of typo's and missing tags that we have found in the raws. Once we've gone through all the text files I'll put the full list in the bug reports section for Toady.

Here's what I've got so far:

Spoiler (click to show/hide)

b_detail_plan_default
- [BP_RELATION:BY_TOKEN:R_EYELID:CLEANS:L_EYE:100]
(Should be [BP_RELATION:BY_TOKEN:R_EYELID:CLEANS:R_EYE:100])
- [BP_RELATION:BY_TOKEN:L_EYELID:AROUND:R_EYE:50]
(Should be [BP_RELATION:BY_TOKEN:L_EYELID:AROUND:L_EYE:50])
- Under [BODY_DETAIL_PLAN:BODY_HAIR_TISSUE_LAYERS], add [BP_LAYERS:BY_CATEGORY:WING:ARG1:1] since this plan is also used to add feathers.

body_default
- None found.

body_rcp
- None found.

building_custom
- Soap Maker is the only thing in there, but no typos found.

c_variation_default
- None found.

creature_amphibians
- None found.

creature_annelids
- None found.

creature_birds
- None found.

creature_domestic
- None found.

creature_equipment
- You used a generic tissue named WOOD, which is probably why we're getting the wagon meat bugs.

creature_faniciful
-Not complete, and not used. So, not worried.

creature_insects
- None found

creature_large_mountain
- [CREATURE:GOAT_MOUNTAIN] has token [CHILD:1][GENERAL_CHILD_NAME:horse foal:horse foals]. Horse foals should probably be changed to mountain goat kid(s).

creature_standard
- [CREATURE:UNICORN] has token [CHILD:1][GENERAL_CHILD_NAME:elk fawn:elk fawns].
Elk Fawn should be probably be changed to something else. Unicorn foals?
- [CREATURE:GIANT] has token [CASTE_NAME:giant:giants:giant] under [CASTE:FEMALE], and [CASTE_NAME:giantess:giantesses:giantess] under [CASTE:MALE]. Should be swapped.

creature_subterranean
- Giant cave spider is missing [ATTACK_FLAG_EDGE] on it's bite attack, making it more difficult to actually inject the poison.
- [CREATURE:BIRD_SWALLOW_CAVE] has tag [GENERAL_CHILD_NAME:red-winged blackbird hatchling:red-winged blackbird hatchlings]. Should be changed to cave swallow hatchling(s).

creature_large_temperate
- Under [CREATURE:ALLIGATOR], [TLCM_NOUN:hair:SINGULAR] should have "hair" replaced with "eyes" and "SINGULAR" with "PLURAL".

reaction_other
-[PRODUCT:100:1:GLOB:NONE:GET_MATERIAL_FROM_REAGENT:B:SOAP_MAT] (Should be [PRODUCT:100:1:BAR:NONE:GET_MATERIAL_FROM_REAGENT:B:SOAP_MAT])

inorganic_stone_mineral
- [INORGANIC:HORN_SILVER]
[USE_MATERIAL_TEMPLATE:METAL_TEMPLATE]
[STATE_NAME_ADJ:ALL_SOLID:horn silver][DISPLAY_COLOR:7:7:1][TILE:156]
[ENVIRONMENT_SPEC:SILVER:CLUSTER_SMALL:100]
(Should be
[INORGANIC:HORN_SILVER]
[USE_MATERIAL_TEMPLATE:METAL_TEMPLATE]
[STATE_NAME_ADJ:ALL_SOLID:horn silver][DISPLAY_COLOR:7:7:1][TILE:156]
[ENVIRONMENT_SPEC:NATIVE_SILVER:CLUSTER_SMALL:100])

material_template_default
- Add [EDIBLE_COOKED] everywhere there is [MEAT].

plant_standard
- Add [EDIBLE_COOKED] to [PLANT:BUSH_QUARRY]

entity_default
- Under dwarves, tag SOLDIER_COLOR] is missing the first bracket. Not sure if that's intentional or not.

File name is listed first, followed by what was found. Please try to follow the same pattern when you put ones you find up, that way I can copy-pasta it directly in. On the ones marked "- None found" please feel free to give those another look over as well. I have no doubt I could have missed something. The new RAWs are huge!

Anyway, this will make it easier for Toady to fix this stuff. Let's get to it!

EDIT: Now in spoiler tags instead of code. The scrolling was annoying me.

Thanks go to:
- shadow_slicer
- Trorbes
- Sphalerite
- Knight Otu
- Iban
- Strange guy

This is turning out really good. Keep up the good work guys!

[RandomNumberGenerator]

Huh. So wagons are composed of Wood Meat? Good to know...

[shadow_slicer]

Make bars of soap, not globs
raw/objects/reaction_other.txt -- change glob to bar:

[PRODUCT:100:1:GLOBBAR:NONE:GET_MATERIAL_FROM_REAGENT:B:SOAP_MAT]


Meat should be cookable
raw/objects/material_template_default.txt (maybe not necessary if code is later changed so that meat implies edible cooked):
Add [EDIBLE_COOKED] everywhere there is [MEAT].


Fix horn silver entry
inorganic_stone_mineral.txt:
[INORGANIC:HORN_SILVER]
[USE_MATERIAL_TEMPLATE:METAL_TEMPLATE]
[STATE_NAME_ADJ:ALL_SOLID:horn silver][DISPLAY_COLOR:7:7:1][TILE:156]
[ENVIRONMENT_SPEC:NATIVE_SILVER:CLUSTER_SMALL:100]


Make Quarry Bushes edible if processed and cooked:
[USE_MATERIAL_TEMPLATE:LEAF:LEAF_TEMPLATE]
[MATERIAL_VALUE:5]
[LEAVES:quarry bush leaf:quarry bush leaves:7:0:0:0:0:1:6:LOCAL_PLANT_MAT:LEAF][EDIBLE_COOKED]

Also, in b_body_plan_default:
[BP_RELATION:BY_TOKEN:R_EYELID:AROUND:L_EYER_EYE:50]

[Trorbes]

Similar to the b_detail_plan_default typo, wouldn't [BP_RELATION:BY_TOKEN:L_EYELID:AROUND:R_EYE:50] also be incorrect?  Unless I'm reading it wrong it's saying that both eyelids are near the RIGHT eye, no?

[rickvoid]

Similar to the b_detail_plan_default typo, wouldn't [BP_RELATION:BY_TOKEN:L_EYELID:AROUND:R_EYE:50] also be incorrect?  Unless I'm reading it wrong it's saying that both eyelids are near the RIGHT eye, no?

Yep. Is wrong.

Make bars of soap, not globs
raw/objects/reaction_other.txt -- change glob to bar:

[PRODUCT:100:1:GLOBBAR:NONE:GET_MATERIAL_FROM_REAGENT:B:SOAP_MAT]


Meat should be cookable
raw/objects/material_template_default.txt (maybe not necessary if code is later changed so that meat implies edible cooked):
Add [EDIBLE_COOKED] everywhere there is [MEAT].


Fix horn silver entry
inorganic_stone_mineral.txt:
[INORGANIC:HORN_SILVER]
[USE_MATERIAL_TEMPLATE:METAL_TEMPLATE]
[STATE_NAME_ADJ:ALL_SOLID:horn silver][DISPLAY_COLOR:7:7:1][TILE:156]
[ENVIRONMENT_SPEC:NATIVE_SILVER:CLUSTER_SMALL:100]


Also, in b_body_plan_default:
[BP_RELATION:BY_TOKEN:R_EYELID:AROUND:L_EYER_EYE:50]

Will add those as well.

But:

Make Quarry Bushes edible if processed and cooked:
[USE_MATERIAL_TEMPLATE:LEAF:LEAF_TEMPLATE]
[MATERIAL_VALUE:5]
[LEAVES:quarry bush leaf:quarry bush leaves:7:0:0:0:0:1:6:LOCAL_PLANT_MAT:LEAF][EDIBLE_COOKED]

Where was this one at?

[Sphalerite]

In creature_standard:

Under then entry for [CREATURE:UNICORN]

we have:

   [CHILD:1][GENERAL_CHILD_NAME:elk fawn:elk fawns]

That's probably not intended.

[shadow_slicer]

Make Quarry Bushes edible if processed and cooked:
[USE_MATERIAL_TEMPLATE:LEAF:LEAF_TEMPLATE]
[MATERIAL_VALUE:5]
[LEAVES:quarry bush leaf:quarry bush leaves:7:0:0:0:0:1:6:LOCAL_PLANT_MAT:LEAF][EDIBLE_COOKED]

Where was this one at?

raw/objects/plant_standard.txt

[PLANT:BUSH_QUARRY]
        [NAME:quarry bush][NAME_PLURAL:quarry bushes][ADJ:quarry bush]
        [USE_MATERIAL_TEMPLATE:STRUCTURAL:STRUCTURAL_PLANT_TEMPLATE]
                [MATERIAL_VALUE:2]
                [EDIBLE_VERMIN]
        [BASIC_MAT:LOCAL_PLANT_MAT:STRUCTURAL]
        [PICKED_TILE:5][PICKED_COLOR:7:0:0]
        [GROWDUR:500][VALUE:2]
        [USE_MATERIAL_TEMPLATE:LEAF:LEAF_TEMPLATE]
                [MATERIAL_VALUE:5]
        [LEAVES:quarry bush leaf:quarry bush leaves:7:0:0:0:0:1:6:LOCAL_PLANT_MAT:LEAF]
        [EDIBLE_COOKED]
        [USE_MATERIAL_TEMPLATE:SEED:SEED_TEMPLATE]
                [MATERIAL_VALUE:1]
        [SEED:rock nut:rock nuts:7:0:1:LOCAL_PLANT_MAT:SEED]
        [SPRING][SUMMER][AUTUMN]
        [FREQUENCY:100]
        [CLUSTERSIZE:5]
        [PREFSTRING:gray leaves]
        [WET][DRY]
        [BIOME:SUBTERRANEAN_WATER]
        [UNDERGROUND_DEPTH:1:3]
        [SHRUB_TILE:58]
        [DEAD_SHRUB_TILE:58]
        [SHRUB_COLOR:7:0:0]
        [DEAD_SHRUB_COLOR:0:0:1]


I haven't quite finished testing it, but they do show up on the kitchen stock screen as cookable, so it should work.

Also, It looks I was wrong about:
[BP_RELATION:BY_TOKEN:R_EYELID:AROUND:L_EYER_EYE:50]
This line was actually correct in the original raws. It was the other line that Trorbes pointed out that was incorrect.

[rickvoid]

In creature_standard:

Under then entry for [CREATURE:UNICORN]

we have:

   [CHILD:1][GENERAL_CHILD_NAME:elk fawn:elk fawns]

That's probably not intended.

Will add.

Make Quarry Bushes edible if processed and cooked:
[USE_MATERIAL_TEMPLATE:LEAF:LEAF_TEMPLATE]
[MATERIAL_VALUE:5]
[LEAVES:quarry bush leaf:quarry bush leaves:7:0:0:0:0:1:6:LOCAL_PLANT_MAT:LEAF][EDIBLE_COOKED]

Where was this one at?

raw/objects/plant_standard.txt

[PLANT:BUSH_QUARRY]
        [NAME:quarry bush][NAME_PLURAL:quarry bushes][ADJ:quarry bush]
        [USE_MATERIAL_TEMPLATE:STRUCTURAL:STRUCTURAL_PLANT_TEMPLATE]
                [MATERIAL_VALUE:2]
                [EDIBLE_VERMIN]
        [BASIC_MAT:LOCAL_PLANT_MAT:STRUCTURAL]
        [PICKED_TILE:5][PICKED_COLOR:7:0:0]
        [GROWDUR:500][VALUE:2]
        [USE_MATERIAL_TEMPLATE:LEAF:LEAF_TEMPLATE]
                [MATERIAL_VALUE:5]
        [LEAVES:quarry bush leaf:quarry bush leaves:7:0:0:0:0:1:6:LOCAL_PLANT_MAT:LEAF]
        [EDIBLE_COOKED]
        [USE_MATERIAL_TEMPLATE:SEED:SEED_TEMPLATE]
                [MATERIAL_VALUE:1]
        [SEED:rock nut:rock nuts:7:0:1:LOCAL_PLANT_MAT:SEED]
        [SPRING][SUMMER][AUTUMN]
        [FREQUENCY:100]
        [CLUSTERSIZE:5]
        [PREFSTRING:gray leaves]
        [WET][DRY]
        [BIOME:SUBTERRANEAN_WATER]
        [UNDERGROUND_DEPTH:1:3]
        [SHRUB_TILE:58]
        [DEAD_SHRUB_TILE:58]
        [SHRUB_COLOR:7:0:0]
        [DEAD_SHRUB_COLOR:0:0:1]


I haven't quite finished testing it, but they do show up on the kitchen stock screen as cookable, so it should work.

Also, It looks I was wrong about:
[BP_RELATION:BY_TOKEN:R_EYELID:AROUND:L_EYER_EYE:50]
This line was actually correct in the original raws. It was the other line that Trorbes pointed out that was incorrect.

Okay, I'll add the quarry bush thing.

As for the eyelid thing, I'll remove yours. And I think I should probably be checking these before I add them... Oops.

[Knight Otu]

In creature_subterranean:
The attack of the giant cave spider looks like this:

Code: [Select]

[ATTACK:STING:BODYPART:BY_CATEGORY:MOUTH]
[ATTACK_SKILL:BITE]
[ATTACK_VERB:bite:bites]
[ATTACK_CONTACT_PERC:100]
[ATTACK_PRIORITY:MAIN]
[SPECIALATTACK_INJECT_EXTRACT:LOCAL_CREATURE_MAT:POISON:LIQUID:100:100]
[ATTACK_FLAG_CANLATCH]
The attack lacks the [ATTACK_FLAG_EDGE], without which the spider has a hard time actually injecting its poison. I don't think that's intentional.

[rickvoid]

In creature_subterranean:
The attack of the giant cave spider looks like this:

Code: [Select]

[ATTACK:STING:BODYPART:BY_CATEGORY:MOUTH]
[ATTACK_SKILL:BITE]
[ATTACK_VERB:bite:bites]
[ATTACK_CONTACT_PERC:100]
[ATTACK_PRIORITY:MAIN]
[SPECIALATTACK_INJECT_EXTRACT:LOCAL_CREATURE_MAT:POISON:LIQUID:100:100]
[ATTACK_FLAG_CANLATCH]
The attack lacks the [ATTACK_FLAG_EDGE], without which the spider has a hard time actually injecting its poison. I don't think that's intentional.

Agreed. Adding.

[Knight Otu]

Another one in b_detail_plan_default:

[BODY_DETAIL_PLAN:BODY_HAIR_TISSUE_LAYERS] gives the tissue layer in question to all imaginable body parts, except wings. Since this detail plan is also used for bird feathers, wings should be added as such:

   [BP_LAYERS:BY_CATEGORY:WING:ARG1:1]

[Sphalerite]

Similar to the unicorns, in creature_large_mountain.txt we have

[CREATURE:GOAT_MOUNTAIN]
   [CHILD:1][GENERAL_CHILD_NAME:horse foal:horse foals]

[rickvoid]

Another one in b_detail_plan_default:

[BODY_DETAIL_PLAN:BODY_HAIR_TISSUE_LAYERS] gives the tissue layer in question to all imaginable body parts, except wings. Since this detail plan is also used for bird feathers, wings should be added as such:

   [BP_LAYERS:BY_CATEGORY:WING:ARG1:1]

Okay. Will add and thanks for the explanation.

Similar to the unicorns, in creature_large_mountain.txt we have

[CREATURE:GOAT_MOUNTAIN]
   [CHILD:1][GENERAL_CHILD_NAME:horse foal:horse foals]

Adding. Young goats are called kids, right? We should probably suggest a name for the young unicorn's as well. Unicorn foals?

[Iban]

Lets not forget how the Giantess is the male giant.

[rickvoid]

Lets not forget how the Giantess is the male giant.

Yeah, I'll go in and find the appropriate stuff.

EDIT: Found it. Added to the top. Thanks Iban.

Okay, so it doesn't look like I'm being lazy and letting you guys have all the fun, I'm trying to figure this one out.

In creature_large_temperate, [CREATURE:ALLIGATOR] has tags [REMOVE_MATERIAL:SKIN][REMOVE_MATERIAL:LEATHER][REMOVE_MATERIAL:HAIR][USE_MATERIAL_TEMPLATE:SCALE:SCALE_TEMPLATE] under [BODY_DETAIL_PLAN:STANDARD_MATERIALS]. He also has [REMOVE_TISSUE:SKIN][REMOVE_TISSUE:HAIR][USE_TISSUE_TEMPLATE:SCALE:SCALE_TEMPLATE] under [BODY_DETAIL_PLAN:STANDARD_TISSUES]. However, if you look at his description, he has hair. AH HA! I figured it out, all on my own. I'm so proud of myself. Anyway, the alligator has these tags:
[SET_TL_GROUP:BY_CATEGORY:EYE:EYE]
         [TL_COLOR_MODIFIER:BLACK:1]
            [TLCM_NOUN:hair:SINGULAR]
Where it says "hair" it should say eyes. That's why it looks like gators have hair.  Adding.