Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Valathil]

Getting the Strings to work was a pain in the ass. Hope you guys enjoy it.

Going off topic here, could you explain the new String structure layout and any odd "gotchas" for me?  Even hints would help.  Also, I think I read that Vector layout has changed, got anything about that?

The 4 Bytes at the beginning are gone. Thats all there is to it. But walk into this without any knowledge about the internal workings of df and try to figure that out by yourself. Was quite challenging ^^. Vector format doesn't seem to be changed. At least the old code seems to work. As an aside note. Peterix is already aware of the changes and implemented a fix in dfhack. Don't know when he will release an update.

[magistrate101]

Peterix is already aware of the changes and implemented a fix in dfhack.

When did this happen? as I REALLY NEED an update for DFhack and RuneSmith 

[alexxeno]

In the worlds of.. Well I'm sure no one has ever said this before. Than'ka ya dude.

[magistrate101]

i need DFhack to work, or else my life shall shrivel, because since DFhack wont work, runesmith wont either

[Gearheart]

dfhack is nice, it saves several seasons of bucket-brigading when embarking on a dry area with no brook.

And prospector is one of my mandatory tests upon embark.

[magistrate101]

prospector is one of my mandatory tests upon embark.

and i've never used the DFliquid thingy yet

[0x517A5D]

The 4 Bytes at the beginning are gone. Thats all there is to it. But walk into this without any knowledge about the internal workings of df and try to figure that out by yourself. Was quite challenging ^^. Vector format doesn't seem to be changed. At least the old code seems to work. As an aside note. Peterix is already aware of the changes and implemented a fix in dfhack. Don't know when he will release an update.

Okay, great.

More offtopic, I have never liked the MSVC implementation of String.  The idea with the builtin 16 character buffer is good, 'cause so many strings are small, but they did it wrong.

It should be something like:

Code: [Select]

TCHAR [16] smallbuffer;
TCHAR * bufferptr;
unsigned int allocated;
unsigned int used;
otherstuff;
bufferptr points to smallbuffer, to malloc'ed memory, or is NULL.  There are no comparisons with sizeof(smallbuffer) to figure out whether to use smallbuffer or bufferptr's external memory, you just:

Code: [Select]

mov EAX, address of string structure
mov EAX, [EAX+offset bufferptr]Only one register used, no branching, no mispredictions, no unnecessary cache-misses, easy prefetch if you feel the need.

And to destruct it, you just

Code: [Select]

mov EAX, address of string structure
cmp EAX, [EAX+offset bufferptr]
je @@skipfree
push [EAX+offset bufferptr]
call free()
@@skipfree:
{deallocate String structure if necessary}(Note that this potentially calls free() with a NULL; technically an error but benign.)

So maybe they changed to this system?

[mLegion]

When did this happen? as I REALLY NEED an update for DFhack and RuneSmith 

It's been in the git repository a while now, haven't tried building it yet though.

[devek]

bufferptr points to smallbuffer, to malloc'ed memory, or is NULL.  There are no comparisons with sizeof(smallbuffer) to figure out whether to use smallbuffer or bufferptr's external memory, you just:

To be fair, it doesn't compare with the size of the buffer to figure out what do do. The last 4 bytes at the end of the string define the mode(F=local 1F=external), so you can use external memory and a 4 byte string.

I know because when I write strings to a process I always use 1f mode and a string table I manage myself in the process' memory.

[magistrate101]

When did this happen? as I REALLY NEED an update for DFhack and RuneSmith 

It's been in the git repository a while now, haven't tried building it yet though.

i'm afraid i do not know how to get it to work '-' if i try to build it it pops up with 50+ errors :| and when i resolve all of the errors for the "missing files" it spits out shit like "cannot identify operating system" or something like that ._.

edit: if you compile it for me, and send it to me, i will put your name in my sig

[James.Denholm]

Applause. Not scattered, but roaring, rises from the gallery, flows over the stage. On this day, you, and those who aided you during this perilous task, have become legends, gods.

Fantastic.

[magistrate101]

Applause. Not scattered, but roaring, rises from the gallery, flows over the stage. On this day, you, and those who aided you during this perilous task, have become legends, gods.

Fantastic.

i would take that, and multiply it by the amount of win in this topic ^.^

[kelewan]

Hi,

thanks for the great work. 

In my new fortress some Migrands came with a skill unknown to DT ("Novice UNKOWN").
In DF this skill is known as "Military Tactics". It seams to be new in 31.13 as it is not listed in the wiki jet.

[Gearheart]

It currently has no use, so it's best to just ignore it for now.

[Maulrus]

Thank you so much, dev team. I can finally start a new .13 fortress! :DDD

One suggestion: perhaps the new developers might fork this into its own topic? This one is very long, and a new topic could keep its title updated, unlike this one. It could link to this topic of course, to give chmod all the credit he deserves, and if he ever decides to resume development, it could just move back to this one.