Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Nabobalis]

0.5.0 is up. I'll update the thread later. But I gotta run!

Dwarves still don't work with jobs enabled by DT.   

Actually on review, your right. I can't get any dwarves to change job in game.

[peterix]

Dwarves still don't work with jobs enabled by DT.   

I think its a bug with DF (i'm sure I read it somewhere), sometimes the job wont be activated even if you activate it. I think either a reload of the save or turn it off and then turn it back on.

Manual job managing seems to be okay at any time.

It's happened to me. I've had to toggle mining on dwarves that embarked with the skill, migrants that came with it, and once for a guy I switched the labor on for. It seems like the Pickup Equipment task doesn't get assigned reliably.

This is because the pickup equipment thing depends on an extra bit to be set.

chmod:
*(_DWORD *)(creature + 0x21C) |= 1;// pickup equipment bit

[chmod]

*(_DWORD *)(creature + 0x21C) |= 1;// pickup equipment bit

Thanks Peterix! When should it be set though? When first putting on a labor that requires a tool, or always when setting a labor with a tool?

[peterix]

*(_DWORD *)(creature + 0x21C) |= 1;// pickup equipment bit

Thanks Peterix! When should it be set though? When first putting on a labor that requires a tool, or always when setting a labor with a tool?

Always. DF sets it for Woodcutting, Mining and Hunting whenever you enable or disable them.
I'm still poking through the code... it seems to be doing much more after that.
It's manipulating the creature's current job (object pointed to by DWORD creature + 0x390) in some really weird ways.

Here's the code that's called:

Spoiler (click to show/hide)

Code: [Select]

int __usercall sub_918CC0<eax>(int creature<edi>)
{
  int creature_job; // esi@1
  signed __int16 v2; // bx@6
  int v3; // esi@6
  __int16 v5; // [sp+Ch] [bp-70h]@1
  unsigned int v6; // [sp+6Ch] [bp-10h]@1
  int v7; // [sp+78h] [bp-4h]@12

  v6 = (unsigned int)&v5 ^ dword_AE71F4;
  creature_job = *(_DWORD *)(creature + 0x390);
  if ( creature_job )
  {
    if ( *(_WORD *)(creature_job + 8) == 53 )
    {
      if ( (*(_DWORD *)(creature_job + 0x6C) - *(_DWORD *)(creature_job + 0x68)) & 0xFFFFFFFC )
      {
        if ( !((*(_DWORD *)(creature_job + 0x6C) - *(_DWORD *)(creature_job + 0x68)) >> 2) )
          _invalid_parameter_noinfo(0);
        v3 = ***(_DWORD ***)(creature_job + 0x68);
        v2 = -1;
        if ( *(_BYTE *)(creature + 0x770) )
          v2 = 0;
        if ( *(_BYTE *)(creature + 0x77A) )
          v2 = 38;
        if ( (unsigned __int16)(**(int (__thiscall ***)(_DWORD))v3)(v3) == 24 )
        {
          if ( sub_5AE4E0(v3) != v2 )
          {
            sub_44F060();
            v7 = 0;
            v5 = 68;
            sub_9093B0(creature, 0, 0, 0, (int)&v5);
            sub_4703C0();
          }
        }
      }
    }
  }
  return sub_9FD3DA(*(_DWORD *)&v5);
}

So... it might be a good idea to avoid doing things to this when the current job is already 53 (pickup equipment). Show a little messagebox that tells the user to wait for that to complete. Manipulating vectors/messing up things doesn't sound like a good idea. Also, function pointers...

[chmod]

*(_DWORD *)(creature + 0x21C) |= 1;// pickup equipment bit

Thanks Peterix! When should it be set though? When first putting on a labor that requires a tool, or always when setting a labor with a tool?

Always. DF sets it for Woodcutting, Mining and Hunting whenever you enable or disable them.

Nice work, I'll put that in.

[Asatruer]

Excellent updates, chmod!
Is there a way to separate out the old 40d# version Custom Professions so that I do not see them when connected to the newest version, and vis versa?  If not, is it feature that could be added, maybe something like storing the data in a file in the therapist folder.  I think that would also fix the other problem I have had in the past where backing up the folder and/or moving it to a new computer doesn't carry over the custom professions.

[Trukkle]

Absolutley wonderful tool, chmod, thankyou.
Any chance of adding a method to the script editor that looks at what migrant wave a dwarf came in on? I know sorting by wave can be hit-or-miss, but being able to group by profession AND restrict the view to the latest immigrant wave would make wrangling those lazy retards even easier.

Are there any plans in the future to allow the scripting system to set/un-set labors?

[gtmattz]

Another dip-o-the beard into me ale in honor of Chmod.

Good work!
 

[Omniarch]

Finally I can play properly!  I found a bug though, I don't know if there's a proper place to report it.  The leatherworking skill is reporting the skill value for tanning, not leatherworking.

[Malicus]

Since the new version of DT doesn't seem to be backwards compatible with DF 40d, maybe you should add a note on the top level post and/or the project page that one should get an earlier version of DT for DF 40d?  (Assuming you aren't planning on making it backwards compatible, that is.)

Edit: I tried to do the process here for finding the new offsets with DT 0.5.0, but after getting to step 6, I get "Unable to talk to Dwarf Fortress" "Dwarf Fortress has either stopped running, or you unloaded your game.  Please re-connect when a fort is loaded."  The scan memory button is NOT enabled.  I modified the files on 0.4.3 instead and it does the same, but the scan button IS enabled, so I'm trying to find things with 0.4.3 now.

[lordkrike]

chmod:

The newest version of DF (31.03) doesn't seem to want to play nice with the checksum updating method you gave out earlier.  I added the checksum and added an ini file for the .03 version, and it refuses to connect at all, telling me that either DF has stopped running or I unloaded the game.

Just a heads up.  Sorry, I'm sure it's not fun updating the checksum every time Toady puts out a new release.

Thanks for all your work!

Edit: Ninja'd!

[Shiv]

I tried the same method with the same results.

[profit]

The new version if I am understanding toady correctly uses some of the 40d# updates just they are not mentioned in the actual release...

"I also did some preliminary merge code yesterday. There are a few more things to check, but it looks like that should proceed without any weird surprises. "

Perhaps it moved memory addresses around.

[chmod]

Excellent updates, chmod!
Is there a way to separate out the old 40d# version Custom Professions so that I do not see them when connected to the newest version, and vis versa?  If not, is it feature that could be added, maybe something like storing the data in a file in the therapist folder.  I think that would also fix the other problem I have had in the past where backing up the folder and/or moving it to a new computer doesn't carry over the custom professions.

There is not currently a way to do that. You may be right that system-wide settings may not be the way to go. They do present problems as the program quickly outgrows its old features. And Your custom profs from 2010 should not have stuff like Suturing if you plan to use them on a 40d series fort.

I will consider saving prefs locally in the future.

Absolutley wonderful tool, chmod, thankyou.
Any chance of adding a method to the script editor that looks at what migrant wave a dwarf came in on? I know sorting by wave can be hit-or-miss, but being able to group by profession AND restrict the view to the latest immigrant wave would make wrangling those lazy retards even easier.

Are there any plans in the future to allow the scripting system to set/un-set labors?

Please go here and log a feature request ticket (http://code.google.com/p/dwarftherapist/issues/list). I quickly lose track of feature requests on the forums.

Finally I can play properly!  I found a bug though, I don't know if there's a proper place to report it.  The leatherworking skill is reporting the skill value for tanning, not leatherworking.

This has been fixed, but not released yet.

The 7 step process doesn't work when using 0.5.0

I screwed up and disabled it on bad connections. Use 0.4.3 if you want to find stuff yourself.

In the meantime, I will hunt down the right offsets for 0.31.03.

[Malicus]

Update...  I think I found the vectors using DT 0.4.3, but when using the vectors it found, DT (both 0.4.3 and 0.5.0) hangs for a while (never even appearing in the taskbar), followed by giving a runtime error (saying that the application has requested the Runtime to terminate it in an unusual way) when starting when 31.03 is open.

This is what I found when searching with 0.4.3:

Spoiler (click to show/hide)

creature_vector = 0x0139fd44 (uncorrected:0x0166fd74)
creature_vector = 0x0166fcf8 (uncorrected:0x0166fcfc)
Dwarf Race = 0x006a6514 (uncorrected:0x01471fbc)
language_vector = 0x008e5580 (uncorrected:0x016b1028)
word_table = 0x00000058
translation_vector = 0x008e55b0 (uncorrected:0x016b1058)

This is what I'm using:

Spoiler (click to show/hide)

[info]
checksum                = 0x4bc3c470
version_name            = v0.31.03

[addresses]
translation_vector      = 0x016b1058
language_vector         = 0x016b1028
creature_vector         = 0x0166fcfc
dwarf_race_index        = 0x01471fbc
(Nothing below is changed from the .02 file)

This is the run.log from trying to run DT 0.5.0 with these changes:

Spoiler (click to show/hide)

2010-Apr-12 21:50:27.406 INFO   Log Opened Successfully
2010-Apr-12 21:50:27.406 INFO   Dwarf Therapist "0.5.0" starting normally.
2010-Apr-12 21:50:27.406 INFO   Minimum log level set to "DEBUG"
2010-Apr-12 21:50:27.468 INFO   Loaded 5 views from disk
2010-Apr-12 21:50:27.484 DEBUG   "redrew views in 16ms" [src\viewmanager.cpp:162]
2010-Apr-12 21:50:27.500 DEBUG   setting up connections for MainWindow [src\mainwindow.cpp:113]
2010-Apr-12 21:50:27.500 DEBUG   group_by now set to 1 [src\models\dwarfmodel.cpp:389]
2010-Apr-12 21:50:27.500 DEBUG   group_by now set to 1 [src\models\dwarfmodel.cpp:389]
2010-Apr-12 21:50:27.500 DEBUG   beginning to read settings [src\dwarftherapist.cpp:108]
2010-Apr-12 21:50:27.500 DEBUG   finished reading settings [src\dwarftherapist.cpp:154]
2010-Apr-12 21:50:27.500 DEBUG   attempting connection to running DF game [src\mainwindow.cpp:221]
2010-Apr-12 21:50:27.500 DEBUG   attempting to find running copy of DF by window handle [src\dfinstancewindows.cpp:209]
2010-Apr-12 21:50:27.500 DEBUG   found copy with HWND:  0xf039a [src\dfinstancewindows.cpp:225]
2010-Apr-12 21:50:27.500 DEBUG   PID of process is:  5160 [src\dfinstancewindows.cpp:232]
2010-Apr-12 21:50:27.500 DEBUG   working set size:  382.512 MB [src\dfinstancewindows.cpp:246]
2010-Apr-12 21:50:27.500 DEBUG   PEB is at:  0x7ffdc000 [src\dfinstancewindows.cpp:250]
2010-Apr-12 21:50:27.500 DEBUG   read 12 bytes BASE ADDR is at:  0x400000 [src\dfinstancewindows.cpp:263]
2010-Apr-12 21:50:27.500 DEBUG   DF's checksum is: 4bc3c470 [src\dfinstancewindows.cpp:275]
2010-Apr-12 21:50:27.500 DEBUG   Attempting to contruct MemoryLayout for  4bc3c470 [src\memorylayout.cpp:11]
2010-Apr-12 21:50:27.515 DEBUG   memory layout for "v0.31.03" loaded [src\dfinstancewindows.cpp:281]
2010-Apr-12 21:50:27.515 DEBUG   memory correction  0 [src\dfinstancewindows.cpp:304]
2010-Apr-12 21:50:27.515 DEBUG   ENUMERATING MEMORY SEGMENTS FROM 0 TO 18283000 [src\dfinstancewindows.cpp:310]
2010-Apr-12 21:50:27.531 DEBUG   MEMORY SEGMENT SUMMARY: accepted 328 rejected 147 total 475 [src\dfinstancewindows.cpp:355]
2010-Apr-12 21:50:27.531 DEBUG   Creating new Scanner for future use [src\mainwindow.cpp:241]
2010-Apr-12 21:50:27.531 DEBUG   Connection to DF version "v0.31.03" established. [src\mainwindow.cpp:243]
2010-Apr-12 21:50:27.531 DEBUG   Loading language translation tables [src\dwarftherapist.cpp:304]
2010-Apr-12 21:50:27.531 DEBUG   Loading generic strings from 16b1028 [src\dwarftherapist.cpp:317]
2010-Apr-12 21:50:27.531 DEBUG   generic words 2107 [src\dwarftherapist.cpp:319]
2010-Apr-12 21:50:27.546 DEBUG   FOUND LANG ENTRY 2ac31b0 "DWARF" [src\dwarftherapist.cpp:330]
2010-Apr-12 21:50:27.546 DEBUG   FOUND LANG ENTRY 61c1920 "ELF" [src\dwarftherapist.cpp:330]
2010-Apr-12 21:50:27.546 DEBUG   FOUND LANG ENTRY 61efa70 "GOBLIN" [src\dwarftherapist.cpp:330]
2010-Apr-12 21:50:27.546 DEBUG   FOUND LANG ENTRY 621da20 "HUMAN" [src\dwarftherapist.cpp:330]
2010-Apr-12 21:50:27.546 DEBUG   Loading dwarf strings from 2ac3204 [src\dwarftherapist.cpp:335]
2010-Apr-12 21:50:27.546 DEBUG   dwarf words 2107 [src\dwarftherapist.cpp:337]
2010-Apr-12 21:51:29.609 INFO   RUNNING VERSION         : "0.5.0"
2010-Apr-12 21:51:29.609 INFO   LATEST AVAILABLE VERSION: "0.5.0"

Did I do something horribly bad?  It seems odd that it'd crash from being given the wrong values, though.