Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Earthquake Damage]

Let it ring from hill to dale that the current source fails to compile.  It's still plagued with errors in the manager, organization, and serializer files.

So I borrowed some working versions from an old revision 216 directory, and they worked...  kinda.  Ultimately, g++ craps out with a linker error (which did not happen with said earlier version) that seems to be related to those files.

Clearly you've gotten it to compile (downloadable binary and all), so you must have files that aren't horribly broken.  Do you mind putting those on sourceforge?

[Cosmonot]

The last time the subject was brought up, Fox said he hasn't been updating the makefile, just the visual c++ project file. I'd bet that he hasn't had time to do it yet.

[penguinofhonor]

I have several bugs to report, and I'll get pictures for them later when I get to my normal computer.

1. I have a teenager that was born on the 14th of " ". There isn't a month where there usually is, just an extra blank space.
2. I have two sleepers (both kidnapped and brainwashed) that are at 50 juice but can't recruit any liberals. My sleeper that I recruited normally can have a follower but won't get one no matter how long I have him on "Expand Sleeper Network".
3. I had a wheelchair-ridden liberal that had over 100 juice but somehow was capped at 0 followers.
4. My sleepers aren't gaining any juice past 50. This might not be a bug.

[Servant Corps]

2. I have two sleepers (both kidnapped and brainwashed) that are at 50 juice but can't recruit any liberals.

That would explain it. Brainwashed sleepers can never recruit. Partly a game balanced mechanism since conversion is easy, and partly because a brainwashed loon isn't really going to be good at trying to convice others to join.

[penguinofhonor]

Wait, if no brainwashed liberals can recruit then it would explain how the wheelchair-ridden liberal couldn't recruit. She was a cop that I brainwashed.

[Servant Corps]

In a previous version of LCS I played (not sure if this was changed), brainwashed people were still able to seduce, so you could still find some way to put that police officer to use. The amount of seduced liberals per person usually is capped at 6 though...

[a1s]

The amount of seduced liberals per person usually is capped at 6 though...

as far as I know it's capped by you seduction skill (I think it's (seduction/2)+1)

also, if brainwashed people can't recruit, why even have the "expand sleeper network" command?

[Jonathan S. Fox]

The amount of seduced liberals per person usually is capped at 6 though...

as far as I know it's capped by you seduction skill (I think it's (seduction/2)+1)

also, if brainwashed people can't recruit, why even have the "expand sleeper network" command?

Agreed, it'll be gone next release, replaced with something more informative about the character being unable to recruit. Same when you just need juice to unlock the command -- it'll say so.

[Earthquake Damage]

As an amendment my source code woes above, I'd like to add that apparently daily/shopsnstuff.cpp has been broken at least as far back as revision 220 (says "enum Weapon" where it should say "enum Weapons").  I suspect there may be several such holes in the source posted on SF.

Regardless, I'm trying to pinpoint the revision that introduced the linker error(s) (undefined references all over the place relating to serializer and such, though the object files compiled just fine).  It's possible there's an issue that your dev environment automagically handles that mine (an uninspiring Cygwin setup) does not.

[penguinofhonor]

A quick note: There's no place to buy axes. I'm thinking that the current axe should be renamed "Fire Axe" and there should be a battle axe for sale in the Oubliette, though the Oubliette's weapons menu is full. Not sure what to do about that.

[Jonathan S. Fox]

The main thing is to find the file that contains the list of files to compile and add all source files created since that file was last updated. I will try to do so before too long. Notwithstanding my Windows-centric development pattern, I'm actually doing all this emulated on a mac, so I am very sympathetic to the cross-platform issue.

It's odd and somewhat disturbing that the VC++ compiled the enum Weapon errors without complaint for all these versions. It's not a hole in the commit, it's just seriously been like that the whole time, and I didn't know because my compiler didn't complain.

Eventually I'd like to switch to using something like the black market interface for all shops, which will resolve the Oubliette issue.

[Earthquake Damage]

I assume then that the following files work for you like a charm as well:
manager/manager.h
organization/orghandler.cpp
configfile.h

I forget how to fix those (several errors, incl. syntax), as template nonsense is beyond me.  I've been using corrected ones (somebody posted a fix some months back IIRC).  If I can relearn diff I should be able to post the required fixes here if you like.

[Jonathan S. Fox]

Template nonsense is never easy, but I can take a look at it if you show me the errors. The diff would be easier though.

[Earthquake Damage]

Code: [Select]

diff -I --text --recursive FIXED/configfile.h BROKEN/configfile.h
62c62
< template <> class configContainer<std::vector<int> > : public configContainerBase
---
> template <> class configContainer<std::vector<int>> : public configContainerBase
diff -I --text --recursive FIXED/manager/manager.h BROKEN/manager/manager.h
22c22
< */
---
> */
28d27
< #include <stdexcept>
80c79
<
---
> 
88c87
<    typename vector<T>::iterator iter; // Iterator to step through my object list
---
>    vector<T>::iterator iter; // Iterator to step through my object list
104c103
<    throw std::invalid_argument(error);
---
>    throw invalid_argument(error);
110c109
<    typename vector<T>::iterator iter; // Iterator to step through my object list
---
>    vector<T>::iterator iter; // Iterator to step through my object list
137c136
< typename vector<T>::iterator iter; // Iterator to step through the object list
---
> vector<object>::iterator iter; // Iterator to step through the object list
146c145
< objects.erase(iter);
---
> objects.erase(iter1);
151c150
< else iter->deleteOrgRecord(obj.ID);
---
> else iter1->deleteOrgRecord(obj.ID);
165c164
< this->nextID = 0;
---
> nextID = 0;
169,173c168,172
< copyClass* getInstance(int baseID)
< {
< copyClass* instance = new copyClass;
< initialize(*instance, baseID);
< return instance;
---
> copyClass* getInstance(int baseID)
> {
> copyClass* instance = new copyClass;
> initialize(*instance, baseID);
> return instance;
176,179c175,178
< void initialize(copyClass &instance, int ID)
< {
< /* find the correct object */
< this->getObj(ID).initializeInstance(instance);
---
> void initialize(copyClass &instance, int ID)
> {
> /* find the correct object */
> getObj(ID).initializeInstance(instance);
188c187
< #endif
---
> #endif
\ No newline at end of file
diff -I --text --recursive FIXED/organization/orghandler.cpp BROKEN/organization/orghandler.cpp
26,27d25
< #include <list>
< #include "orghandler.h"
114d111
<

The broken files were taken from r220 (the most recent of the ones I've looked at thus far), but SF says none of those have changed since r213.  Does that help at all?

Now that I think about it, there may have been an associated fix to another file (god only knows what) that would fix this linker error.  Guess I need to find that damn post somewhere around here...

I think it came from here, especially since either r216 or r217 was the last one I toyed with:

I'm working on getting 31104branch r216 to compile and run on Linux. http://omploader.org/vbXAx/linux-compile-fixes.patch handles the former, but the game segfaults after the opening questions still... I'm looking into that at the moment. (considering the obvious typos in this revision that would have prevented it from building on any compiler, I'm afraid it was not buildtested, and so obviously not playtested either)

(incidentally, please remind me that the next time I go around looking for answers to obscure linker errors... I check if all the project files even get compiled first)

[Jonathan S. Fox]

Found the file I needed to update, changed according to the diff you provided. Some of that was only working on this end because Visual Studio was culling it due to nothing calling it -- it would never have actually compiled. I'm about to start trying to build on my mac. If it will build for OSX, it should build for Linux, and I'll commit.