Trog = Death of many weak monsters, but you overexert and are left vulnerable afterwards to that elemental creeping around the corner.
Makhleb = Overall goodness.
Xom = Tons and tons and tons of cursed items, hordes of demons(hostile), and a bloody death.
Shining One = A set of bullshit rules that serverely limit you.
Zin = Almost as bad as Shining One, but a little better.
Those are the ones I have experience with.
Basically I pretty much agree.
Since I play monk the most, there's something I have to add:
I think (but never tried it enough) that it's actually a good thing to train a weapon later on. Just one. If you go a more magical route, that's out of the question, but I think UC, Fighting, dodging and then some supplemental skills (like either a real weapon or a small magic tree) are absolutely doable, XP wise.
So in that light, trog might be a useful choice, since "weapons focused on damage" are perfect, since your defense is mostly based on dodging, anyway.
Zin on the other hand might be a shitty deity, but RP-wise (don't laugh, all I got in ascii games is my imagination
) I really like the preaching and brawling combination ... I never got far that way, tho, but I'm working on it.