Bit of a necro but I've made a bit of progress into making the President more interesting. You could just go and download it (Link at the bottom) But wouldn't be more fun to read this really long and quite frankly unnecessary changelog I wrote for my minor changes? I'll leave that choice up to you.
***FEATURES**** President now has a unique sleeper function! When set to "Advocate Liberalism" they will act like a L+ in bills! (they *might* vote for Liberal supreme court justices I can't remember if they currently do)(currently doesn't change their colour in the politics screen.)
* If the President is apart of the active squad the are considered "missing" and the VP will vote on bills in their place (I'm not American so this might not be how that works. If not let me know and I'll change it)
* If the President is missing for longer than 12 - LCSRandom(7-1) (math is a bit random I just kinda threw it in there) the VP will just take over and the president will become an ex-president.
***BUGFIXES**** you can no longer duplicate the President. As they should now not be present at the White House while they is being recruited, kidnapped, and dated. They are also no longer at the White House if they are apart of the active LCS.(whether in the current squad or not) This also prevents you from duplicating the President if they are a sleeper. (if you try to talk or date them it will print a unique message) If I've missed any President duplication bugs please let me know.
***BUGS***
* Not an issue with anything I've written but it seems to be something I can't fix. The function that promotes the VP does not change the variable that changes the Presidents unique id. This means that in some cases, killing a ex-president will kill the ex-VP now President. The reason I can't fix this is due to how headers seem to work with LCS. I've written a bit of C++ but the amount of conflicts all 70 of the headers cause if I try and fix it cause seems to prevent me from changing this. (If anyone knows a way to include the Unique Creatures class in politics.h without the conflicts please submit a pull on the git .)
* The for whatever reason the unique dialogue you get when talking to a Sleeper President seems to randomly occur when talking with the Corp CEO. I have no Idea why as I haven't edited the Unique Creatures class in any way.
***TODO**** Add a mechanic to handle the President constantly voting against their party. I'm currently toying with the idea of impeachment (and execution if laws are C+ enough) and (permanent?) infiltration hits .
* Custom events if the President is seen fighting with the Liberal Crime Squad in public.
* Ability for the President to cancel police, military and CIA raids if their infiltration is high enough.
If anyone would be willing to rewrite the unique sleeper turn down dialogues and/or write newspapers for the events in TODO I would greatly appreciate it. I would do it myself but I'm not at all good a writing (as you might be able to tell from this post)
LINK:
https://github.com/Lemminggit/LCSPrestest (for whatever reason I downloaded lcs as a .zip instead of forking and then cloning it. So the repo is currently not a fork of the main one)
(just download a zip and run the exe.)