Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[PatrikLundell]

Milk: The cause of the naming problem is that milk and cheese doesn't use a prefix like other tissues do. Again, however, MySQL reports an error when I try to access Mantis for a bug report...
I believe I've managed to remove animal people from the list of eligible milk and cheese products, though.

The Creepy Crawler can be butchered because it doesn't have the [NOT_BUTCHERABLE] tag together with being large enough to generate meat when slaughtered.

The [FISHITEM] tag is set on every vermin fish, plus the moghopper. The only things I've found that sets the moghopper apart from the rest is that it can't be eaten (according to the wiki) and that it has a creature extract reaction.

I haven't looked at CASTE flags before, but there seems to be some general flags buried down there. It can be noted that the script still iterates over the raw strings for NON_BUTCHERABLE, for instance: I haven't changed that yet.

The updated version if the script. Note the variable "replace_vermin" at the top. It's set to "false", so the script behaves as before (minus some bugs). If the variable is changed to "true", the script should replace all non "fish" vermin (no Creepy Crawler, Mog Juice, or Dwarven Milk/Cheese as a collateral result).

Spoiler (click to show/hide)

Code: [Select]

local replace_vermin = false --  If true, all non "fish" vermin are replaced by "real" food
                             --  This also excludes Creepy Crawler (can be butchered),
                             --  Moghopper Juice, and Dwarven Milk/Cheese
                             
--  Bumblebee honey is impossible to obtain in vanilla, and thus does bumblebee mead remain
--  out of reach. Feather trees are bugged so you can't get any eggs, and thus not get at
--  the egg white or yolk (despite the trade depot being contaminated by feather tree egg
--  yolk after the elves have visited).
--
local bumblebee = -1
local feather_tree = -1

for i, creature in ipairs (df.global.world.raws.creatures.all) do
  if creature.creature_id == "BUMBLEBEE" then
    bumblebee = i
    break
  end
end

for i, plant in ipairs (df.global.world.raws.plants.all) do
  if plant.id == "FEATHER" then
    feather_tree = i
    break
  end
end

local min_butcher_size = --  Data taken from http://www.bay12forums.com/smf/index.php?topic=78108.0
                         --  The values are shifted down one order of magnitude to match the ingame (rather than the raw) unit.
  {["MUSCLE"] =          190,  --  Meat in the reference
   ["FAT"] =             190,  --  Haven't seen any preferences for it
   ["TALLOW"] =          190,  --  i.e. rendered fat. Haven't seen any preferences for it, though
   ["SKIN"] =            190,  --  Inedible, but here for completeness
   ["BONE"] =            200,  --  Inedible
   ["INTESTINES"] =      500,
   ["BRAIN"] =          1000,
   ["LUNG"] =           1000,
   ["LIVER"] =          1000,
   ["STOMACH"] =        1000,  --  Called tripe as food
   ["GUT"] =            1000,  --  ###Not in reference. Guessing it's the same most others.
   ["GIZZARD"] =        1000,  --  Not in reference. Wiki claims size similar to brain and liver.
                               --    Wiki DF2014:Prepared_organs does not list Gut or Gizzard.
   ["NERVE"] =          1500,  --  ###Name not checked. Inedible anyway
   ["HOOF"] =           1500,  --  Inedible
   ["HEART"] =          2000,
   ["PANCREAS"] =       2000,  --  Called sweetbread as food
   ["SPLEEN"] =         2000,
   ["KIDNEY"] =         2000,
   ["HORN"] =           2000,  --  Inedible
   ["CARTILAGE"] =     20000,  --  Inedible
   ["HAIR"] =          20000,  --  Inedible
   ["EYE"] =           50000,
   ["TOOTH"] =       2500000,  --  Inedible
   ["CHEESE"] =            0}  --  Not a butcher product, and thus no size relation, but exists as food preferences.

local butcher_edible =
  {["MUSCLE"] =         true,  --  Meat in the reference
   ["FAT"] =           false,  --  Haven't seen any preferences for it
   ["TALLOW"] =        false,  --  i.e. rendered fat. Haven't seen any preferences for it, though
   ["SKIN"] =          false,  --  Inedible, but here for completeness
   ["BONE"] =          false,  --  Inedible
   ["INTESTINES"] =     true,
   ["BRAIN"] =          true,
   ["LUNG"] =           true,
   ["LIVER"] =          true,
   ["STOMACH"] =        true,  --  Called tripe as food
   ["GUT"] =            true,  --  ###Not in reference. Guessing it's the same most others.
   ["GIZZARD"] =        true,  --  Not in reference. Wiki claims size similar to brain and liver.
                               --    Wiki DF2014:Prepared_organs does not list Gut or Gizzard.
   ["NERVE"] =         false,  --  Inedible
   ["HOOF"] =          false,  --  Inedible
   ["HEART"] =          true,
   ["PANCREAS"] =       true,  --  Called sweetbread as food
   ["SPLEEN"] =         true,
   ["KIDNEY"] =         true,
   ["HORN"] =          false,  --  Inedible
   ["CARTILAGE"] =     false,  --  Inedible
   ["HAIR"] =          false,  --  Inedible
   ["EYE"] =            true,
   ["TOOTH"] =         false,  --  Inedible
   ["CHEESE"] =        false}  --  Handled separately, like milk
   

local available_plant = {}
local available_creature = {}

-----------------------------

function item_type_of (matinfo)
  if type (matinfo) == "number" then
    if df.global.world.raws.creatures.all [matinfo].flags.VERMIN_FISH then
      return df.item_type.FISH
     
    else
      return df.item_type.MEAT
    end
   
  else
    if matinfo.material.flags.MEAT then
      return df.item_type.MEAT
     
    elseif matinfo.material.flags.ALCOHOL then
      return df.item_type.DRINK
     
    elseif matinfo.material.flags.POWDER_MISC then
      return df.item_type.POWDER_MISC
     
    elseif matinfo.material.flags.LIQUID_MISC then
      return df.item_type.LIQUID_MISC

    elseif matinfo.material.flags.STRUCTURAL_PLANT_MAT then
      return df.item_type.PLANT
     
    elseif matinfo.material.flags.SEED_MAT then
      return df.item_type.SEEDS
     
    elseif matinfo.material.flags.LEAF_MAT then
      return df.item_type.PLANT_GROWTH

    elseif matinfo.material.flags.CHEESE then
      return df.item_type.CHEESE
   
    else
      dfhack.printerr ("item_type_of encountered item it couldn't classify: " .. matinfo.material.id)
    end
  end
end

-----------------------------

function is_resident (unit)
  return not dfhack.units.isCitizen (unit) and
         unit.civ_id == df.global.ui.civ_id and
         not unit.flags1.marauder and
         not unit.flags1.tame and
         not unit.flags2.visitor and
         not unit.flags1.merchant and
         not unit.flags1.forest and
         not unit.flags1.diplomat
end

-----------------------------

function replacement_string (preference, replacement, unit)
  local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
 
  if preference.item_type == df.item_type.DRINK or
     preference.item_type == df.item_type.LIQUID_MISC then  --  The state in the preferences seems locked to Solid
    local material = dfhack.matinfo.decode (preference.mattype, preference.matindex)
    local man = ""
   
    if material.creature and
       material.creature.flags.CASTE_CAN_LEARN then
      man = " man "
    end
   
    return material.material.state_name.Liquid ..
           " with " .. replacement.material.state_name.Liquid .. man ..
           " on " .. dfhack.TranslateName (unit.name, true)
 
  elseif preference.matindex == -1 then
    local old_str = df.global.world.raws.creatures.all [preference.mattype].name [0]
    local new_str = ""
     
    if type (replacement) == "number" then
      new_str = df.global.world.raws.creatures.all [replacement].name [0]
         
    else       
      if replacement.material.prefix == "" then
        new_str = replacement.material.state_name.Solid
         
      else
        new_str = replacement.material.prefix .. " " .. replacement.material.state_name.Solid
      end
    end
     
    return old_str .. " with " .. tostring (new_str) .. " on " .. dfhack.TranslateName (unit.name, true)
     
  else
    if old_mat.mode == "creature"  then
      local old_str = ""
      local new_str = ""
     
      if old_mat.material.prefix == "" then
        old_str = old_mat.material.state_name.Solid
       
      else
        old_str =  old_mat.material.prefix .. " " .. old_mat.material.state_name.Solid
      end
     
      if type (replacement) == "number" then
        new_str = df.global.world.raws.creatures.all [replacement].name [0]
         
      else       
        if replacement.material.prefix == "" then
          new_str = replacement.material.state_name.Solid
         
        else
          new_str = replacement.material.prefix .. " " .. replacement.material.state_name.Solid
        end
      end
     
      return old_str .. " with " .. tostring (new_str) .. " on " .. dfhack.TranslateName (unit.name, true)
     
    else
      local old_str = ""
      local new_str = ""
     
      if not old_mat then
        old_str = df.global.world.raws.plants.all [preference.mattype].name
       
      elseif  old_mat.material.prefix == "" then
        old_str =  old_mat.material.state_name.Solid
       
      else
        old_str =  old_mat.material.prefix .. " " .. old_mat.material.state_name.Solid
      end
     
      if type (replacement) == "number" then
        new_str = df.global.world.raws.plants.all [replacement].name
         
      else       
        if replacement.material.prefix == "" then
          new_str = replacement.material.state_name.Solid
         
        else
          new_str = replacement.material.prefix .. " " .. replacement.material.state_name.Solid
        end
      end
     
      return old_str .. " with " .. tostring (new_str) .. " on " .. dfhack.TranslateName (unit.name, true)
    end
  end
end

-----------------------------

function fix_food_needs ()
--  printall (dfhack.matinfo.find ("PLANT:POD_SWEET:EXTRACT"))
--  printall (dfhack.matinfo.find ("CREATURE:COW:CHEESE"))
  local drinkable = {}  --  Entries will be matinfo structures
  local edible = {}     --  Entries will either be an integer creature index for a whole vermin creature,
                        --  or a matinfo structure
  local rng = dfhack.random.new ()
 
  for i, plant in ipairs (df.global.world.raws.plants.all) do
    available_plant [i] = false
  end
 
  for i, creature in ipairs (df.global.world.raws.creatures.all) do
    available_creature [i] = (creature.flags.CASTE_COMMON_DOMESTIC  or               --  Some of them don't exist in the wild
                              creature.flags.BIOME_RIVER_TEMPERATE_FRESHWATER or     --  Don't know how to check availability
                              creature.flags.BIOME_RIVER_TEMPERATE_BRACKISHWATER or  --  -"-
                              creature.flags.BIOME_RIVER_TEMPERATE_SALTWATER or      --  -"-
                              creature.flags.BIOME_RIVER_TROPICAL_FRESHWATER or      --  -"-
                              creature.flags.BIOME_RIVER_TROPICAL_BRACKISHWATER or   --  -"-
                              creature.flags.BIOME_RIVER_TROPICAL_SALTWATER)         --  -"-
  end
 
  for i, region in ipairs (df.global.world.world_data.regions) do
    for k, pop in ipairs (region.population) do
      if pop.type == df.world_population_type.Animal or
         pop.type == df.world_population_type.Vermin or
         pop.type == df.world_population_type.VerminInnumerable or
         pop.type == df.world_population_type.ColonyInsect then
        available_creature [pop.race] = true
       
      elseif pop.type == df.world_population_type.Tree or
             pop.type == df.world_population_type.Grass or
             pop.type == df.world_population_type.Bush then
        available_plant [pop.plant] = true
      end
    end
  end
 
  for i, region in ipairs (df.global.world.world_data.underground_regions) do
    for k, pop in ipairs (region.feature_init.feature.population) do
      if pop.type == df.world_population_type.Animal or
         pop.type == df.world_population_type.Vermin or
         pop.type == df.world_population_type.VerminInnumerable or
         pop.type == df.world_population_type.ColonyInsect then
        available_creature [pop.race] = true
       
      elseif pop.type == df.world_population_type.Tree or
             pop.type == df.world_population_type.Grass or
             pop.type == df.world_population_type.Bush then
        available_plant [pop.plant] = true
      end
    end
  end
 
  for i, plant in ipairs (df.global.world.raws.plants.all) do
    if available_plant [i] and
       not plant.flags.GRASS then  -- Grasses can't be harvested in any way, but evil ones are made of meat...
      for k, material in ipairs (plant.material) do
        if (material.flags.ALCOHOL_PLANT or
            material.flags.LIQUID_MISC_PLANT) and
           material.flags.EDIBLE_RAW then
          table.insert (drinkable, dfhack.matinfo.find ("PLANT:" .. plant.id .. ":" .. material.id))
         
        elseif not material.flags.LIQUID_MISC_PLANT and  --  Oils that can't be drunk raw don't seem to be cooked by DF.
               (material.flags.EDIBLE_RAW or
                material.flags.EDIBLE_COOKED) and
               plant.index ~= feather_tree then  --  Feather tree eggs are bugged...
          table.insert (edible, dfhack.matinfo.find ("PLANT:" .. plant.id .. ":" .. material.id))
        end
      end
    end
  end
 
  for i, creature in ipairs (df.global.world.raws.creatures.all) do
    if not creature.flags.GENERATED and  --  Exclude FBs, demons, etc.
       not creature.flags.CASTE_CAN_LEARN and
       available_creature [i] then
      if creature.flags.any_vermin then
        if not replace_vermin or
--           not creature.caste [0].flags.NOT_BUTCHERABLE or  --  Would allow Creepy Crawler
           (creature.caste [0].flags.FISHITEM and
            #creature.caste [0].extracts.extract_mat == 0) then  --  Moghopper has FISHITEM set, but can't be eaten
          local can_be_eaten = false

          for k, material in ipairs (creature.material) do
            if material.id == "MUSCLE" then
              can_be_eaten = true
           
            elseif material.id == "MILK" then
              table.insert (drinkable, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
           
            elseif material.id == "CHEESE" then
              table.insert (edible, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
            end
          end
       
          if can_be_eaten then  --  Weed out stuff like e.g. fire snakes
            table.insert (edible, i)
          end
        end
       
      else
        local butcherable = true
                 
        for k, str in ipairs (creature.raws) do
          if str [0] == "[NOT_BUTCHERABLE]" then
            butcherable = false
            break
          end
        end
       
        if min_butcher_size ["MUSCLE"] > creature.adultsize then
          butcherable = false  --  Technically possibly, but nothing edible resulting
        end
               
        for k, material in ipairs (creature.material) do
          if material.id == "MILK" then
              table.insert (drinkable, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
           
          elseif material.id == "CHEESE" then
              table.insert (edible, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
           
          elseif butcherable and
                 not creature.flags.CASTE_CAN_LEARN and  --### Is this the correct criterion?
                 min_butcher_size [material.id] and
                 min_butcher_size [material.id] <= creature.adultsize and
                 butcher_edible [material.id] then
            table.insert (edible, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))           
          end   
        end
      end
    end
  end
 
--  dfhack.println (#drinkable, #edible)
 
  for i, unit in ipairs (df.global.world.units.all) do
    if (dfhack.units.isCitizen (unit) or
        is_resident (unit)) and
       dfhack.units.isAlive (unit) and
       unit.status.current_soul then
      for k, preference in ipairs (unit.status.current_soul.preferences) do
        if preference.active then
          if preference.type == df.unit_preference.T_type.LikeFood then         
            local material = dfhack.matinfo.decode (preference.mattype, preference.matindex)
           
            if preference.matindex ~= -1 and
               (material.mode == "plant" or
                material.mode == "creature") then
              if preference.item_type == df.item_type.DRINK or
                 preference.item_type == df.item_type.LIQUID_MISC then  --  The state in the preferences seems locked to Solid
                if material.mode == "creature"  then
                  if not available_creature [preference.matindex] or
                     preference.matindex == bumblebee then
                    local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
                    local rng_number = rng:random (#drinkable - 1) + 1  --  To get it into the Lua vector range
                   
                    while preference.item_type == df.item_type.DRINK and
                          not drinkable [rng_number].material.flags.ALCOHOL do
                      rng_number = rng:random (#drinkable - 1) + 1
                    end
                   
                    dfhack.println ("Replacing unavailable " .. replacement_string (preference, drinkable [rng_number], unit))
                   
                    preference.mattype = drinkable [rng_number].type
                    preference.matindex = drinkable [rng_number].index                                               
                    preference.item_type = item_type_of (drinkable [rng_number])
                    preference.item_subtype = drinkable [rng_number].subtype
                  end
               
                else
                  if not available_plant [preference.matindex] then
                    local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
                    local rng_number = rng:random (#drinkable - 1) + 1  --  To get it into the Lua vector range
                   
                    while preference.item_type == df.item_type.DRINK and
                          not drinkable [rng_number].material.flags.ALCOHOL do
                      rng_number = rng:random (#drinkable - 1) + 1
                    end
                   
                    dfhack.println ("Replacing unavailable " .. replacement_string (preference, drinkable [rng_number], unit))
                    preference.mattype = drinkable [rng_number].type
                    preference.matindex = drinkable [rng_number].index
                    preference.item_type = item_type_of (drinkable [rng_number])                   
                    preference.item_subtype = drinkable [rng_number].subtype
                  end
                end
       
              else  --  Food
                if material.mode == "creature" then
                  local butcherable = true
                  local too_small = false
                 
                  for i, str in ipairs (material.creature.raws) do
                    if str [0] == "[NOT_BUTCHERABLE]" then
                      butcherable = false
                      break
                    end
                  end
       
                  if min_butcher_size [material.material.id] then
                    if min_butcher_size [material.material.id] > material.creature.adultsize then
                      too_small = true
                     
                      if min_butcher_size ["MUSCLE"] > material.creature.adultsize then
                        butcherable = false  --  Technically possibly, but nothing edible resulting
                      end
                    end
         
                  else
                    dfhack.printerr ("fix_food_needs found unexpected animal food preference (continuing): " .. material.material.id)
                  end
                 
                  if not available_creature [preference.matindex] or
                     (replace_vermin and
                      df.global.world.raws.creatures.all [preference.matindex].flags.any_vermin and
                     (not df.global.world.raws.creatures.all [preference.matindex].caste [0].flags.FISHITEM or
                      #df.global.world.raws.creatures.all [preference.matindex].caste [0].extracts.extract_mat > 0)) then
                    local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                    dfhack.println ("Replacing non existent " .. replacement_string (preference, edible [rng_number], unit))
                   
                    if type (edible [rng_number]) == "number" then
                      preference.mattype = edible [rng_number]
                      preference.matindex = -1
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = -1  --###
                     
                    else
                      preference.mattype = edible [rng_number].type
                      preference.matindex = edible [rng_number].index
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = edible [rng_number].subtype
                   end
                                                         
                  elseif not butcherable then
                    if material.creature.flags.any_vermin then
                      dfhack.println ("Replacing vermin part " .. replacement_string (preference, preference.matindex, unit))
                      preference.mattype = preference.matindex
                      preference.matindex = -1
                      preference.item_subtype = -1  --###
                     
                    else
                      local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
                      local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                      dfhack.println ("Replacing unbutcherable " .. replacement_string (preference, edible [rng_number], unit))
                   
                      if type (edible [rng_number]) == "number" then
                        preference.mattype = edible [rng_number]
                        preference.matindex = -1
                        preference.item_type = item_type_of (edible [rng_number])
                        preference.item_subtype = -1  --###
                     
                      else
                        preference.mattype = edible [rng_number].type
                        preference.matindex = edible [rng_number].index
                        preference.item_type = item_type_of (edible [rng_number])
                        preference.item_subtype = edible [rng_number].subtype
                      end
                    end
                   
                  elseif too_small then
                    for l, mat in ipairs (material.creature.material) do
                      if mat.id == "MUSCLE" then
                        local material = dfhack.matinfo.find ("CREATURE:" .. material.creature.creature_id .. ":MUSCLE")
                       
                        dfhack.println ("Replacing unobtainable " .. replacement_string (preference, material, unit))

                        if not material then
                          dfhack.printerr ("Replacement failed", preference.mattype, preference.matindex)
                       
                        else
                          preference.mattype = material.type
                          preference.matindex = material.index
                          preference.item_subtype = material.subtype
                        end
                     
                        break
                      end
                    end
                  end
                 
                else
                  if not available_plant [preference.matindex] then
                    local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                    dfhack.println ("Replacing unavailable " .. replacement_string (preference, edible [rng_number], unit))
                   
                    if type (edible [rng_number]) == "number" then
                      preference.mattype = edible [rng_number]
                      preference.matindex = -1
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = -1  --###
                     
                    else
                      preference.mattype = edible [rng_number].type
                      preference.matindex = edible [rng_number].index
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = edible [rng_number].subtype
                    end
                                     
                  elseif material.matindex == feather_tree then
                    local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                    dfhack.println ("Replacing unobtainable " .. replacement_string (preference, edible [rng_number], unit))
                   
                    if type (edible [rng_number]) == "number" then
                      preference.mattype = edible [rng_number]
                      preference.matindex = -1
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = -1  --###
                     
                    else
                      preference.mattype = edible [rng_number].type
                      preference.matindex = edible [rng_number].index
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = edible [rng_number].subtype
                    end
                  end
                end
              end
             
            elseif not available_creature [preference.mattype] or
                   (replace_vermin and
                    df.global.world.raws.creatures.all [preference.mattype].flags.any_vermin and
                     (not df.global.world.raws.creatures.all [preference.mattype].caste [0].flags.FISHITEM or
                      #df.global.world.raws.creatures.all [preference.mattype].caste [0].extracts.extract_mat > 0)) then
              local unavailable = "unavailable "
              local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
              if available_creature [preference.mattype] then
                unavailable = "vermin "
              end
             
              dfhack.println ("Replacing " .. unavailable .. replacement_string (preference, edible [rng_number], unit))
                   
              if type (edible [rng_number]) == "number" then
                preference.mattype = edible [rng_number]
                preference.matindex = -1
                preference.item_type = item_type_of (edible [rng_number])
                preference.item_subtype = -1  --###
                     
              else
                preference.mattype = edible [rng_number].type
                preference.matindex = edible [rng_number].index
                preference.item_type = item_type_of (edible [rng_number])
                preference.item_subtype = edible [rng_number].subtype
              end
            end
          end
        end
      end
    end
  end
end

fix_food_needs ()


Edit: I finally managed to file a bug report: http://www.bay12games.com/dwarves/mantisbt/view.php?id=10959

[Saiko Kila]

I think it works very good now. I needed to personalize it only by adding logging. Maybe also I will modify so vermin is changed to aquatic vermin, because that would be easier to fulfil, and I like to cheat.

Regarding moghopper, I don't believe it is inedible and I wanted to prove it (also wiki on moghopper says it's edible). However, I tried and failed to find an embark where moghopper is present in the population list. Actually, in most embarks (with unmodded game!) pools are empty since the beginning, and I can't fish anything. I'm not sure if it's my luck or some kind of a bug. Dwarves trying to catch a live fish vermin (using the Fishery workshop task) when pools are empty (i.e. in all my tested cases) will just stand somewhere in the corner till I cancel the task, even if they are hungry or thirsty...

Regarding the bug with milk and cheese: it seems impossible to easily modify it with RAW. I was able to correct it by changing c_variation_default.txt so it removed milk and cheese tags from all giant versions, and then manually adding milk and cheese tags to proper RAWs for female giant animals (I did it only for a few, to test it). The same could be done with animal men. It's too much work to be fun (the new tags need to be in proper place and sequence), but it's doable.

[PatrikLundell]

The wiki page on vermin claims the moghopper is not edible, but yes, the page on the moghopper claims it is, so the pages are conflicting.
It can be noted that the raws for the creature makes it available only in summer, so for a "live" testing I'd consider removing the season restrictions. However, I've found pools to be surprisingly empty of vermin fish when a blasted mood require shells, forcing me to try some emergency fishing for pond turtles.

Your testing with the raws shows that it is possible to fix the bug with raws only, though, even if it's tedious, which is probably better than changing the code (especially if the community would do the work and Toady would accept the results). Personally I'd leave animal women out, as I don't think they should produce theoretically milkable but practically unavailable, milk (and hence cheese).

[Saiko Kila]

I tried proper live tests with moghopper at first - in my fort in summer, and then on new embark in new world, using spring time to prepare traps and workshops. But the only fish I can catch are in the rivers or oceans, not in the ponds. Maybe caverns are viable, but I don't fish there, instead buying cave fish from caravan.

The bug with milk is still a bug, even if in RAWs, and maybe it would actually need some code changes for easier modification, or rather generation of name? Currently names have to be explicitly declared, and giant/animal men versions simply copy the names from the base creature. You could name liquid cow's milk "a rainbow puke", frozen one "elixir of youth No.5" and gaseous "bar of soap", and if the giant cows existed their milk would be named the same.

After some tries I find that the best modification to me is these steps:
1. extract raws of critters as the game sees them
2. modify raws of giant/animal men
3. overwrite original definition in the proper txt files with the new changes.

So for example in giant kangaroo's case, find the giant kangaroo in creature_temperate_new.txt, remove [CREATURE:GIANT_KANGAROO] and everything below to the line about sponsorship of koala's, and insert

Spoiler (click to show/hide)

Code: [Select]

[CREATURE:GIANT_KANGAROO]
[NAME:giant kangaroo:giant kangaroos:giant kangaroo]
[CASTE_NAME:giant kangaroo:giant kangaroos:giant kangaroo]
[GENERAL_CHILD_NAME:giant kangaroo joey:giant kangaroo joeys]
[DESCRIPTION:A huge monster in the shape of a kangaroo.]
[POPULATION_NUMBER:15:30]
[CLUSTER_NUMBER:2:4]
[CREATURE_TILE:'K']
[COLOR:6:0:0]
[PET_EXOTIC]
[PETVALUE:500]
[MOUNT_EXOTIC]
[CHILD:1]
[CREATURE_CLASS:MAMMAL]
[BIOME:GRASSLAND_TEMPERATE]
[BIOME:SAVANNA_TEMPERATE]
[BIOME:SHRUBLAND_TEMPERATE]
[BIOME:ANY_DESERT]
[VISION_ARC:50:310]
[LARGE_ROAMING]
[BENIGN]
[MEANDERER]
[STANDARD_GRAZER]
[BODY:HUMANOID_NECK:TAIL:2EYES:2EARS:NOSE:2LUNGS:HEART:GUTS:ORGANS:THROAT:NECK:SPINE:BRAIN:SKULL:MOUTH:GENERIC_TEETH:RIBCAGE]
[NATURAL]
[BODY_DETAIL_PLAN:STANDARD_MATERIALS]
[BODY_DETAIL_PLAN:STANDARD_TISSUES]
[BODY_DETAIL_PLAN:VERTEBRATE_TISSUE_LAYERS:SKIN:FAT:MUSCLE:BONE:CARTILAGE]
[BODY_DETAIL_PLAN:BODY_HAIR_TISSUE_LAYERS:HAIR]
[SELECT_TISSUE_LAYER:HEART:BY_CATEGORY:HEART]
[PLUS_TISSUE_LAYER:SKIN:BY_CATEGORY:THROAT]
[TL_MAJOR_ARTERIES]
[BODY_DETAIL_PLAN:STANDARD_HEAD_POSITIONS]
[BODY_DETAIL_PLAN:HUMANOID_RIBCAGE_POSITIONS]
[USE_MATERIAL_TEMPLATE:SINEW:SINEW_TEMPLATE]
[TENDONS:LOCAL_CREATURE_MAT:SINEW:200]
[LIGAMENTS:LOCAL_CREATURE_MAT:SINEW:200]
[HAS_NERVES]
[USE_MATERIAL_TEMPLATE:BLOOD:BLOOD_TEMPLATE]
[BLOOD:LOCAL_CREATURE_MAT:BLOOD:LIQUID]
[CREATURE_CLASS:GENERAL_POISON]
[GETS_WOUND_INFECTIONS]
[GETS_INFECTIONS_FROM_ROT]
[USE_MATERIAL_TEMPLATE:PUS:PUS_TEMPLATE]
[PUS:LOCAL_CREATURE_MAT:PUS:LIQUID]
[BODY_SIZE:0:0:9000]
[BODY_SIZE:1:0:45000]
[BODY_SIZE:2:0:90000]
[BODY_APPEARANCE_MODIFIER:LENGTH:90:95:98:100:102:105:110]
[BODY_APPEARANCE_MODIFIER:HEIGHT:90:95:98:100:102:105:110]
[BODY_APPEARANCE_MODIFIER:BROADNESS:90:95:98:100:102:105:110]
[MAXAGE:10:20]
[ATTACK:KICK:BODYPART:BY_TYPE:GRASP]
[ATTACK_SKILL:GRASP_STRIKE]
[ATTACK_VERB:punch:punches]
[ATTACK_CONTACT_PERC:100]
[ATTACK_PREPARE_AND_RECOVER:3:3]
[ATTACK_PRIORITY:MAIN]
[ATTACK_FLAG_WITH]
[ATTACK:KICK:BODYPART:BY_TYPE:STANCE]
[ATTACK_SKILL:STANCE_STRIKE]
[ATTACK_VERB:kick:kicks]
[ATTACK_CONTACT_PERC:100]
[ATTACK_PREPARE_AND_RECOVER:4:4]
[ATTACK_PRIORITY:MAIN]
[ATTACK_FLAG_WITH]
[ATTACK_VELOCITY_MODIFIER:3000]
[ATTACK_FLAG_BAD_MULTIATTACK]
[ATTACK:BITE:CHILD_BODYPART_GROUP:BY_CATEGORY:HEAD:BY_CATEGORY:TOOTH]
[ATTACK_SKILL:BITE]
[ATTACK_VERB:bite:bites]
[ATTACK_CONTACT_PERC:100]
[ATTACK_PENETRATION_PERC:100]
[ATTACK_FLAG_EDGE]
[ATTACK_PREPARE_AND_RECOVER:3:3]
[ATTACK_PRIORITY:SECOND]
[ATTACK_FLAG_CANLATCH]
[NOCTURNAL]
[CREPUSCULAR]
[HOMEOTHERM:10070]
[SWIMS_INNATE]
[CASTE:FEMALE]
[FEMALE]
[MULTIPLE_LITTER_RARE]
[USE_MATERIAL_TEMPLATE:MILK:MILK_TEMPLATE]
[STATE_NAME:ALL_SOLID:frozen giant kangaroo's milk]
[STATE_ADJ:ALL_SOLID:frozen giant kangaroo's milk]
[STATE_NAME:LIQUID:giant kangaroo's milk]
[STATE_ADJ:LIQUID:giant kangaroo's milk]
[STATE_NAME:GAS:boiling giant kangaroo's milk]
[STATE_ADJ:GAS:boiling giant kangaroo's milk]
[PREFIX:NONE]
[MILKABLE:LOCAL_CREATURE_MAT:MILK:20000]
[USE_MATERIAL_TEMPLATE:CHEESE:CREATURE_CHEESE_TEMPLATE]
[STATE_NAME:SOLID:giant kangaroo cheese]
[STATE_ADJ:SOLID:giant kangaroo cheese]
[STATE_NAME:SOLID_POWDER:giant kangaroo cheese powder]
[STATE_ADJ:SOLID_POWDER:giant kangaroo cheese powder]
[STATE_NAME:LIQUID:melted giant kangaroo cheese]
[STATE_ADJ:LIQUID:melted giant kangaroo cheese]
[STATE_NAME:GAS:boiling giant kangaroo cheese]
[STATE_ADJ:GAS:boiling giant kangaroo cheese]
[PREFIX:NONE]
[CASTE:MALE]
[MALE]
[SET_BP_GROUP:BY_TYPE:LOWERBODY]
[BP_ADD_TYPE:GELDABLE]
[SELECT_CASTE:ALL]
[SET_TL_GROUP:BY_CATEGORY:ALL:HAIR]
[TL_COLOR_MODIFIER:BROWN:1]
[TLCM_NOUN:hair:SINGULAR]
[SET_TL_GROUP:BY_CATEGORY:ALL:SKIN]
[TL_COLOR_MODIFIER:BROWN:1:BURNT_UMBER:1:CINNAMON:1:COPPER:1:DARK_BROWN:1:DARK_PEACH:1:DARK_TAN:1:ECRU:1:PALE_BROWN:1:PALE_CHESTNUT:1:PALE_PINK:1:PEACH:1:PINK:1:RAW_UMBER:1:SEPIA:1:TAN:1:TAUPE_PALE:1:TAUPE_SANDY:1]
[TLCM_NOUN:skin:SINGULAR]
[SET_TL_GROUP:BY_CATEGORY:EYE:EYE]
[TL_COLOR_MODIFIER:BLACK:1]
[TLCM_NOUN:eyes:PLURAL]
[LARGE_ROAMING]
[SAVAGE]
[SELECT_CASTE:ALL]
[CHANGE_FREQUENCY_PERC:50]
[SELECT_CASTE:ALL]
[CHANGE_BODY_SIZE_PERC:953]
[PREFSTRING:pouches]
[PREFSTRING:great leaps]
[GAIT:WALK:Fastest Walk:183:10:3:549:50:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:50]
[GAIT:WALK:Faster Walk:366:5:3:549:10:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:20]
[GAIT:WALK:Fast Walk:549:NO_BUILD_UP:5:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:10]
[GAIT:WALK:Walk:900:NO_BUILD_UP:0]
[GAIT:WALK:Slow Walk:1900:NO_BUILD_UP:0]
[GAIT:WALK:Slowest Walk:2900:NO_BUILD_UP:0]
[GAIT:SWIM:Maximum Swim Speed:8775:10:3:8900:50:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:50]
[GAIT:SWIM:Faster Swim:8825:5:3:8900:10:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:20]
[GAIT:SWIM:Fast Swim:8900:NO_BUILD_UP:5:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:10]
[GAIT:SWIM:Swim:9000:NO_BUILD_UP:0]
[GAIT:SWIM:Slow Swim:9500:NO_BUILD_UP:0]
[GAIT:SWIM:Creeping Swim:9900:NO_BUILD_UP:0]
[GAIT:CRAWL:Scramble:8775:10:3:8900:50:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:50]
[GAIT:CRAWL:Faster Crawl:8825:5:3:8900:10:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:20]
[GAIT:CRAWL:Fast Crawl:8900:NO_BUILD_UP:5:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:10]
[GAIT:CRAWL:Crawl:9000:NO_BUILD_UP:0]
[GAIT:CRAWL:Slow Crawl:9500:NO_BUILD_UP:0]
[GAIT:CRAWL:Creep:9900:NO_BUILD_UP:0]
[GAIT:CLIMB:Scramble:8775:10:3:8900:50:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:50]
[GAIT:CLIMB:Faster Climb:8825:5:3:8900:10:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:20]
[GAIT:CLIMB:Fast Climb:8900:NO_BUILD_UP:5:LAYERS_SLOW:STRENGTH:AGILITY:STEALTH_SLOWS:10]
[GAIT:CLIMB:Climb:9000:NO_BUILD_UP:0]
[GAIT:CLIMB:Slow Climb:9500:NO_BUILD_UP:0]
[GAIT:CLIMB:Creep:9900:NO_BUILD_UP:0]

Sure, this way the giant kangaroo's definition is divorced from the base creature's definition, but at least the only thing which changes from the game's perspective is the only thing I want to have changed. This is also guaranteed to be save compatible, while I'm not so sure about the product of tag changing, which is prone to mistakes. This can be automated by a script, but since this script would need testing anyway, maybe it's not worth doing, time-wise. Besides, manually changing can help in finding bugs in RAW definition (for example giant koala doesn't have opening bracket in GENERAL_CHILD_NAME tag, so the tag is not applied, and giant koalas don't have specific names for young, I found out only because it is just after kangaroos).

The new definition of giant kangaroo takes 5815 characters, the original definition has 1039 characters. Downside is that the file size is bigger, but file size would have to be bigger anyway, if the strings are to be changed.

[PatrikLundell]

If I was to change the code in a limited way, I'd use wildcards such that generic milk would be defined as "*milk"/"frozen *milk"/etc. and the parsing of the RAWS replacing '*' with the name of the creature in possessive form (i.e."'s") followed by a blank (allowing for very generic milk being called "milk" rather than " milk"). I'd allow this to be overridden both by a [WILDCARD] tag (similar to the current [PREFIX]) and possibly by specific string tag overrides. Purring Maggot would have a [WILDCARD] of "Dwarf" for both milk and cheese. However, it's Toady who'd have to do code changes.

[Saiko Kila]

Eh, I've checked all RAWs, and there are only four species which produce both milk and animal/giant version. I thought there are more. So it is perfectly possible to change it manually without a script, heh. These animals are both kind of camel, kangaroo and tapir. Probably modded versions of RAWs would need more, and they can use more work, but vanilla is pretty easy as it is.

Yes, Toady could think about using some tags which use more intelligent parsing and renaming, as you suggest, especially since he likes these variations. Funny thing with this purring maggot, good that dwarven women don't produce milk, would be confusing.

[PatrikLundell]

Dwarves being mammals, I assume dwarven women lactate while nursing their babies, but its all abstracted, and I don't see much point in simulating it beyond a nursing action for adventure mode offspring once that becomes possible. Only a small number of species have been bred to produce an excess of milk (and I don't believe kangaroos are among those: even milking them would be tricky, as I believe the teats are at the bottom of the pouch).

[Saiko Kila]

I think this is abstracted too much now - when a dwarf woman is in depression and bears a baby, it is dropped down instantly and crawls around, until the mother comes to her senses and picks the baby up. It can take days, even a week, and the baby is still alive and well, before the mother pays attention to it for the first time. It makes life of an overseer easier, but means that the mother is kind of redundant.

I have compared amount of milk bigger kangaroos produce to amount of other animals, and even human females beat the bigger kangaroos in peak daily output. But the giant kangaroos in DF are much bigger, and since kangaroos (no matter size) lactate for longer than humans, and can feed even three different sized children at the same time, I believe that dwarves would find a way to utilise them. But why giant kangaroos (or tapirs) are milk producers in DF, but not for example giant goat mountain or giant goat I cannot fathom.

[Cjenz]

@Saiko Kila:

Bananas: I hack bananas to yield wood and I hack all surface biomes to contain all eligible plants and animals... This means it's only a matter of time before they show up in my embark (which is carefully created [and hacked] to contain 9 biomes, although only 6 is needed to get all boozable plants).

9 biomes in one sounds quite FUN. Any chance of a link to a hacked map which contains one such dwarven playground?

[PatrikLundell]

@Saiko Kila:

Bananas: I hack bananas to yield wood and I hack all surface biomes to contain all eligible plants and animals... This means it's only a matter of time before they show up in my embark (which is carefully created [and hacked] to contain 9 biomes, although only 6 is needed to get all boozable plants).

9 biomes in one sounds quite FUN. Any chance of a link to a hacked map which contains one such dwarven playground?

The world: https://www.dropbox.com/s/mgtay25ovjnuia0/Newhope%202.zip?dl=0
You'd embark in the north/center region (i.e. inside the "ocean" in the single good desert tile (towards the southern end of the area). Once your focus is in that world tile, you'd run this DFHack script:

Spoiler (click to show/hide)

Code: [Select]

function regionembark ()
  --  [Y], [X] for split_x, [X], [Y] for split_y
  local split = {[0] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                        [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 47, y = 47},
                        [8] = {x = 23, y = 23}, [9] = {x = 0, y = 0}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
         [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
                 [1] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                        [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 47, y = 47},
                        [8] = {x = 23, y = 23}, [9] = {x = 0, y = 0}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
   [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[2] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                        [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 47, y = 47},
                        [8] = {x = 23, y = 23}, [9] = {x = 0, y = 0}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
   [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[3] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                        [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 47, y = 47},
                        [8] = {x = 23, y = 23}, [9] = {x = 0, y = 0}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
   [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[4] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                        [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 47, y = 47},
                        [8] = {x = 23, y = 23}, [9] = {x = 0, y = 0}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
   [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[5] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                        [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 47, y = 47},
                        [8] = {x = 23, y = 23}, [9] = {x = 0, y = 0}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
   [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[6] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                        [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 47, y = 47},
                        [8] = {x = 23, y = 23}, [9] = {x = 0, y = 0}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
   [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[7] = {[0] = {x = 0, y = 47}, [1] = {x = 0, y = 47}, [2] = {x = 0, y = 47}, [3] = {x = 0, y = 47},
                        [4] = {x = 0, y = 47}, [5] = {x = 0, y = 47}, [6] = {x = 0, y = 47}, [7] = {x = 23, y = 23},
                        [8] = {x = 23, y = 23}, [9] = {x = 23, y = 23}, [10] = {x = 0, y = 47}, [11] = {x = 0, y = 47},
   [12] = {x = 0, y = 47}, [13] = {x = 0, y = 47}, [14] = {x = 0, y = 47}, [15] = {x = 0, y = 47}},
[8] = {[0] = {x = 0, y = 47}, [1] = {x = 0, y = 47}, [2] = {x = 0, y = 47}, [3] = {x = 0, y = 47},
                        [4] = {x = 0, y = 47}, [5] = {x = 0, y = 47}, [6] = {x = 0, y = 47}, [7] = {x = 0, y = 47},
                        [8] = {x = 12, y = 36}, [9] = {x = 0, y = 47}, [10] = {x = 0, y = 47}, [11] = {x = 0, y = 47},
   [12] = {x = 0, y = 47}, [13] = {x = 0, y = 47}, [14] = {x = 0, y = 47}, [15] = {x = 0, y = 47}},
[9] = {[0] = {x = 0, y = 47}, [1] = {x = 0, y = 47}, [2] = {x = 0, y = 47}, [3] = {x = 0, y = 47},
                        [4] = {x = 0, y = 47}, [5] = {x = 0, y = 47}, [6] = {x = 0, y = 47}, [7] = {x = 23, y = 23},
                        [8] = {x = 23, y = 23}, [9] = {x = 23, y = 23}, [10] = {x = 0, y = 47}, [11] = {x = 0, y = 47},
   [12] = {x = 0, y = 47}, [13] = {x = 0, y = 47}, [14] = {x = 0, y = 47}, [15] = {x = 0, y = 47}},
[10] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                         [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 0, y = 47},
                         [8] = {x = 0, y = 47}, [9] = {x = 0, y = 47}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
    [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[11] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                         [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 0, y = 47},
                         [8] = {x = 0, y = 47}, [9] = {x = 0, y = 47}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
    [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[12] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                         [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 0, y = 47},
                         [8] = {x = 0, y = 47}, [9] = {x = 0, y = 47}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
    [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[13] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                         [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 0, y = 47},
                         [8] = {x = 0, y = 47}, [9] = {x = 0, y = 47}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
    [12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[14] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                         [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 0, y = 47},
                         [8] = {x = 0, y = 47}, [9] = {x = 0, y = 47}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
[12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}},
[15] = {[0] = {x = 47, y = 47}, [1] = {x = 47, y = 47}, [2] = {x = 47, y = 47}, [3] = {x = 47, y = 47},
                         [4] = {x = 47, y = 47}, [5] = {x = 47, y = 47}, [6] = {x = 47, y = 47}, [7] = {x = 0, y = 47},
                         [8] = {x = 0, y = 47}, [9] = {x = 0, y = 47}, [10] = {x = 0, y = 0}, [11] = {x = 0, y = 0},
[12] = {x = 0, y = 0}, [13] = {x = 0, y = 0}, [14] = {x = 0, y = 0}, [15] = {x = 0, y = 0}}}
 
  --  [Y], [X]
  local biome_corner = {[0] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
                        [1] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [2] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [3] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [4] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [5] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [6] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [7] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [8] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                               [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
        [9] = {[0] = 2, [1] = 2, [2] = 2, [3] = 2, [4] = 2, [5] = 2, [6] = 2, [7] = 2,
                               [8] = 3, [9] = 3, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
       [10] = {[0] = 2, [1] = 2, [2] = 2, [3] = 2, [4] = 2, [5] = 2, [6] = 2, [7] = 2,
                               [8] = 3, [9] = 3, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
       [11] = {[0] = 2, [1] = 2, [2] = 2, [3] = 2, [4] = 2, [5] = 2, [6] = 2, [7] = 2,
                               [8] = 3, [9] = 3, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
       [12] = {[0] = 2, [1] = 2, [2] = 2, [3] = 2, [4] = 2, [5] = 2, [6] = 2, [7] = 2,
                               [8] = 3, [9] = 3, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
       [13] = {[0] = 2, [1] = 2, [2] = 2, [3] = 2, [4] = 2, [5] = 2, [6] = 2, [7] = 2,
                               [8] = 3, [9] = 3, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
       [14] = {[0] = 2, [1] = 2, [2] = 2, [3] = 2, [4] = 2, [5] = 2, [6] = 2, [7] = 2,
                               [8] = 3, [9] = 3, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
       [15] = {[0] = 2, [1] = 2, [2] = 2, [3] = 2, [4] = 2, [5] = 2, [6] = 2, [7] = 2,
                               [8] = 3, [9] = 3, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3}}
 
  --  [Y], [X] for biome_x, [X], [Y] for biome_y
  local biome = {[0] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
                 [1] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
     [2] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
[3] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
[4] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
[5] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
[6] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
[7] = {[0] = 0, [1] = 0, [2] = 0, [3] = 0, [4] = 0, [5] = 0, [6] = 0, [7] = 0,
                        [8] = 0, [9] = 0, [10] = 0, [11] = 0, [12] = 0, [13] = 0, [14] = 0, [15] = 0},
[8] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
[9] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
[10] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
[11] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
[12] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
[13] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
[14] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1},
[15] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1,
                        [8] = 1, [9] = 1, [10] = 1, [11] = 1, [12] = 1, [13] = 1, [14] = 1, [15] = 1}}
 
  --  [Y], [X]
  local biome_ref =
                {[0] = {[0] = 7, [1] = 7, [2] = 7, [3] = 7, [4] = 7, [5] = 7, [6] = 7, [7] = 8,
                        [8] = 8, [9] = 8, [10] = 9, [11] = 9, [12] = 9, [13] = 9, [14] = 9, [15] = 9},
                 [1] = {[0] = 7, [1] = 7, [2] = 7, [3] = 7, [4] = 7, [5] = 7, [6] = 7, [7] = 8,
                        [8] = 8, [9] = 8, [10] = 9, [11] = 9, [12] = 9, [13] = 9, [14] = 9, [15] = 9},
     [2] = {[0] = 7, [1] = 7, [2] = 7, [3] = 7, [4] = 7, [5] = 7, [6] = 7, [7] = 8,
                        [8] = 8, [9] = 8, [10] = 9, [11] = 9, [12] = 9, [13] = 9, [14] = 9, [15] = 9},
[3] = {[0] = 7, [1] = 7, [2] = 7, [3] = 7, [4] = 7, [5] = 7, [6] = 7, [7] = 8,
                        [8] = 8, [9] = 8, [10] = 9, [11] = 9, [12] = 9, [13] = 9, [14] = 9, [15] = 9},
[4] = {[0] = 7, [1] = 7, [2] = 7, [3] = 7, [4] = 7, [5] = 7, [6] = 7, [7] = 8,
                        [8] = 8, [9] = 8, [10] = 9, [11] = 9, [12] = 9, [13] = 9, [14] = 9, [15] = 9},
[5] = {[0] = 7, [1] = 7, [2] = 7, [3] = 7, [4] = 7, [5] = 7, [6] = 7, [7] = 8,
                        [8] = 8, [9] = 8, [10] = 9, [11] = 9, [12] = 9, [13] = 9, [14] = 9, [15] = 9},
[6] = {[0] = 7, [1] = 7, [2] = 7, [3] = 7, [4] = 7, [5] = 7, [6] = 7, [7] = 8,
                        [8] = 8, [9] = 8, [10] = 9, [11] = 9, [12] = 9, [13] = 9, [14] = 9, [15] = 9},
[7] = {[0] = 4, [1] = 4, [2] = 4, [3] = 4, [4] = 4, [5] = 4, [6] = 4, [7] = 7,
                        [8] = 8, [9] = 9, [10] = 6, [11] = 6, [12] = 6, [13] = 6, [14] = 6, [15] = 6},
[8] = {[0] = 4, [1] = 4, [2] = 4, [3] = 4, [4] = 4, [5] = 4, [6] = 4, [7] = 4,
                        [8] = 5, [9] = 6, [10] = 6, [11] = 6, [12] = 6, [13] = 6, [14] = 6, [15] = 6},
[9] = {[0] = 4, [1] = 4, [2] = 4, [3] = 4, [4] = 4, [5] = 4, [6] = 4, [7] = 1,
                        [8] = 2, [9] = 3, [10] = 6, [11] = 6, [12] = 6, [13] = 6, [14] = 6, [15] = 6},
[10] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 2,
                        [8] = 2, [9] = 2, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
[11] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 2,
                        [8] = 2, [9] = 2, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
[12] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 2,
                        [8] = 2, [9] = 2, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
[13] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 2,
                        [8] = 2, [9] = 2, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
[14] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 2,
                        [8] = 2, [9] = 2, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3},
[15] = {[0] = 1, [1] = 1, [2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 2,
                        [8] = 2, [9] = 2, [10] = 3, [11] = 3, [12] = 3, [13] = 3, [14] = 3, [15] = 3}}
 
  for x = 0, 15 do
    for y = 0, 15 do
  df.global.world.world_data.region_details [0].edges.split_x [x] [y] = split [y] [x]
  df.global.world.world_data.region_details [0].edges.split_y [x] [y] = split [x] [y]
  df.global.world.world_data.region_details [0].edges.biome_corner [x] [y] = biome_corner [y] [x]
  df.global.world.world_data.region_details [0].edges.biome_x [x] [y] = biome [y] [x]
  df.global.world.world_data.region_details [0].edges.biome_y [x] [y] = biome [x] [y]
  df.global.world.world_data.region_details [0].biome [x] [y] = biome_ref [y] [x]
end
  end 
end

regionembark()


The script hacks the mid level tiles to generate a 3*3 area with 9 biomes close to the center of the map, which is the intended embark area. Note that the effects of the script are removed if you move the focus to a different world tile and back (but you can run the script again). It's possible to generate the same kind of multi region embark using the Region Manipulator, but this script predates that tool, as well as does exactly what I want with a single command.

Edit: I screwed up the zip file, and accidentally provided one with a bug report save. I've corrected the link above (the file names differ with a blank character...).

[em312s0n]

I tried the updated script in 47.04 but its giving me a "...\Desktop\DF\Dwarf Fortress 0.47.04/hack/scripts/food.lua:250: Cannot read field BitArray<>.CASTE_COMMON_DOMESTIC: not found.
stack traceback:
        [C]: in metamethod '__index'
        ...\Desktop\DF\Dwarf Fortress 0.47.04/hack/scripts/food.lua:250: in global 'fix_food_needs'
        ...\Desktop\DF\Dwarf Fortress 0.47.04/hack/scripts/food.lua:594: in local 'script_code'
        ...0n\Desktop\DF\Dwarf Fortress 0.47.04\hack\lua\dfhack.lua:680: in function 'dfhack.run_script_with_env'
        (...tail calls...)"

Can you share if you've fixed it? thank you

[PatrikLundell]

I updated the script to handle changed flag names and a weird issue with vermin flags not working as one would think.

Spoiler (click to show/hide)

Code: [Select]

local replace_vermin = false --  If true, all non "fish" vermin are replaced by "real" food
                             --  This also excludes Creepy Crawler (can be butchered),
                             --  Moghopper Juice, and Dwarven Milk/Cheese
                             
--  Bumblebee honey is impossible to obtain in vanilla, and thus does bumblebee mead remain
--  out of reach. Feather trees are bugged so you can't get any eggs, and thus not get at
--  the egg white or yolk (despite the trade depot being contaminated by feather tree egg
--  yolk after the elves have visited).
--
local bumblebee = -1
local feather_tree = -1

for i, creature in ipairs (df.global.world.raws.creatures.all) do
  if creature.creature_id == "BUMBLEBEE" then
    bumblebee = i
    break
  end
end

for i, plant in ipairs (df.global.world.raws.plants.all) do
  if plant.id == "FEATHER" then
    feather_tree = i
    break
  end
end

local min_butcher_size = --  Data taken from http://www.bay12forums.com/smf/index.php?topic=78108.0
                         --  The values are shifted down one order of magnitude to match the ingame (rather than the raw) unit.
  {["MUSCLE"] =          190,  --  Meat in the reference
   ["FAT"] =             190,  --  Haven't seen any preferences for it
   ["TALLOW"] =          190,  --  i.e. rendered fat. Haven't seen any preferences for it, though
   ["SKIN"] =            190,  --  Inedible, but here for completeness
   ["BONE"] =            200,  --  Inedible
   ["INTESTINES"] =      500,
   ["BRAIN"] =          1000,
   ["LUNG"] =           1000,
   ["LIVER"] =          1000,
   ["STOMACH"] =        1000,  --  Called tripe as food
   ["GUT"] =            1000,  --  ###Not in reference. Guessing it's the same most others.
   ["GIZZARD"] =        1000,  --  Not in reference. Wiki claims size similar to brain and liver.
                               --    Wiki DF2014:Prepared_organs does not list Gut or Gizzard.
   ["NERVE"] =          1500,  --  ###Name not checked. Inedible anyway
   ["HOOF"] =           1500,  --  Inedible
   ["HEART"] =          2000,
   ["PANCREAS"] =       2000,  --  Called sweetbread as food
   ["SPLEEN"] =         2000,
   ["KIDNEY"] =         2000,
   ["HORN"] =           2000,  --  Inedible
   ["CARTILAGE"] =     20000,  --  Inedible
   ["HAIR"] =          20000,  --  Inedible
   ["EYE"] =           50000,
   ["TOOTH"] =       2500000,  --  Inedible
   ["CHEESE"] =            0}  --  Not a butcher product, and thus no size relation, but exists as food preferences.

local butcher_edible =
  {["MUSCLE"] =         true,  --  Meat in the reference
   ["FAT"] =           false,  --  Haven't seen any preferences for it
   ["TALLOW"] =        false,  --  i.e. rendered fat. Haven't seen any preferences for it, though
   ["SKIN"] =          false,  --  Inedible, but here for completeness
   ["BONE"] =          false,  --  Inedible
   ["INTESTINES"] =     true,
   ["BRAIN"] =          true,
   ["LUNG"] =           true,
   ["LIVER"] =          true,
   ["STOMACH"] =        true,  --  Called tripe as food
   ["GUT"] =            true,  --  ###Not in reference. Guessing it's the same most others.
   ["GIZZARD"] =        true,  --  Not in reference. Wiki claims size similar to brain and liver.
                               --    Wiki DF2014:Prepared_organs does not list Gut or Gizzard.
   ["NERVE"] =         false,  --  Inedible
   ["HOOF"] =          false,  --  Inedible
   ["HEART"] =          true,
   ["PANCREAS"] =       true,  --  Called sweetbread as food
   ["SPLEEN"] =         true,
   ["KIDNEY"] =         true,
   ["HORN"] =          false,  --  Inedible
   ["CARTILAGE"] =     false,  --  Inedible
   ["HAIR"] =          false,  --  Inedible
   ["EYE"] =            true,
   ["TOOTH"] =         false,  --  Inedible
   ["CHEESE"] =        false}  --  Handled separately, like milk
   

local available_plant = {}
local available_creature = {}

-----------------------------

function item_type_of (matinfo)
  if type (matinfo) == "number" then
    if df.global.world.raws.creatures.all [matinfo].flags.VERMIN_FISH then
      return df.item_type.FISH
     
    else
      return df.item_type.MEAT
    end
   
  else
    if matinfo.material.flags.MEAT then
      return df.item_type.MEAT
     
    elseif matinfo.material.flags.ALCOHOL then
      return df.item_type.DRINK
     
    elseif matinfo.material.flags.POWDER_MISC then
      return df.item_type.POWDER_MISC
     
    elseif matinfo.material.flags.LIQUID_MISC then
      return df.item_type.LIQUID_MISC

    elseif matinfo.material.flags.STRUCTURAL_PLANT_MAT then
      return df.item_type.PLANT
     
    elseif matinfo.material.flags.SEED_MAT then
      return df.item_type.SEEDS
     
    elseif matinfo.material.flags.LEAF_MAT then
      return df.item_type.PLANT_GROWTH

    elseif matinfo.material.flags.CHEESE then
      return df.item_type.CHEESE
   
    else
      dfhack.printerr ("item_type_of encountered item it couldn't classify: " .. matinfo.material.id)
    end
  end
end

-----------------------------

function is_resident (unit)
  return not dfhack.units.isCitizen (unit) and
         unit.civ_id == df.global.ui.civ_id and
         not unit.flags1.marauder and
         not unit.flags1.tame and
         not unit.flags2.visitor and
         not unit.flags1.merchant and
         not unit.flags1.forest and
         not unit.flags1.diplomat
end

-----------------------------

function replacement_string (preference, replacement, unit)
  local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
 
  if preference.item_type == df.item_type.DRINK or
     preference.item_type == df.item_type.LIQUID_MISC then  --  The state in the preferences seems locked to Solid
    local material = dfhack.matinfo.decode (preference.mattype, preference.matindex)
    local man = ""
   
    if material.creature and
       material.creature.flags.HAS_ANY_INTELLIGENT_LEARNS then
      man = " man "
    end
   
    return material.material.state_name.Liquid ..
           " with " .. replacement.material.state_name.Liquid .. man ..
           " on " .. dfhack.TranslateName (unit.name, true)
 
  elseif preference.matindex == -1 then
    local old_str = df.global.world.raws.creatures.all [preference.mattype].name [0]
    local new_str = ""
     
    if type (replacement) == "number" then
      new_str = df.global.world.raws.creatures.all [replacement].name [0]
         
    else       
      if replacement.material.prefix == "" then
        new_str = replacement.material.state_name.Solid
         
      else
        new_str = replacement.material.prefix .. " " .. replacement.material.state_name.Solid
      end
    end
     
    return old_str .. " with " .. tostring (new_str) .. " on " .. dfhack.TranslateName (unit.name, true)
     
  else
    if old_mat.mode == "creature"  then
      local old_str = ""
      local new_str = ""
     
      if old_mat.material.prefix == "" then
        old_str = old_mat.material.state_name.Solid
       
      else
        old_str =  old_mat.material.prefix .. " " .. old_mat.material.state_name.Solid
      end
     
      if type (replacement) == "number" then
        new_str = df.global.world.raws.creatures.all [replacement].name [0]
         
      else       
        if replacement.material.prefix == "" then
          new_str = replacement.material.state_name.Solid
         
        else
          new_str = replacement.material.prefix .. " " .. replacement.material.state_name.Solid
        end
      end
     
      return old_str .. " with " .. tostring (new_str) .. " on " .. dfhack.TranslateName (unit.name, true)
     
    else
      local old_str = ""
      local new_str = ""
     
      if not old_mat then
        old_str = df.global.world.raws.plants.all [preference.mattype].name
       
      elseif  old_mat.material.prefix == "" then
        old_str =  old_mat.material.state_name.Solid
       
      else
        old_str =  old_mat.material.prefix .. " " .. old_mat.material.state_name.Solid
      end
     
      if type (replacement) == "number" then
        new_str = df.global.world.raws.plants.all [replacement].name
         
      else       
        if replacement.material.prefix == "" then
          new_str = replacement.material.state_name.Solid
         
        else
          new_str = replacement.material.prefix .. " " .. replacement.material.state_name.Solid
        end
      end
     
      return old_str .. " with " .. tostring (new_str) .. " on " .. dfhack.TranslateName (unit.name, true)
    end
  end
end

-----------------------------

function fix_food_needs ()
--  printall (dfhack.matinfo.find ("PLANT:POD_SWEET:EXTRACT"))
--  printall (dfhack.matinfo.find ("CREATURE:COW:CHEESE"))
  local drinkable = {}  --  Entries will be matinfo structures
  local edible = {}     --  Entries will either be an integer creature index for a whole vermin creature,
                        --  or a matinfo structure
  local rng = dfhack.random.new ()
 
  for i, plant in ipairs (df.global.world.raws.plants.all) do
    available_plant [i] = false
  end
 
  for i, creature in ipairs (df.global.world.raws.creatures.all) do
    available_creature [i] = (creature.flags.HAS_ANY_COMMON_DOMESTIC  or             --  Some of them don't exist in the wild
                              creature.flags.BIOME_RIVER_TEMPERATE_FRESHWATER or     --  Don't know how to check availability
                              creature.flags.BIOME_RIVER_TEMPERATE_BRACKISHWATER or  --  -"-
                              creature.flags.BIOME_RIVER_TEMPERATE_SALTWATER or      --  -"-
                              creature.flags.BIOME_RIVER_TROPICAL_FRESHWATER or      --  -"-
                              creature.flags.BIOME_RIVER_TROPICAL_BRACKISHWATER or   --  -"-
                              creature.flags.BIOME_RIVER_TROPICAL_SALTWATER)         --  -"-
  end
 
  for i, region in ipairs (df.global.world.world_data.regions) do
    for k, pop in ipairs (region.population) do
      if pop.type == df.world_population_type.Animal or
         pop.type == df.world_population_type.Vermin or
         pop.type == df.world_population_type.VerminInnumerable or
         pop.type == df.world_population_type.ColonyInsect then
        available_creature [pop.race] = true
       
      elseif pop.type == df.world_population_type.Tree or
             pop.type == df.world_population_type.Grass or
             pop.type == df.world_population_type.Bush then
        available_plant [pop.plant] = true
      end
    end
  end
 
  for i, region in ipairs (df.global.world.world_data.underground_regions) do
    for k, pop in ipairs (region.feature_init.feature.population) do
      if pop.type == df.world_population_type.Animal or
         pop.type == df.world_population_type.Vermin or
         pop.type == df.world_population_type.VerminInnumerable or
         pop.type == df.world_population_type.ColonyInsect then
        available_creature [pop.race] = true
       
      elseif pop.type == df.world_population_type.Tree or
             pop.type == df.world_population_type.Grass or
             pop.type == df.world_population_type.Bush then
        available_plant [pop.plant] = true
      end
    end
  end
 
  for i, plant in ipairs (df.global.world.raws.plants.all) do
    if available_plant [i] and
       not plant.flags.GRASS then  -- Grasses can't be harvested in any way, but evil ones are made of meat...
      for k, material in ipairs (plant.material) do
        if (material.flags.ALCOHOL_PLANT or
            material.flags.LIQUID_MISC_PLANT) and
           material.flags.EDIBLE_RAW then
          table.insert (drinkable, dfhack.matinfo.find ("PLANT:" .. plant.id .. ":" .. material.id))
         
        elseif not material.flags.LIQUID_MISC_PLANT and  --  Oils that can't be drunk raw don't seem to be cooked by DF.
               (material.flags.EDIBLE_RAW or
                material.flags.EDIBLE_COOKED) and
               plant.index ~= feather_tree then  --  Feather tree eggs are bugged...
          table.insert (edible, dfhack.matinfo.find ("PLANT:" .. plant.id .. ":" .. material.id))
        end
      end
    end
  end
 
  for i, creature in ipairs (df.global.world.raws.creatures.all) do
    if not creature.flags.GENERATED and  --  Exclude FBs, demons, etc.
       not creature.flags.HAS_ANY_INTELLIGENT_LEARNS and
       available_creature [i] then
      local vermin = creature.flags.VERMIN_EATER or
                     creature.flags.VERMIN_GROUNDER or
                     creature.flags.VERMIN_ROTTER or
                     creature.flags.VERMIN_SOIL or
                     creature.flags.VERMIN_SOIL_COLONY or
                     creature.flags.VERMIN_FISH
                     
      for k, caste in ipairs (creature.caste) do
        if (caste.flags.VERMIN_NOROAM or
            caste.flags.VERMIN_NOTRAP or
            caste.flags.VERMIN_NOFISH or
            caste.flags.VERMIN_HATEABLE or
            caste.flags.VERMIN_MICRO) and
           not creature.flags.HAS_ANY_INTELLIGENT_LEARNS then
          vermin = true
          break
        end
      end
           
      if vermin then
        if not replace_vermin or
--           not creature.caste [0].flags.NOT_BUTCHERABLE or  --  Would allow Creepy Crawler
           (creature.caste [0].flags.FISHITEM and
            #creature.caste [0].extracts.extract_mat == 0) then  --  Moghopper has FISHITEM set, but can't be eaten
          local can_be_eaten = false

          for k, material in ipairs (creature.material) do
            if material.id == "MUSCLE" then
              can_be_eaten = true
           
            elseif material.id == "MILK" then
              table.insert (drinkable, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
           
            elseif material.id == "CHEESE" then
              table.insert (edible, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
            end
          end
       
          if can_be_eaten then  --  Weed out stuff like e.g. fire snakes
            table.insert (edible, i)
          end
        end
       
      else
        local butcherable = true
                 
        for k, str in ipairs (creature.raws) do
          if str [0] == "[NOT_BUTCHERABLE]" then
            butcherable = false
            break
          end
        end
       
        if min_butcher_size ["MUSCLE"] > creature.adultsize then
          butcherable = false  --  Technically possibly, but nothing edible resulting
        end
               
        for k, material in ipairs (creature.material) do
          if material.id == "MILK" then
              table.insert (drinkable, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
           
          elseif material.id == "CHEESE" then
              table.insert (edible, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))
           
          elseif butcherable and
                 not creature.flags.HAS_ANY_INTELLIGENT_LEARNS and  --### Is this the correct criterion?
                 min_butcher_size [material.id] and
                 min_butcher_size [material.id] <= creature.adultsize and
                 butcher_edible [material.id] then
            table.insert (edible, dfhack.matinfo.find ("CREATURE:" .. creature.creature_id .. ":" .. material.id))           
          end   
        end
      end
    end
  end
 
--  dfhack.println (#drinkable, #edible)
 
  for i, unit in ipairs (df.global.world.units.all) do
    if (dfhack.units.isCitizen (unit) or
        is_resident (unit)) and
       dfhack.units.isAlive (unit) and
       unit.status.current_soul then
      for k, preference in ipairs (unit.status.current_soul.preferences) do
        if preference.active then
          if preference.type == df.unit_preference.T_type.LikeFood then         
            local material = dfhack.matinfo.decode (preference.mattype, preference.matindex)
           
            if preference.matindex ~= -1 and
               (material.mode == "plant" or
                material.mode == "creature") then
              if preference.item_type == df.item_type.DRINK or
                 preference.item_type == df.item_type.LIQUID_MISC then  --  The state in the preferences seems locked to Solid
                if material.mode == "creature"  then
                dfhack.println (df.global.world.raws.creatures.all [preference.matindex].creature_id, i, dfhack.TranslateName (unit.name, false))
                  if not available_creature [preference.matindex] or
                     preference.matindex == bumblebee then
                    local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
                    local rng_number = rng:random (#drinkable - 1) + 1  --  To get it into the Lua vector range
                   
                    while preference.item_type == df.item_type.DRINK and
                          not drinkable [rng_number].material.flags.ALCOHOL do
                      rng_number = rng:random (#drinkable - 1) + 1
                    end
                   
                    dfhack.println ("Replacing unavailable " .. replacement_string (preference, drinkable [rng_number], unit))
                   
                    preference.mattype = drinkable [rng_number].type
                    preference.matindex = drinkable [rng_number].index                                               
                    preference.item_type = item_type_of (drinkable [rng_number])
                    preference.item_subtype = drinkable [rng_number].subtype
                  end
               
                else
                  if not available_plant [preference.matindex] then
                    local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
                    local rng_number = rng:random (#drinkable - 1) + 1  --  To get it into the Lua vector range
                   
                    while preference.item_type == df.item_type.DRINK and
                          not drinkable [rng_number].material.flags.ALCOHOL do
                      rng_number = rng:random (#drinkable - 1) + 1
                    end
                   
                    dfhack.println ("Replacing unavailable " .. replacement_string (preference, drinkable [rng_number], unit))
                    preference.mattype = drinkable [rng_number].type
                    preference.matindex = drinkable [rng_number].index
                    preference.item_type = item_type_of (drinkable [rng_number])                   
                    preference.item_subtype = drinkable [rng_number].subtype
                  end
                end
       
              else  --  Food
                if material.mode == "creature" then
                  local butcherable = true
                  local too_small = false
                 
                  for i, str in ipairs (material.creature.raws) do
                    if str [0] == "[NOT_BUTCHERABLE]" then
                      butcherable = false
                      break
                    end
                  end
       
                  if min_butcher_size [material.material.id] then
                    if min_butcher_size [material.material.id] > material.creature.adultsize then
                      too_small = true
                     
                      if min_butcher_size ["MUSCLE"] > material.creature.adultsize then
                        butcherable = false  --  Technically possibly, but nothing edible resulting
                      end
                    end
         
                  else
                    dfhack.printerr ("fix_food_needs found unexpected animal food preference (continuing): " .. material.material.id)
                  end
                 
                  if not available_creature [preference.matindex] or
                     (replace_vermin and
                      df.global.world.raws.creatures.all [preference.matindex].flags.any_vermin and
                     (not df.global.world.raws.creatures.all [preference.matindex].caste [0].flags.FISHITEM or
                      #df.global.world.raws.creatures.all [preference.matindex].caste [0].extracts.extract_mat > 0)) then
                    local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                    dfhack.println ("Replacing non existent " .. replacement_string (preference, edible [rng_number], unit))
                   
                    if type (edible [rng_number]) == "number" then
                      preference.mattype = edible [rng_number]
                      preference.matindex = -1
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = -1  --###
                     
                    else
                      preference.mattype = edible [rng_number].type
                      preference.matindex = edible [rng_number].index
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = edible [rng_number].subtype
                   end
                                                         
                  elseif not butcherable then
                    local vermin = material.creature.flags.VERMIN_EATER or
                                   material.creature.flags.VERMIN_GROUNDER or
                                   material.creature.flags.VERMIN_ROTTER or
                                   material.creature.flags.VERMIN_SOIL or
                                   material.creature.flags.VERMIN_SOIL_COLONY or
                                   material.creature.flags.VERMIN_FISH
                     
                    for l, caste in ipairs (material.creature.caste) do
                      if (caste.flags.VERMIN_NOROAM or
                          caste.flags.VERMIN_NOTRAP or
                          caste.flags.VERMIN_NOFISH or
                          caste.flags.VERMIN_HATEABLE or
                          caste.flags.VERMIN_MICRO) and
                         not material.creature.flags.HAS_ANY_INTELLIGENT_LEARNS then
                        vermin = true
                        break
                      end
                    end
                   
                    if vermin then
                      dfhack.println ("Replacing vermin part " .. replacement_string (preference, preference.matindex, unit))
                      preference.mattype = preference.matindex
                      preference.matindex = -1
                      preference.item_subtype = -1  --###
                     
                    else
                      local old_mat = dfhack.matinfo.decode (preference.mattype, preference.matindex)
                      local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                      dfhack.println ("Replacing unbutcherable " .. replacement_string (preference, edible [rng_number], unit))
                   
                      if type (edible [rng_number]) == "number" then
                        preference.mattype = edible [rng_number]
                        preference.matindex = -1
                        preference.item_type = item_type_of (edible [rng_number])
                        preference.item_subtype = -1  --###
                     
                      else
                        preference.mattype = edible [rng_number].type
                        preference.matindex = edible [rng_number].index
                        preference.item_type = item_type_of (edible [rng_number])
                        preference.item_subtype = edible [rng_number].subtype
                      end
                    end
                   
                  elseif too_small then
                    for l, mat in ipairs (material.creature.material) do
                      if mat.id == "MUSCLE" then
                        local material = dfhack.matinfo.find ("CREATURE:" .. material.creature.creature_id .. ":MUSCLE")
                       
                        dfhack.println ("Replacing unobtainable " .. replacement_string (preference, material, unit))

                        if not material then
                          dfhack.printerr ("Replacement failed", preference.mattype, preference.matindex)
                       
                        else
                          preference.mattype = material.type
                          preference.matindex = material.index
                          preference.item_subtype = material.subtype
                        end
                     
                        break
                      end
                    end
                  end
                 
                else
                  if not available_plant [preference.matindex] then
                    local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                    dfhack.println ("Replacing unavailable " .. replacement_string (preference, edible [rng_number], unit))
                   
                    if type (edible [rng_number]) == "number" then
                      preference.mattype = edible [rng_number]
                      preference.matindex = -1
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = -1  --###
                     
                    else
                      preference.mattype = edible [rng_number].type
                      preference.matindex = edible [rng_number].index
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = edible [rng_number].subtype
                    end
                                     
                  elseif material.matindex == feather_tree then
                    local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
                    dfhack.println ("Replacing unobtainable " .. replacement_string (preference, edible [rng_number], unit))
                   
                    if type (edible [rng_number]) == "number" then
                      preference.mattype = edible [rng_number]
                      preference.matindex = -1
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = -1  --###
                     
                    else
                      preference.mattype = edible [rng_number].type
                      preference.matindex = edible [rng_number].index
                      preference.item_type = item_type_of (edible [rng_number])
                      preference.item_subtype = edible [rng_number].subtype
                    end
                  end
                end
              end
             
            elseif not available_creature [preference.mattype] or
                   (replace_vermin and
                    df.global.world.raws.creatures.all [preference.mattype].flags.any_vermin and
                     (not df.global.world.raws.creatures.all [preference.mattype].caste [0].flags.FISHITEM or
                      #df.global.world.raws.creatures.all [preference.mattype].caste [0].extracts.extract_mat > 0)) then
              local unavailable = "unavailable "
              local rng_number = rng:random (#edible - 1) + 1  --  To get it into the Lua vector range
                   
              if available_creature [preference.mattype] then
                unavailable = "vermin "
              end
             
              dfhack.println ("Replacing " .. unavailable .. replacement_string (preference, edible [rng_number], unit))
                   
              if type (edible [rng_number]) == "number" then
                preference.mattype = edible [rng_number]
                preference.matindex = -1
                preference.item_type = item_type_of (edible [rng_number])
                preference.item_subtype = -1  --###
                     
              else
                preference.mattype = edible [rng_number].type
                preference.matindex = edible [rng_number].index
                preference.item_type = item_type_of (edible [rng_number])
                preference.item_subtype = edible [rng_number].subtype
              end
            end
          end
        end
      end
    end
  end
end

fix_food_needs ()


[em312s0n]

Awesome as always thanks. On another note ive just found that the workflow plugin can automate brewing of specific alcohol.

I first made a repeating brew from plant task from the still:

Spoiler (click to show/hide)

alt A to specify material then esc to set:

Spoiler (click to show/hide)

Alt W creates the workflow restriction and it lists the possible products so choose dwarven wine:

Spoiler (click to show/hide)

and it creates the restriction

Spoiler (click to show/hide)

you can just change the range to fit your fort's needs shift R:

Spoiler (click to show/hide)

now it will queue up the order when needed to your specific range so you can just set it then forget it:

Spoiler (click to show/hide)

Just posting it here just in case someone finds it useful

You can't do this with prepared foods sadly. I tried. Workflow can create the restriction but the building cant attach the task to the restriction. I think it has something to do with meals using multiple materials or maybe because the kitchen really only outputs roasts, stews etc not like the still where it outputs dwarven rum, beer, sewer brew, etc depending on the input material.

[PatrikLundell]

I don't know anything specific about Workflow, but it's definitely possible for a script to specify the ingredients to use for specific kitchen jobs. A restriction is that the first ingredient has to be solid.

[em312s0n]

I don't know anything specific about Workflow, but it's definitely possible for a script to specify the ingredients to use for specific kitchen jobs. A restriction is that the first ingredient has to be solid.

Sorry when I wrote restriction I meant the workflow constraint(maintain x amount of y type of items). restriction is just a term that I use in my head when I use workflow hehe.

So what I meant was I could create a workflow constraint saying "maintain 40-50 roasts with a plump helmet as ingredient":

Spoiler (click to show/hide)

and I can have the kitchen create an order specifying to create a roast with a plump helmet as ingredient with alt A

Spoiler (click to show/hide)

this has 2 plump helmets as ingredients but the 4th ingredient will always be the name of the roast

but workflow wouldnt link the order with the constraint:

Spoiler (click to show/hide)

If you created a workflow constraint prior to creating the order it would automatically show up here under wokrflow constraints

If I hit shift A.
I was hoping this to say "roast of plump helmet so that it would be linked with the workflow constraint"

on that example it would just make plump helmet roasts regardless of whether its within the set range or not.

Spoiler (click to show/hide)