Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Putnam]

...the reason for the rename is because it did not mean what we thought it meant and using it to mean "dead" is incorrect so it should be replaced in anything that assumes that having that flag be "true" must mean that unit is dead.

[PatrikLundell]

Yes, as Putnam said, just changing scripts to use the same flag (regardless of access method) without checking the logic for why that flag is used isn't a winning strategy. Sometimes the logic turns out to work out as desired, and sometimes it needs to be revised. All the scripts and plugins in DFHack have been examined, and many of them had to have their logic revised.

[lethosor]

Also, flags1[1] is much less readable. Saying you need to "test functions first" is a bad excuse - you can look at the source of isDead here - it's literally just two flag checks that indicate dead units. If you really care about inactive units instead, either use "flags1.inactive" or "not dfhack.units.isActive(unit)".

[Saiko Kila]

Also, flags1[1] is much less readable. Saying you need to "test functions first" is a bad excuse - you can look at the source of isDead here - it's literally just two flag checks that indicate dead units. If you really care about inactive units instead, either use "flags1.inactive" or "not dfhack.units.isActive(unit)".

I do care about inactive units. Flag flags1.inactive/flags1.dead (on) and flags2.killed (off) together are used to determine that the unit just went off the map or is coming in (like migrants, merchants, invaders or animals do). So both flags are useful. If I want to make my script usable in two different versions of DF, then I have to use more direct method of accessing, because of this name change. This is much less pain than editing the script for every version separately, when I change something.

That, and some functions are not available in earlier dfhacks, or do not work like I think they should (like this dfhack.units.getVisibleName() I have problem with now, or dfhack.units.isCitizen() I had problems with).

[lethosor]

You should write your own function, then, or just drop support for older DFHack versions. Never use flags1[1] or anything like that - it's just not readable.

The point of functions is that they'll work correctly across DFHack versions, barring bugs. If you find an issue, reporting it is a better solution than ignoring it and using something that will break later. Of course, new functions don't exist in old DFHack versions, but you can implement your own version of a function in a script if that's an issue.

There is a reported issue with getVisibleName: https://github.com/DFHack/dfhack/issues/1279. I think it has to do with new false identity stuff in 0.44. Not quite sure how to fix it.

[PatrikLundell]

The way I deal with support for multiple, incompatible, versions in scripts is to write version dependent scripts, so if it's older than the new structure I use the old name/location, while if it's new I use the new one. One of the few advantages with scripts not checking semantics legality is this ability. I certainly don't complain about newer DFHack versions updating things to be more correct, like e.g. naming anon fields, or removing a nesting level that's probably artificial.

[lethosor]

0.44.11-beta1 is up: https://github.com/DFHack/dfhack/releases/tag/0.44.11-beta1
Thanks to BenLubar for handling most of the things I forgot to do when publishing the release.

This should fix the getVisibleName issue, I think. If it doesn't, a save that has issues would be very helpful.

[Radipon]

The console seems to hang on startup. Encountered on the x86_win64 build and reproduced with a fresh install.

[scourge728]

I can't actually USE the console, it loads and everything, but typing does nothing.....

[Imperator314]

I can't actually USE the console, it loads and everything, but typing does nothing.....

Same here. I did a 100% fresh install and I still can't figure it out.

[lethosor]

If you could all specify that you're using Windows, that would help.
In any case, we're aware of the issue: https://github.com/DFHack/dfhack/issues/1345

[Imperator314]

If you could all specify that you're using Windows, that would help.

Yes, Windows 10.

[lethosor]

We've found the issue, and 0.44.11-beta2 should be up in an hour or two at https://github.com/dfhack/dfhack/releases to fix it.

Edit: Stonesense is garbage and broke the build. The 64-bit Windows one worked, though, so it's up at https://github.com/DFHack/dfhack/releases/tag/0.44.11-beta2. Just in time for 0.44.12, too! We'll try to get a beta2.1 or something up before moving away from 0.44.11.

[lethosor]

https://github.com/DFHack/dfhack/releases/tag/0.44.11-beta2.1 is up now. 0.44.12 support is coming up, although we have no timeline for that yet.

[lethosor]

0.44.12 build! https://github.com/DFHack/dfhack/releases/tag/0.44.12-alpha1

Unfortunately someone reported a remove-stress issue just before the build was finished. You can fix it by changing "Enraged" to "Enranged" in hack/scripts/remove-stress.lua. (Yes, that's introducing a typo to match another typo. The name in the next release should be fixed.)