Here's the current code. Got an error where the rollResult int value will only go up or down 1 level upon the if-else statements, no matter what the value of penalty or attempts is set to. (Had set randomNumber to 50 during testing, only got the two surrounding it). I hold no doubts it is because I messed something up. I don't know if I messed the casing formatting up, but I get the nagging feeling I had. Have limited time for writing code, so can't track down the bug in time. Plus, a bit of feedback on the current values I have set would be good.
[snip]
I shall attempt to get something up for it by tomorrow.
[/quote]
Assuming you also would like some feedback on the code itself. It's not an attack on you or your coding, only an attempt to improve your style.
Please also note that my last C# programming is about five years back and I did not test the code below, so I might have made some mistakes.
1. Replace the question/answers with a bool-returning function, i.e.
if (ask_bool("Has a design similar to this type been made before (ex. Design is a tank and an armored car has been made)?")) {
which automatically adds the "1 = Yes, 0 = No" part and conversion.
2. Those nested ifs look very confusing, and you run the risk of choosing the wrong research penalty to change later on. Instead, I'd recommend either something like this:
continue_checking = True;
if (continue_checking && not ask_bool("Has a design similar to this type been made before (ex. Design is a tank and an armored car has been made)?")) {
continue_checking = False;
penalty = 5;
}
if (continue_checking && not ask_bool("Has a design of this type been made by a nearby faction before (ex. If design is a tank, has the foe made a tank)?")) {
continue_checking = False;
penalty = 10;
}
etc.
Alternatively, write a for-loop and store the penalty and question in a dictionary. That also cuts down on repeated code. I can't ad-lib that in C#, but in python it'd look something like this:
penalty_questions = {
5: "Has a design similar to this type been made before (ex. Design is a tank and an armored car has been made)?",
10: "Has a design of this type been made by a nearby faction before (ex. If design is a tank, has the foe made a tank)?"
}
for k in sorted(penalty_questions.keys()):
if ask_bool(penalty_questions[k]):
penalty = k
break
3. It's the same for the actual results. The many levels of indentation make it difficult to follow and difficult to change. I'd recommend either a for-loop as above or just assigning the string, then doing the write-out later on, i.e.:
if (roll_result > 100) {
printResult = "The design has no problems.";
} else if (rollResult > 80) {
printResult = "The design has minor problems with its existing components.";
} else etc
}
Console.WriteLine (Convert.ToString(printResult));
writerOutput = printResult;
writeToFile.WriteLine (writerOutput);
Speaking of which, else-if statements.
4. By the way, your random generator returns numbers from 1 to 99 (inclusive).
5. Also, you're regenerating your random number generator every time you reiterate. Don't, just do it once per run.
6. Also, ask for bools, not ints.
7. Also note that you never actually modify attempts.
8. Also note that, once you reattempt a result, you'll always ignore any previous penalty.
Also, do you know that you always have a penalty of at least 5 unless reattempting?
Lastly, I had a fun time (uglily) reimplementing it in python:
import random
def ask_bool(question):
ask_str = question + " [y/n] "
while True:
answer = raw_input(ask_str)
if answer.lower() in ["y", "yes", "1"]:
return True
if answer.lower() in ["n", "no", "0"]:
return False
def get_first_attempt_penalty():
continue_asking = True
questions = [
("Has a design similar to this type been made before (ex. Design is a tank and an armored car has been made)?", 5),
("Has a design of this type been made by a nearby faction before (ex. If design is a tank, has the foe made a tank)?", 10),
("Has a design similar to this type been made by a nearby faction before (ex. Design is a tank and an armored car has been made)?", 15),
("Has a design of this type been made upon the planet before?", 20),
("Has a design similar to this type been made upon the planet before?", 25)
]
worst_penalty = 30
penalty = None
for q in questions:
if ask_bool(q[0]):
penalty = q[1]
break
if penalty is None:
penalty = worst_penalty
return penalty
def print_result(roll_result, outfile=None):
results = {
5: "The design has major problems with all its components.",
15: "The design has minor problems with its new components, and major problems with its other components.",
30: "The design has major problems with its new components, and minor problems with its other components.",
45: "The design has minor problems with all its components.",
60: "The design has minor problems with its new components.",
80: "The design has minor problems with its existing components.",
100: "The design has no problems.",
}
default_result = "The design will not work at all"
for k in sorted(results.keys(), reverse=True):
if roll_result > k:
print(results[k])
if file is not None:
outfile.write(str(roll_result) + ": " + results[k] + "\n")
return
print(default_result)
if file is not None:
outfile.write(str(roll_result) + ": " + default_result + "\n")
attempts_multiply = 5
decision = True
uses = raw_input("How many times have you run this program before? ")
filename = "output" + str(uses) + ".txt"
with open(filename, "w") as outfile:
print("This is the output file name for this run: " + filename)
attempts = 0
weapon_name = raw_input("Please type weapon name: ")
outfile.write(weapon_name + "\n")
while decision:
random_number = random.randint(1, 100)
if attempts == 0:
penalty = get_first_attempt_penalty()
print("Penalty is %s" %penalty)
roll_result = random_number - penalty
else:
attempts_result = attempts * attempts_multiply
roll_result = random_number + attempts_result
print("Result is %s (rolled %s)" %(roll_result, random_number))
print_result(roll_result, outfile)
attempts += 1
decision = ask_bool("Do you want to run this again?")
Author
Topic: Arms Race/Design Bureau Hub/General OOC (Got a Discord Channel now) (Read 110962 times)