Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Manzeenan]

How would I go about creating a reaction that can take any weapon and raise its quality at least one level? Is this even possible?

[Dirst]

How would I go about creating a reaction that can take any weapon and raise its quality at least one level? Is this even possible?

Not with raw modding alone, and I'm not sure there's much of a roleplaying justification for such a reaction: it'd be easier to make a similar item of higher quality than to 'fix' an existing one.

That said, I know you can manipulate wear levels with DFHack, I'm pretty sure quality levels could be overwritten as well.  To invoke DFHack from a reaction, you make a Lua script to do what you want, then set up a reaction-trigger in the onload.init file.

Another way is to register an event in Lua, which would probably be easier to identify the item being upgraded:

Code: (improve-thing.lua) [Select]

local event = require "plugins.eventful"

function improveThing(reaction, unit, input_items, input_reagents, output_items, call_native)
-- code to increment the quality of the output_items
end

event.registerReaction("LUA_HOOK_IMPROVE_THING", improveThing)

[milo christiansen]

Like Dirst said, such a thing would be trivial with some DFHack Lua-fu. It would be hard to target the item if you did it via reaction-trigger, but I think it could be done trivially with Lua hooks (using eventful).

If I had my DF stuff on this computer I would even code it up for you (but I don't, and I won't be home until sometime after tuesday, and then I won't have internet *sigh*).

[Meph]

That would be a very nice script to have. Reaction accepts any weapon that is not masterwork, levels it up one quality level. I'd put that into MasterworkDF in a heartbeat.

[milo christiansen]

Lua hooks are the way to go in most cases, the number of things they can do that are difficult or impossible to do with reaction-trigger is just INSANE. If you can wait a week or two I'll see what I can do

(Don't get me wrong, reaction-trigger is really nice (way better than autoSyndrome anyway), but Lua hooks are more powerful in every possible way)

[Dirst]

That would be a very nice script to have. Reaction accepts any weapon that is not masterwork, levels it up one quality level. I'd put that into MasterworkDF in a heartbeat.

I know that reaction-trigger is 0.40-only (and it doesn't even pass a reference to the reaction's products).  I'm not sure about the eventful Lua hook, but I wouldn't be surprised if it was as well.

Items have a .item_quality characteristic which is a simple integer that can be manipulated.  Something like

Code: [Select]

local event = require "plugins.eventful"

function improveThing(reaction, unit, input_items, input_reagents, output_items, call_native)
    local upgradeItem
    upgradeItem = output_items[1]

    if upgradeItem.item_quality < 6 then
        upgradeItem.item_quality = upgradeItem.item_quality + 1
    end
end

event.registerReaction("LUA_HOOK_IMPROVE_THING", improveThing)

Can't actually run this right now, so be sure to check the output_items object before doing anything drastic.

[Manzeenan]

Didn't expect this much actual feedback, this is awesome 

[kiwiphoenix]

If you don't want to rely on DFHack, you could use the neat little trick given to us in this latest version, Toad be praised.

Spoiler (click to show/hide)

EXAMPLE

[REACTION:REWORK_WEAPON]
   [NAME:hone weapon][ADVENTURE_MODE_ENABLED]
   [REAGENT:item:1:WEAPON:NONE:INORGANIC:NONE]
   [REAGENT:whetstone:1:ROCK:NONE:NONE:NONE][PRESERVE_REAGENT][NO_EDGE_ALLOWED]
   [PRODUCT:95:1:GET_ITEM_DATA_FROM_REAGENT:item:NONE]
   [SKILL:FORGE_WEAPON]

This will use up any stone or metal weapon and produce a copy, potentially with a different quality level.
Now, I personally use this for adventure mode, but you could pretty easily put it into Fortress mode.
It's not guaranteed to raise the quality level, but a low-qual weapon honed by an expert worker will almost certainly improve.

[milo christiansen]

Dirst's code was almost exactly what I would have used (and yes, it will work for 34.11).

Not 100% sure if it will work without testing it, but it should work just fine.

[Manzeenan]

If you don't want to rely on DFHack, you could use the neat little trick given to us in this latest version, Toad be praised.

Spoiler (click to show/hide)

EXAMPLE

[REACTION:REWORK_WEAPON]
   [NAME:hone weapon][ADVENTURE_MODE_ENABLED]
   [REAGENT:item:1:WEAPON:NONE:INORGANIC:NONE]
   [REAGENT:whetstone:1:ROCK:NONE:NONE:NONE][PRESERVE_REAGENT][NO_EDGE_ALLOWED]
   [PRODUCT:95:1:GET_ITEM_DATA_FROM_REAGENT:item:NONE]
   [SKILL:FORGE_WEAPON]

This will use up any stone or metal weapon and produce a copy, potentially with a different quality level.
Now, I personally use this for adventure mode, but you could pretty easily put it into Fortress mode.
It's not guaranteed to raise the quality level, but a low-qual weapon honed by an expert worker will almost certainly improve.

This mightve been what I was initially looking for, does this use a stone and does it work in fort mode? I might make a grindstone workshop that uses oil as a reagent.

[milo christiansen]

ROCK is little stone picked up off the ground in ADV mode, use BOULDER for fortress mode (assuming you want to use a hunk of stone), other than that you will want to replace ADVENTURE_MODE_ENABLED with a BUILDING tag (and unless you want to randomly want to lose your weapon change the "95" to "100").

[Raidau]

The script you are looking for already exists, see here
http://www.bay12forums.com/smf/index.php?topic=135597.0

[milo christiansen]

That effects the currently equipped weapon, not really suitable for use in a fortress mode reaction.

[Raidau]

item-imbue - changes the material of an item with a reaction

[milo christiansen]

We are talking about changing the quality not the material.