Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Rose]

Yeah, legacy won't work at all with it.

[breadman]

A little question about stockpiles and lua.

As I can see in stockflow.lua - stockpile is a bunch of tiles with special flags.
So, if I want to get all items in selected stockpile - I must flow through all "df.global.world.items.all" and compare their position/on_ground with coords of my stockpile' tiles?
There's no easiest way?

There are more optimized ways than the method stockflow uses, but I haven't found an easier one.  Granted, stockflow is also interested in how many spaces are available for new items; most stockpile applications would be happy with a simple list of stored items.

For example, autotrade.cpp goes through a list of IN_PLAY items and checks each one against a list of stockpiles it cares about.  But that check involves comparing the item's coordinates with the stockpile's extents.  It also omits checking the stockpile settings, where stockflow makes a token attempt to ignore stone at the very least.

It should also be possible to to speed things up even more by checking the items vector of each overlapping 16x16 map block, but that requires some calculations.  It may well be worthwhile to add a function that does so to DFHack, where it can become the obvious way to check stockpile contents.  Doing so as an iterator would be ideal, but requires a bit more C++ hackery than I'm familiar with.

There is an unnamed vmethod in df.buildings.xml, and several in df.items.xml; perhaps one of them might be helpful.  Unfortunately, there are also vmethods that sound related, but aren't: stockpile.getFreeCapacity, stockpile.canStoreItem, item.getStockpile, item.isAssignedToStockpile, item.isAssignedToThisStockpile, item.getStockpile2, and probably others.

No, you're right, the layout changed.  In .34, the Done line was always on line 23, and the links started some number of lines from the bottom and worked their way up.  Yes, that means that even the default interface had collisions for certain screen sizes, and stockflow was well positioned up near the main menu.

Now in .40, the Done line is always near the bottom, and the links start just below the main menu and work their way down, paging before they would hit the Done line.  Nicer overall, but subtle enough that you don't notice the difference unless something else is being drawn on top.

... which means it is overwritten by dfhack now:
j: no job selected

overwrites the second link

Yes, that's exactly what pull request #290 fixes.  I'm hoping to see it in the next DFHack release, which might be a bit due to the new fields in 0.40.09 making alignment tricky again.

Until then, feel free to disable stockflow when you need to see the overwritten link(s).

[kr0pper]

most stockpile applications would be happy with a simple list of stored items.

I'm a newbie in c++, so lua is my way.
For example, need to create "cut gems" jobs in linked workshop according stored rough gems in stockpile.

There's a some ways I tested:
1. check stockpile's settings and iterate items in df.global.world.items.other.[TYPE]
2. iterate items from highest to lower id
3. cache items, and use an EventManager.onItemCreated for update cache

checking the items vector of each overlapping 16x16 map block, but that requires some calculations

Interesting. Via dfhack.maps.getTileBlock(coords).items ?
And find items via df.item.find(X) ? I'll try it.

There is an unnamed vmethod in df.buildings.xml

How to call a numbered vmethod in lua? All vmethods in *.h are protected.




ADDED:

checking the items vector of each overlapping 16x16 map block, but that requires some calculations

Brilliant!

A little change in hack/lua/plugins/stockflow.lua.
For test, I replaced function findItemsAtTile by this:

Code: [Select]

function findItemsAtTile2(x, y, z)
local found = {}
local items = dfhack.maps.getTileBlock(x, y, z).items
for _, item_id in ipairs(items) do
local item = df.item.find(item_id)
if item.pos.x == x and item.pos.y == y and
item.pos.z == z and item.flags.on_ground then
found[#found+1] = item
end
end
return found
end

and run check_pile(stockpile, true)

Was: 101 sec.
Now:  1 sec.

Much better now

[expwnent]

expwnent: Before you do extra work, I will try with registration and see how it goes. You mentioned a script a while ago that automatically reads out raws and creates the correct syntax? That would be fine, no need for you to port stuff before I at least have tested the new system. If you and Roses say its amazing, who am I to not us it.

It should be named something obvious in modtools. It might be slightly wrong, but it should be close enough that you can tweak it or just find/replace the things that are wrong so that they're right. Unless I fixed it and forgot about it. I remember having some doubts.

[shaver]

Curious, though I'm probably not the only person to be curious in this way: have people considered asking Toady for him to give the debug symbols for each build to the dfhack team? If he doesn't object to the work then he wouldn't divulge much. A tool could be written to even strip out everything but the structure definitions (so no function names, f.e.) to restrict it further. (I think so, at least. For Linux and OS X it's definitely possible, windows could be trickier, but the structure defs should be the same or determinable given the information there.)

[Satlan_Leng]

How long till the update for 40.09? Got my taste of DFhack with 40.08 but dwarfs that wouldn't marry killed the fortress(migrants stopped due to dead civ, king and all dwarfs single in fortress, no babies)

[Eko]

palu, Meph -

Thanks for your suggestions.  I still think I want to explore a binary patch or something to enable building over water similar to how building over magma is handled right now.  I'll build out the workshops and test using the hermit needs water for now, though.  I really want a way to build over an AIR, EMPTY tile, but it invalidates the building area.  If I can change that, then with the outdoor only script and a small change to test for water, that would work too.

[Quietust]

There is an unnamed vmethod in df.buildings.xml

How to call a numbered vmethod in lua? All vmethods in *.h are protected.

If vmethods are unnamed, then it means we don't know what they do (and, in some cases, what parameters they take), so attempting to call them could just make DF crash. Experimenting with unnamed vmethods from DFHack is also completely pointless - if you want to figure out what it does and how it's used, you disassemble the entire game (e.g. in IDA Pro) and then analyze the vmethod code directly (and, if possible, track down and identify the places that call it).

Besides, there's no reason why Toady would put a stockpile-specific operation in a virtual method available within the base class - he'd put it as a non-virtual method directly within stockpile itself (which I'm pretty sure is what he's already doing).

[expwnent]

Meph: Let me know if you have trouble with the conversion script. It's probably a lot easier for me to tweak it than for you to manually do 500 registrations or however many there are.

[PotatoHaulerBlu]

keep up the good work perhaps work on the overlay problems too because it is fun to have. anyway good work

[Euius]

So I've identified  those annoying (to me, anyways) leaf/fruit circles under trees as spatter structures in block_events, but deleting the structures (with erase()) does nothing, they're still quite visible.

Where else might these be defined?

[Meph]

Meph: Let me know if you have trouble with the conversion script. It's probably a lot easier for me to tweak it than for you to manually do 500 registrations or however many there are.

I am on vacation. Beginning next month with it, I'll let you know.

[Rumrusher]

learn something about armies well the adventurer is a floating array in a pool of it unlike before where it was set to 0. this means the adventurer will swap around in the army list if you keep moving.
kinda means any travel mode script has to search for the adventurer every time the player moves

in good news here have a experimental script that allows you to dive through the 3 layers of the travel menu

Code: [Select]

http://pastebin.com/RCqzsd1Z
so far it does nothing for players since you can't fast travel unless there is a tunnel... and I haven't figure out how to give players access to travel freely... or spawn tunnels or build roads.

[Quietust]

So I've identified  those annoying (to me, anyways) leaf/fruit circles under trees as spatter structures in block_events, but deleting the structures (with erase()) does nothing, they're still quite visible.

Where else might these be defined?

They aren't defined anywhere else - if you remove them from map_block.block_events[], they should disappear.

The next version of DFHack will have an option to remove them with the "clean map" command.

[Shuuya]

I'm having problems using stonesense. I installed DFHack 40_08 over DF Starter Pack 40_08 and when I open stonesense, it crashes my game.
Here is the crash thing.

Spoiler (click to show/hide)

  Problem Event Name:   APPCRASH
  Application Name:   Dwarf Fortress.exe
  Application Version:   0.0.0.0
  Application Timestamp:   53e90092
  Fault Module Name:   atioglxx.dll
  Fault Module Version:   6.14.10.6465
  Fault Module Timestamp:   45f8a27d
  Exception Code:   c0000005
  Exception Offset:   0035068e
  OS Version:   6.1.7601.2.1.0.256.1
  Locale ID:   1033
  Additional Information 1:   0a9e
  Additional Information 2:   0a9e372d3b4ad19135b953a78882e789
  Additional Information 3:   0a9e
  Additional Information 4:   0a9e372d3b4ad19135b953a78882e789

EDIT: Just for further clarification, I believe that since it's that specific dll file, it has to do with my graphics card. I have an ATi Mobility Radeon x1400, which is pretty out of date and only supports OpenGL 2.0