Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[lethosor]

The subscreen field was removed (maybe in 0.40, in fact, but we noticed it in 0.42). That'll need to be fixed.

[mifki]

Hmmm.

Code: [Select]

/home/thefunk/.df/hack/scripts/names.lua:42: Cannot write field viewscreen_setupadventurest.subscreen: not found.
stack traceback:
        [C]: in function '__newindex'
        /home/thefunk/.df/hack/scripts/names.lua:42: in function 'f'
        ./hack/lua/dfhack.lua:554: in function <./hack/lua/dfhack.lua:495>
        (...tail calls...)
I notice there are pages now in the adventurer setup screens, but none specifically seem to point to the custom name screen.

It is now .page = df.viewscreen_setupadventurest.T_page.Background

[gchristopher]

<... stuff ...>

Most importantly check if the item has in_job flag (if so remove from job and unset flag) and don't forget to call dfhack.items.moveToGround so everything is correctly set (e.g. tile flags that it contains item, item list in map chunk etc...)

I tried a more minimal approach, just cleared the item.flags.owned flag, the owned item.general_refs and the unit.owned_items entry, then marked the item for dumping. Eventually the dwarf dropped it. However, that dwarf appears to immediately claim that item (the minecart) as owned any time he picks it up for any reason!

However, the bug is pretty endemic. Several dwarves have claimed ownership of whatever item is in their right hands. I'm trying to create a bug tracker account to document it, but the captcha there appears to be broken.

[Dirst]

I have one other related question... Can Lua manipulate the sidebar while placing a building?  This would give the player more immediate feedback if a location is "appropriate".  Any single tile can only have one base material, so a single generic Altar would still work even though building materials aren't selected until after the position (for example, if it's a marble tile, the sidebar can report if the location is suitable for an Altar To Marble).

[lethosor]

I have one other related question... Can Lua manipulate the sidebar while placing a building?  This would give the player more immediate feedback if a location is "appropriate".  Any single tile can only have one base material, so a single generic Altar would still work even though building materials aren't selected until after the position (for example, if it's a marble tile, the sidebar can report if the location is suitable for an Altar To Marble).

You can replace the sidebar entirely (well, technically that involves creating a new screen, rendering the parent/dwarfmode screen, and then drawing over (parts of) the sidebar). The HistScreen class at https://github.com/lethosor/dfhack/blob/designation-history/plugins/lua/designation-history.lua is an example.

[Max™]

The subscreen field was removed (maybe in 0.40, in fact, but we noticed it in 0.42). That'll need to be fixed.

The subscreen worked in 0.40 though, but I'll try the way mifki suggested.

That worked, still gotta clean it up so it applies the name when you exit the screen but eh.

[gchristopher]

<... stuff ...>

Most importantly check if the item has in_job flag (if so remove from job and unset flag) and don't forget to call dfhack.items.moveToGround so everything is correctly set (e.g. tile flags that it contains item, item list in map chunk etc...)

I tried a more minimal approach, just cleared the item.flags.owned flag, the owned item.general_refs and the unit.owned_items entry, then marked the item for dumping. Eventually the dwarf dropped it. However, that dwarf appears to immediately claim that item (the minecart) as owned any time he picks it up for any reason!

However, the bug is pretty endemic. Several dwarves have claimed ownership of whatever item is in their right hands. I'm trying to create a bug tracker account to document it, but the captcha there appears to be broken.

The item also appears in units.used_items. My doctor was growing attached to a stack of adamantine coins (and who could blame him.) I tried removing the reference to the item from used_items. Let's see if he stops picking it back up now.

Oh, look! The doctor left a job to take a drink, and has again claimed ownership of the item he was using for a previous job. This time I saw it happen start to finish. I'm certain he just picked up the item (a steel coin) and was melting it when he left to get a drink, and now that coin is held in his right hand, and he is its new owner.

Looking over my dwarf population, 3 out of 20 have some inappropriate items in their right hand. One has six glass pots of alcohol in his right hand, and is asleep in bed. (Ha, that sounds about right.)

That bug is definitely confirmed for 42.04, I'll try to get a Mantis account to post it.

[Grax]

Can somebody make dfhack with just a "reveal" module?

[Dirst]

I have one other related question... Can Lua manipulate the sidebar while placing a building?  This would give the player more immediate feedback if a location is "appropriate".  Any single tile can only have one base material, so a single generic Altar would still work even though building materials aren't selected until after the position (for example, if it's a marble tile, the sidebar can report if the location is suitable for an Altar To Marble).

You can replace the sidebar entirely (well, technically that involves creating a new screen, rendering the parent/dwarfmode screen, and then drawing over (parts of) the sidebar). The HistScreen class at https://github.com/lethosor/dfhack/blob/designation-history/plugins/lua/designation-history.lua is an example.

Thanks, I will take a look at this.

[Ghills]

<... stuff ...>

Most importantly check if the item has in_job flag (if so remove from job and unset flag) and don't forget to call dfhack.items.moveToGround so everything is correctly set (e.g. tile flags that it contains item, item list in map chunk etc...)

I tried a more minimal approach, just cleared the item.flags.owned flag, the owned item.general_refs and the unit.owned_items entry, then marked the item for dumping. Eventually the dwarf dropped it. However, that dwarf appears to immediately claim that item (the minecart) as owned any time he picks it up for any reason!

However, the bug is pretty endemic. Several dwarves have claimed ownership of whatever item is in their right hands. I'm trying to create a bug tracker account to document it, but the captcha there appears to be broken.

The item also appears in units.used_items. My doctor was growing attached to a stack of adamantine coins (and who could blame him.) I tried removing the reference to the item from used_items. Let's see if he stops picking it back up now.

Oh, look! The doctor left a job to take a drink, and has again claimed ownership of the item he was using for a previous job. This time I saw it happen start to finish. I'm certain he just picked up the item (a steel coin) and was melting it when he left to get a drink, and now that coin is held in his right hand, and he is its new owner.

Looking over my dwarf population, 3 out of 20 have some inappropriate items in their right hand. One has six glass pots of alcohol in his right hand, and is asleep in bed. (Ha, that sounds about right.)

That bug is definitely confirmed for 42.04, I'll try to get a Mantis account to post it.

Thanks for the heads-up. Guess I'm sticking with 42.03 for now.

[scamtank]

Just a thought: does this inappropriate hanging-on happen with anything other than TOOLs? I could easily imagine there's something about the way people carry around books and scrolls that's had an awful side effect on other tools.

[gchristopher]

Thanks for the heads-up. Guess I'm sticking with 42.03 for now.

It's not such a terrible bug, and it's probably related to 0009443: Dwarfs acquire and equip multiple empty goblets

All of the dwarves who are claiming ownership of items have a preference for the items material.

Removing ownership references and item attachment references seems to fix the items in question. I will try changing the dwarves preferences so they longer like the item materials and see if they stop pathologically claiming items.

I guess if I'm editing preferences, I could make every dwarf prefer potato wine (vodka) and call it Russian Fortress.

Overall, 42.04 is great! I recommend it. Also thanks to the dfhack team for such a continually amazing effort!

[Symmetry]

Just a thought: does this inappropriate hanging-on happen with anything other than TOOLs? I could easily imagine there's something about the way people carry around books and scrolls that's had an awful side effect on other tools.

I have seen my soldiers sparring while carrying upto six bars in their hands.  They should be doing nothing buy hauling them.
I can't promise this is the same bug but it seems very likely.

Mine seemed to go away with a "replace clothing" change but I really wasn't paying attention and I was glad of the weight training for the soldiers.  Not sure if that is a real thing but I hope so.

[KirigStonebeard]

I'm getting an error every time I try to launch DFHack, that I'm running an unknown version of DF. I've tried 0.42.04 and 0.42.03, including fresh installs of both, and I tried redownloading the DFHack zip in case there was an error on the first DL. stderr.log reads as follows:

FirstCall()
Initized HOOKS!
DFHack build: v0.40.24-r5-0-g3330225
Identifying DF version.
Loading hack\symbols.xml ... OK
v0.40.24 SDL: PE: 0x54ad7e66
v0.40.24 linux: MD5: c42f55948a448645d6609102ef6439e8
v0.40.24 osx: MD5: c935236736139882b670ed9f1adec52c
Loaded 3 DF symbol tables.
Unable to retrieve version information.
PE timestamp: 0x567ef345

I'm pretty confused because it doesn't seem like anyone else is having this problem. Anyone have any suggestions?

[mifki]

DFHack build: v0.40.24-r5-0-g3330225