No fishing
Skills go up for skeleton migrants. Transformation does not raise the natural skill, only the skill learn rate. Nothing I can do abou it. But I will try to add this using scripts.
Warpstone based weaponry: Possibly, I havent gotten that far.
Vampires will drink drinks automatically, but they will not chose bloodwine over... lets say dwarven rum or wine. Thats why I added this extra manual reaction. They should be quite rare, so its not too much management. I am also not entire sure how the game handles this, because after 3 months they get the bloodsucker tag back, but I dont know if their blood-thirst counter has been set to 0 with this. It might be that they dont drink blood for 3 months, then get that tag back and are like "Oh my, I havent had a drink for 3 months" and instakill someone.
Thrall Chamber: The Thralls will wander about randomly. No control. So yeah, putting this up where invaders walk through might make sense. I really couldnt give you thralls for your army that use weapons and armor, they are so indestructable... doesnt count like a pet, cant be pastured.
Ebonglass Forge: Currently it takes 10 powder, for the glass reaction, but you get 150 from grinding ore. I dont think that there will be a shortage. Its mostly to take green glass and recolor it. Of course the weapon grade ones are more expensive... but I dont think I will add alchemy to this. Maybe chemistry, I havent done that yet. I think about adding AoE attack materials like Acids and Warpstone to it.
Darkpact: Remember, you need quite a bit to build it, and destroying all plants/trees on the map is pretty damning. Same for "kills worker", because you dont have many warlocks. And misery, the dfhack plugin doubles the impact of negative thoughts. I obviously havent tested this ingame, but I think its ok like it is. If testing shows that its too abusive, I can change the balancing easily.
Vampire Crypt: Yeah, why not? Blood Elixier and Blood Frenzy... mh.... I could even make vampire specific spells, now that you mention this.
Any good ideas for Werebeasts? I cant really see how I can add them into the civ. Because they transform that fully heal, they pause/zoom every month, which is annoying, and they drop all their gear, making them bad for the military.
Nobles are appointed. Just like military commander/militia captian.
The crumbles when warlocks dies: No need for a workshop, I can do this automatically.