Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[cephelo]

Seems like stables are broken in the unified branch with dfhack_r4, they end up starving even when being fed regularly.

[Urist McTeellox]

Seems like stables are broken in the unified branch with dfhack_r4, they end up starving even when being fed regularly.

Hmm, I'm investigating this now. I can verify that `feedsimple` still works, and that `fovcommand [id] feedsimple` does indeed zero the hunger counters of everything in the field of view of a given unit...

Here's the relevant RAW:

Spoiler (click to show/hide)

Code: [Select]

[INORGANIC:PET_FEEDING]
[USE_MATERIAL_TEMPLATE:STONE_VAPOR_TEMPLATE]
        [STATE_NAME_ADJ:ALL:Feed nearby grazers]
[MATERIAL_VALUE:0][SYNDROME]
        [SYN_CLASS:\COMMAND]
        [SYN_CLASS:fovcommand]
        [SYN_CLASS:\WORKER_ID]
        [SYN_CLASS:feedsimple]
[SYN_AFFECTED_CLASS:PET_HEALING] => should target grazers only


So either autosyndrome isn't firing, or somehow there's something screwy with it only targetting the PET_HEALING class. Hmm...

Just to check, you have `enable autoSyndrome` in your dfhack.init file, yes? (It should be there by default for all the newer unified releases)

Are there any warnings or messages on the dfhack console when you try using the stables?

~ T

[Putnam]

You also need to put [SYN_CLASS:\AUTOSYNDROME] into all autosyndrome materials

[Urist McTeellox]

You also need to put [SYN_CLASS:\AUTOSYNDROME] into all autosyndrome materials

Oh, is that a new change with r4? Otherwise I'm confused how these would have worked at all in r3.

[Meph]

yes, thats missing from the raws. All boiling rocks under 9000 boiling temp did trigger it. With r4 its only if the material has this tag, but it ignores the temp.

[Urist McTeellox]

yes, thats missing from the raws. All boiling rocks under 9000 boiling temp did trigger it. With r4 its only if the material has this tag, but it ignores the temp.

Sweet, that sounds like an easy fix, and potentially explains a number of the DFHack r4 integration bugs we've seen.

I'm currently merging/rebasing off 4e; I'll look at doing a mass AUTOSYNDROME add afterwards. (And once I find coffee!)

~ T

[Urist McTeellox]

Master and upstream are now based upon 4e. Both sets now use the Splinterz' configuration code from the upstream release. All patches applied cleanly.

DFHack issues with upstream/r4 are a known bug due to autoSyndrome not triggering. I'm hoping to correct these this afternoon.

Master should be golden.

~ T

[Urist McTeellox]

I've added AUTOSYNDROME tags whenever I could spot a SYN_CLASS:\COMMAND. Gosh that was a lot of work going through them all.

Spoiler (click to show/hide)

Code: [Select]

$ perl -i -pe's/(\[SYN_CLASS:\\COMMAND\])/[SYN_CLASS:\\AUTOSYNDROME]$1/;' inorganic_*


This does *not* mean I've caught all the autosyndrome locations, but this should hopefully provide some relief for the most common problems. (In particular, stables and libraries *should* work now...)

Changes are live on unified. (master is unchanged, since it uses DFHack r3.) I don't know if it's possible to download MWDF-patch-unified.zip, extract the inorganic*.txt files, and drop them into a live save, but if you're willing to live on the edge I would.  Make backups of your saves first.

I also had a minor scare because I thought I'd completely booched the integration of the 4e release, until I realised that 4e contained all my patches. (At the time of posting, 4e and master are functionally identical.)

~ T

[Meph]

4e contained all my patches

Almost... The folder structure is completly different, keep that in mind.

[Urist McTeellox]

4e contained all my patches

Almost... The folder structure is completly different, keep that in mind.

Wait, what was missing? Splinterz' new config system was moved around a bit, but aside from that 4e appears to contain all the patches on the master branch of MWDF-SWP. There's the updated version of ItemSyndrome for r3, the gun rebalancing, the turret fixes, the confusing armours removed, hide root oil, the updates to the orcish drydocks...

Either that or I've totally downloaded the wrong file named `MasterworkDF V.4e.7z` this morning.

Don't worry, nothing is in there which I consider the least bit experimental, so I'm delighted with the fixes being out! 

~ T

[Meph]

All this is in, yes. But not the dfhack r4. And the content of the MasterworkDwarfFortress folder is sorted and renamed quite a bit.

[Urist McTeellox]

Spacefox was failing to display cave fungus tiles; they'd just come out black.

I've fixed that now. (master and unified)

However I'm definitely a n00b when it comes to colours and tiles, so feedback is definitely appreciated. (Previously they were black, now they're a light cyan/blue).

~ T

[cephelo]

Hmm, I have the new unified, but my stable still doesn't work - and yes, brand new world gen. Not sure if others work, Stable is just the easiest to test. The \AUTOSYNDROME tag is in the "feed pet" reaction, and a manual fovcommand does work fine from the dfhack console.

[Urist McTeellox]

Hmm, I have the new unified, but my stable still doesn't work - and yes, brand new world gen. Not sure if others work, Stable is just the easiest to test. The \AUTOSYNDROME tag is in the "feed pet" reaction, and a manual fovcommand does work fine from the dfhack console.

Gosh darn it. Looks like I have more testing ahead of me. Thank you very much for the bug reports, they're very much appreciated.

[Meph]

Talk to Boltgun and Kurik Amudnil. These two know most about fovcommand.