Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[kingubu]

Ugh, well to muddy the waters, sometimes birds grow, sometimes they don't.

Wrote this script to dump all the bird sizes to a file

Spoiler (click to show/hide)

Code: (listbirds.lua) [Select]

for i,j in pairs(df.global.world.raws.creatures.all) do
if (j.creature_id == "BIRD_PEAFOWL_BLUE") then
bird1 = i
end
if (j.creature_id == "BIRD_GOOSE") then
bird2 = i
end
if (j.creature_id == "BIRD_TURKEY") then
bird3 = i
end
if (j.creature_id == "BIRD_CHICKEN") then
bird4 = i
end
end
local file = io.open("birdsize.txt","w")
for i,j in pairs(df.global.world.units.active) do
if (j.race == bird1) then
file:write(i, "\tPEAFOWL\t", j.body.blood_max, "\n")
end
if (j.race == bird2) then
file:write(i, "\tGOOSE\t", j.body.blood_max, "\n")
end
if (j.race == bird3) then
file:write(i, "\tTURKEY\t", j.body.blood_max, "\n")
end
if (j.race == bird4) then
file:write(i, "\tCHICKEN\t", j.body.blood_max, "\n")
end
end
file:close()


Ran it every season for a year on 400+ birds.
Data here http://dffd.wimbli.com/file.php?id=7742

Long story short, about 10% of chicks grow properly.
Put that in your pipe and smoke it.

Edit:  Birds that grow properly are all of the same clutch as well.

[Urist Da Vinci]

I found (over in the DFHack thread) that the bug also prevents proper size calculation for strength and fatness. The old and young dwarves in your fort that grow properly aren't affected, but the rest will keep to a single body size regardless of how much they eat. This means that if the bug is fixed, all of your corpulent lazy adult dwarves will suddenly need bigger belts and will move slower because of their increased size.

Currently if you view an obese dwarf's info page, it will correctly tell you how fat they should be, but this currently doesn't affect how fast they move or what size of pressure plate they will trigger for bugged dwarves.

[Kurik Amudnil]

Using a modification of kingubu's script, I confirmed that in my test sample, one out of 12 clutches are growing.  I started with 3 females each (peafowl, goose, chicken, turkey) and one male each. In the second batch of eggs, again, one out of the 12 clutches are growing, but I managed to catch that clutch soon after birth and found that when they "grew" they shrank to a normal size for their age.  Also, I noticed that they grow when unit.relations.birth_time mod 1200 == df.global.cur_year_tick mod 1200. 

Spoiler: The modified script (click to show/hide)

Code: [Select]

local TU_PER_DAY = 1200
local TU_PER_MONTH = TU_PER_DAY * 28
local TU_PER_YEAR = TU_PER_MONTH * 12
function CalcAge(t1,t2)
if t1.ticks < t2.ticks then
return { year = (t1.year - t2.year - 1) , ticks = (TU_PER_YEAR + t1.ticks - t2.ticks) }
else
return { year = (t1.year - t2.year) , ticks = (t1.ticks - t2.ticks) }
end
end


local birds = {  }
for i,j in pairs(df.global.world.raws.creatures.all) do
if (j.creature_id == "BIRD_PEAFOWL_BLUE") then
birds[i] = "PEAFOWL"
elseif (j.creature_id == "BIRD_GOOSE") then
birds[i] = "GOOSE"
elseif (j.creature_id == "BIRD_TURKEY") then
birds[i] = "TURKEY"
elseif (j.creature_id == "BIRD_CHICKEN") then
birds[i] = "CHICKEN"
elseif (j.creature_id == "BIRD_DUCK") then
birds[i] = "DUCK" -- added for a migrant duck
end
end
local birth_time, age, PAT
local cur_time = { year = df.global.cur_year , ticks = df.global.cur_year_tick }
local file = io.open("birdsize.txt","w")
local str = "UNIT_ID\tRACE\tBIRTH\tAGE\tTHICK_SIZE\tBODY_SIZE\tPAT_2\tPAT_3\tPAT_4\tPAT_5\tBLOOD_MAX\tSTR\tFAT\n"
file:write(str)
for _,unit in pairs(df.global.world.units.active) do
if birds[unit.race] then
birth_time = { year = unit.relations.birth_year , ticks = unit.relations.birth_time }
age = CalcAge( cur_time , birth_time )
PAT = unit.body.physical_attr_tissues
str = string.format( '%i\t%s\t"%+i_%06i"\t"%+i_%06i"\t%i\t%i\t%i\t%i\t%i\t%i\t%i\t%i\t%i\n' , unit.id, birds[unit.race], birth_time.year, birth_time.ticks, age.year, age.ticks, PAT[0], PAT[1], PAT[2], PAT[3], PAT[4], PAT[5], unit.body.blood_max, unit.body.physical_attrs.STRENGTH.value, unit.counters2.stored_fat )
file:write(str)
end
end
file:close()


My data dumps

Edit:  forgot the code tag

[VerdantSF]

Edited due to cure being found!

[Okami No Rei]

Patched Vanilla Raws, as well as a .dfmod file for DF Mod Manager 0.7. 

Do PM me if I've missed something.  I'm just now testing it.

[Di]

Adjusting the Infant/Child sizes seems like a good workaround.
I foresee that dwarven mothers will move a LOT slower since they have to haul all that extra weight.
Which I guess is actually more realistic than drafting all the moms into the military and birthing while in a sparring session.

I guess they're going to turn into dreadnoughts with that: normal babies are able to stop a couple of arrows or a single strike with halberd, now imagine a meatshield of the size of an adult dwarf, also greater size would allow them to actually punch someone to death while mommy is busy swinging an axe.

[Urist Da Vinci]

Using a modification of kingubu's script, I confirmed that in my test sample, one out of 12 clutches are growing.  I started with 3 females each (peafowl, goose, chicken, turkey) and one male each. In the second batch of eggs, again, one out of the 12 clutches are growing, but I managed to catch that clutch soon after birth and found that when they "grew" they shrank to a normal size for their age.  Also, I noticed that they grow when unit.relations.birth_time mod 1200 == df.global.cur_year_tick mod 1200. 

...

So a clutch of birds that are all born at the same time either all have the bug or all don't. What creature type grew properly in the first batch? Was it the same as the creature type for the second batch? The same mother? Do you have their birth times from DFHack?

[Urist Da Vinci]

Double post because solution:

Code: [Select]

unit.relations.birth_time=-1
This single line of code will change a dwarf's birthday and cure them of the aging bug. Probably works for animals too (needs crowdsourced testing).

[Kurik Amudnil]

Double post because solution:

Code: [Select]

unit.relations.birth_time=-1
This single line of code will change a dwarf's birthday and cure them of the aging bug. Probably works for animals too (needs crowdsourced testing).

Wow, I will have to try that.  And some variations.   As for the birds in my test, the first set that worked were geese, the second set were chickens, so not the same mother.

[CognitiveDissonance]

Double post because solution:

Code: [Select]

unit.relations.birth_time=-1
This single line of code will change a dwarf's birthday and cure them of the aging bug. Probably works for animals too (needs crowdsourced testing).

Urist Da Vinci, you are amazing. did you know that?

Could somebody add this info to
http://www.bay12games.com/dwarves/mantisbt/view.php?id=6334

[Kurik Amudnil]

in my few test that I have done so far, yes -1 works.  however, I also found that a multiple of 1200 works.  Then I found that a multiple of 10 works.  All of the birds that were growing were born on a tick ending in zero.  This means that we don't have to totally mess up their birth time.

[k33n]

in my few test that I have done so far, yes -1 works.  however, I also found that a multiple of 1200 works.  Then I found that a multiple of 10 works.  All of the birds that were growing were born on a tick ending in zero.  This means that we don't have to totally mess up their birth time.

That is... so strange. I can only imagine the code behind this.

Should I hold off that latest fix until this new one is implemented?

[Kurik Amudnil]

Putnam and I have each posted a script on the dfhack thread (Putnam's) (mine).  I think they need more polish.

I think I would prefer to use either of the scripts rather than mod the creature sizes.  However, it is important to note that with the bug, babies and children often are born or migrate with a size far greater than they are supposed to have and once fixed they will shrink to the correct size and grow from there.  This means that getting butchering young animals will provide no returns or fewer returns for creatures with large babies.  Setting birth_time to -1 such as Putnam's script does, will give units born latter in the year the same size as units born earlier in the year which may improve butcher results from the younger animal population.  I also have concerns about mods, scripts, or other places that use the birth time from the historical figure entry or assumed identities so I suggested a modification for Putnam's script.

I also think we need to test whether or not vampires, undead, and other not living things will grow after being fixed or will properly stay where they are.  Or should they grow if they gain/lose strength or fat?  Does this fix make a unit lose size when they lose a limb or other body part? Do we care?

Edit: fixed typo, thanks!

Also, looking at my bird tests for birth time, I missed some growing birds.  Thats what I get for not writing a function in the spread sheet to show diffs in size

[Brilliand]

I also think we need to test weather or not vampires, undead, and other not living things will grow after being fixed or will properly stay where they are.  Or should they grow if they gain/lose strength or fat?  Does this fix make a unit lose size when they lose a limb or other body part? Do we care?

s/weather/whether/

Confused me on the first readthrough.  Weather is actually a thing in DF.  (I wonder if we should test weather?)

[crossmr]

Double post because solution:

Code: [Select]

unit.relations.birth_time=-1
This single line of code will change a dwarf's birthday and cure them of the aging bug. Probably works for animals too (needs crowdsourced testing).

Do we have to hunt and peck through each dwarf and creature to add this, and keep checking new ones?