Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Billy Jack]

Make Fishing Poles and Fishing Nets able to be stockpiled separately:

Add to inorganic_zmasterwork.txt

Spoiler (click to show/hide)

[INORGANIC:BLANK_FISHING]
[STATE_NAME_ADJ:ALL_SOLID:(fishing supplies)][DISPLAY_COLOR:7:7:1][TILE:176]
[MATERIAL_VALUE:1]
[STATE_NAME:ALL_SOLID:(fishing supplies)]
       [STATE_ADJ:ALL_SOLID:(fishing supplies)]
       [STATE_NAME:LIQUID:(fishing supplies)]
       [STATE_ADJ:LIQUID:(fishing supplies)]
   [SOLID_DENSITY:1000]
   [IS_STONE]

Modify reactions in reaction_masterwork.txt

Replace:

Spoiler (click to show/hide)

[REACTION:MAKE_POLE]
[NAME:make fishing pole]
[BUILDING:FISH_POND:CUSTOM_P][BUILDING:FISH_POND_KOBOLD:CUSTOM_P]
[REAGENT:A:15000:THREAD:NONE:NONE:NONE][NOT_WEB]
[REAGENT:B:1:WOOD:NONE:NONE:NONE]
[PRODUCT:100:1:TOOL:ITEM_TOOL_FISHING_POLE:GET_MATERIAL_FROM_REAGENT:B:NONE]
[SKILL:DISSECT_FISH]

[REACTION:MAKE_NET]
[NAME:make fishing net]
[BUILDING:FISH_POND:CUSTOM_N][BUILDING:FISH_POND_KOBOLD:CUSTOM_N]
[REAGENT:A:150000:THREAD:NONE:NONE:NONE][NOT_WEB]
[REAGENT:B:4:BLOCKS:NONE:INORGANIC:NONE][WORTHLESS_STONE_ONLY]
[PRODUCT:100:1:TOOL:ITEM_TOOL_FISHING_NET:GET_MATERIAL_FROM_REAGENT:A:NONE]
[SKILL:DISSECT_FISH]

[REACTION:FISH_POLE]
[NAME:fish with pole]
[BUILDING:FISH_POND:CUSTOM_SHIFT_P][BUILDING:FISH_POND_KOBOLD:CUSTOM_SHIFT_P]
[REAGENT:A:1:TOOL:ITEM_TOOL_FISHING_POLE:NONE:NONE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_MOLLY_SAILFIN:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_TROUT_RAINBOW:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_KNIFEFISH_BANDED:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_BULLHEAD_BROWN:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_LUNGFISH:MALE]
[PRODUCT:95:1:TOOL:ITEM_TOOL_FISHING_POLE:NONE:NONE]
[SKILL:DISSECT_FISH]

[REACTION:FISH_NET]
[NAME:fish with net]
[BUILDING:FISH_POND:CUSTOM_SHIFT_N][BUILDING:FISH_POND_KOBOLD:CUSTOM_SHIFT_N]
[REAGENT:A:1:TOOL:ITEM_TOOL_FISHING_NET:NONE:NONE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_MACKEREL:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_FLOUNDER:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_SOLE:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_GUPPY:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_PERCH:MALE]
[PRODUCT:95:1:TOOL:ITEM_TOOL_FISHING_NET:NONE:NONE]
[SKILL:DISSECT_FISH]

with:

Spoiler (click to show/hide)

[REACTION:MAKE_POLE]
[NAME:make fishing pole]
[BUILDING:FISH_POND:CUSTOM_P][BUILDING:FISH_POND_KOBOLD:CUSTOM_P]
[REAGENT:A:15000:THREAD:NONE:NONE:NONE][NOT_WEB]
[REAGENT:B:1:WOOD:NONE:NONE:NONE]
[PRODUCT:100:1:TOOL:ITEM_TOOL_FISHING_POLE:INORGANIC:BLANK_FISHING]
[SKILL:DISSECT_FISH]

[REACTION:MAKE_NET]
[NAME:make fishing net]
[BUILDING:FISH_POND:CUSTOM_N][BUILDING:FISH_POND_KOBOLD:CUSTOM_N]
[REAGENT:A:150000:THREAD:NONE:NONE:NONE][NOT_WEB]
[REAGENT:B:4:BLOCKS:NONE:INORGANIC:NONE][WORTHLESS_STONE_ONLY]
[PRODUCT:100:1:TOOL:ITEM_TOOL_FISHING_NET:INORGANIC:BLANK_FISHING]
[SKILL:DISSECT_FISH]

[REACTION:FISH_POLE]
[NAME:fish with pole]
[BUILDING:FISH_POND:CUSTOM_SHIFT_P][BUILDING:FISH_POND_KOBOLD:CUSTOM_SHIFT_P]
[REAGENT:A:1:TOOL:ITEM_TOOL_FISHING_POLE:NONE:NONE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_MOLLY_SAILFIN:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_TROUT_RAINBOW:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_KNIFEFISH_BANDED:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_BULLHEAD_BROWN:MALE]
[PRODUCT:4:1:FISH_RAW:NONE:FISH_LUNGFISH:MALE]
[PRODUCT:95:1:TOOL:ITEM_TOOL_FISHING_POLE:INORGANIC:BLANK_FISHING]
[SKILL:DISSECT_FISH]

[REACTION:FISH_NET]
[NAME:fish with net]
[BUILDING:FISH_POND:CUSTOM_SHIFT_N][BUILDING:FISH_POND_KOBOLD:CUSTOM_SHIFT_N]
[REAGENT:A:1:TOOL:ITEM_TOOL_FISHING_NET:NONE:NONE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_MACKEREL:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_FLOUNDER:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_SOLE:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_GUPPY:MALE]
[PRODUCT:8:1:FISH_RAW:NONE:FISH_PERCH:MALE]
[PRODUCT:95:1:TOOL:ITEM_TOOL_FISHING_NET:INORGANIC:BLANK_FISHING]
[SKILL:DISSECT_FISH]

[Billy Jack]

Peat collection:

Only peat that is a soil layer is actually collectable.  Peat that is part of a "vein" in a dirt layer is not collectable as it is treated as stone instead of soil.

To fix:
Remove the line [ENVIRONMENT_SPEC:DIRT:CLUSTER:100] from the [INORGANIC:PEAT_SOIL] definition in inorganic_stone_soil.txt. This will stop peat from showing up as a vein in dirt layers, thereby eliminating the possible confusion on which peat is collectable and which is not.

[Meph]

Thanks Billy Jack, I applied both patches. Just as background info: I added the peat into dirt, because I wanted to raise the chance of finding it, because one more soil layer (dirt) makes all other soils layers more rare... seemed it didnt work out.

[Billy Jack]

So as I'm testing out the fishing changes, I discovered that the Turtle reactions don't work because their product is TURTLE_CAVE, a creature which does not exist.

Changing to POND_TURTLE

[Meph]

What do you think of producing the items as buildmats, ordering a specialized "bag of fish eggs" as buildmat to make it somehow reasonable that you can start a fishfarm, and then... use disposable "fish food" you make in the kitchen to actually farm fish?

[Billy Jack]

With the change to make the items (fishing supplies), I think they are fine not being buildmats. But I do think it would be good to order the fish eggs as well.  It just seems too easy that you can cut 15 blocks, make a couple of buckets, and then have an endless supply of food.  At least the fish eggs will slow that down for a year. (but it also makes sense that you would be able to embark with them.   )

As far as bait, I like the idea.  Restrict the possible bait to meat/vermin/other body parts/etc. if possible.  Don't know of many fish that are caught for food, that actually eat plants.


and another bug/fix:

Remove the FIRED_MAT token from the end of the product output for all of the BUILDING:KILN reactions.
Change GET_MATERIAL_FROM_REAGENT:clay:FIRED_MAT to GET_MATERIAL_FROM_REAGENT:clay:NONE.

This change allows workflow to predict the output and manage the number.


Also, I notice workflow isn't able to control fishing output (other than the net and pole). Don't know how it could be fixed, unless you fish for some fish_tool that is processed at the Fishery into the raw fish to be cleaned.  That may help with the balancing as you could leave it at having a 4% chance of catching the one fish_tool, which would be then processed into the random fish type. (of course they could process the fish_tool at the Fishpond as well).

Further balancing: reactions to specify what you are fishing for. One for Trout, one for Lungfish, etc. Each still having a low chance of success. As I understand the probabilities on the reactions, its a dice roll for each one, meaning if you were lucky, you could currently catch all five of the possible fish with the pole in one reaction.  Different bait for each as well.


And as long as you are listening.     I find it odd that dwarfs, a race born from the stone and genetically designed to live underground, can get black lung from coal dust.  I turn off harder mining, but then have to go turn warpstones back on in the RAWS.

[Meph]

I never used workflow, so I have no idea.

I would like to use water as a buildmat, which is somewhat possible... but dwarves are too stupid to fill buckets. They just check for "the item = water", ignoring all wells and ponds and rivers....

Remove the FIRED_MAT token from the end of the product output for all of the BUILDING:KILN reactions. Change GET_MATERIAL_FROM_REAGENT:clay:FIRED_MAT to GET_MATERIAL_FROM_REAGENT:clay:NONE. This change allows workflow to predict the output and manage the number.

I'll probably add this then, if it helps workflow.

[Billy Jack]

The FIRED_MAT change helps me from having diarrhea of fire clay beds.

hmmm.... would that burn the sphincter??

I've also fished the hell out of my underground water cistern, so truly balancing fishing is something Toady will need to do.

[silentdeth]

Remove the FIRED_MAT token from the end of the product output for all of the BUILDING:KILN reactions. Change GET_MATERIAL_FROM_REAGENT:clay:FIRED_MAT to GET_MATERIAL_FROM_REAGENT:clay:NONE. This change allows workflow to predict the output and manage the number.

I'll probably add this then, if it helps workflow.

Then they would be clay and fireclay beds instead of earthenware and stoneware.

[Billy Jack]

Remove the FIRED_MAT token from the end of the product output for all of the BUILDING:KILN reactions. Change GET_MATERIAL_FROM_REAGENT:clay:FIRED_MAT to GET_MATERIAL_FROM_REAGENT:clay:NONE. This change allows workflow to predict the output and manage the number.

I'll probably add this then, if it helps workflow.

Then they would be clay and fireclay beds instead of earthenware and stoneware.

Incorrect.  GET_MATERIAL_FROM_REGEANT:clay.  The reagent for the reactions specify that it is Fire Clay.  [REAGENT:clay:1:BOULDER:NONE:INORGANIC:FIRE_CLAY]

Since it is just a reaction, feel free to test it on a fort where you have Fire Clay or Kaolinite.

[Baffler]

Probably mentioned already given its apparent severity, but I'll post it here just in case. I came across a crash bug when I set up a world. I disabled frost giants and warlocks, and enabled dark elves and dwarves. I also enabled the additional kiln reactions and disabled harder farming. The world genned just fine but when I tried to start either fort or adventure mode the game crashed. This happened all three times I tried. Removing the elves fixed adventure mode, oddly, but not fort mode. Removing the dark dwarves fixed fort mode. Each time I genned a small world with a short history to expedite the testing process.

[RickRollYou2]

Small issue: Lots of reactions have "seperate", the correct spelling is "separate"  just a heads up, not sure if anyone's mentioned it

Bigger issue: I may be misunderstanding how this works because I don't use it in-game, but wouldn't

Spoiler (click to show/hide)

[REACTION:BUY_BLESSING_D]
   [NAME:Buy breath of armok for 5000 sovereigns]
   [BUILDING:RARE_MERCHANTS_STALL:NONE]
   [REAGENT:A:5000:COIN:NONE:INORGANIC:GOLD]
[PRODUCT:100:1:ROUGH:NONE:INORGANIC:BLESSING_OF_ARMOK] breath[SKILL:TANNER]   
[REACTION:BLESSING_SELL_D]
   [NAME:Sell breath of armok for 99999 sovereigns]
   [BUILDING:RARE_MERCHANTS_STALL:NONE]
   [REAGENT:A:1:ROUGH:NONE:INORGANIC:BLESSING_OF_ARMOK]
   [PRODUCT:100:99999:COIN:NONE:INORGANIC:GOLD][SKILL:TANNER]   

this be exploitable by repeatedly buying and selling it? Or is this meant to be a joke, since the BoA should vapourise immediately?

[Godlysockpuppet]

It vapourises iirc

[Meph]

Remove the FIRED_MAT token from the end of the product output for all of the BUILDING:KILN reactions. Change GET_MATERIAL_FROM_REAGENT:clay:FIRED_MAT to GET_MATERIAL_FROM_REAGENT:clay:NONE. This change allows workflow to predict the output and manage the number.

I'll probably add this then, if it helps workflow.

Then they would be clay and fireclay beds instead of earthenware and stoneware.

Incorrect.  GET_MATERIAL_FROM_REGEANT:clay.  The reagent for the reactions specify that it is Fire Clay.  [REAGENT:clay:1:BOULDER:NONE:INORGANIC:FIRE_CLAY]

Since it is just a reaction, feel free to test it on a fort where you have Fire Clay or Kaolinite.

Actually, he is right. You collect INORGANIC:CLAY, then make an item with get-material-from-reagent. The reagent is INORGANIC:CLAY, the product will be INORGANIC:CLAY as well. I used material-reaction-product before, to link to stoneware, earthenware and porcelain.

@Rickroll: Yep, I wondered till somebody noticed that. You cant sell it, its gas. and thanks for the typo-find.

[Billy Jack]

Ooops!  My bad for being cocky.     -- Sorry, Silentdeath.

But, how about this:

PRODUCT:100:1:TOY:ITEM_TOY_BRAZIER:INORGANIC:CERAMIC_EARTHENWARE
... etc.

Since each material has its own reaction, just specify what the outcome material should be.

After changing the reactions to having a product material of INORGANIC:CERAMIC_EARTHENWARE, INORGANIC:CERAMIC_STONEWARE, and INORGANIC:CERAMIC_PORCELAIN, I am now producing actual "stoneware" items instead of the "fire clay" items.