I agree the short version is clearly better, I was trying to find what caused the bug but couldn't really see it as I assumed both operators had the same priority
I had to look up the && vs || priority myself before posting -- I remembered back from my early programming courses (which were taught in C++, lucky me?) that they have different priority, but I can never keep them straight. That sort of logic should always have explicit grouping, since many programmers won't intuit the priority between them; it really was a mistake on my part to leave off the parentheses, not just because it caused the code to break.
Edit: Also, it is by no means wrong to revert a change to see that a commit is what created the bug. You didn't do anything wrong, I just wanted to make sure my clean code baby wasn't thrown out with the bathwater.
fix is in the repo
Thank you! I feel bad that you fixed a bug I introduced in just code cleanup, but I appreciate that you did it.
Well, not sure if it's a bug or I'm not understanding the mechanic, but whenever I perform a successful sneak attack, it still immediately trips the alarm.
It's possible it's a bug -- I had this happen once in testing, but wasn't able to reproduce it. What sort of enemy are you attacking? I'm wondering if your opponent had body armor, you got him down to near death, and he bled out and died immediately.
happens every time for me, I tried to use a dagger, and a combat knife, tried withitout knife skill, and with. it seems to occur every time I only have 1 operative. to clarify: when I have more people sneaking, it's fine (no alarm).
Thanks, I should be able to find the bug if it happens consistently with single Liberal squads. I don't see why that would happen off hand, but it gives a good place to start.
How annoying would it be to get this thing to run on mac?
It has been done before. I did it myself a couple times, many years back, with an earlier version of the game.
I believe you can follow the Linux instructions to get the game to run on a Mac. The primary annoying thing about it is that one does not buy a Mac in order to muck about on the command line running make files, so Mac users are significantly less likely than Linux users to know what they're doing. Also, it's somewhat uncharted territory, which makes the game's already shoddy forum-based tech support even worse. If you do go for it, let me know how it goes.