Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Aseaheru]

What?

[Octobomb]

What?

His tg maintainer training kicked in the moment he heard 'stolen code'. For the record, there's no copypaste. Just stealing. And I'm rewriting it now .

[Tsuchigumo550]

So, my glorious return involved being a useless Sec member and a pile of glass stacked so high that it instakilled a barefoot clown, and then a Vox raider that got high and stole healthcare.

[Cerapter]

But now, a question: anyone knows any good European medium+ RP servers?
I'd really like some serious, non-laggy RP too after the handful of tg rounds.

[Aseaheru]

Do you know Russian?
because thats all I can think of.

[Octobomb]

Okay, interesting bug alert. The new code shatters perfectly, and works incredibly well. Scrdest, you might want to use it for your vamp, because it's much simpler. But the destruction occurs at the character's location, not the grenade's location. The flashbang effects do. Help please?

Spoiler: Code within. Any ideas? (click to show/hide)

Code: [Select]

/obj/item/weapon/grenade/sonicnade
name = "sonic grenade"

prime()
..()
/*for(var/obj/structure/window/W in view(3)) //Previous code, worked fine
new /obj/item/weapon/shard(W.loc)
if(W.reinf) new /obj/item/stack/rods(W.loc)
W.Del()

for(var/obj/structure/window/W in view(6)) //Shatters regular windows
if(W.reinf) continue //I don't know how to do it in one for
new /obj/item/weapon/shard(W.loc) //So let's do it in two.
W.Del()*/


for(var/obj/structure/window/W in view(6)) //Shatters regular windows
W.hit(20,1)
for(var/obj/structure/window/W in view(3)) //Applies sufficient damage for reinf
W.hit(60,0)
for(var/obj/structure/window/W in view(1)) //And for regular phoron ones.
W.hit(40,0)
for(var/obj/machinery/door/window/D in view(6)) //Busting windoors
D.take_damage(150)
for(var/obj/machinery/door/window/D in view(3)) //And brigdoors..
D.take_damage(150) //Perfect for breakouts!


for(var/mob/living/carbon/M in hearers(7, get_turf(src)))
var/safety = 0
if(ishuman(M) && M:is_on_ears(/obj/item/clothing/ears/earmuffs))
safety += 1
M.Weaken(8)
M.ear_deaf = (20)
M.stuttering = (20)
M.Stun(8)
M.make_jittery(150)
M << "<span class='warning'><font size='3'><b>You hear a tremendous bang!</font></b></span>"
playsound(src.loc, 'sound/effects/bang.ogg', 50, 1, 5)
del(src)
returnApologies for the lack of safety code handling and range management, it's still in the testing phase.

[miauw62]

Please use absolute paths. Do you guys have any code standards at all?

You also haven't defined a second argument for view(),  which may be your problem since you use get_turf for the flashbang effects (this reeks of copypasted code, btw)

[Kriellya]

Please use absolute paths. Do you guys have any code standards at all?

Absolute paths? Why absolute? I've always been told to use relative paths for a number of reasons. (though I'm so unfamiliar with BYOND coding that I'm not even sure what you're talking about in this code fragment )

[Glloyd]

Please use absolute paths. Do you guys have any code standards at all?

Oh come on Miauw. He hasn't even made a pull request for it yet. Don't conflate his one snippet of WIP code to represent our entire codebase.

[Octobomb]

Please use absolute paths. Do you guys have any code standards at all?

You also haven't defined a second argument for view(),  which may be your problem since you use get_turf for the flashbang effects (this reeks of copypasted code, btw)

Thank you. A get_turf(src) argument sounds like it should work. I'm not at my computer now, but I'll test that tomorrow. I've just realised you want me to expand the prime() proc into an absolute. The other grenades do have it relative, so I'll change it.

Spoiler: Blather (click to show/hide)

I'm by far the least experienced contributor though, to the point where I swelled with pride to load up the CMO and walk them into maint. Please don't tar people like Glloyd, who puts hundreds of hours of work in and produces work like glloydstation, with my brush. I'm sure he'd tell me where I went wrong if I pr'd it. Also, I'd appreciate you explaining exactly how I violated this practise next time (it will happen again). I'm new and learning, remember. Hence the borrowed code.\rant
But I'd honestly rather not bicker. Thank you for your advice, it sounds very promising.

E: Browsing through http://www.byond.com/docs/ref/ reveals view does indeed take two arguments. This will solve the problem. Thanks!
@Kriella

Spoiler: Explain the fragment (click to show/hide)

It's pretty standard. It names the grenade, hooks into the prime() proc of the parent (which is what I've just realised Miauw is chewing me out for, but it's how the other grenades did it. I'll fix it before he gets an aneurism). The next bit is commented out by /* and */, then it checks for windows within 6 tiles and smacks them with with 20 damage each (they have 14 health). It then repeats the process at 3 tiles to bring the damage to 80 total (reinforced windows take half damage through this proc and have 40 health. It repeats the process at adjacent tiles to kill off phoron windows and then again for windoors. Finally, it smacks people in the area with stuns and knockdowns (soon to be subject to range effects, methinks and put into it's own proc).

[scrdest]

I can only say one thing.

'WE NEED A SLOGAN!'

[Glloyd]

I can only say one thing.

'WE NEED A SLOGAN!'

Oh god, did I miss an LCS round?

[scrdest]

I can only say one thing.

'WE NEED A SLOGAN!'

Oh god, did I miss an LCS round?

Yes. And one without admins starting it.

[Aedel]

I can only say one thing.

'WE NEED A SLOGAN!'

Oh god, did I miss an LCS round?

Yes. And one without admins starting it.

This is why I wanted objectives removed, folks.

[Glloyd]

I can only say one thing.

'WE NEED A SLOGAN!'

Oh god, did I miss an LCS round?

Yes. And one without admins starting it.

Ah shit, that sound awesome. Wish I wasn't so bogged down with school right now.