Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Shadowgandor]

Well hello there people of Bay12, I'm trying to overload an operator in C++ but I just can't seem to do it. Seeing how it's pretty basic stuff, I thought someone on here might be able to help me.
I'm trying to overload the operation so that if I use Point1>Point2, it returns weither Point1.x+Point1.y is larger then Point2.x+Point2.y. Pretty useless but atleast I'd be able to see how overloading works.

This is what I have now:

Spoiler (click to show/hide)

Code: [Select]

class Point {
    private:
        int x;
        int y;
    public:
        //Point operator>(Point& c);
Point operator>(const Point&) const;




Point() {  // default constructor
x = 0;
y = 0;
}

bool Point::operator>(const Point& c) const{
if ((x+y)>(c.getX()+c.getY())){
return true;
}else{
return false;
}
}


int Point::getX(){
return x;
}

int getY(){
return y;
}



Point(int new_x, int new_y) {  // constructor
x = new_x;
y = new_y;
}

void showLoc(){
cout <<"("<<x<<","<<y<<")\n";
}

void setX(int newX){
x=newX;
}

void setY(int newY){
y=newY;
}

void setLoc(int newX,int newY){
x=newX;
y=newY;
}

int CalculateDistance(Point two){
int distance;
distance=(int)sqrt(pow(double(getX()-two.getX()),2)+pow(double(getY()-two.getY()),2));
return distance;
}

};

The important part is:

Spoiler (click to show/hide)

Code: [Select]

Point operator>(const Point&) const;




Point() {  // default constructor
x = 0;
y = 0;
}

bool Point::operator>(const Point& c) const{
if ((x+y)>(c.getX()+c.getY())){
return true;
}else{
return false;
}
}

Now, the operator> function says ''Unable to overload function distinguished with return type alone'' but I have no idea what I can do. Anyone know what I'm doing wrong?


ps: I recall some other programming help request threads, maybe we can turn this one into a ''Ask all your programming questions here!'' thread if people are interested.

[RulerOfNothing]

The problem here is that operator overloading is like function overloading in that you need to have different parameter sets for each overload. I would get rid of the version of operator> that returns a Point (unless you could provide a meaningful explanation of such an operator). Incidentally, my memory tells me that a class instance can access private members of other instances of the same class, so you could replace (x+y)>(c.getX()+c.getY()) with (x+y)>(c.x+c.y).

[Shadowgandor]

*facepalm* Indeed! Just removing "Point operator>(Point& c);" was the solution! Thanks for the quick response! And yes, you can use c.x and c.y, so that too helped a lot

[miauw62]

Seeing how it's pretty basic stuff

I see what you did there!

[Shadowgandor]

And I'm back for more! Right now I'm trying the following thing:

PriorityQueue PriorityQueue::operator+(const PriorityQueue& c) const{
         PriorityQueue <T> Test(size_+c.size_);
         for(int i=0;i<size_;i++){
            Test.push(list);
         }
         for(int i=0;i<c.size_;i++){
            Test.push(c.list);
         }
         return Test;
      }

Entire code in spoiler:

Spoiler (click to show/hide)

// PriorityQueue.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include <iostream>
#include "iostream"
#include <limits.h>
#include <stdio.h>
#include <conio.h>
#include <math.h>
using namespace std;

template<class T>class PriorityQueue
{
private:
   T *list;
   int size_;
   int top_;

public:   
   PriorityQueue(int n){
      size_=n;
      list=new T[size_];
      top_=0;
   }
   PriorityQueue PriorityQueue::operator+(const PriorityQueue& c) const{
         PriorityQueue <T> Test(size_+c.size_);
         for(int i=0;i<size_;i++){
            Test.push(list);
         }
         for(int i=0;i<c.size_;i++){
            Test.push(c.list);
         }
         return Test;


      }
   void push(T n){
      if(top_==0){
      list[top_]=n;
      top_++;
      }else if(top_==size_){
         list[top_]=n;
         top_++;
      for(int i=top_; i>0;i--){
         if (list>list[i-1]){
            swap(i,i-1);
         }
      }
      }else{
         T *templist=new T[size_+5];
         for (int i=0; i<top_;i++){
            templist=list;
         }
         size_=size_+5;
         delete[]list;
         list=templist;
         list[top_]=n;
         top_++;
         for(int i=top_; i>0;i--){
            if (list>list[i-1]){
               swap(i,i-1);
         }
      }
      
      }
      
   }

   void swap(int a, int b){
      
      T *temp = new T[size_];
      for(int i=0;i<size_;i++){
         temp=list;
      }
      list[a]=temp;
      list=temp[a];
      delete temp;

   }

   T pop(){

   return list[--top_];
   }

};



class Point {
    private:
        int x;
        int y;
    public:
        //Point operator>(Point& c);
      


      
      
      Point() {  // default constructor
      x = 0;
      y = 0;
      }

      bool Point::operator>(const Point& c) const{
         if ((x+y)>(c.x+c.y)){
         return true;
         }else{
         return false;
         }
      }

      int Point::getX(){
      return x;
      }

      int getY(){
      return y;
      }
      


      Point(int new_x, int new_y) {  // constructor
      x = new_x;
      y = new_y;
      }

      void showLoc(){
      cout <<"("<<x<<","<<y<<")\n";
      }

      void setX(int newX){
      x=newX;
      }

      void setY(int newY){
         y=newY;
      }

      void setLoc(int newX,int newY){
      x=newX;
      y=newY;
      }

      int CalculateDistance(Point two){
      int distance;   
      distance=(int)sqrt(pow(double(getX()-two.getX()),2)+pow(double(getY()-two.getY()),2));
      return distance;
      }

};


int _tmain(int argc, _TCHAR* argv[])
{
   PriorityQueue<int> Q(5);
   Q.push(5);Q.push(10);Q.push(4);Q.push(15);Q.push(100);Q.push(42);
   PriorityQueue<int> W(5);
   W.push(1);W.push(2);
   Q=Q+W;
   cout<<Q.pop()<< "\n";
   cout<<Q.pop()<< "\n";
   cout<<Q.pop()<< "\n";
   cout<<Q.pop()<< "\n";
   cout<<Q.pop()<< "\n";
   cout<<Q.pop()<<"\n";
   PriorityQueue<Point> PQ(5);
   Point a(1,0);
   Point b(2,3);
   Point c(4,2);
   Point d(1,1);
   PQ.push(a);PQ.push(b);PQ.push(c);
   system("pause");
   return 0;
}

Now this doesn't seem to work as all Integers are -842150451 now when I pop them.
Anyone have an idea what's going on? Sorry for pestering you folks with all these questions btw ^^

[Shadowgandor]

Nevermind. Found the solution. I used size_ instead of top_. Fail!