Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1] 2

Author Topic: Possible cause for stagnant river bug  (Read 6123 times)

Loud Whispers

  • Bay Watcher
  • They said we have to aim higher, so we dug deeper.
    • View Profile
    • I APPLAUD YOU SIRRAH
Possible cause for stagnant river bug
« on: April 20, 2012, 12:10:55 pm »

*Shock horror*
I used the search bar, and it appears no one has found a reason for river stagnation yet :/

Whilst happily going about my fortress business, the brook running through my fortress froze. I chose this time to dig out a reservoir and collect some ice - so dug out a big portion of the river. A season later, the river thaws and I happen to notice that every tile in the brook that I mined out was no longer marked as a brook tile, but instead a normal muddied tile which carried the stagnant water tag.
It's a bit hard to show, but pics anyways:

Near the river source

The boundary where I dug out the river

There's no easy way to replicate the results without playing spending a bit of time in a temperate biome, but I'm going to take a guess and say that the stagnation bug is caused by rivers no longer being treated as river tiles, whether it be through freezing, player meddling or sudden magma flooding.

peskyninja

  • Bay Watcher
  • Natural de-selector
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #1 on: April 20, 2012, 12:15:02 pm »

I'm playing in a temperate biome, I'll try to replicate that.
Logged
Burn the land and boil the sea. You can't take the sky from me

Thou son of a b*tch wilt not ever make subjects of Christian sons; we have no fear of your army, by land and by sea we will battle with thee, f**k thy mother.

Loud Whispers

  • Bay Watcher
  • They said we have to aim higher, so we dug deeper.
    • View Profile
    • I APPLAUD YOU SIRRAH
Re: Possible cause for stagnant river bug
« Reply #2 on: April 20, 2012, 02:07:18 pm »

Well, then all we'll have to do is wait for the paint to dry...

Draximo

  • Bay Watcher
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #3 on: April 20, 2012, 02:19:52 pm »

I have also noticed after i mined out some ice from the brook for my awesome ice tower of death, that the brook water when it melted and started flowing again was stagnant. I never messed with the water spawn tiles at all. its been that way ever since.
Logged

wierd

  • Bay Watcher
  • I like to eat small children.
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #4 on: April 20, 2012, 02:37:19 pm »

Toady needs to put a simple flag check on the stagnant flag code.

If the water is moving, by definition the water cannot be stagnant. It can be nasty, but not stagnant.

For moving water, he could have a contaminant, like "festering filth".

But a stagnant brook? Contradiction of terms.

Logged

Loud Whispers

  • Bay Watcher
  • They said we have to aim higher, so we dug deeper.
    • View Profile
    • I APPLAUD YOU SIRRAH
Re: Possible cause for stagnant river bug
« Reply #5 on: April 20, 2012, 02:41:45 pm »

In his defense DF has a long way to go before it meets everyone's standards :P

On the bright side, this bug may be entirely player-caused, and avoidable.

NW_Kohaku

  • Bay Watcher
  • [ETHIC:SCIENCE_FOR_FUN: REQUIRED]
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #6 on: April 20, 2012, 02:44:48 pm »

It is not player-caused. It is a bug.  It occurs on maps before changes have been made by the player, although player changes can still cause stagnation.

See the bug report here.  It is caused by the fact that "stagnant" status is placed in the damp soil surrounding a murky pool, and if that soil is adjacent to a stream, that stream then also becomes stagnant. 
Logged
Personally, I like [DF] because after climbing the damned learning cliff, I'm too elitist to consider not liking it.
"And no Frankenstein-esque body part stitching?"
"Not yet"

Improved Farming
Class Warfare

white_darkness

  • Bay Watcher
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #7 on: April 20, 2012, 02:58:20 pm »

Definitely not 100% player on this one.  though I do believe the freezing/thawing issue impacts it strongly.  My untouched brook is stagnant after the first freeze, whereas my aquifer source and all it's attendant plumbing is still pure, even with the multi-z-level drops works in to put the wells by the bedrooms about 10 z-levels below....
Logged

Sphalerite

  • Bay Watcher
    • View Profile
    • Drew's Robots and stuff
Re: Possible cause for stagnant river bug
« Reply #8 on: April 20, 2012, 03:10:08 pm »

Can a site have both stagnant and salty water?  My current oceanside fortress has several murky pools, none of which seem to be stagnant.  They're probably all salty instead.
Logged
Any intelligent fool can make things bigger and more complex... It takes a touch of genius --- and a lot of courage to move in the opposite direction.

Loud Whispers

  • Bay Watcher
  • They said we have to aim higher, so we dug deeper.
    • View Profile
    • I APPLAUD YOU SIRRAH
Re: Possible cause for stagnant river bug
« Reply #9 on: April 20, 2012, 03:15:39 pm »

player changes can still cause stagnation.

And this is what I'm looking at. Bit odd, and I don't know how it works exactly, but doesn't water have to pass a tile/come into contact with stagnant water to become stagnant itself?

NW_Kohaku

  • Bay Watcher
  • [ETHIC:SCIENCE_FOR_FUN: REQUIRED]
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #10 on: April 20, 2012, 03:24:00 pm »

And this is what I'm looking at. Bit odd, and I don't know how it works exactly, but doesn't water have to pass a tile/come into contact with stagnant water to become stagnant itself?

That's the problem - stagnation can "leak" into a freshwater source simply by having a stagnant pool randomly happen to be in the same area because "damp" soil carries stagnation.

Or, in other words, if a single puddle of stagnant water is ever adjacent to a freshwater stream to within a few tiles, the entire stream will be tainted forever. 
Logged
Personally, I like [DF] because after climbing the damned learning cliff, I'm too elitist to consider not liking it.
"And no Frankenstein-esque body part stitching?"
"Not yet"

Improved Farming
Class Warfare

Loud Whispers

  • Bay Watcher
  • They said we have to aim higher, so we dug deeper.
    • View Profile
    • I APPLAUD YOU SIRRAH
Re: Possible cause for stagnant river bug
« Reply #11 on: April 20, 2012, 03:39:10 pm »

My brook was perfectly fine before, and it was only until I mined out the ice that this change occurred. And it's isolated to those squares, so river tiles are supposed to apparently protect against this stagnation. It wasn't a sudden leap of water from a murky pool to the brook - it was an immediate change the moment the river thawed, affecting only the areas where the river was dug.

i2amroy

  • Bay Watcher
  • Cats, ruling the world one dwarf at a time
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #12 on: April 20, 2012, 03:48:11 pm »

My brook was perfectly fine before, and it was only until I mined out the ice that this change occurred. And it's isolated to those squares, so river tiles are supposed to apparently protect against this stagnation. It wasn't a sudden leap of water from a murky pool to the brook - it was an immediate change the moment the river thawed, affecting only the areas where the river was dug.
It' because when you dug out those areas you were basically creating "pools" in the middle of your brook. These pools then when stagnant, spreading to the nearby area. If you had done it to a river instead of a brook then nothing would have happened.
Logged
Quote from: PTTG
It would be brutally difficult and probably won't work. In other words, it's absolutely dwarven!
Cataclysm: Dark Days Ahead - A fun zombie survival rougelike that I'm dev-ing for.

CodexDraco

  • Bay Watcher
  • [SARCASTIC]
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #13 on: April 20, 2012, 03:51:32 pm »

This happened to me when I pumped water out of my river but I didn't properly wall off the output. The whole river became stagnant the second when the pumped water touched the river.
Logged
Finely minced dwarven wine... what?

wierd

  • Bay Watcher
  • I like to eat small children.
    • View Profile
Re: Possible cause for stagnant river bug
« Reply #14 on: April 20, 2012, 04:17:32 pm »

Again, these would nearly all be solved by a simple check for the "flow" tag.

*shrug
Logged
Pages: [1] 2