Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Rakeela]

Credit Card Fraud was broken for me in the latest version, as were several hacking operations.  I looked into the source and made the following change, fixing the problem.  I hope this isn't terribly presumptuous of me.

The causes of the crash were unsigned integers in activities.ccp, specifically lines 1198 and 1298.  An if statement was incorrectly evaluating to true due to a negative number being treated as unsigned because truehack.size was unsigned.  This was enabling illegal vector access.  Implementing these changes should stop that from happening.  Testing indicates changing both files is necessary.

Code: [Select]

Index: creature.h
===================================================================
--- creature.h (revision 492)
+++ creature.h (working copy)
@@ -25,20 +25,18 @@
 #define GENDER_FEMALE  2
 #define GENDER_WHITEMALEPATRIARCH 3
 
-enum CheckDifficulty
-{
-   DIFFICULTY_AUTOMATIC    = 1,
-   DIFFICULTY_VERYEASY     = 3,
-   DIFFICULTY_EASY         = 5,
-   DIFFICULTY_AVERAGE      = 7,
-   DIFFICULTY_CHALLENGING  = 9,
-   DIFFICULTY_HARD         = 11,
-   DIFFICULTY_FORMIDABLE   = 13,
-   DIFFICULTY_HEROIC       = 15,
-   DIFFICULTY_SUPERHEROIC  = 17,
-   DIFFICULTY_IMPOSSIBLE   = 19
-};
 
+const int DIFFICULTY_AUTOMATIC    = 1;
+const int   DIFFICULTY_VERYEASY     = 3;
+const int DIFFICULTY_EASY         = 5;
+const int DIFFICULTY_AVERAGE      = 7;
+const int DIFFICULTY_CHALLENGING  = 9;
+const int DIFFICULTY_HARD         = 11;
+const int DIFFICULTY_FORMIDABLE   = 13;
+const int DIFFICULTY_HEROIC       = 15;
+const int DIFFICULTY_SUPERHEROIC  = 17;
+const int DIFFICULTY_IMPOSSIBLE   = 19;
+
 enum CreatureAttribute
 {
    ATTRIBUTE_STRENGTH,


Code: [Select]

Index: activities.cpp
===================================================================
--- activities.cpp (revision 492)
+++ activities.cpp (working copy)
@@ -1195,7 +1195,7 @@
 
       int difficulty = DIFFICULTY_HEROIC;
         
-      if(DIFFICULTY_HEROIC<=hack_skill+truehack.size()-1)
+      if(DIFFICULTY_HEROIC<=hack_skill+((int)truehack.size())-1)
       {
          if(truehack.size()>1)strcpy(msg,"Your Hackers have ");
          else {strcpy(msg,truehack[0]->name);strcat(msg," has ");}
@@ -1295,7 +1295,7 @@
          for(int h=0;h<truehack.size();h++)
             addjuice(*truehack[h],juiceval,200);
       }
-      else if(DIFFICULTY_FORMIDABLE<=hack_skill+truehack.size()-1)
+      else if(DIFFICULTY_FORMIDABLE<=hack_skill+((int)truehack.size())-1)
       {
          int issue=LCSrandom(VIEWNUM-5);
          int crime;


[mainiac]

That is epic user feedback.

[EuchreJack]

I agree with mainiac, this is awesome.  This community greatly encourages user input, code corrections, and more.

[Carlos Gustavos]

I've put in the second part. The first part wasn't necessary for me.

I don't get why this error occurs on those two lines, but not on any of the other (vector).size()-1 that are in the same file.

[Rakeela]

I've put in the second part. The first part wasn't necessary for me.

I don't get why this error occurs on those two lines, but not on any of the other (vector).size()-1 that are in the same file.

I wouldn't call myself a skilled coder.  I wonder why the first part was necessary for me, but not for you, and I wonder if there's similar variance elsewhere.  Questions abound all around, and having done this tempts me to try to test the game more thoroughly and see if I can trigger any other crashes.

[EuchreJack]

I've put in the second part. The first part wasn't necessary for me.

I don't get why this error occurs on those two lines, but not on any of the other (vector).size()-1 that are in the same file.

I wouldn't call myself a skilled coder.  I wonder why the first part was necessary for me, but not for you, and I wonder if there's similar variance elsewhere.  Questions abound all around, and having done this tempts me to try to test the game more thoroughly and see if I can trigger any other crashes.

If you fix every crash that you find, then I wish you happy crashday!

[Rakeela]

I found several!  I even reproduced a few of them.  Alas, I suck as a coder, and haven't been able to fix any of the others so far.  I'll keep trying.

[InfernoZeus]

I found several!  I even reproduced a few of them.  Alas, I suck as a coder, and haven't been able to fix any of the others so far.  I'll keep trying.

It'd be good if you posted them somewhere, just in case they haven't already been acknowledged. I'm not sure if there's a proper issue tracker though.