Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[UselessMcMiner]

I was wondering if there was a list of relationship_id's that gui/family-affairs is using? I'm making a variation of the script to help make dwarves into friends but relationship_id.Friend doesn't work and causes an IndexError? Is there a string dump of the values?

[mifki]

Code: [Select]

lua @df.unit_relationship_type

[UselessMcMiner]

Hey I found the proper ID but this line of code

Code: [Select]

local single = source.relationship_ids.Friend == -1
Causes this error

Code: [Select]

Cannot read field int32_t[].Friend: index out of bounds
Sorry i'm very new to this so sorry if its obvious.

[UselessMcMiner]

I guess let me be more specific. It seems like lines 4 and 5 in this function create an IndexError. How do I handle relationships like friendships without creating an IndexError? I guess becauseunlike with spouses you can become friends with multiple people. So it breaks down pretty quickly.

Code: [Select]

function Marriage (source,target)
    local source_hf = df.historical_figure.find(source.hist_figure_id)
    local target_hf = df.historical_figure.find(target.hist_figure_id)
    source.relationship_ids.Friend = target.id
    target.relationship_ids.Friend = source.id

    local new_link = df.histfig_hf_link_spousest:new() -- adding hf link to source
    new_link.target_hf = target_hf.id
    new_link.link_strength = 100
    source_hf.histfig_links:insert('#',new_link)

    new_link = df.histfig_hf_link_spousest:new() -- adding hf link to target
    new_link.target_hf = source_hf.id
    new_link.link_strength = 100
    target_hf.histfig_links:insert('#',new_link)
end

[mifki]

Ah, right, unit.relationship_ids only stores some of the relationships, the first 10. I can't say right now where the remaining ones are stored.

[PatrikLundell]

Relations are stored in the hist fig in a rather messy logic.

This is a snippet of a script printing it (getting it wrong for married if they've been friends, as the relationship_ids aren't consulted):

Spoiler (click to show/hide)

Code: [Select]

------------------------------------------
--  Seems to match the sorting order. Note that only the values noted have actually been seen to have an effect.
--  "Supplemental" values can appear, such as 23, and friends seem to have 7 as a supplemental value for citizens,
--  while visitors have been observed to have friends both with and without a supplemental 7 (even the same citizen).
--
function friend_lt (f1, f2)
  local f1_relation_level = 3   --  Passing Acquaintance
  local f2_relation_level = 3
 
  if #f1.attitude > 0 then
    if f1.attitude [0] == 1 or    --  Friend
       f1.attitude [0] == 2 or    --  Grudge
       f1.attitude [0] == 3 then  --  Bonded
      f1_relation_level = 1      --  Friend/Grudge/Bonded
   
    elseif f1.attitude [0] == 7 then
      f1_relation_level = 2      --  Friendly Terms
    end
  end
 
  if #f2.attitude > 0 then
    if f2.attitude [0] == 1 or    --  Friend
       f2.attitude [0] == 2 or    --  Grudge
       f2.attitude [0] == 3 then  --  Bonded
      f2_relation_level = 1      --  Friend/Grudge/Bonded
     
    elseif f2.attitude [0] == 7 then
      f2_relation_level = 2      --  Friendly Terms
    end
  end
 
  if f1_relation_level > f2_relation_level then
    return true
 
  elseif f1_relation_level < f2_relation_level then
    return false
  end
 
  if f1_relation_level == 1 then  --  Friend/Grudge/Bonded
    return f1.histfig_id > f2.histfig_id
  end
 
  if f1.rank == f2.rank then
    return f1.histfig_id > f2.histfig_id
   
  else
    return f1.rank < f2.rank
  end
end
 
------------------------------------------
:
:
:
    if hf.info.relationships ~= nil then
      for k, relation in ipairs (hf.info.relationships.list) do
        --### Ought to filter out parents from this list, as they sometimes appear here.
        --### Ought to filter out any spouse as well.
        table.insert (friends, relation)
      end
     
      for k = 1, #friends - 1 do
        for l = k + 1, #friends do
          if friend_lt (friends [k], friends [l]) then
            temp = friends [k]
            friends [k] = friends [l]
            friends [l] = temp
          end
        end
      end     
     
      for k, relation in ipairs (friends) do
        if relation.rank > 0 then
          if #relation.attitude == 0 then
          --### "Long-term Acquaintance" is either determined based on the age of the relation or on the rank.
--            dfhack.print ("Passing Acquaintance ")
            dfhack.print ("Passing Acquaintance " .. tostring (relation.rank) .. " ")
         
          elseif relation.attitude [0] == 1 then
--            dfhack.print ("Friend ")
            dfhack.print ("Friend " .. tostring (relation.counter [0]) .. " " .. tostring (relation.rank) .. " ")
            if #relation.attitude >= 2 and
               relation.attitude [1] == 7 then
              dfhack.print (tostring (relation.counter [1]) .. " ")
            end
         
          elseif relation.attitude [0] == 2 then
            dfhack.print ("Grudge ")
         
          elseif relation.attitude [0] == 3 then
            dfhack.print ("Bonded ")
         
          elseif relation.attitude [0] == 7 then
--            dfhack.print ("Friendly Terms ")
            dfhack.print ("Friendly Terms " .. tostring (relation.counter [0]) .. " " .. tostring (relation.rank) .. " ")
       
          else
            dfhack.error ("Unknown primary relation found " .. tostring (relation.attitude [0]))
          end
               
          dfhack.println (get_hf_name (relation.histfig_id))
        end
      end
    end



[UselessMcMiner]

So how should I modify my script? Because now i'm even more stuck.

[UselessMcMiner]

Ok so clearly the issue is something else that i've figured out. I'll make a seperate post about it because it's a lot different compared to the other issue. Thanks a lot mifki and  PatrikLundell! And Patrik the issue is the fact that dwarves can have multiple Friends but only one Spouse so friends are somewhere else. I'll get some help in trying to find it.

[PatrikLundell]

The script snippet I posted uses the "somewhere else": it's in the hist fig, not the unit. "hf" is the hist fig, and "info.relationships" is where relationships are stored. The hf relationship structure is a vector of variable size (to allow for a bazillion passing acquaintances with visitors), and the function at the top of the snippet is used to sort the elements of this structure in the same order as DF does when displaying it.
As can be seen, the data isn't organized in a particularly user friendly manner...

[UselessMcMiner]

I guess my big question is how can I modify it? Will that code snippet be enough do you think?

EDIT: I guess how complicated will it be to edit a historical figure's relationships?

[PatrikLundell]

I would expect it's a matter of inserting a new element in the vector and filling it with the appropriate field values. However, if I remember correctly, there is a bunch of fields which haven't been identified, and I have no idea of whether those are important or not.

[UselessMcMiner]

Sorry for asking but what is a vector? I have only just started programming and sorry if its a stupid question. And also where is f1.attitude located? In the historical id file right?

[PatrikLundell]

A vector in this context is a C(++) structure that contains a "list" of elements of some C(++) type. It's somewhat similar to an array (in C terminology). A vector contains information about how long it is in a "header" structure, and it's capable of being extended or shrunk. DFHack maps DF's vectors onto Lua lists, allowing you to iterate over them (as well as modifying their lengths).

"f1" isn't located anywhere: it's a parameter to the friend_lt function, and if you look at the call to friend_lt you'll find that f1 and f2 are friends [k] and friends [l] respectively. "friends", in its turn, is a Lua vector the script builds for its own use (table.insert...), and the elements of that vector are populated by the iterator variable "relation" (using the peculiar Lua "ipairs" iterator construct). "relation", in turn, takes the value of "hf.info.relationships.list [k]", which is the value of each of the elements (in turn) of the DF vector that's part of the "hf.info.relationships.info" vector. Thus, that is the vector you're looking for.

I'm not sure this is the best place to learn Lua scripting, as manipulation of pointers in an incorrect manner is a good way to get DF to crash (and there are a whole lot of incorrect ways, and only a few correct ones). This is in addition to leaking memory by allocating memory and not freeing it afterwards (Lua is supposed to do that for its own data [although I'm skeptic and not sure it works correctly], but C(++) is inherently unsafe and all safety of almost any kind has to be added manually (or by using classes that add them, in which case you would be better off using a high level language that had safety built in).