Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Reelya]

<EDIT> Scratch everything I wrote about not being able to compile. I found my mistake (reading the readme should have been the first thing I did).

I did find an actual issue that was an error in the source code, one of the files uses mem_fun but doesn't reference the header where this is defined, which is <functional>. I just stuck that in the file that needed it rather than throw in in the include.h path.

Doing everything through one huge #include is really dumb. I'm sure that adds a heap to compile time. I'm a big fan of every cpp file #including just the functionality that they need. That way, you can see the dependencies quickly for any file by looking at the top of the file rather than having to guess which files might break if you change a specific thing.

[IsaacG]

Doing everything through one huge #include is really dumb. I'm sure that adds a heap to compile time. I'm a big fan of every cpp file #including just the functionality that they need. That way, you can see the dependencies quickly for any file by looking at the top of the file rather than having to guess which files might break if you change a specific thing.

I agree entirely.  In Eclipse, it even complains if you try to do that with Java (sort of).
Putting everything in includes.h completely defeats some central aspects of object oriented programming.
Fixing it, however, is likely a bigger challenge than what we're working on already.

[Purple Gorilla]

Other problems are also some unfortunate macros and the interface methods.

The macros GIVE_WEAPON_CIVILLIAN, GIVE_GENDER_MALE and GIVE_GENDER_FEMALE in creaturetypes.cpp insert big chunks of code, and should be repaced with functions. If you use compiler optimisation, the compiler chokes on this file, probably trying to find it out itself.

The other problems are the interface methods, that do nothing than returning a value. Declaring everything public will make a lot of things easier. I am pretty sure, the compiler will resolve interface methods itself, but it still increases readability. Another problem with interface methods is, that it is more difficult to write "cheats" for debugging, as changing a variable in an object from outside isn't possible without another interface method.

Further, should it be avoided to use features that the unmodded game didn't use. In the LCS-nightly Mod, the modder used nullptr instead of NULL, and Java-style for loops, breaking the downward compatiblity with no gain at all. This is easy to fix for an experienced programmer, but Taberone now tried two months to compile it -> http://www.bay12forums.com/smf/index.php?topic=152165.0 .

[Reelya]

I was wondering, who has admin rights for the SVN etc, I made some productive improvements to one of the source files as a test in refactoring and streamlining the code (in a totally-not-breaking-compatibility way), but I really want to be able to integrate these changes back into the project before I spend any significant time on doing something like that. A lot of bad features have been in there for a long time and I think the game needs a big refactoring effort more than it needs piecemeal mods. Basically for the reason that every time people want to mod something basic into the game we need to tell them the same pile of bullshit about all the lines of code that need to change. Reducing that would spur more, and more comprehensive mods.

[Carlos Gustavos]

Jonathan has admin rights.

[Reelya]

I was kinda afraid if that. Jonathan hasn't logged in since the start of the year. So can you clarify/confirm what that means in terms of updating the trunk build? Is it impossible to push/merge etc without admin privileges? Or is admin a higher level than general contributor?

If there's no other way, making a new repo for further development would be necessary at some point.

[SlatersQuest]

Is it possible to reach Jonathan? We kinda need him.

[Carlos Gustavos]

I and a bunch of others can commit changes without Jonathan. He'd probably give you commit rights too if you asked. He's been permissive on allowing people to participate.

As for reaching him, if pming doesn't work his website gives his email address: jonathansfox@gmail.com