Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  

Author Topic: Masterwork version control repository?  (Read 1599 times)

Urist McTeellox

  • Bay Watcher
    • View Profile
Masterwork version control repository?
« on: October 23, 2013, 04:45:42 pm »

I know Meph is travelling like a badass, so this may take a while to be answered... However...

Once upon a time the raws for Masterwork lived in a mercurial repo on javaforge. That seems to have since disappeared or moved (or I'm failing my mercurial rolls).

I seem to be doing a lot of tweaking as I play (fixing a bug where composite bows were incorrectly powered, rebalancing archaeology a little so one doesn't end up with oodles of guardians of Armok,  seeing if I can tweak orcish raiding to occasionally result in sieges, etc). This is great for me, and I can apply those tweaks to new releases of Masterwork. However I'd *love* to be able to send them upstream for consideration.

Obviously I can post them here, but that doesn't feel right compared to sending pull requests and using gitomancy/mercurialmancy. Does anyone know if Meph is doing MWDF development in a public repo anywhere? If that comes with a list of known bugs, then that's even better, because it means I can take a stab at fixing some. :)

Many thanks,

~ T
Logged

CuriousCreativity

  • Bay Watcher
    • View Profile
Re: Masterwork version control repository?
« Reply #1 on: October 23, 2013, 05:49:10 pm »

Don't quote me, but when I was talking with him about setting one up for something I'm working on it didn't sound like he had Github set-up anyways.  I am probably wrong, however - but that was my impression.
Logged

Urist McTeellox

  • Bay Watcher
    • View Profile
Re: Masterwork version control repository?
« Reply #2 on: October 23, 2013, 05:59:04 pm »

Don't quote me...

The troll quotes the Bay12 user in the forum with his +literal interpretation+.  ;)
Logged

Etherdrinker

  • Bay Watcher
  • ☼Etherdrink☼
    • View Profile
Re: Masterwork version control repository?
« Reply #3 on: October 23, 2013, 07:01:32 pm »

http://www.bay12forums.com/smf/index.php?topic=125638.0 <---- is the top sticky, unless my gray matter donīt understand what you are trying  to say.

Urist McTeellox

  • Bay Watcher
    • View Profile
Re: Masterwork version control repository?
« Reply #4 on: October 23, 2013, 08:23:55 pm »

http://www.bay12forums.com/smf/index.php?topic=125638.0 <---- is the top sticky, unless my gray matter donīt understand what you are trying  to say.

Alas, not quite what I'm after. That gives me all the code, but no revision control features, which allows one to track the changes to said code.

Revision control makes it very easy to share updates between developers, make sure that changes are applied consistently (eg, if something is renamed in the raws, make sure it's changed in all of them), back out changes which don't work, have branches where experimental features can be developed, and so on.

For example, Putnam does great work on dfhack, and you can see every change by Putnam (and others, and what they depend upon) at https://github.com/Putnam3145/dfhack/ . Seeing graphs like https://github.com/expwnent/dfhack/network are fabulous visualisations of how code is developed (you may wish to use shift-right to jump to the right to see the most current commits).

I don't actually expect that Meph has a public repository, but if he does, then I should be using that as a basis to track my own changes against MWDF.

~T
Logged

Putnam

  • Bay Watcher
  • DAT WIZARD
    • View Profile
Re: Masterwork version control repository?
« Reply #5 on: October 23, 2013, 09:48:12 pm »

why'd you use my example

I've never even used that repository...

though including expwnent's is good

Meph

  • Bay Watcher
    • View Profile
    • worldbicyclist
Re: Masterwork version control repository?
« Reply #6 on: October 24, 2013, 02:07:08 pm »

I never used Github, except to download custom dfhack scripts.

If you make revisions to my raws, and want to upload them to see if I'd like to add them into the mod, please do it here on bay12. We have an entire board just for the mod, that should be enough space. I like having things in one place. Usually when people do upload raws (lets say 90% of the time) it is for a good reason and something that I will include in the mod. So please, do indulge me. ;)

Your orc siege-triggering had some bugs in it though, because of how autosyndrome triggers.
Logged
::: ☼Meph Tileset☼☼Map Tileset☼- 32x graphic sets with TWBT :::
::: ☼MASTERWORK DF☼ - A comprehensive mod pack now on Patreon - 250.000+ downloads and counting :::
::: WorldBicyclist.com - Follow my bike tours around the world - 148 countries visited :::

Urist McTeellox

  • Bay Watcher
    • View Profile
Re: Masterwork version control repository?
« Reply #7 on: October 24, 2013, 08:10:51 pm »

Roger that! Would you prefer all patches in the existing orc/kobold/dwarf threads, a new topic for each patch, or one single thread called "Urist McTellox's patch thread"? ;)

To be honest I'd *love* to add descriptions to a lot of items. Otherwise I keep having to check the raws to see "how much coverage does this armour provide?" or "which bow is better again?".

On the topic of bows, I know I posted elsewhere a fix to adjust the power of composite bows. They previously had a power of 10k, which was almost twice that of a great bow. The patch below fixes them to have a power of 4k (the same as all the improved/flavoured longbows).

Spoiler (click to show/hide)
Logged

Putnam

  • Bay Watcher
  • DAT WIZARD
    • View Profile
Re: Masterwork version control repository?
« Reply #8 on: October 24, 2013, 08:11:47 pm »

Items can't have descriptions.

Urist McTeellox

  • Bay Watcher
    • View Profile
Re: Masterwork version control repository?
« Reply #9 on: October 24, 2013, 08:18:13 pm »

Items can't have descriptions.

D'oh. That would explain why I keep looking at the raws and manuals. :)
Logged

Meph

  • Bay Watcher
    • View Profile
    • worldbicyclist
Re: Masterwork version control repository?
« Reply #10 on: October 24, 2013, 08:26:01 pm »

Quote
one single thread called "Urist McTellox's patch thread"
If you plan on a lot of them, yes, this is what I'd prefer, a single thread.
Logged
::: ☼Meph Tileset☼☼Map Tileset☼- 32x graphic sets with TWBT :::
::: ☼MASTERWORK DF☼ - A comprehensive mod pack now on Patreon - 250.000+ downloads and counting :::
::: WorldBicyclist.com - Follow my bike tours around the world - 148 countries visited :::

Urist McTeellox

  • Bay Watcher
    • View Profile
Re: Masterwork version control repository?
« Reply #11 on: October 24, 2013, 10:10:41 pm »

If you plan on a lot of them, yes, this is what I'd prefer, a single thread.

Shall do! Everything will be patches against the 4b release unless encouraged otherwise. :)

Current goals:

* Orc raids can trigger sieges (without bugs)
* Warlocks no longer to have the ethics of vegan elves. :)

~ T
Logged