Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  

Author Topic: [38c] Error sorting rivers  (Read 524 times)

Fleeb

  • Bay Watcher
  • The Fleebiest
    • View Profile
[38c] Error sorting rivers
« on: April 11, 2008, 05:06:00 pm »

I've made a few new worlds lately, first time I've ever seen this in the errorlog:

Error sorting rivers: working with 1376 ran into 1936
Error sorting rivers: working with 1394 ran into 2911

Full sized world. I've been modding creatures, but I don't think I've done anything else.

[ April 11, 2008: Message edited by: Fleeb ]

Logged
"If you push something hard enough, it will fall over" -Fudds First Law of Opposition
"If it goes in, it must come out" -Teslicles Deviant to Fudds Law

Toady One

  • The Great
    • View Profile
    • http://www.bay12games.com
Re: [38c] Error sorting rivers
« Reply #1 on: April 15, 2008, 01:51:00 am »

Yeah, I hate this one -- it's bug report 606, which I created myself when I saw it in the log during testing, but I wasn't able to determine the seed.  Do you have a seed?  I'd like a seed I can use to get it to happen, since it should be easy to fix once I get it to reproduce.
Logged
The Toad, a Natural Resource:  Preserve yours today!

Fleeb

  • Bay Watcher
  • The Fleebiest
    • View Profile
Re: [38c] Error sorting rivers
« Reply #2 on: April 15, 2008, 09:52:00 pm »

Sadly I don't, I've regenerated world a few times since the error. If it happens again I'll note the seed.
Logged
"If you push something hard enough, it will fall over" -Fudds First Law of Opposition
"If it goes in, it must come out" -Teslicles Deviant to Fudds Law

Cavalcadeofcats

  • Bay Watcher
    • View Profile
Re: [38c] Error sorting rivers
« Reply #3 on: May 10, 2008, 11:31:00 pm »

Noticed this, found the seed.

code:
Error sorting rivers: working with 275 ran into 1059
Error sorting rivers: working with 341 ran into 1059
Error sorting rivers: working with 615 ran into 944
Error sorting rivers: working with 1059 ran into 1356
Error sorting rivers: working with 1093 ran into 1243
Error sorting rivers: working with 1356 ran into 1879
Error sorting rivers: working with 1812 ran into 1837


code:
 
[WORLD_GEN]
   [TITLE:STANDARD]
   [CUSTOM_NAME:Venaria]
   [SEED:3848588915]
   [DIM:129:257]


Hopefully this is helpful.

EDIT: Forgot; I've modded the game somewhat, Sean's Minerals mod, among other things. If it doesn't duplicate, then that's to blame.

[ May 11, 2008: Message edited by: Cavalcadeofcats ]

Logged

Derakon

  • Bay Watcher
    • View Profile
Re: [38c] Error sorting rivers
« Reply #4 on: May 11, 2008, 12:48:00 am »

Y'know, it'd be worth having a top-level exception handler during worldgen that'd write the worldgen parameters to the error log. That'd make catching fatal errors during worldgen a lot more straightforward.
Logged
Jetblade - an open-source Metroid/Castlevania game with procedurally-generated levels

Keldor

  • Bay Watcher
  • Blood for the blood god!
    • View Profile
Re: [38c] Error sorting rivers
« Reply #5 on: May 13, 2008, 05:06:00 am »

Yes.  I mean, there's already code to spit out the errors into the worldgen log...
Logged
If ignorance is bliss, why are my dwarves all tantruming?

Toady One

  • The Great
    • View Profile
    • http://www.bay12games.com
Re: [38c] Error sorting rivers
« Reply #6 on: May 20, 2008, 07:15:00 am »

This bug is finally fixed.  The seed was very helpful, though it took a long time since I was stuck generating the world whenever I wanted to check something.  It turns out the loop erase algorithm for rivers was killing off legitimate river flags in the case where a very long convoluted dead-end river was adjacent to another shorter river that ran first, which caused the brook placement to become confused about where brooks could flow, which made them bump into each other, which confused river elevation smoothing, which gave rise to the error log.
Logged
The Toad, a Natural Resource:  Preserve yours today!