Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[PatrikLundell]

I think the error is in the line that assumes hist fig vector indices are equal to hist fig id + 1. The "proper" way to get a hist fig is to use the find function. The script as written might work if culling of unimportant hist figs is disabled, but will definitely not work if it's enabled.

The somewhat weird find binary search functions operate on the type contained in the vector, with the actual vector targeted being completely implicit. My guess, without looking at any types, would be something like:
histfig = df.historical_figure.find (unit.hist_figure_id)

[Scruiser]

That sounds like it may be it.  My quick test worlds only had 125 years of history, so I left cull historical figures off, but for my super old world, I had turned it on of course.  I will figure out the correct way of finding the histfig...

[therahedwig]

I never generate worlds with culled histfigs, so that might be why I didn't see it either

[Scruiser]

The alternative method suggested by PatrikLundell works for that section... but later on the script again uses the hist fig id+1 method in another way...
Line 80

Code: [Select]

maker = df.global.world.history.figures[(book.author+histfigOffset+1)]
I couldn't quite figure out make use of the book.author.  For some reason maker = df.historical_figure.find(book.author) didn't work.  Maybe the book author is a culled historical figure.

So to fix that part, I just commented out the part that finds and prints the book authors.  The full list of books is also kind of cumbersome, I might cut and paste it into a different script.

For now what I have is as follows (note I also commented out the skill information because I can just get that from therapist...).  It seems to be working okay.

Spoiler (click to show/hide)

Code: [Select]

-- View knowledge for currently selected unit
--[====[

read-knowledge
==============
View knowledge for currently selected unit

]====]

    local i,unit_name

    local unit=dfhack.gui.getSelectedUnit()
        if unit==nil then
            print ("No unit under cursor!  Aborting.")
        return
    end

    unit_name=dfhack.TranslateName(dfhack.units.getVisibleName(unit))

    print("")
    print("Printing data for "..unit_name)
    print("======================================")
    print("")
   
    histfigOffset = 0
   
   
    print(unit.hist_figure_id)
    --histfig = df.global.world.history.figures[(unit.hist_figure_id+1)]
    histfig = df.historical_figure.find(unit.hist_figure_id)
   
    for _, hf in pairs(df.global.world.history.figures) do
        if hf.name.first_name == unit.name.first_name and hf.name.language == unit.name.language then
            same_lastname = false
            for w, word in pairs(hf.name.words) do
                if (word > 0) then
                    same_lastname = (word == unit.name.words[w])
                end
            end
           
            if same_lastname == true then
                print(dfhack.TranslateName(hf.name))
                if histfig.id ~= hf.id then
                    print("Mismatching Histfig ID")
                    print("Unit: "..histfig.id.." Actual ID: "..hf.id)
                    histfigOffset = hf.id-histfig.id
                    histfig = hf
                    break
                end
            end
        end
    end

    print(dfhack.TranslateName(histfig.name))
   --[[
    for _, skill in pairs(unit.status.current_soul.skills) do
        print(df.job_skill[skill.id])
        print("\t"..skill.rating)
        print("\t"..skill.experience)
    end
   --]]
    if (histfig.info.secret ~= nil) then
        print("Books Read:")
        print("-----------")
        for _,book_id in pairs(histfig.info.secret.read_books) do
            book = df.global.world.written_contents.all[book_id]
                if (book.id==book_id) then
                    bookName = book.title
                    print("")
                    print("-\t"..bookName)
                    style = ""
                    for x, s in pairs(book.styles) do
                        sep = " "
                        if (x>0) then
                            sep = ", "
                        end
                        style = (style..sep..df.written_content_style[s])
                    end
                    print("\ta"..style.." ".. df.written_content_type[book.type])
--[[
                    if book.author > -1 then
                        maker = df.global.world.history.figures[(book.author+histfigOffset+1)]
                        makerName = dfhack.TranslateName(maker.name)
                        print("\tby ".. makerName)
                    end
--]]                   
                    for x, ref in pairs(book.refs) do
                       
                        if (ref._type==df.general_ref_value_levelst) then
                            print(book.ref_aux[x] , df.value_type[ref.value], ref.level)
                        else
                            printall(ref)
                            print(book.ref_aux[x] )
                        end
                    end
                end
        end
       
        print("")
        print("Knowledge:")
        print("----------")
        print("")
        knowledge = histfig.info.secret.knowledge
       
        poetic_forms = histfig.info.secret.unk_v4201_1
        musical_forms = histfig.info.secret.unk_v4201_2
        dance_forms = histfig.info.secret.unk_v4201_3
       
        if unit.status.current_soul.performance_skills ~= nil then
       
            if poetic_forms ~= nil then
               
                print("Poetic forms:")
                print("-------------")
                for _, form in pairs(unit.status.current_soul.performance_skills.poetic_forms) do
                    print(dfhack.TranslateName(df.global.world.poetic_forms.all[form.id].name, true, true).."\t"..form.rating.."\t"..form.experience)
                   
                end
            end
           
            if musical_forms ~= nil then
               
                print("Musical forms:")
                print("--------------")
                for _, form in pairs(unit.status.current_soul.performance_skills.musical_forms) do
                    print(dfhack.TranslateName(df.global.world.musical_forms.all[form.id].name, true, true).."\t"..form.rating.."\t"..form.experience)
                   
                end
            end
           
            if dance_forms ~= nil then
               
                print("Dance forms:")
                print("------------")
                for _, form in pairs(unit.status.current_soul.performance_skills.dance_forms) do
                    print(dfhack.TranslateName(df.global.world.dance_forms.all[form.id].name, true, true).."\t"..form.rating.."\t"..form.experience)
                   
                end
            end
       
        end
       
       
        if (knowledge==nil) then return end
       
        knowledge_goal_category = knowledge.knowledge_goal_category
        knowledge_goal = knowledge.knowledge_goal
        research_points = knowledge.research_points
        research_percentage = (research_points/100000) *100
       
        print("Times pondered:", knowledge.times_pondered)
        print("")
       
       
        knowledges = {}
        knowledgeNames = {}
        knowledges[0] = knowledge.philosophy
        knowledges[1] = knowledge.philosophy2
        knowledges[2] = knowledge.math
        knowledges[3] = knowledge.math2
        knowledges[4] = knowledge.history
        knowledges[5] = knowledge.astronomy
        knowledges[6] = knowledge.naturalist
        knowledges[7] = knowledge.chemistry
        knowledges[8] = knowledge.geography
        knowledges[9] = knowledge.medicine
        knowledges[10] = knowledge.medicine2
        knowledges[11] = knowledge.medicine3
        knowledges[12] = knowledge.engineering
        knowledges[13] = knowledge.engineering2
       
       
        for no, knowledge_type in pairs(knowledges) do
            entry = 0
            for name, known in pairs(knowledge_type) do
                entry = entry+1
                if (known==true) then
                    print("- ".. name)
                end
if (entry==1 and knowledge_goal_category==no and knowledge_goal[0]==true) then
print("- "..name.." (Learning: "..research_points.." / 100000 or "..research_percentage.."%)")
end
                if( knowledge_goal_category==no) then
                    for entry_g, known_g in pairs(knowledge_goal) do
                        if (known_g == true and entry_g==entry-1) then
                            print("- "..name.." (Learning: "..research_points.." / 100000 or "..research_percentage.."%)")
                        end
                    end
                end

            end
        end
   
    end
   
    print("")


[hun]

On a different note, is there a way (dfhack script?) to search for the specific artifacts for creating a mission? I am trying to raid for specific books, but looking for those manually in the list with hundreds, if not thousands, entries is just insanely tedious.

[PatrikLundell]

DF shouldn't cull a hist fig if it has written a book, as it shouldn't leave dangling references around, so if it does, it's a bug.

@hun: It ought to be possible to e.g. write a script that checks that the appropriate raid page is open and inserts an appropriate reference in the correct field. Note, though, that there tends to be multiple books with the same title, so you'd need some way to select the "correct" one.