Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Altaree]

So, I was switching from crossbows to javelin throwers but the dwarves wouldn't switch ammo.  I created this script to get them a nice thunk on the head.

Code: [Select]

for _,v in ipairs(df.global.world.units.all) do
if v.race == df.global.ui.race_id then
unit=v
if unit==nil then
print ("No unit found!  Aborting with extreme prejudice.")
return
end
loc=unit.pos
for _,k in pairs(unit.inventory) do
if k.item:getType() ==  df.item_type.QUIVER then
print ('  ', dfhack.items.getDescription(k.item,0))
print(k.item.flags.container)
print(k.item:getType())
for _,j in pairs(dfhack.items.getContainedItems(k.item)) do
print ('  ', dfhack.items.getDescription(j,0))
r = dfhack.items.moveToGround(j,loc)
end

end
end
end
end



[Quietust]

So, I was switching from crossbows to javelin throwers but the dwarves wouldn't switch ammo.  I created this script to get them a nice thunk on the head.

Code: [Select]

for _,v in ipairs(df.global.world.units.all) do
if v.race == df.global.ui.race_id then
unit=v
if unit==nil then
print ("No unit found!  Aborting with extreme prejudice.")
return
end
loc=unit.pos
for _,k in pairs(unit.inventory) do
if k.item:getType() ==  df.item_type.QUIVER then
print ('  ', dfhack.items.getDescription(k.item,0))
print(k.item.flags.container)
print(k.item:getType())
for _,j in pairs(dfhack.items.getContainedItems(k.item)) do
print ('  ', dfhack.items.getDescription(j,0))
r = dfhack.items.moveToGround(j,loc)
end

end
end
end
end



Just so you know, that "unit==nil" check is totally superfluous and cannot possibly trigger, since if it was null then the act of checking "v.race" would've failed. Besides, df.global.world.units.all should never contain null pointers, no matter what.

[Altaree]

Thanks,
That was a hold over from when I was getting a single unit from the cursor.  I tend to leave it in but should have removed it when sharing the script.  Now that I look at is, the formatting is REALLY off too.  I need to reverse the indents.

Code: [Select]

for _,v in ipairs(df.global.world.units.all) do
if v.race == df.global.ui.race_id then
unit=v
loc=unit.pos
for _,k in pairs(unit.inventory) do
if k.item:getType() ==  df.item_type.QUIVER then
print (dfhack.items.getDescription(k.item,0))
print('  ', k.item.flags.container)
print('  ', k.item:getType())
for _,j in pairs(dfhack.items.getContainedItems(k.item)) do
print ('  ', '  ', dfhack.items.getDescription(j,0))
r = dfhack.items.moveToGround(j,loc)
end

end
end
end
end


[Hesperid]

Speaking of the v.race check, it has the effect of emptying the quivers of dwarves in invaders populations while refusing to work for mercenaries and petitioned citizens who use quivers.

And emptying every single quiver while your squads (and hunters) retain all their assigned ammunition IDs is likely to leave you with endless screenfuls of "Equipment mismatch" after you've run the script a few times.

[lethosor]

An alternative to checking v.race would be dfhack.units.isCitizen(v).

[Altaree]

Thanks! I have been checking the race  in a lot of scripts where citizen makes more sense.

[lethosor]

I forgot to mention this earlier - isCitizen performs a bunch of checks in addition to a simple "is group member" check - it excludes any creatures that are insane, undead, invaders, merchants, diplomats, and others (see here for a full list). If you don't want any of those, you can use isOwnGroup instead. (I imagine you do want those extra checks for this script, but maybe not for others.)