Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[milo christiansen]

Yay! A menu that allows you to specify art images and materials for jobs! Be still my heart!

...

Except it doesn't work.

Oh it works OK for vanilla jobs, but it is an utter failure when it comes to reactions. The problems are two fold:

a) The material selections are based on the item type of the input item not the material. This means that reaction classes do not work at all (I haven't tested material reaction products, but I doubt they work either).
b) No matter what the produced item is you cannot set an art image for reactions.

Would it be possible to override this menu with DFHack? Is Toady planning on fixing it so it actually works? Right now if your mod uses any kind of special reaction based industry this more-or-less destroys it.

EDIT: Bug report over here

[Bogus]

there already exists a script which lets you select job materials and items, after you issued the job. it does largely the same thing as the new builtin one, except it doesnt handle images and it doesnt seem to respect reaction classes etc (?). im not sure if you can read reaction classes and the like from the items in a job struct for builtin reactions.

other than that, i still have this kind-of-working script to replace shop menus. it can handle material and item selections based on a number of criteria, including reaction classes and reaction products. it does not currently know about art images so i can only guess that it might work if you write the code for that.

[milo christiansen]

Oh, I know about both of those. The problem is that neither one works any better right now.

Frankly I dont care about builtin reactions, the existing menu works OK for them.

DFHack job-material works great for selecting a material, but that doesn't help with art images. Trying to roll my own replacement for the whole workshop sidebar is way overkill, but if Toady doesn't fix his POS I may have to...

Is it possible to override a single control to redirect to your own menu? That would make writing a replacement menu much more feasible.

[Bogus]

you can remove and possibly replace single reactions or menu items, but you cant run custom code from there afaik. you may be able to replace the entire job details submenu tho (if its anything like the "Addjob" menu)

other than that, replacing whole menus has the advantage that you can run code at any time when navigating the menu. you can run your material selection before you add the job, much like the vanilla blacksmith.

[milo christiansen]

I'm not talking about the buttons in the reactions list, I am talking about the "details (d)" button in the job list. It probably isn't possible, which means that replacing the entire job list menu would be the only way, sigh...

[Bogus]

yes i changed my above post. the question is if there exists a gui focus for the details menu, if so, you very likely can replace it, with a bit of hackery to catch that focus.

im using this to poll the focus state after entering a workshop menu and then run my custom menu when the "Addjob" focus is active:

Spoiler (click to show/hide)

Code: [Select]

-- this crashes when non-workshops are selected. why is it even active in that case?
-- this function polls the current focus within the selected workshop menu and waits for the user to enter the "Addjob" submenu
-- at which point the actual menu is openend
-- for some reason i have to check for the workshop type here, tho eventful should only call when the correct workshop is selected. 

local function queryFocus()
local wshop = dfhack.gui.getSelectedBuilding()
if wshop then
-- print (wshop._type)
local name
if wshop._type == df.building_workshopst then
name = wshop.custom_type > -1 and df.global.world.raws.buildings.all[wshop.custom_type].code
or string.upper(df.workshop_type[wshop.type])
elseif wshop._type == df.building_furnacest then
name = wshop.custom_type > -1 and df.global.world.raws.buildings.all[wshop.custom_type].code
or string.upper(df.furnace_type[wshop.type])
else
--print("wrong building type")
return
end
for k, v in pairs(registeredMenus) do
for _, shopname in pairs(v.shops) do
if shopname == name then -- will see
if dfhack.gui.getFocusString(dfhack.gui.getCurViewscreen()) == FOCUS_PATH and -- FOCUS_PATH = "dwarfmode/QueryBuilding/Some/Workshop/AddJob"
wshop:getMaxBuildStage() == wshop:getBuildStage() then
WorkshopMenuBuilder{currentWorkshop = wshop, currentWorkshopMenu = v}:show()
dfhack.timeout_active(timer, nil)
return
else
timer = dfhack.timeout(1,'frames',queryFocus) -- we are still in the building, but in a different focus. so keep the query going
return
end
end
end
end
else
-- print("wub wub")
end
dfhack.timeout_active(timer, nil)
end

-- this is the actual callback registered to eventful.
local function fillSideBarCallback(wshop)
print("callback")
timer = dfhack.timeout(1,'frames',queryFocus)
end


[milo christiansen]

That may be useful, thanks! I'll hve to see what I can do when I get home...

Toady should still fix the vanilla menu though. I am surely not the only person whose mod is screwed over by this.

EDIT: I just posted this on the bug tracker, so maybe something will come of that... I'm not holding my breath though.

[Deon]

I was sad seeing this breaking mods. Here's hope Toady pays attention to it .

[Meph]

Sorry, how exactly does this break existing mods?

[Deon]

You can have a reaction taking some item from specific material. However the game will let you select a different material based on the item type instead.

You can trust people not abusing this, but it is still broken.

[Meph]

Ah, so if I want a platinum figurine for some ritual, the reaction would accept any figurine, if the player selects another material?

[milo christiansen]

Maybe not for figurines, but for bars, logs, boulders, etc? Definitely.

[Grimlocke]

You could add an item reaction product to each material to make sure the reaction puts out a nothing if that material is not used.