Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Talanic]

I'm attempting to test a cause of FPS death - specifically the presence of item quality modifiers.  What do I add to the RAWs to make it so dwarves no longer make anything higher than standard quality? 

[BlackFlyme]

Prevent dwarves and other races from being able to learn anything. If all skills are stuck at zero, they will be incredibly unlikely to make items with quality modifiers. It can still happen if the individual has very high attributes used for their specific craft, but will be much less frequent.

You can also remove the skill token from each reaction in the raws, but that won't affect hard-coded reactions.

[Talanic]

Ah yes!  Skill tokens!  I knew there was a way, but couldn't remember.  Thanks!

It won't affect the hard-coded reactions, but they can be coded around by making other reactions that do the same without using a skill.

[sv-esk]

This script changes quality of all created items on the map:

Spoiler (click to show/hide)

Code: [Select]

--qualityitems.lua
-- Sets quality for all items

local utils=require('utils')

validArgs = --[[validArgs or--]] utils.invert({
 'help',
 'q'
})

local args = utils.processArgs({...}, validArgs)

if args.help then
    print('qualityitems: sets quality to Ordinary')
    print(' qualityitems -q 1: sets quality to WellCrafted')
    print(' qualityitems -q 2: sets quality to FinelyCrafted')
    print(' qualityitems -q 3: sets quality to Superior')
    print(' qualityitems -q 4: sets quality to Exceptional')
    print(' qualityitems -q 5: sets quality to Masterful')
    print(' qualityitems -q 6: sets quality to Artifact')
  return
end

local count = 0

local q = 0

if args.q then q  = tonumber(args.q) end

for _,v in ipairs(df.global.world.items.all) do
        count = count + 1
        v:setQuality(q)
end

print('Changed '..count..' items. '..df.item_quality[q])


Put script into hack/scripts/qualityitems.lua
Run command in the dfhack console:
qualityitems -q 0    - to make all items ordinary
qualityitems -q 1    - for well crafted, etc

[nomad_delta]

although I'm not sure that simply having everything with same/lowest quality modifer would really help FPS, since all of the items would still have and track quality modifiers, even if they're all set the same.

[Talanic]

I had the same thought.  I've tested and confirmed that setting them all to have the same quality does not help - which means, of course, that removing the ability of dwarves to make higher quality items wouldn't help either.

Tests using createitem imply that there's no significant difference between blocks, tables, and helms with regard to FPS death.  So, no luck there; my entire theory is wrong.