Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[kiwiphoenix]

So... I found DFLocalise recently, used it to tweak the skill ranks and calendar months for clarity.
However, I found that in the patched exe, DFHack's Embark Anywhere plugin no longer works, returning the message:

[...]scripts/embark.lua:23: attempt to index local 'seg' (a nil value)
stack traceback:
[...]scripts/embark.lua:23: in function 'embark'
[...]scripts/embark.lua:23: in main chunk
(...tail calls...)

Tried removing the Embark plugin and replacing it after patching, but that didn't help.
Never used lua before, and am completely lost.
Any lua-literate people out there who'd be willing to shed some light on the situation?

For reference, the Embark plugin code:

Spoiler (click to show/hide)

-- lets you embark anywhere.
helpstring=[[ embark [-t|-d|-e|-h]
 -t   test if the patch can be applied
 -d   disable the patch if enabled
 -e   enable the patch if disabled
 -h   shows help
]]
args={...}
if args[1]=="-h" then
    print(helpstring)
    return
end
local ms=require("memscan")
local dfu=require("plugins.dfusion")
local patch
function embark() --windows only?
   local seg=ms.get_code_segment()
   local idx,off
    local patch=dfu.patches.embark_anywhere
   if patch~=nil then
       return patch
    else
        idx,off=seg.uint8_t:find_one{0x66, 0x83, 0x7F ,0x1A ,0xFF,0x74,0x04}
        if idx then
            patch=dfu.BinaryPatch{name="embark_anywhere",pre_data={0x74,0x04},data={0x90,0x90},address=off+5}
            return patch
        else
            qerror("Offset for embark patch not found!")
        end
    end
end
patch=embark()
if args[1]=="-t" then
    if patch:test() and not patch.is_applied then
        print("all okay, patch can be applied")
    elseif patch.is_applied then
        print("patch is currently applied, can be removed")
    else
        qerror("patch can't be applied")
    end
elseif args[1]=="-d" then
    if patch.is_applied then
        patch:remove()
        print("patch removed")
    end
elseif args[1]=="-e" then
    if not patch.is_applied then
        patch:apply()
        print("patch applied")
    end
else
    print(helpstring)
end

[Putnam]

It's lua, so it's a script.

Anyway:

This line ain't working:

Code: [Select]

   local seg=ms.get_code_segment()
The translation patcher changes some offsets around, so I'm not really surprised.

[Warmist]

Yes it's known bug. The translation patcher should not mark segments as executable (why would you want to execute the text?). This confuses the multi-embark hack.